| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Path name translation (/ to \) of various MSVSTool attributes.
* Explicit keyword= arguments to MSVSProject. This will likely
go away eventually in favor of uniform behavior.
* Add a relative_path_substitutions array that can be used
to substitute in Visual Studio variable like $(OutDir).
* Add a local_directory_prefix that can be set to './' to only
affect files in the current directory.
* Additional Keyword ordering in Tool attributes to continue to
match the default order Visual Studio generates.
* Add a Derived() proxy class that can wrap a File node to tell
the .vcproj generation that we want the derived file, not its
source(s), in the file list.
* In the individual *.scons files, add the necessary files (mostly
.h files) to file lists, and update MSVSProject() calls with
the additional necessary information.
Result is identical .vcproj files modulo the following differences:
* Four locales .vcproj files (da, en-US, he and zh-TW) with
source file orders that don't match the other locale .vcproj
files have re-ordered file lists to match the rest.
* Cosmetic XML changes (white space, ending tags) in:
chrome/app/chrome_dll.vcproj
chrome/app/generated_resources.vcproj
net/build/net_resources.vcproj
* Removal or addition of ./ prefixes from various files that don't
match the other file specifications within their individual
.vcproj files:
chrome/installer/util/util.vcproj
net/build/net.vcproj
net/build/net_unittests.vcproj
* Add missing empty sections (<ToolFiles>, <References>, <Globals>)
for consistency with other .vcproj files:
chrome/tools/test/image_diff/image_diff.vcproj
third_party/libpng/libpng.vcproj
third_party/zlib/zlib.vcproj
* Add missing RootNameSpace attribute:
chrome/test/automation/automation.vcproj
testing/gtest.vcproj
* Use && instead of \r\n as a command separator, to sidestep
XML-generation problems:
chrome/app/chrome_exe.vcproj
* Remove unnecessary (?) duplicate files in the file list:
chrome/browser/views/browser_views.vcproj
(event_utils.cc and event_utils.h were duplicated)
Review URL: http://codereview.chromium.org/17603
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
value of WaitForSingleObject and the error code.
R=eroman
BUG=6500
Review URL: http://codereview.chromium.org/18182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
into their own files to get some files compiling."
Conflicts with something that went in in the interim...
Review URL: http://codereview.chromium.org/18187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
files to get some files compiling.
Review URL: http://codereview.chromium.org/18136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to getting user scripts working in extensions because extensions won't express
their metadata using the UserScript header, so parsing can't be done in the
renderer.
Review URL: http://codereview.chromium.org/18308
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18342
Patch from Steve Krulewitz <skrulx@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
includes a javascript file with stubbed versions of all the
greasemoney API methods as well as changes to the Greasemonkey
slave to inject this javascript file along with other user
scripts into the page.I also have a userscript I'm using for
the unit testing of the API methods. I don't think there is
a good place for it in the chrome tree (if there is I'd like
to know), but you can view it here:
http://skrul.com/greasemonkey/test.user.js
Right now all the tests fail except for testLog and
testUnsafeWindow.
Review URL: http://codereview.chromium.org/18183
Patch from Steve Krulewitz <skrulx@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Added glue code to ResourceHandle for WebMediaPlayerDelegate.
Review URL: http://codereview.chromium.org/18282
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
contains no chunk URLs (i.e. the client is up to date).
We currently don't handle this case properly, which results
in a DCHECK being hit.
BUG=6049 (http://crbug.com/6049)
Review URL: http://codereview.chromium.org/18181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
are now passing due to either recent merges or fixes we've made
recently.
I compared our win baseline to the mac baseline and don't find
differences beyond text metrics and such so I'm marking these
as fixed.
If the test also passed unexpectedly on Linux, I also marked
them as fixed for Linux.
Review URL: http://codereview.chromium.org/18340
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
ui_test build bot since it is a source of regular hangs.
Review URL: http://codereview.chromium.org/18338
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This works by parenting windowed plugins with an HWND that's hosted in the browser process, so that no synchronous cross process messages are used when scrolling.
BUG=5428
Review URL: http://codereview.chromium.org/18082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
#ifdef.
This only partially works. Missing pieces:
- gears resources for HTML dialogs (permissions, shortcut, settings).
- able to compile with a non-official gears build.
Review URL: http://codereview.chromium.org/18299
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18333
Patch from Dan Erat <dan@erat.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the PasswordManager opens, rather than always using the PasswordManager itself as the delegate.
The crash was occuring because before one infobar completely finished closing (i.e during its close animation), another password infobar would be opened, and for a moment in time two infobars are pointing to the same delegate. When the initial closing animation completes, it would null-out a field (pending_decision_manager_), which the now visible infobar would depend on when the user clicks one of the native buttons. This click would dereference a null member, hence causing the crash.
Other clients of infobars seem to be immune to this problem because they either all create dedicated delegate instances per infobar, or they don't reset any state on InfoBarClosed.
I think (at the very least) the infobar code should document that it can be risky to use a "shared" delegate due to the possibility of two simultaneously visible infobars referring to the same delegate.
Review URL: http://codereview.chromium.org/18065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ChromeViews dependency. (Required for porting).
TEST=Open two browser windows. In one, enter "javascript:alert('Foo');" into the address bar and hit enter. Click on the other window. The modal dialog should be focused and the window it was opened over should flash in the taskbar,
Review URL: http://codereview.chromium.org/18179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tony
Review URL: http://codereview.chromium.org/18337
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18336
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It turns out that the LayoutTestControllers are only reset
when a test is started. Some tests leave sub-windows open
(e.g. http/tests/security/aboutBlank/security-context-window-open.html)
When these tests are run through the purify runner - which
only runs one test per test shell - the effect is that the
LayoutTestController does not get cleaned up.
BUG=5329
Review URL: http://codereview.chromium.org/18300
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The ui tests continued to time out after this test was disabled.
Looks like someone disconnected the bot and fixed something. the
tests are now all passing, so I think we can re-enable.
Review URL: http://codereview.chromium.org/18331
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
we don't actually want to run this code on windows.
TBR=evanm
Review URL: http://codereview.chromium.org/18171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18332
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/16611
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
data is generated and included in the .pak file, we need to add
a dependency in the SCons build. Making the corresponding
changes to mac/win is harder, so punting for now.
Review URL: http://codereview.chromium.org/18127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
plugin supported mime types.
R=jam
Review URL: http://codereview.chromium.org/18141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For the moment, it only works on Linux, although it should be pretty easy to
get it working on Mac with __builtin_return_address and __builtin_frame_address.
It will mostly fail to resolve functions. Use this wrapper script:
import os
import sys
import subprocess
import re
address = re.compile('.*\[(0x[0-9a-fA-F]{4,8})\].*')
if __name__ == '__main__':
p = subprocess.Popen(sys.argv[1:], stderr = subprocess.STDOUT, stdout = subprocess.PIPE)
addr2line = subprocess.Popen(['addr2line', '-e', sys.argv[1], '-f', '-C', '-s'],
stdout = subprocess.PIPE, stdin = subprocess.PIPE)
for line in p.stdout.readlines():
m = address.match(line);
if m is not None:
addr2line.stdin.write(m.groups()[0] + '\n')
function = addr2line.stdout.readline()[:-1]
location = addr2line.stdout.readline()[:-1]
sys.stdout.write('%s (%s)\n' % (function, location))
else:
sys.stdout.write(line)
Review URL: http://codereview.chromium.org/18303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
windows are closed when they receive a notification rather than by being called directly from BrowserList. Also browser_list.cc should not include window.h, required for porting.
TEST=Open browser. Open options dialog box. Close browser. Options dialog should close too.
Review URL: http://codereview.chromium.org/18328
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/18023
Review URL: http://codereview.chromium.org/18167
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18325
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
priority.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/18168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- unforking TestShell::CreateNewWindow, all code must live in a platform's
Initialize method instead (some tests rely on knowing what CreateNewWindow
does). (mac had issues w/ this)
- Mac: make the code path for tests that forces down windows properly clean up
the bits in the same way a trip through the event loop would.
- add a few more logs/checks in the mac code to catch issues.
Review URL: http://codereview.chromium.org/18166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18330
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18164
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(http://crbug.com/6093).
The directionality of gears button is already fixed.
This CL fixes the wrong location of ":".
It adds RLM at the end of string "Google Gears:" for Hebrew and Arabic Chrome,
so that the ":" in "Google Gears:" in Hebrew is displayed leftmost instead of
rightmost.
Test:
1) open chrome, Hebrew UI
2) option -> under the hood -> google gears
Without the fix, the name appears as "Google Gears:".
With the fix, the name appears as ":Google Gears".
Review URL: http://codereview.chromium.org/18279
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=macdome
Review URL: http://codereview.chromium.org/18140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=945322
Review URL: http://codereview.chromium.org/17459
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rebaseline this for two reasons:
. We've turned on pan and scroll, which results in different middle mouse behavior.
. we don't support an OTHER mouse button, resulting in different mouse events.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/18157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18160
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8194 0039d316-1c4b-4281-b951-d872f2087c98
|