summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Also return bookmark index through bookmarks API.kuchhal@chromium.org2009-08-201-1/+4
| | | | | | Review URL: http://codereview.chromium.org/173074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23840 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit DEPS roll 47547:47575.dimich@google.com2009-08-202-1/+9
| | | | | | | | | TBR=jianli BUGS=19835 TEST=none Review URL: http://codereview.chromium.org/174147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23839 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old filters that aren't necessary now that SpellCheck is disabled.erikkay@chromium.org2009-08-201-4/+1
| | | | | | | | TBR: huanr BUG=19833 BUG=19834 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23838 0039d316-1c4b-4281-b951-d872f2087c98
* Fix theme install on 64 bit chromium builds.tony@chromium.org2009-08-201-4/+4
| | | | | | | | | | Extension signature sizes are always 4 bytes, not variable depending on platform. Review URL: http://codereview.chromium.org/173104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23837 0039d316-1c4b-4281-b951-d872f2087c98
* Make new FTP the default on Windows. Use the --wininet-ftpwtc@chromium.org2009-08-203-12/+11
| | | | | | | | | | | | command-line switch to select the old WinInet-based FTP implementation. R=phajdan.jr BUG=http://crbug.com/4965 TEST=none Review URL: http://codereview.chromium.org/173099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23836 0039d316-1c4b-4281-b951-d872f2087c98
* Fix log message during install.kuchhal@chromium.org2009-08-201-2/+1
| | | | | | | | BUG=19745 Review URL: http://codereview.chromium.org/174084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23835 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Attempt #2 at updating PRIMARY selection on Ctrl-C in omnibox.derat@chromium.org2009-08-202-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | r23596 was the original attempt; r23714 reverted it. Using gtk_text_buffer_copy_clipboard() gives the GtkTextBuffer ownership of the GtkClipboard and appears to prevent it from unhighlighting its text. Tested as follows: 1. Select text in webkit and hit Ctrl-C; check that both the PRIMARY and CLIPBOARD selections contain it. 2. Click in the omnibox. All of the text gets highlighted. Check that the PRIMARY selection contains the omnibox text and the CLIPBOARD selection contains the webkit text. 3. Type Ctrl-C and confirm that the CLIPBOARD selection now contains the omnibox text. 4. Copy webkit text back to both selections. 5. Type Ctrl-L. The omnibox text gets highlighted but both selections still contain the webkit text. 6. Type Ctrl-C and confirm that both selections now contain the omnibox text. 7. Try hitting Ctrl-C again while the omnibox text is on the CLIPBOARD selection to make sure that a bizarre GTK crash doesn't occur (see comment in code). BUG=19648 TESTED=see above Review URL: http://codereview.chromium.org/173098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23834 0039d316-1c4b-4281-b951-d872f2087c98
* Remove personalization.h/cc by putting things in final resting placestim@chromium.org2009-08-2020-385/+140
| | | | | | Review URL: http://codereview.chromium.org/173085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23833 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline slider mouse events test (changed upstream ↵victorw@chromium.org2009-08-202-5/+11
| | | | | | | | | | | http://trac.webkit.org/changeset/45658) TBR=dglazkov TEST=LayoutTests\fast\forms\slider-mouse-event.html BUG=16289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23832 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline editing test imagesvictorw@chromium.org2009-08-205-8/+2
| | | | | | | | | TBR=dglazkov TEST=layout test BUG=17883 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23831 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r23820 by mnaganov due to Interactive Test failuresasargent@chromium.org2009-08-2010-254/+32
| | | | | | | | | TBR=brg TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23830 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the compile for TOOLKIT_VIEWS.phajdan.jr@chromium.org2009-08-201-1/+1
| | | | | | | | TBR=tony Review URL: http://codereview.chromium.org/174146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23829 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Reapply r23734, fixing destruction order issues.erg@google.com2009-08-203-9/+131
| | | | | | | | http://crbug.com/18856 Review URL: http://codereview.chromium.org/174100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23828 0039d316-1c4b-4281-b951-d872f2087c98
* Add (incomplete) UI for creating application shortcuts on Linuxphajdan.jr@chromium.org2009-08-205-11/+146
| | | | | | | | | TEST=none http://crbug.com/17251 Review URL: http://codereview.chromium.org/171082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23827 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Make sure that the window tooltip is within the browser viewport.arv@google.com2009-08-201-8/+18
| | | | | | | | | | | | | | BUG=18534 TEST=Open a new window. Open several tabs in this window and then close the window. An item representing this window should be shown on the new tab page. Hover this item (or tab to it). The tooltip should be repositioned so that it is not clipped by the window viewport. Review URL: http://codereview.chromium.org/173100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23825 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Remove the DownloadsHandler from the new tab page.arv@google.com2009-08-202-16/+0
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/174099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23824 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: make cpu profiler buildable with tcmalloc (does not enable tcmalloc).willchan@chromium.org2009-08-201-8/+18
| | | | | | | | | I forgot to add the cpu profiler files last time and got surprised when CPUPROFILE didn't do anything. I've added the files in now. I also made the libcmt dependency specific to windows, since the make build doesn't like it. Review URL: http://codereview.chromium.org/173110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23823 0039d316-1c4b-4281-b951-d872f2087c98
* Do extensions update manifest XML parsing in a sandboxed process.asargent@chromium.org2009-08-2015-439/+724
| | | | | | | | | | | | | | | | This involves moving the xml parsing code from static functions in extension_updater.cc to a UpdateManifest class, and switching from logging any errors directly to collecting them up and passing them across the IPC channel. BUG=http://crbug.com/12677 TEST=extensions auto-update should still work correctly Review URL: http://codereview.chromium.org/164541 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23822 0039d316-1c4b-4281-b951-d872f2087c98
* Various omnibox UI fixes:rohitrao@chromium.org2009-08-203-37/+80
| | | | | | | | | | | | | * Truncate match contents to 70% of the available width, reserving 30% for the description. * Animate omnibox shrinkage. BUG=14898 TEST=Omnibox should animate smaller, but not bigger/opened/closed. Match description should always be partially visible, if present. Review URL: http://codereview.chromium.org/173002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23821 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools l10n: generate localized strings and use them.mnaganov@chromium.org2009-08-2010-32/+254
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/174140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23820 0039d316-1c4b-4281-b951-d872f2087c98
* Don't compile with TraceLog support on by default.deanm@chromium.org2009-08-201-0/+7
| | | | | | | | | | | This is just some experimental performance code. Previously it was creating a singleton object which created a ProcessMetrics object. This caused a bunch of possibly expensive calls to query system information to happen on startup. Review URL: http://codereview.chromium.org/174118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23819 0039d316-1c4b-4281-b951-d872f2087c98
* Change default memory model from MEDIUM to HIGH.mbelshe@google.com2009-08-201-1/+1
| | | | | | | | | | | | | | | This will eliminate the workingsetsize reductions that we currently do in the browser. Memory usage will increase by about 25%. But it should alleviate swapping issues that some users are seeing. BUG=none TEST=none Review URL: http://codereview.chromium.org/173057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23818 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Remove resource panel-related RPC methods.pfeldman@chromium.org2009-08-205-90/+35
| | | | | | Review URL: http://codereview.chromium.org/174142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23817 0039d316-1c4b-4281-b951-d872f2087c98
* linux: Plugin descriptions can be UTF-8.evan@chromium.org2009-08-201-1/+1
| | | | | | | | | | | Tested with a Japanese locale, I saw Japanese plugin descriptions when I assumed UTF-8. BUG=18866 Review URL: http://codereview.chromium.org/174078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23815 0039d316-1c4b-4281-b951-d872f2087c98
* Change an ASSERT_TRUE to a CHECK() to remove the gtest dependency.evan@chromium.org2009-08-201-1/+1
| | | | | | | | This fixes the shared build. Review URL: http://codereview.chromium.org/173083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23814 0039d316-1c4b-4281-b951-d872f2087c98
* Essentially revert r16636. We get no speedup from using CIImage and we are ↵avi@chromium.org2009-08-201-14/+3
| | | | | | | | | | | susceptible to random leaks. BUG=http://crbug.com/18661 TEST=throbbers should work just fine Review URL: http://codereview.chromium.org/171110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23813 0039d316-1c4b-4281-b951-d872f2087c98
* Add filter for a new reliability regression.maruel@chromium.org2009-08-201-0/+3
| | | | | | | | | BUG=19813 TBR=jam TEST=none Review URL: http://codereview.chromium.org/173120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23812 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Add delegate for method added upstream.pfeldman@chromium.org2009-08-201-1/+1
| | | | | | Review URL: http://codereview.chromium.org/173119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23811 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 23809.sgjesse@chromium.org2009-08-201-1/+1
| | | | | | | | | | | | Updating V8 to version 1.3.5 caused crashed on ChromeBot. TEST=none BUG=none TBR=ager@chromium.org Review URL: http://codereview.chromium.org/174135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23810 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 in Chromium to version 1.3.5.sgjesse@chromium.org2009-08-201-1/+1
| | | | | | Review URL: http://codereview.chromium.org/173058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23809 0039d316-1c4b-4281-b951-d872f2087c98
* Add WebPlugin::acceptsInputEvents method.darin@chromium.org2009-08-204-0/+9
| | | | | | | | | | | | | | This allows us to restore a windowless_ check that used to exist in webplugin_impl.cc prior to r23797. The goal of this change is to not handle input events for windowed plugins. R=hbono BUG=none TEST=pending/plugins/iframe-shims.htm Review URL: http://codereview.chromium.org/173114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23808 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 23805.abarth@chromium.org2009-08-203-4/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23807 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor OCSP handler.ukai@chromium.org2009-08-201-141/+48
| | | | | | | | | | | | | | Get rid of the Core class and merge into OCSPRequestSession. OCSPCreate adds ref to the OCSPRequestSession and OCSPFree calls OCSPRequestSession::Cancel and releases a reference to it. BUG=none TEST=none Review URL: http://codereview.chromium.org/173051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23806 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the XSSAuditor by default. Please watch out for compatibility issues.abarth@chromium.org2009-08-203-5/+4
| | | | | | Review URL: http://codereview.chromium.org/174013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23805 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit deps: r47528:47546jorlow@chromium.org2009-08-202-1/+9
| | | | | | | | | TEST=none BUG=19796 Review URL: http://codereview.chromium.org/173113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23804 0039d316-1c4b-4281-b951-d872f2087c98
* Splits the menu classes into individual files in anticipation ofsky@chromium.org2009-08-2018-11/+3988
| | | | | | | | | | | porting them. BUG=none TEST=make sure to thorougly test bookmark menus on windows. Review URL: http://codereview.chromium.org/173091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23801 0039d316-1c4b-4281-b951-d872f2087c98
* Need to cast to WebCore::Widget explicitly since the method beingdarin@chromium.org2009-08-201-2/+4
| | | | | | | | | | | | called takes a void pointer! Argh :( TBR=jam BUG=10036 TEST=covered by layout tests Review URL: http://codereview.chromium.org/174126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23800 0039d316-1c4b-4281-b951-d872f2087c98
* Move WebPluginContainer into the WebKit APIdarin@chromium.org2009-08-2013-648/+892
| | | | | | | | | | | | | | | | | | | | | | This change introduces the following new interfaces: WebPlugin WebPluginContainer The implementation of WebPluginContainer is moved to webkit/api/src/WebPluginContainerImpl.{h,cpp}, and WebPluginImpl from webkit/glue now implements WebKit::WebPlugin. This change does not completely eliminate dependencies in WebPluginImpl on WebCore. The rest will be removed in a separate change. A hack was added to TemporaryGlue to deal with the fact that ChromeClientImpl still resides in webkit/glue. Also, StackingOrderIterator in webkit/glue because there is another CL out to remove that from the source tree. Note: This change depends on another CL that I am brewing to make WebCanvas be a CGContext on Mac. R=jam BUG=10036 TEST=covered by existing tests Review URL: http://codereview.chromium.org/165464 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23797 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a line that was accidently deleted in my plugin change.jam@chromium.org2009-08-201-1/+1
| | | | | | | TBR=ananta Review URL: http://codereview.chromium.org/173108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23794 0039d316-1c4b-4281-b951-d872f2087c98
* Make unit_tests UtilityProcessHostTest use the helper app on the Mac.mark@chromium.org2009-08-203-20/+26
| | | | | | | | | | BUG=none, not worth it for this TEST=unit_tests '--gtest_filter=UtilityProcessHostTest*' runs Chromium Helper, not Chromium. No application icon should appear in the dock during this test. Review URL: http://codereview.chromium.org/174061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23792 0039d316-1c4b-4281-b951-d872f2087c98
* Omit DLOGs and DCHECKs from release-mode Google Chrome-branded builds onmark@chromium.org2009-08-201-5/+15
| | | | | | | | | | | | | non-Windows. They were previously omitted on Windows official builds only. BUG=16512 TEST=DCHECK logging unavailable in official builds; Mac .app shrinks by about 740kB; Mac .dmg shrinks by about 315kB; Linux binary and package shrink by similar amounts Review URL: http://codereview.chromium.org/171093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23791 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that SyncWaiter (base/waitable_event_posix.cc) condition variablesmark@chromium.org2009-08-201-37/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | cannot be destroyed (pthread_cond_destroy) during a broadcast (pthread_cond_broadcast). SyncWaiter::Fire now holds the lock until the broadcast is complete. Given the lock ordering, this guarantees that the condition variable cannot be destroyed until it is safe to do so. Holding the lock through the broadcast is harmless, as pthread_cond_wait and pthread_cond_timedwait will simply block (if needed) until able to take the lock prior to returning. Ownership of the lock and condition variable is moved to SyncWaiter for better self-documentation. The only true functional change here, however, is the duration that SyncWaiter::Fire holds the lock. This bug caused hangs in optimized official release builds on the Mac when DCHECKS were optimized away. The DCHECK optimization was initially covered in bug 16512 r20497 and was backed out due to bug 16871 r20889. The optimization changed the timings just enough that we wound up hitting this case. On the Mac, pthread_cond_broadcast wound up blocking indefinitely (with a trashed stack) when its condition variable was destroyed beneath it; this caused other locks held by its thread to never be released, resulting in other threads becoming deadlocked and made the bug particularly difficult to diagnose. BUG=19710 TEST=Application works with no unexplained deadlocks, hanging, or crashing base_unittests (specifically WaitableEvent*) ipc_tests (especially IPCSyncChannelTest.ChattyServer, which would hang previously on the Mac with DCHECKs optimized away) Review URL: http://codereview.chromium.org/173059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23790 0039d316-1c4b-4281-b951-d872f2087c98
* Make the paths in the layout test dashboard point to the actual JSONojan@google.com2009-08-202-14/+38
| | | | | | | | | | | | files now that they're available on the bots. Also a couple bug fixes: -Don't remove whitespace from the expectations JSON since there is legitimate whitespace in the values. -Fix bug in generated HTML for the links in the header. Review URL: http://codereview.chromium.org/173096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23789 0039d316-1c4b-4281-b951-d872f2087c98
* remove SpellCheckTest.*, since it's consuming nearly 400MB of purify spaceerikkay@chromium.org2009-08-201-1/+1
| | | | | | TBR: huanr git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23788 0039d316-1c4b-4281-b951-d872f2087c98
* Updates to test_expectations for fallout from webkit merge to 47528.jparent@chromium.org2009-08-201-0/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/173105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23787 0039d316-1c4b-4281-b951-d872f2087c98
* Added linux baseline failure back to test_expectations listvictorw@chromium.org2009-08-201-0/+1
| | | | | | | | | TBR=dglazkov BUG=17883 TEST=layout test git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23785 0039d316-1c4b-4281-b951-d872f2087c98
* Roll the WebKit deps r47417:47528.jorlow@chromium.org2009-08-202-3/+101
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/173094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23782 0039d316-1c4b-4281-b951-d872f2087c98
* Add failed editing tests to test_expectationsvictorw@chromium.org2009-08-201-0/+5
| | | | | | | | | TBR=dglazkov BUG=17883 TEST=layout tests git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23781 0039d316-1c4b-4281-b951-d872f2087c98
* Try to shutdown the browser more peacefully before using more brutal methods.phajdan.jr@chromium.org2009-08-192-33/+33
| | | | | | | | | | | | | Also, do proper cleanup before browser shutdown in MetricsService UI test. I hope this will reduce the flakiness. TEST=none BUG=none Review URL: http://codereview.chromium.org/173023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23780 0039d316-1c4b-4281-b951-d872f2087c98
* Update test expectation list to assign new bug or associate old bug for somejianli@chromium.org2009-08-191-6/+10
| | | | | | | | | | | tests under LayoutTests/platform/mac that fail for specific reasons. BUG=none TEST=none Review URL: http://codereview.chromium.org/174040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23779 0039d316-1c4b-4281-b951-d872f2087c98