| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=0
TEST=n/a
Review URL: http://codereview.chromium.org/899003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37353
TEST=this is a test
Review URL: http://codereview.chromium.org/843004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In most case, this won't happen because
the parent view sets child view's parent to
NULL before deletion. This is necessary to safely
delete view that is not owned by parent.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/872006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Introduced panel's state to manage which notifications will be shown.'
* Added "OnPanelStateChanged" to PanelController::Delegate method to monitor the panel's state.
* Removed unnecessary SetSize in BalloonViewImpl. The size is set in BalloonViewImpl::Layout.
BUG=33306
TEST=This requires chromeos's wm and system notification to test (which does not exit yet).
None for now but I am writing unittest now.
Review URL: http://codereview.chromium.org/874004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
fixed bugs, added calls to parent class constructor to classes that didn't have them before, added a few demos to exhibit/test textures and render surfaces.
Review URL: http://codereview.chromium.org/856004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Handling pointer sized items
- Beefing up unit tests
- Beefing up integration tests
- Enabling Process, Thread and Token IPCs
- Making validation tests compile again
BUG=27218
TEST= unit tests included
Review URL: http://codereview.chromium.org/757001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36487
TEST=Open bookmark folder. Clicking both the bookmark bar and its opening folder should dismiss it.
Review URL: http://codereview.chromium.org/857009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the renderer.
BUG=35204
TEST=Manual testing with screenshot extension.
Review URL: http://codereview.chromium.org/885006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I suspect it is the cause of the flakiness.
BUG=37109
TEST=Watch the bots to see if it is still flaky.
Review URL: http://codereview.chromium.org/870008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FullTabModeIE_UnloadEventTest.
Revert 41463 - When ChromeFrame switches to IE on receiving the OnHttpEquiv notification indicating the presence of a meta
tag indicating that the page is to be rendered in Chrome, we check if the notification is received for a
site rendered in an IFrame to ensure that we don't switch in this case. This code is not reliable and we end
up assuming that a top level navigation is actually an embedded frame.
To work around this we now maintain a pending navigation count in BeforeNavigate2, which is decremented in
NavigateComplete2 and NavigateError. We perform the check for an embedded document only if the pending navigation
count is greater than 1.
This fixes http://code.google.com/p/chromium/issues/detail?id=36825
The other change made is to add a delay of 100ms in SendString between each character to better reflect actual
timing for real user input.
Bug=36825
Review URL: http://codereview.chromium.org/837008
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/877009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=tested manually with non-gmail google account
Review URL: http://codereview.chromium.org/863006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use the new method to avoid using CopyFromBackingStore() for screen captures when CopyFromBackingStore() will not give a flawless copy.
BUG=35204
TEST=Manual testing with example screenshot extension.
Review URL: http://codereview.chromium.org/830001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/905002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows: Add UMA metrics for each time that the bookmarks toolbar menu
button it's clicked.
Since it isn't fully supported we need this to know how many people
are using it.
BUG=36191
TEST=none
Review URL: http://codereview.chromium.org/885005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mar 2010) | 8 lines
Fix the rest of the gtk/options directory to use new callback macros.
Problematically, the callback macros don't cover the case where the GObject* isn't a GtkWidget* D:
BUG=None
TEST=compile
it's breaking unit tests
Review URL: http://codereview.chromium.org/886005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
"Change Mac to DCHECK if NetworkChangeNotifier observer list is not empty by destruction time."
Apparently NetworkChangeNotifierMac's observers are still getting leaked in ExtensionApiTest.ShowPageActionPopup.
Review URL: http://codereview.chromium.org/871007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
indicating the presence of a meta
tag indicating that the page is to be rendered in Chrome, we check if the notification is received for a
site rendered in an IFrame to ensure that we don't switch in this case. This code is not reliable and we end
up assuming that a top level navigation is actually an embedded frame.
To work around this we now maintain a pending navigation count in BeforeNavigate2, which is decremented in
NavigateComplete2 and NavigateError. We perform the check for an embedded document only if the pending navigation
count is greater than 1.
This fixes http://code.google.com/p/chromium/issues/detail?id=36825
The other change made is to add a delay of 100ms in SendString between each character to better reflect actual
timing for real user input.
Bug=36825
Review URL: http://codereview.chromium.org/837008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This uses the 16x16 icon as defined in the manifest for extension pages.
BUG=36514
TEST=Open the new bookmark manager. It should now show its favicon.
Review URL: http://codereview.chromium.org/650185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/894002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=maruel
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/916001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
destruction time.
Review URL: http://codereview.chromium.org/870003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Problematically, the callback macros don't cover the case where the GObject* isn't a GtkWidget* D:
BUG=None
TEST=compile
Review URL: http://codereview.chromium.org/857006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=36687
Review URL: http://codereview.chromium.org/854005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=pfeldman
Review URL: http://codereview.chromium.org/895004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
DPI only in the PrintBegin method. The plugin is expected to remember this until PrintEnd is called.
BUG=None
TEST=Test printing with plugins that support the new interface
Review URL: http://codereview.chromium.org/858007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19476
TEST=prefs dialog is usable under RI (scrolling Under the Hood is wonky; don't think we can fix that)
Review URL: http://codereview.chromium.org/915001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/876002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Get model, add/remove, add folder, reparent, change title/url.
BUG=34492
Review URL: http://codereview.chromium.org/792003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37707
TEST=build Chrome on Mac
Review URL: http://codereview.chromium.org/853007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
manifest changes on browser restart.
BUG=24850
Review URL: http://codereview.chromium.org/789007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of letting Omaha do it.
BUG=37410
R=cpu
TEST=Install system-level chrome, then install user-level chrome. System-level Chrome should launch (with err message)
Review URL: http://codereview.chromium.org/878002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/822008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=35248
TEST=Switch the language used by the ChromiumOS using the top left corner menu of the Network selection wizard.
Or you may use the following command on desktop using Chromium (built with GYP_DEFINES="chromeos=1"):
out/Debug/chrome --login-manager --login-screen=nework
Review URL: http://codereview.chromium.org/912001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
if the server requests a client certificate. This is an interim
solution until we modify SSLClientSocketNSS to use CryptoAPI to
do SSL client authentication.
R=mbelshe
BUG=37560
TEST=SSL client authentication should continue to work on Windows.
Review URL: http://codereview.chromium.org/795006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/903001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Finnur fixed the test a few days ago.
TBR=finnur
TEST=none
BUG=38065
Review URL: http://codereview.chromium.org/854009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
launching into Browser for easier access by the launcher.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/668245
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=finnur
TEST=none
BUG=38065
Review URL: http://codereview.chromium.org/897004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Unit tests for the autofill change processor. This includes changes from the chrome side -- a user adding, updating, and removing an autofill entry. Also tests handing of errors during change processing. Includes a bug fix for autofill remove.
Review URL: http://codereview.chromium.org/837005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The code for that was already there, but it didn't fire, because clicking on a bookmark button dismissed the bookmark folder controller.
BUG=36487
TEST=click bookmark bar folder twice. first click should open menu, second should close.
Review URL: http://codereview.chromium.org/870006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
"broken but pretty".
BUG=http://crbug.com/19476
TEST=run in RI and see themes. Still broken a bit but a lot better.
Review URL: http://codereview.chromium.org/879003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=37960
TEST=Unit tests provided, run chrome_tests.
Checking in patch from Denis Romanov, reviewed as:
http://codereview.chromium.org/889001/show
Review URL: http://codereview.chromium.org/842007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Purely cleanup, no functional changes.
Review URL: http://codereview.chromium.org/855003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The key change here is to use the return value from placement
new rather than casting buf_. Avoiding the cast avoids the
strict aliasing issue.
BUG=28749
Review URL: http://codereview.chromium.org/548011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NPN on resume was broken symmetrically between OpenSSL and NSS (which
is probably why we didn't notice for so long). OpenSSL wasn't
expecting the message and NSS wasn't sending it.
This change sends the NextProtocol message when resuming and disables
NPN when not using SPDY.
The reason for the latter is that we have GFEs deployed which don't
expect NextProtocol when resuming and we have to wait some time before
they get replaced. Because of this, we can't have NPN enabled by
default. Instead, we'll use --host-resolver-rules to redirect
everything to known-good GFEs in the mean time.
http://codereview.chromium.org/841003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
warnings from the 10.6 toolchain.
BUG=none
TEST=less warnings on 10.6 builds, everything still works
Review URL: http://codereview.chromium.org/838005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If it's set (in System Prefs) to minimize windows on double-click (on the title
bar), double-clicking on the blank area of the floating bar will beep.
BUG=37972
TEST=Make sure Minimize is disabled in the Window menu, Cmd-M shouldn't work, and double-clicking on the blank area of the floating bar shouldn't minimize (it should beep if System Prefs is set as described above).
Review URL: http://codereview.chromium.org/862007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NetworkManager
NOTE: Adds a new build dependency on dbus-glib, on ubuntu you can meet this with:
$ sudo aptitude install dbus-glib-1-dev
BUG=http://crbug.com/37199
TEST=use browser with --enable-geolocation
Review URL: http://codereview.chromium.org/787003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/865003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=evan
BUG=30785
TEST=none
Review URL: http://codereview.chromium.org/840004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41428 0039d316-1c4b-4281-b951-d872f2087c98
|