| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
checked in last time (and give it a different bug number),
add one that got away
BUG=11282,17966,20320,20653,20659
TEST=green valgrind bots
Review URL: http://codereview.chromium.org/177034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20577
TBR=rafaelw@chromium.org
Review URL: http://codereview.chromium.org/177032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DEBUG, since they were fixed by Skia r341 (which included the
appropriate fix for the assertion failure).
BUG=http://crbug.com/19397
TEST=Green is good.
TBR=dglazkov
Review URL: http://codereview.chromium.org/183013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
test from test_expectations.txt.
BUG=None
TEST=Green is good.
TBR=dglazkov
Review URL: http://codereview.chromium.org/180039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
failures. This update also improves path rendering (missing pixels are no longer missing).
BUG=http://crbug.com/18896
TEST=None
TBR=dglazkov
Review URL: http://codereview.chromium.org/177033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Getting to the tail end of a fishing expedition on ui tests on linux and mac.
BUG=11282,16326,20581,20641
TEST=green ui valgrind mac & linux
Review URL: http://codereview.chromium.org/175023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is what it looks like with this change:
http://dl.getdropbox.com/u/124107/cap.png
Note that this removes the information about content scripts.
I would actually like to expand that information to show all
the components of the extension eventually, but with just
content scripts, it didn't seem super useful.
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=erikkay
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/173623
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the New Tab page.
BUG=http://crbug.com/20415
TEST=With the extension toolstrip visible, go to the New Tab page and press Ctrl + Alt + B. Watch the toolstrip merge into the New Tab page and back again into a separate toolstrip (when you press Ctrl + Alt + B again). Also, when you do this on a regular webpage (as opposed to NTP) this should toggle the toolstrip visiblity.
Review URL: http://codereview.chromium.org/175017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
selecting a new tab.
BUG=20583
TEST=Open a browser with two tabs. Select the unselected tab. The now-unselected tab should be rendered as unselected.
Review URL: http://codereview.chromium.org/182025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
weren't hitting the codepath that initializes this variable, leading to a UMR that caused glitchy rendering.
BUG=20157
TEST=Drag a tab. The rendering should not be glitchy.
Review URL: http://codereview.chromium.org/176035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
other paths in the browser, like navigating away from Interstitial pages, etc. We end up crashing the browser because of dereferencing a NULL reply_message pointer.
Added a check for the same.
This fixes http://b/issue?id=2057296
Bug=2057296
Review URL: http://codereview.chromium.org/179024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Widen a couple errors, add a few new ones.
This handles most of the errors in the last run on the mac valgrind ui bots.
TBR stuartmorgan
BUG=17291,17451,19191,20580,20581,20582,20616,20617
Review URL: http://codereview.chromium.org/178032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Patch contributed by thiago.farina@gmail.com
Review URL: http://codereview.chromium.org/173260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/175021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: finnur
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- The failure was happening because of my change to use api_test.js in the test. Because of that, there were now two calls to chrome.test.pass(), and I was asserting that there had been only one. This was only failing under Release, presumably because it wound up getting both pass events in the single event loop (a timing issue).
BUG=none
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Overrides
Review URL: http://codereview.chromium.org/181012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ui_tests needs to be considered as a "large module" now otherwise linking failure may happen.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/182016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
download shelf.
BUG=20343
TEST=Look at it.
Review URL: http://codereview.chromium.org/173621
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This caused the possible url dialog in the options menu to never load favicons, and instead DCHECK (crashing debug builds).
Review URL: http://codereview.chromium.org/179034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20236
TBR=aa
Review URL: http://codereview.chromium.org/178028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=10384
TEST=Covered by layout tests.
Review URL: http://codereview.chromium.org/180035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/180030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This adds constructor arguments for socket idle timeouts. This allows me to control it for testing, and also makes it possible to run experiments on how long to enable it for.
Currently I've set the timeout for unused sockets to 10 seconds, since that will cover 90% of the TCP RSTs we're seeing. We can probably increase this, but I'm waiting on histogram data to decide what to change it to.
BUG=http://crbug.com/18192
Review URL: http://codereview.chromium.org/176021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20573
TEST=Install sample extensions without modifying command line flags. They should install (and run on next startup).
Review URL: http://codereview.chromium.org/179032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
fail on that platform.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/178031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=10416
TEST=Covered by layout test.
Review URL: http://codereview.chromium.org/176030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
closed bugs when removing the last test for that bug.
TBR=jparent@chromium.org
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/182022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jparent@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/182020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were already doing this, this change modifies the
mechanism. Before we were relying on the presence of the
--enable-extensions flag, but as we are getting ready to
remove that on dev, we needed something else.
This forces local storage and database to be enabled on
chrome-extension:// pages.
Also, change the way database enabling works in general to
be more like the way local storage works, just for
consistency. Will remove old, unnecessary WebKit API in an
upstream change.
erikkay: extensions stuff
dumi: database stuff
jorlow: local storage stuff
BUG=19511
Review URL: http://codereview.chromium.org/173306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
longer flaky.
BUG=18569,13692,10374,10375,10384,10418,9798,11469,11810,20442
TEST=Covered by layout tests
Review URL: http://codereview.chromium.org/173618
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
test-expectations - it has been passing on all platforms since webkit merge to 47873, and was likely fixed by http://trac.webkit.org/changeset/47872. Thank you flakyness dashboard!
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173619
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/182019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=aa, rafaelw
Review URL: http://codereview.chromium.org/183009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
http://crbug.com/17251
Review URL: http://codereview.chromium.org/179008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/178026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
cf. http://build.chromium.org/buildbot/waterfall/builders/Linux%20UI%201%20of%203%20(valgrind)/builds/65/steps/valgrind%20test%3A%20ui/logs/stdio
BUG=19191,20541
Review URL: http://codereview.chromium.org/181008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/183007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17363, 20407
TEST=none
Review URL: http://codereview.chromium.org/174327
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
whose images have failed to process correctly, drop back to the default theme.
BUG= http://crbug.com/20263
TEST= Use a preferences file from an older version of Chrome that has a theme installed, and open Chrome. Observe that Chrome opens using the default theme.
Review URL: http://codereview.chromium.org/175013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
asynchronous IO.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/178023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Factor out common window rounding code from two places where it was used,
generalize it, and use it to round the "Search site for:" hint in the location
bar. Theoretically, people should be able to use this anywhere they need a
window to have rounded corners.
http://crbug.com/18310
Review URL: http://codereview.chromium.org/179026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit e6ab23c81e56c6b9fbb062bbb090a648e6ebef12.
TBR=beng
Review URL: http://codereview.chromium.org/183006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor so that the dialog is shown by calling BrowserWindow::ShowRepostFormWarningDialog
BUG=19761
TEST=see bug
Review URL: http://codereview.chromium.org/174294
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160401
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This should help with decision which FTP server types we can safely stop supporting.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/176020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/20506
TEST= Install any theme. Observe that tips are legible.
Review URL: http://codereview.chromium.org/182012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Left a TODO to rename the class to something more general but
it is preferable to do a rename separate from code changes, it
will make things easier to sync and be quicker since that change
is relatively trivial.
The exact look may be changed later but I'll attach screenshots
to this issue to show the initial implementation.
Also left as future enhancement is the possibility of limiting
the size of the notification list in cases where a lot of hosts
are affected. The most extreme example I found was some Gizmodo
page with 36 domains using cookies.
BUG=16932
TEST=none
Review URL: http://codereview.chromium.org/179013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The combobox still isn't implemented, but this makes TextBox work, and also
does some changes around the info_bubble to make sure it get created properly.
TEST=none
BUG=none.
Review URL: http://codereview.chromium.org/177026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turns out there's a way to allow sending signals to yourself that works on both 10.5 & 10.6 so use that...
Remove temporary hack to only enable syntax on Leopard.
BUG=20370
TEST=On both 10.5 & 10.6 - Follow repro steps for crash in 20366, browser process should show sad tabs rather than crash.
Review URL: http://codereview.chromium.org/180028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24820 0039d316-1c4b-4281-b951-d872f2087c98
|