| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
allow for a module that fails to load.
R=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2072001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the Mac, always give libwebcore.a to the linker first.
BUG=43791
TEST=unit_tests should link on Mac in debug mode
Review URL: http://codereview.chromium.org/2082002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=jianli@chromium.org
Review URL: http://codereview.chromium.org/2089001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
views::View::PropagateNativeViewHierarchyChanged
BUG=44066
TEST=none
TBR=rvargas
Review URL: http://codereview.chromium.org/2088001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crosbug.com/3247
TEST=Use debug version of Chrome on the device. It should not crash on login.
Review URL: http://codereview.chromium.org/2087001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=44065
TEST=none
TBR=rvargas
Review URL: http://codereview.chromium.org/2064004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebCore::RenderInline::destroy ... HTMLParser::handleResidualStyleCloseTagAcrossBlocks
TEST=none
TBR=rvargas
BUG=44064
Review URL: http://codereview.chromium.org/2085001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider,thestig
Review URL: http://codereview.chromium.org/2065002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Old login screen now is only used as "Other user" screen.
Rare case is when you specifically pass --login-screen=[login|oobe|network] and it's not prefilled with the last user. But that's dev test case.
BUG= http://crosbug.com/2853
TEST=Select "Other user" screen from the login screen with avatars. Username field should be empty.
Review URL: http://codereview.chromium.org/2077001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Because window manager on login screen ignores window position the bubble is shown on the center of screen. It can be closed by ESC or clicking on x-button.
BUG=crosbug.com/2800
TEST=On Chrome OS type wrong password and see the bubble.
Review URL: http://codereview.chromium.org/1990003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crosbug.com/3162
TEST=Change UI language on welcome screen. Combobox should show "No selection" message when network hasn't been selected previously.
Review URL: http://codereview.chromium.org/2011014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ui_test.gtest_linux.txt instead to disable it only under Valgrind Linux.
TEST=none
TBR=rvargas,phajdan.jr
BUG=43974
Review URL: http://codereview.chromium.org/2078001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=44053
TBR=rvargas
Review URL: http://codereview.chromium.org/2073002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and added support for TSan/Win
Review URL: http://codereview.chromium.org/1996016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
stable or dev. Initially just use the same url twice.
Review URL: http://codereview.chromium.org/2013017
TBR=chron@chromium.org
Review URL: http://codereview.chromium.org/2074001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create an initial framework for running tests across all Chrome sandbox types.
Also added 2 simple initial tests to illustrate usage.
The main motivation for adding this code is for an upcoming x-process font loading cl which needs this infrastructure.
Test case registration is currently done manually. It would be better to have a macro that does this at compile time but given the small number of current tests this seems like overkill at this point.
BUG=37285
TEST=Unit tests should pass
Review URL: http://codereview.chromium.org/1993005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Valgrind bot.
TEST=none
BUG=43974
TBR=rvagas,tigerf
Review URL: http://codereview.chromium.org/2073001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Pass default profile and correct top window in OOBE.
BUG=http://crosbug.com/2978
TEST=On welcome screen select encrypted 802.1X network and open "select certificate" dialog. It should open withot crash.
Review URL: http://codereview.chromium.org/2053001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The situations when we need to use HighResNow are really rare,
and I believe this is not one of them.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2042013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
per James Hawkins' request from http://codereview.chromium.org/2055014/show
The problem is that this test does not appear on the flakiness dashboard,
but hopefully the new flakiness bot will help with that.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2012012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL removes the code related to following unconfigurable ibus configs:
general/use_global_engine
general/hotkey/trigger
Their default values will be correctly initialized in ibus.
Also renames following configs:
next_engine renames to next_engine_in_menu
prev_engine renames to previous_engine
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1983009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This fixes a DCHECK failure in webkit/glue/webmediaplayer_impl.cc.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2038013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Visual inspection. The Omnibox should never become visible for tabs with a collapsed toolbar (app tabs). F11 twice should not show the Omnibox.
Review URL: http://codereview.chromium.org/2032015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not sure why it wasn't picked up earlier, but if I build from scratch I get the following error:
--------------------Configuration: chrome_version_header - Release Win32-----------------------
Generating version header file: "C:\b\slave\build\src\chrome\Release/obj/global_intermediate/version.h"
Traceback (most recent call last):
File "tools/build/version.py", line 197, in ?
sys.exit(main())
File "tools/build/version.py", line 169, in main
values = fetch_values(variable_files)
File "tools/build/version.py", line 55, in fetch_values
fetch_values_from_file(values, file_name)
File "tools/build/version.py", line 30, in fetch_values_from_file
for line in open(file_name, 'r').readlines():
IOError: [Errno 2] No such file or directory: 'C:/b/slave/build/src/chrome/Release/obj/global_intermediate/build/LASTCHANGE'
Project : error PRJ0002 : Error result 1 returned from 'C:\Windows\SysWow64\cmd.exe'.
Build log was saved at "file://C:\b\slave\build\src\chrome\Release\obj\chrome_version_header\BuildLog.htm"
chrome_version_header - 1 error(s), 0 warning(s)
TBR=robertshield
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/issues/detail?id=43922.
The active document url was not being updated when we receive the navigation state from chrome. This caused a couple
of chrome frame tests to fail.
Bug=43922
TBR=amit
Review URL: http://codereview.chromium.org/2052011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sync/notifier threads to pass into NetworkChangeNotifierProxy.
Refactored unit tests a bit.
BUG=19784
TEST=unit tests
Review URL: http://codereview.chromium.org/1987013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutoFill heuristics were successfully matching labels such as "First Name" but not "First Name". Extra whitespace and other separator characters are now allowed. There are examples of this in the sample3.html test file.
BUG=38257
TEST=Manual testing against sample3.html, sample6.html, and sample8.html.
NameFieldTest.FirstLastMiddleWithSpaces
Review URL: http://codereview.chromium.org/1993013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes: Adjusted customize sync text field to be as wide as the content view and made it wrap. Created customizeSyncDescriptionTextField_ outlet and hooked it up.
BUG=43945
TEST=manual with French
Review URL: http://codereview.chromium.org/2001018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=43467
TEST=made sure sync_integration_tests don't have any more ~QName crashes
Review URL: http://codereview.chromium.org/2012014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, change "use current" to allow new tab page.
BUG=43802
TEST=manual
Review URL: http://codereview.chromium.org/2012016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
libcros part: http://codereview.chromium.org/2051009
BUG=chromium-os:3226
TEST=manual
Review URL: http://codereview.chromium.org/2003014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ServiceGaiaAuthenticator implementation.
BUG=None.
TEST=None.
Review URL: http://codereview.chromium.org/1992016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:3237
TEST=get debug build, open content browser, right click on a file
Review URL: http://codereview.chromium.org/2025011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2038016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:3211
TEST=Use html in bug, click "test" and then click close button.
App shouldn't freeze.
We will write new tests to cover this. The current ones bypass
the native dialog code and send the events directly. That's
why they didn't catch the regression.
Review URL: http://codereview.chromium.org/2053007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
since. Please look into this and resubmit.
Revert 47065 - An attempt to catch unexpected script errors in html test pages in a more generic way.
TEST=This is meant to help track down flakiness of a few tests.
BUG=none
Review URL: http://codereview.chromium.org/2052006
TBR=tommi@chromium.org
Review URL: http://codereview.chromium.org/2011017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Boot on ARM...boottimes shouldn't display but chrome should
still work. We will be stating a file every half second though
until /tmp/uptime-login-prompt-ready is emited.
Review URL: http://codereview.chromium.org/2007010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was due to a regression introduced recently where we removed
the chrome frame stream cache from the urlmon request object and instead cached the stream passed in. While this was all fine, we failed to handle
the case where an attempt to read from this stream in response to a read request from chrome returned S_FALSE which means end of data, in which case
we should release the stream. Not doing this caused us to not send over the end request notification to chrome, thus causing the tests to indefinitely
wait.
Review URL: http://codereview.chromium.org/2001019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=antonm
Review URL: http://codereview.chromium.org/2062001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2061007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CheckFileBrowseClosed could crash if the delayed execution happens after
FileBrowse popup is destroied. Change the wait to use notification.
BUG=none
TEST=FileBrowseBrowserTest.InputFileTriggerFileBrowse should not crash.
Review URL: http://codereview.chromium.org/2006013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
success regardless of whether we have
a valid delegate or not.
Bug=43927
Review URL: http://codereview.chromium.org/2030009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some timer values were not initialized before we called to
dump histograms, and this was leading to bogus intervals in
our stats, and at times, producing DCHECK() failures (for
overly large values).
BUG=43220
r=davemoore
Review URL: http://codereview.chromium.org/2042007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeFrame maintains the current top level URL
which is used by the moniker patch to decide whether to wrap the callback. This url is typically set in the Bho in the BeforeNavigate
callback. We also had code to update this url when we receive a navigation update from Chrome. The reason we would not switch is because
of a race condition between receiving a top level navigation request from chrome and receiving a navigation update for the previous operation
which caused us to not wrap the bind status callback.
Fix is to not update the url in the callback when we receive a navigation status update. In any case it is Chrome's responsibility to inform
ChromeFrame about top level url navigations. We should fix the bug if any in Chrome which caused this hack to go in.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=43922
Other changes are to replace the NOTREACHED in the chrome frame automation proxy code with a DLOG as this fires during chrome frame test runs.
Bug=43922
Review URL: http://codereview.chromium.org/1991008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
callback OnResponse implementation. Crash
occurs while dereferencing a NULL delegate.
Fix is to add a check for the same. This could happen if the binding was stopped before receiving the OnResponse notification.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=43927
Bug=43927
Review URL: http://codereview.chromium.org/2060002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47085 0039d316-1c4b-4281-b951-d872f2087c98
|