| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
TBR=sergeyu
BUG=53192
Review URL: http://codereview.chromium.org/3197016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
temporary suppressions
BUG=none
TEST=none
TBR=dumi
Review URL: http://codereview.chromium.org/3137036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/57178 broke some tests in browser_test and ui_test.
This patch is same as the patch in http://codereview.chromium.org/3136019/show except test RedirectTest.ClientCancelled.
RedirectTest.ClientCancelled was broken on windows platform when landing the original patch. So I revert it.
After digging in code, I found the root cause of why the test was broken on windows platform. Please refer to
http://crbug.com/53091 for details.
So I add FAILS_ prefix to RedirectTest.ClientCancelled on windows platform.
BUG=17655
TEST=RedirectTest.ClientCancelled, AppApiTest.AppProcess, ExtensionBrowserTest.WindowOpenExtension, ExtensionBrowserTest.WindowOpenInvalidExtension
Review URL: http://codereview.chromium.org/3186023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Preferences.xib changes: Connect the Enabled pin of the "Show home button" checkbox to PreferencesWindowController's showHomeButtonEnabled @property.
BUG=49603
TEST=manual
Review URL: http://codereview.chromium.org/3171022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53184
TBR=timurrrr
Review URL: http://codereview.chromium.org/3112030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=53149
Review URL: http://codereview.chromium.org/3186027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TabContents and an invalid read in ClientSocketBaseHelper
BUG=50936,53187,53188
TBR=glider
TEST=Memory waterfall becomes greener
Review URL: http://codereview.chromium.org/3130049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor the policy template generator in preparation for the Mac manifest and Windows ADMX output files. Replace dictionaries with lists in the input JSON file so that sequence of elements is preserved. Add a list data type for policies, and add extension whitelist/blacklist policy. Split homepage policy group into two.
Previous CL: http://codereview.chromium.org/3068012/show.
BUG=49316
TEST=tools/grit/grit/format/policy_templates/policy_template_generator.py and manual testing of output .adm files
Review URL: http://codereview.chromium.org/3191021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST-None
Review URL: http://codereview.chromium.org/3116032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This just converts it from being a dialog to being a bubble, with no significant changes to the content.
This is only active on Windows, so I'm leaving the old dialog implementation behind.
Known issues:
- View certificate not there yet.
- Doesn't look exactly like the mocks.
BUG=http://crbug.com/52916
TEST=None
Review URL: http://codereview.chromium.org/3136027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=levin
Review URL: http://codereview.chromium.org/3162033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
displaying the standard explanation for experimental APIs.
TBR=kathyw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=kathyw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I realized at the last minute this was missing and
that developers probably wouldn't be able to
make use of the API without it.
TBR=kathyw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Theory: pinned tabs are actually pretty ok, once the url
schenanigans are disabled and they don't have big ugly icons,
especially if we were to add something to the right-click menu
of the apps in the launcher like 'launch in a normal tab'.
Review URL: http://codereview.chromium.org/3152040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none; This is a part of test code.
Review URL: http://codereview.chromium.org/3176031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42641
TEST=WorkerTest.QueuedSharedWorkerShutdown
Review URL: http://codereview.chromium.org/3153036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TemplateURLModel.
Also made TemplateURLModel::Update private since there were no
external users of this method.
BUG=None
TEST=unit_tests --gtest_filter=TemplateURL*.*
Review URL: http://codereview.chromium.org/3202005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Rename ResetContextIcon()->UpdatePlatformContextIcon().
BUG=37375
TEST=CreateIcon updated
Review URL: http://codereview.chromium.org/3127028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=manually on the netbook
BUG=chromium-os:5152
Review URL: http://codereview.chromium.org/3153022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
called on the same thread as the constructor. ThreadChecker allows you to do this.
BUG=38475
TEST=base_unittests --gtest_filter=NonThreadSafeTest.* and base_unittests --gtest_filter=ThreadChecker.*
Review URL: http://codereview.chromium.org/3148032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=rolandsteiner
Review URL: http://codereview.chromium.org/3149030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was that unlike plugins, the compositor surface is not destroyed on navigation, only a variable is_gpu_rendering_active is updated. The fix is to tell the RenderWidgetHostView if this variable changed and then to adapt the visibility of the view rendering the compositing layer accordingly.
Also, destroy its AcceleratedSurfaceContainer when the compositor is destroyed.
BUG=52134,51748
TEST=go to http://webkit.org/blog/386/3d-transforms/, then hit back. page should redraw on back button. go forward, should work too.
Review URL: http://codereview.chromium.org/3132038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=51328,53044
TEST=test_suppressions.py says leak is still suppressed
Review URL: http://codereview.chromium.org/3146036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
incorrectly send over
top level navigations twice for the same render view.
Fix is to reset the page_id counters once we route the top level navigations to the
host browser.
TBR=amit
Review URL: http://codereview.chromium.org/3192012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3197014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52957
TEST=none (ran 3D CSS demos with --enable-accelerated-compositing)
Review URL: http://codereview.chromium.org/3150030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Properly enable and disable the Edit and Remove buttons based on select
control state.
* Modify the title of the address/CC overlays when pressing the
'Add address/CC' buttons.
* Remove the ability to select multiple options.
BUG=49094
TEST=none
Review URL: http://codereview.chromium.org/3125039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(r57119)
TBR=rsesek
Review URL: http://codereview.chromium.org/3163035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52781
TEST=see bug
Review URL: http://codereview.chromium.org/3106033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=53141
TEST=none
Review URL: http://codereview.chromium.org/3136029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Making window.focus()/blur() work only when there is a user gesture.
Also making window.focus() select tab if it is not visible.
The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed).
TBR=darin,sky
BUG=29643,52346
TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab.
Review URL: http://codereview.chromium.org/3174030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3184018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:5828
TEST=make sure browser_tests pass on chrome os
Review URL: http://codereview.chromium.org/3204001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Save the information that the setup of remoting has completed.
After setup has been completed we start and stop service process when
--enable-remoting presents when browser starts.
Also save the information in the service process that host is registered
and ready to be used. Again start chromoting host automatically once
the host registration is done.
BUG=50244, 50242, 50243, 50249
Review URL: http://codereview.chromium.org/3153029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This removes copy-pasted code in each platform implementation.
BUG=47320
TEST=compiles
Review URL: http://codereview.chromium.org/3163023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When I run them on OSX, I get a gtest warning about multiple threads:
"Death tests use fork(), which is unsafe particularly in a threaded context.
For this test, Google Test detected 2 threads."
This patch fixes the warnings.
BUG=43165
TEST=base_unittest --gtest_filter=OutOfMemoryDeathTest.*
Review URL: http://codereview.chromium.org/3201009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reported back
to the host browser. We no longer have a counter which tracks the last page id.
Top level navigations are reported back if the current frame does not have an opener
or if the origins don't match. The other conditions remain the same i.e reloads/back forwards
and posts don't make it to the host browser and are treated as internal navigations.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=52931
Disabled the navigate out chrome frame test as this needs to be fixed to propertly detect
navigations coming out of chrome frame.
Bug=52931
Review URL: http://codereview.chromium.org/3174027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=52097
Review URL: http://codereview.chromium.org/3191015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename HostMessage and ClientMessage to Chromoting{Host|Client}Message to
avoid conflicts with messages in X11.
Actually, only ClientMessage needs to be changed due to conflict, but HostMessage is changed to keep the names consistent.
BUG=none
TEST=remoting unittests
Review URL: http://codereview.chromium.org/3161034
TBR=garykac@chromium.org
Review URL: http://codereview.chromium.org/3141036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=38475
TEST=Not fully testable yet (but the test is
unit_test --gtest_filter=SearchProviderTest.TestIsSearchProviderInstalled
Review URL: http://codereview.chromium.org/3117034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52621
TEST=unit_tests
Review URL: http://codereview.chromium.org/3135035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename HostMessage and ClientMessage to Chromoting{Host|Client}Message to
avoid conflicts with messages in X11.
Actually, only ClientMessage needs to be changed due to conflict, but HostMessage is changed to keep the names consistent.
BUG=none
TEST=remoting unittests
Review URL: http://codereview.chromium.org/3161034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compile
TBR=thestig
Review URL: http://codereview.chromium.org/3141035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49094
TEST=none
Review URL: http://codereview.chromium.org/3174028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We first show a search engine choice dialog (basically matches windows) but also (in the google chrome case) show a second dialog with the "make chrome the default browser" and "report crashes?" checkboxes. In the chromium case, we don't show the second dialog because it would have a single checkbox (no crash reporting in chromium), and that checkbox is covered by an infobar anyway.
In Chrome, the search engines have image logos. In chromium, they only have plain text logos.
We also no longer show the first run bubble.
BUG=49705
TEST=manual (Chrome and Chromium)
TODO:
- skip the search engine choice when there are no suggested search engines
- show the default search if it's not in the first 3 search engines list
- randomize the search engines list (sometimes)
- remove first run bubble code
Review URL: http://codereview.chromium.org/3106031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reduces the unnecessary NetLog spam, since we would log to the NetLog everytime we created the backup ConnectJob, even though we usually wouldn't actually call Connect() on it. Now, we only create the backup ConnectJob when we intend to call Connect() on it.
Includes some various cleanup necessary for this:
* struct Group => class Group
* method_factory moves from CSP to Group
Review URL: http://codereview.chromium.org/3171017
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/3198009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gesture.
Also making window.focus() select tab if it is not visible.
The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed).
BUG=29643,52346
TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab.
Review URL: http://codereview.chromium.org/3156016
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/3201008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reduces the unnecessary NetLog spam, since we would log to the NetLog everytime we created the backup ConnectJob, even though we usually wouldn't actually call Connect() on it. Now, we only create the backup ConnectJob when we intend to call Connect() on it.
Includes some various cleanup necessary for this:
* struct Group => class Group
* method_factory moves from CSP to Group
Review URL: http://codereview.chromium.org/3171017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57100 0039d316-1c4b-4281-b951-d872f2087c98
|