summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Only pump messages during a cookie query if it results in a user prompt.darin@chromium.org2010-02-2410-24/+109
| | | | | | | | | | | | | | Note: I left LocalStorage intact. I want to first confirm that this CL resolves the Intl2 performance regression. If so, then I'll follow-up with a CL to add similar treatment for LocalStorage. R=jam BUG=36310 TEST=none Review URL: http://codereview.chromium.org/657074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39908 0039d316-1c4b-4281-b951-d872f2087c98
* Give cookie icon real transparency.thakis@chromium.org2010-02-241-0/+0
| | | | | | | | | BUG=31645 TEST=Open cookie manager and look at a cookie. The icon should look as before on windows and better on os x and linux. Review URL: http://codereview.chromium.org/658010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39907 0039d316-1c4b-4281-b951-d872f2087c98
* Disabled DiskCacheBackendTest.*InvalidRankings* on TSan/Mac.timurrrr@chromium.org2010-02-241-3/+1
| | | | | | | BUG=36657 TBR=glider git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39906 0039d316-1c4b-4281-b951-d872f2087c98
* SSL False Start Supportagl@chromium.org2010-02-2410-3/+396
| | | | | | | | | | | | | | | | | | | | | | | | * Adds TLS false start support. This allows us to start sending encrypted data before we have validated the server's Finished message. (This behaviour is already enabled on Android.) I've verified that this works using netem to add a 200ms delay on the loopback adaptor. I've also checked that an incorrect Finished message from the server causes an error by hacking the Go TLS server. Beware when looking at packet traces that the time taken in NSS's SQLite calls can exceed the RTT of the connection and make it appear that this code isn't functioning. * Adds DEBUG and TRACE defines to libssl when building Chromium in Debug mode. This means that setting SSLTRACE in the environment now works for debug builds. http://codereview.chromium.org/518065 BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39905 0039d316-1c4b-4281-b951-d872f2087c98
* Mac client-side SSL cert improvements.snej@chromium.org2010-02-244-27/+62
| | | | | | | | | | | Allow Netscape-style client certs. Remember which identity the user chooses for a domain, and put it at the top of the list next time. BUG=36316,36446 TEST=none Review URL: http://codereview.chromium.org/651090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39904 0039d316-1c4b-4281-b951-d872f2087c98
* Update Chrome Frame's reliability tests to allow them to register a given CF ↵robertshield@chromium.org2010-02-244-6/+58
| | | | | | | | | | | dll. BUG=29451 TEST=Reliability tests can be staged more easily on the vm tests. Review URL: http://codereview.chromium.org/656021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39903 0039d316-1c4b-4281-b951-d872f2087c98
* Disabled DiskCacheBackendTest.NewEvictionInvalidRankingsSuccess on Mac.timurrrr@chromium.org2010-02-241-0/+1
| | | | | | | BUG=36657 TBR=glider git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39902 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix the case where the browser livelocks if we cannot open a file."agl@chromium.org2010-02-2410-213/+65
| | | | | | (Still breaks Mac net_unittests. Damm you Mac.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39901 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the case where the browser livelocks if we cannot open a file.agl@chromium.org2010-02-2410-65/+213
| | | | | | | | | | | | | | | | | | | If one tries to upload a file that one doesn't have read access to, the browser livelocks. It tries to read from the file, gets nothing but spins forever because it knows that it hasn't finished reading. To address this, firstly we add a check at stat() time to make sure that we can read the file. However, this doesn't take care of the case where the access() call was incorrect, or the permissions have changed under us. In this case, we replace the missing file with NULs. (Land attempt two: first in r39446, reverted in r39448) http://codereview.chromium.org/541022 BUG=30850 TEST=Try to upload a file that isn't readable (i.e. /etc/shadow). The resulting upload should be a 0 byte file. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39899 0039d316-1c4b-4281-b951-d872f2087c98
* Disabled DiskCacheBackendTest.InvalidRankingsSuccess on Mac.timurrrr@chromium.org2010-02-241-1/+2
| | | | | | | BUG=36657 TBR=glider git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39898 0039d316-1c4b-4281-b951-d872f2087c98
* adding bug link i forgotthomasvl@chromium.org2010-02-241-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39897 0039d316-1c4b-4281-b951-d872f2087c98
* fix bug to not trigger translation when source language is modified in ↵kuan@chromium.org2010-02-241-6/+2
| | | | | | | | | | | before-translate infobar BUG=36666 TEST=verify per bug report. TBR=jeremy Review URL: http://codereview.chromium.org/652229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39895 0039d316-1c4b-4281-b951-d872f2087c98
* Mark a mac test as flaky that seems to be failing on 10.6 but not 10.5thomasvl@chromium.org2010-02-241-1/+1
| | | | | | | | | TBR=stuartmorgain@chromium.org BUG=36670 TEST=stops some red on the waterfall Review URL: http://codereview.chromium.org/657084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39894 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: improve look of content exceptions edit dialogevan@chromium.org2010-02-241-1/+5
| | | | | | | | | | | Adds some padding and improves resize behavior; same code as other dialogs. Just noticed this while clicking around. Review URL: http://codereview.chromium.org/657079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39892 0039d316-1c4b-4281-b951-d872f2087c98
* Fix style issue mentioned in previous review that I overlooked.evan@chromium.org2010-02-241-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39891 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilePaths in the SafeBrowsing unit tests.evan@chromium.org2010-02-241-25/+24
| | | | | | | | BUG=24672 Review URL: http://codereview.chromium.org/652225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39890 0039d316-1c4b-4281-b951-d872f2087c98
* Do not override LD_LIBRARY_PATHjochen@chromium.org2010-02-241-1/+5
| | | | | | | | | BUG=none TEST=Compile chrome with shared libraries and execute chrome_tests Review URL: http://codereview.chromium.org/652223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39889 0039d316-1c4b-4281-b951-d872f2087c98
* Disabled DiskCacheBackendTest.NewEvictionInvalidRankings2 on Mac.glider@chromium.org2010-02-241-0/+4
| | | | | | | | | BUG=36657 TBR=timurrrr Review URL: http://codereview.chromium.org/657078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39888 0039d316-1c4b-4281-b951-d872f2087c98
* Adds Geolocation browser test.bulach@chromium.org2010-02-245-18/+338
| | | | | | | | | | Note: they're disabled on Mac pending my investigation (it seems to be a similar issue to http://code.google.com/p/chromium/issues/detail?id=29424). This will at least get some coverage for geolocation on win and linux for the time being. TEST=geolocation_browsertest.cc Review URL: http://codereview.chromium.org/650134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39885 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug found in the location arbitrator whilst doing trial integration: ↵joth@chromium.org2010-02-243-18/+63
| | | | | | | | | | | need to make callback when new observer registers. + add a test for it. BUG=none TEST=GeolocationLocationArbitratorTest.RegistrationAfterFixArrives Review URL: http://codereview.chromium.org/652136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39884 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on session storage by default.jorlow@chromium.org2010-02-245-7/+6
| | | | | | | | | TEST=none BUG=4360 Review URL: http://codereview.chromium.org/551098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39883 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Implement HTML5 database items in "Cookies and Other Data" dialog.evan@chromium.org2010-02-246-854/+588
| | | | | | | | | | | | | | Code changes to support a new variant of CocoaCookieTreeNode that displays the information about web databases. Changes to Cookies.xib: Added a new NSView "Database" in the existing information summary view for items selected in the cookie tree. This Database view provides the details for selected items that are web databases, and is in the same implement + layout style as the existing "Cookie" and "Local Storage" views. Added a key "databaseDescription" to the CocoaCookieTreeNode to support the display of the new node type. TEST=manual testing in the "Cookies and Other Data" dialog BUG=http://crbug.com/35191 Patch from Dan Clifford <danno@google.com>. Review URL: http://codereview.chromium.org/596058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39882 0039d316-1c4b-4281-b951-d872f2087c98
* Update hunspell and its dictionaries.hbono@chromium.org2010-02-241-1/+1
| | | | | | | | | TBR=brettw,estade BUG=33024,36523 TEST=http://codereview.chromium.org/652107/show Review URL: http://codereview.chromium.org/657067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39881 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 336.0 to 337.0chrome-release@google.com2010-02-241-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39879 0039d316-1c4b-4281-b951-d872f2087c98
* Further reduce the bad dependency of chrome/common on chrome/browser.phajdan.jr@chromium.org2010-02-2435-79/+111
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/656011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39877 0039d316-1c4b-4281-b951-d872f2087c98
* linux: eliminate some now-redundant codeevan@chromium.org2010-02-241-7/+3
| | | | | | | | We removed the label, but not the stuff that was positioning the label. Review URL: http://codereview.chromium.org/657076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39876 0039d316-1c4b-4281-b951-d872f2087c98
* Allow building without SVG.evan@chromium.org2010-02-241-7/+9
| | | | | | | | Only useful for debug builds, obviously. Review URL: http://codereview.chromium.org/655001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39875 0039d316-1c4b-4281-b951-d872f2087c98
* Adding new strings for some upcoming translate related UI.jcampan@chromium.org2010-02-241-2/+21
| | | | | | | | | | BUG=None TEST=None TBR=ben Review URL: http://codereview.chromium.org/657068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39872 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Cookie confirmation dialog.thakis@chromium.org2010-02-246-8/+153
| | | | | | | | | | | | | This is not the final UI (the "more info" disclosure triangle is missing), but it's pretty close and, more importantly, functional. BUG=34894 TEST=Go to Preferences->under the hood->content settings->cookies and select "ask me every time". Then browser around and note that a message box pops up all the time. All the buttons on the message box should do what they claim. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39756 Review URL: http://codereview.chromium.org/650206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39867 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a valgrind suppression for mac. This is a duplicate of suppression ↵dhollowa@chromium.org2010-02-241-1/+27
| | | | | | | | | | | | 35625. A known (and reported) Apple leak. It is getting triggered again due to a new unit test added today. BUG=35625 TEST=valgrind on mac Review URL: http://codereview.chromium.org/652214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39866 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable WorkerTest.WorkerCloseFast to investigate hang after ↵dimich@google.com2010-02-241-1/+2
| | | | | | | | | | | r55180 upstream. TBR=levin BUG=36630 TEST=none Review URL: http://codereview.chromium.org/657063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39864 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Remove the 14px vertical offset for fullscreen windows that are not on ↵rohitrao@chromium.org2010-02-243-10/+27
| | | | | | | | | | the primary monitor. BUG=36579 TEST=Fullscreen a window on a secondary monitor. The tab strip should not be taller than normal. Review URL: http://codereview.chromium.org/652203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39863 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling options that sxs channel does not support.huanr@chromium.org2010-02-242-7/+47
| | | | | | | | | BUG=35574 TEST=Run setup with those options and "--chrome-sxs". Review URL: http://codereview.chromium.org/652197 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39861 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for tab key view loop issue with Autofill dialog.dhollowa@chromium.org2010-02-249-29/+51
| | | | | | | | | | | | | | | | | | | | | | | | As sub-views got added and removed from the Autofill dialog the window's key view loop was not getting updated correctly. This manifested where tab cycling between text fields would not see the new address or credit card. After adding or removing an item we now tell the dialog's window to recompute the key view loop. Also including small cleanup to unit tests. Using scoped_nsobject<> at John's request. Also spotted that the dialog title was not internationalized properly. That is the change to AutoFillDialog.xib. Specifically, changed the dialog window title to be "^IDS_AUTOFILL_DIALOG_TITLE". BUG=36567 TEST=unit_tests --gtest_filter=AutoFillDialogControllerTest.*:AutoFillAddressModelTest.*:AutoFillAddressViewControllerTest.*:AutoFillCreditCardModelTest.*:AutoFillCreditCardViewControllerTest.*:DisclosureViewControllerTest.*:SectionSeparatorViewTest.*:VerticalLayoutViewTest.* TEST=1. Launch Chrome on Mac, 2. Open Preferences dialog, 3. Navigate to Personal Stuff panel, 4. Click on "Setup Autofill..." button, 5. Click in an address label text field, 6. Hit the tab key. 7. Create a new address with the "Add an Address" button, 8. Click in new address label text field, 9. Hit the tab key. Expect: focus to change to the next text field. Review URL: http://codereview.chromium.org/657036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39853 0039d316-1c4b-4281-b951-d872f2087c98
* Move nphostapi.h to be with the rest of the NPAPI headers.jam@chromium.org2010-02-2410-328/+343
| | | | | | Review URL: http://codereview.chromium.org/652161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39852 0039d316-1c4b-4281-b951-d872f2087c98
* Request the szOID_PKIX_KP_SERVER_AUTH usage when constructingwtc@chromium.org2010-02-241-7/+16
| | | | | | | | | | | | | | | | | | the certificate chain so that we reject a root CA certificate whose "Server Authentication" certificate purpose has been disabled. R=rvargas BUG=34231 TEST=On Windows, run certmgr.msc as Administrator. Under "Trusted Root Certification Authorities", open the Properties for the root CA certificate with the friendly name "VeriSign Class 3 Public Primary CA" and disable its "Server Authentication" certificate purpose. Visit https://www.google.com/. Chrome should display the "Invalid Server Certificate" error page. Review URL: http://codereview.chromium.org/652181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39851 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline and re-enable two layout tests.dumi@chromium.org2010-02-245-11/+27
| | | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/657054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39849 0039d316-1c4b-4281-b951-d872f2087c98
* windows: Theme the popup window with the incognito theme when we are in the ↵jhawkins@chromium.org2010-02-241-4/+8
| | | | | | | | | | | | | | incognito mode. BUG=20373 TEST=see bug Patch by Thiago Farina <thiago.farina@gmail.com> Original review at http://codereview.chromium.org/606060 Review URL: http://codereview.chromium.org/657042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39844 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix themes for fullscreen windows.rohitrao@chromium.org2010-02-241-0/+9
| | | | | | | | BUG=None TEST=Omnibox focus ring for fullscreen windows should not be black. Review URL: http://codereview.chromium.org/657053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39842 0039d316-1c4b-4281-b951-d872f2087c98
* Preparation for mac content confirmation dialog. More tidy in general as well.thakis@chromium.org2010-02-242-2/+20
| | | | | | | | | | Patch mostly by sky. BUG=34894 Review URL: http://codereview.chromium.org/652178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39840 0039d316-1c4b-4281-b951-d872f2087c98
* Be more restrictive when finding file names for libraries that need patching.markus@chromium.org2010-02-241-2/+17
| | | | | | | | | | | | | | | | | | | | | This avoids false positives if the directory name matches one of the well-known library names (e.g. ld). False positives not only result in a performance hit at startup, because we are now trying to instrument libraries that don't actually contain any system calls; but even worse than this, we could try to instrument system calls in the sandboxing code itself. And those system calls are deliberately coded so that they will not get rewritten. Fortunately, none of this is a security problem. If we accidentally rewrite system calls that weren't supposed to be rewritten, we will just crash on startup. TEST=the sandbox now works on the buildbots BUG=36133 Review URL: http://codereview.chromium.org/652188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39839 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly ask for unsigned values when comparing addresses. Not only is thismarkus@chromium.org2010-02-241-2/+2
| | | | | | | | | | | code hard to understand (and possibly broken) otherwise, some versions of GCC complain about the comparison without the cast. TEST=none BUG=none Review URL: http://codereview.chromium.org/657034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39838 0039d316-1c4b-4281-b951-d872f2087c98
* Treat calls to lstat() and lstat64() the same as calls to stat(). In practise,markus@chromium.org2010-02-243-17/+72
| | | | | | | | | | | | | | | this means the calls will still be denied. But we now return a correct return code. But more importantly, this change brings the source code in line with the code of the stand-alone opensource sandbox. Wherever possible, we try to keep both code bases identical. TEST=none BUG=none Review URL: http://codereview.chromium.org/657040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39837 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting the revert, reinstating 39825. ↵avi@chromium.org2010-02-247-53/+81
| | | | | | FindBarTextFieldCellTest.FocusedDisplay is flaky. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39834 0039d316-1c4b-4281-b951-d872f2087c98
* Don't report the language if the CLD reports it as unreliable or if the text ↵jcampan@chromium.org2010-02-243-3/+26
| | | | | | | | | | | | | is too short. That might trigger a translate infobar with the wrong language, it is better to show none. BUG=36593 TEST=Open the pages reported in the bug. No translate infobar should be shown. Review URL: http://codereview.chromium.org/652144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39833 0039d316-1c4b-4281-b951-d872f2087c98
* Add another flaky crashing SVG test.dpranke@chromium.org2010-02-241-0/+1
| | | | | | | | | | BUG=36603 TBR=darin@chromium.org TEST=svg/text/text-text-06-t.svg Review URL: http://codereview.chromium.org/657051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39832 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r39825.avi@chromium.org2010-02-247-81/+53
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39830 0039d316-1c4b-4281-b951-d872f2087c98
* Update TOSlaforge@chromium.org2010-02-2442-2906/+2862
| | | | | | Review URL: http://codereview.chromium.org/657039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39829 0039d316-1c4b-4281-b951-d872f2087c98
* Landing Chris Guillory CL.jcampan@chromium.org2010-02-245-60/+71
| | | | | | | | | | | | See original review at: http://codereview.chromium.org/626014/show BUG=None TEST=None Review URL: http://codereview.chromium.org/657020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39828 0039d316-1c4b-4281-b951-d872f2087c98
* Landing Marshall Greenblatt change.jcampan@chromium.org2010-02-244-8/+93
| | | | | | | | | | | | | See review at: http://codereview.chromium.org/609010/show BUG=None TEST=None Review URL: http://codereview.chromium.org/657019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39827 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 06:36:03 +0000