| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Select the highest FF version, not just the the HCKU one.
- I don't have a repro case, it is a blind fix
Seems like leftovers of old FF installs in HCKU are tripping us, that
is my guess, now we would find FF3 in HKLM.
BUG=3109
Review URL: http://codereview.chromium.org/9675
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
which was an issue with the site failing to detect Windows media player. The site would run a script which would enumerate the list of plugins from the navigator object and compare each plugin name for "Windows Media" and "Plug". This is under the assumption that the windows media player plugin is typically named as
Microsoft� Windows Media Player Firefox Plugin and it would find both the strings in the name.
I had changed the name of activex shim instance for media player previously to Windows Media to fix a similar issue with bloomberg.com. Should have changed it to the full name at that point.
The fix is to fully match the windows media player plugin name in the shim.
The other change is to perform a case insensitive comparison of the plugin file names while looking for matching plugins.
R=jam
Bug=4137
Review URL: http://codereview.chromium.org/9482
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
while it is in use. This should work for per user as well as system level
installs (after some additional changes once Google Update changes are ready).
The following scenarios should work now:
- If Chromium is using two different profiles at the same time we do not switch
chrome executables until all of them are closed.
- The old version of Chromium can be run after a restart if the renaming of
executables fails.
- We will not use environment variable any more but we need to keep it until all
the users get this change on their machines.
- opv/rename registry keys and new_chrome.exe should always together. If one
exist all three should exist because they are created and deleted as one atomic
operation (as much as possible given laws of physics).
BUG=1463346
Review URL: http://codereview.chromium.org/9436
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9479
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
purpose (targets built there are per-browser).
Review URL: http://codereview.chromium.org/9483
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9626
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9667
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9480
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Gather data to show the duration of time between the first
byte sent, to last byte read. Use a second histogram to
look at latency when the content-encoding is not really
sdch (due to server side experiment, or proxy interference).
r=huanr,wtc
Review URL: http://codereview.chromium.org/9448
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
by the time the download item is created, you have the download tab opened and you press on the discard button.
This is because such downloads gets added to a vector that is used to unregister the DownloadTabView as an observer.
We were deleting the download item before notifying the DownloadTabView, which would cause it to access the deleted download item.
BUG=4134
TEST=Open the download tab, start the download of a short exe. Click the discard button in the dangerous download prompt.
Review URL: http://codereview.chromium.org/9435
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
SConscript.inputs. This file will be shared by the symbian port.
SConscript.inputs is mostly a cut+paste of the original files. The few
changes are to stick resources on the 'env' var so they can be shared.
Review URL: http://codereview.chromium.org/9666
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
waterfall.
BUG=4173
TEST=look at page-cycler step on waterfall
Review URL: http://codereview.chromium.org/9658
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
in an unload handler (i.e. we have an infinite-ish alert loop).
Review URL: http://codereview.chromium.org/9477
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
notification exists. This is a copy of Firefox's behaviour.
BUG=crbug.com/4007
Review URL: http://codereview.chromium.org/9656
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=2183
Review URL: http://codereview.chromium.org/8806
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use the HTTP "referer" header to identify subresources used during a
page load. Store that info, and use it when next visiting the referenced
hosts to pre-resolve the (probably) needed subresources.
This set of changes will surely evolve as we see how it plays out
on broader distribution (via histogram measurments), but this should be
the foundation of the change.
In design specs, this was previously referred to as "adaptive correlated
DNS prefetching."
r=mbelshe
Review URL: http://codereview.chromium.org/9168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Will submit this TBR.
Propogating fix from mainline sct.
Review URL: http://codereview.chromium.org/9663
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9662
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9468
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it easier to share inputs among files, in preparation for the symbian port.
Also, some small fixes:
- Added a hack to the third party lib scripts to place the libraries in the
right directory. Normally SCons does this, but fails due to a bug when
COMPONENT_LIBRARY_DIR is changed.
- Added fake notifier targets to make the win32 installer happy.
- Added NPAPI's gears.dll to the win32 installer dependencies, so it is built (even though it isn't used by the installer).
- Added symbian file to sqlite compile.
Review URL: http://codereview.chromium.org/9657
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Get rid of some unnecessary addRepository() calls that mapped specific
webkit\port\ subdirectories to third_party\WebKit\WebCore subdirectories,
in ways that were already covered by the mapping in webkit\SConscript of
all of $WEBKIT_DIR\port to third_party\WebKit\WebCore.
This takes about 40 duplicate /I options out of a typical compilation
command line (and, more importantly, out of the .h file searches).
Add additional comments about future potential efficiency that we
can get from eliminating the quirky way we remap specific directories
into webkit\port, instead of just maintaining a completely parallel
directory structure and mapping the whole tree once.
Review URL: http://codereview.chromium.org/9466
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
that the tree still flicker during a resize
on RTL locales but not on LTR.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9652
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9624
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Initialize PAINTSTRUCT to prevent crash if BeginPaint fails.
* Sanitize width-height for empty bitmaps.
* Return failure from initialize instead of crashing at that point.
BUG=3795
Review URL: http://codereview.chromium.org/9459
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=1442838
Review URL: http://codereview.chromium.org/9422
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the display of the extension. This touches a lot of files because it renames url_elider to text_elider (as it already contained a bunch of text ellision functions), and so requires header file reference changes. BUG=1208
Review URL: http://codereview.chromium.org/9613
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
let it drop on the floor.
Review URL: http://codereview.chromium.org/9653
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/9467
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/9460
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9464
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9651
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9650
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
add password_autocomplete_listener.cc to the build
TBR=mark
Review URL: http://codereview.chromium.org/9648
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also added a histogram to show effective bandwidth of the download.
r=darin,wtc
Review URL: http://codereview.chromium.org/9625
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9646
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
"config.h" needs to be included first
TBR=mark
Review URL: http://codereview.chromium.org/9647
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
add autocomplete_input_listener.cc to the glue lib
TBR=mark
Review URL: http://codereview.chromium.org/9645
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
add dom_operations.cc to the mac build
TBR=mark
Review URL: http://codereview.chromium.org/9644
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many of these files that I don't added to the build would even compile
and link, but don't yet pass with current test_shell on Linux.
They just hang.
Patch from Paweł Hajdan jr <phajdan.jr@gmail.com> on
http://codereview.chromium.org/9417
Review URL: http://codereview.chromium.org/9641
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
select boxes (but does not affect scroll bars). I created a helper class, ThemeHelperWin, which automatically wraps the logic necessary to do this. There are three modes: draw the form control normally, draw it at a different size (for scaling, just tell Windows it's a different size and don't transform the graphics coordinates), or arbitrary transforms (where it's drawn to an offscreen buffer and transformed by our graphics layer.
Review URL: http://codereview.chromium.org/9008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
vector growth / copies for the typical cookie database.
Review URL: http://codereview.chromium.org/9437
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
was already removed from Debug). Remove the trailing space on the
FEATURE_DEFINES setting in debug mode; it was causing a DOUBLE space in the
--defines string being passed to generate-bindings.pl, of which that script is
intolerant.
Review URL: http://codereview.chromium.org/9640
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With V8 r648 (Review URL: http://codereview.chromium.org/8909) attaching the debugger to V8 will initialize V8 if not already initialized. This needs to be serialized with the initialization of V8 in the renderer thread.
This change does not require the changes in V8 r648, but will not have any effect without.
Added a few comments.
BUG=3723
Review URL: http://codereview.chromium.org/8735
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IMEs.
Recent Japanese IMEs (ATOK2008 and MSIME 2007) display a suggestion window (a window which contains suggestions) above a composition string. To fix this issue, we do not only send the lower-left corner of a composition string but also send its upper-left corner and its upper-right corner. So, this change changes IPC parameters used by IME from a tuple of integers to gfx::Rect.
Also, this change fixes cursor positions for Japanese IMEs.
BUG=2770 "IME: Candidate window of Japanese IME follows the end of composition"
BUG=2771 "ATOK 2008 IME pop-ups are displayed below the main Chrome window."
BUG=2775 "IME: Caret is always displayed at the last of IME composition."
Review URL: http://codereview.chromium.org/7385
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I tested on the buildbot
and this is the only one I could see leaks in. If it stays green, I'll narrow it more by modifying the
test.
TBR=erikkay
Review URL: http://codereview.chromium.org/9451
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4871 0039d316-1c4b-4281-b951-d872f2087c98
|