summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Disable a test which is causing an error under valgrind TSAN.eroman@chromium.org2010-02-051-1/+1
| | | | | | | | | | It looks like there is a problem with the test setup (BlockableProxyResolver tests a bool outside of a lock). I will fix that next. TBR=willchan Review URL: http://codereview.chromium.org/578011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38194 0039d316-1c4b-4281-b951-d872f2087c98
* Remove size_t from audio IPC code.jam@chromium.org2010-02-0540-404/+401
| | | | | | | The change got to this size because I had to modify the surrounding code (I didn't want to just cast at the last minute). Review URL: http://codereview.chromium.org/577006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38192 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak some things to be compatible with libpng 1.4.craig.schlenter@chromium.org2010-02-051-9/+4
| | | | | | | | | | | libpng 1.2 should still work too. BUG=32805 TEST=compiles on tryservers and locally against libpng 1.4 Review URL: http://codereview.chromium.org/569009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38188 0039d316-1c4b-4281-b951-d872f2087c98
* Support app menu and double-click close on upper left corner of window, part ↵pkasting@chromium.org2010-02-0517-192/+31
| | | | | | | | | | | | one. This makes things work right for windows that have an icon. The behavior of the main window is unchanged because right now it never returns HTSYSMENU anywhere. Part two of this change will be figuring out how to return that at the right place, which will make things Just Work. BUG=6961 TEST=Open an app or popup window. Single click the icon. The app menu should appear. Close it, then click-and-drag into the app menu. The item you release on should execute. Double-click the icon. The window should close. Review URL: http://codereview.chromium.org/577018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38187 0039d316-1c4b-4281-b951-d872f2087c98
* PGL was relying on pthread_key_create not returning zero, which does notsehr@google.com2010-02-051-6/+9
| | | | | | | | | seem to conform to the documented interface. I have added an allocated flag. This is needed to fix NaCl PGL. Review URL: http://codereview.chromium.org/576002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38186 0039d316-1c4b-4281-b951-d872f2087c98
* Implement launch disposition for extension-apps.rafaelw@chromium.org2010-02-0513-19/+150
| | | | | | | | | | | | This change adds an --app-id command switch that signifies that the extension-app with the given id should be launched according to its configuration. It also adds parsing for app.window_type in the manifest and the behavior that when installed and a desktop shortcut is created, the --app-id switch is used rather than the --app switch. BUG=32361 Review URL: http://codereview.chromium.org/573016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38184 0039d316-1c4b-4281-b951-d872f2087c98
* Add a timing measurement to LoadLog that shows how long a proxy resolve ↵eroman@chromium.org2010-02-053-3/+90
| | | | | | | | | request was stalled waiting to be scheduled to a thread. TEST=SingleThreadedProxyResolverTest.UpdatesLoadLogWithThreadWait Review URL: http://codereview.chromium.org/570019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38181 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some tests that are now living upstream, and eliminatedarin@chromium.org2010-02-055-876/+33
| | | | | | | | | | | | some usage of glue_util.h. R=yaar BUG=none TEST=none Review URL: http://codereview.chromium.org/572013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38180 0039d316-1c4b-4281-b951-d872f2087c98
* Implement backend support for forcing cookies to be saved asdarin@chromium.org2010-02-057-12/+91
| | | | | | | | | | | | | | session cookies. Introduces a new CookiePolicy result code OK_FOR_SESSION_ONLY. R=eroman BUG=34571 TEST=none Review URL: http://codereview.chromium.org/577013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38179 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when extensions try to set cookies. It is valid fordarin@chromium.org2010-02-051-15/+21
| | | | | | | | | | | | | the cookie policy to be NULL, in which case we should default to allowing cookies to be set. R=eroman BUG=34649 TEST=Try to install extension AniWeather from official gallery site Review URL: http://codereview.chromium.org/578007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38178 0039d316-1c4b-4281-b951-d872f2087c98
* Add unittest for r37566 (on PAC failure, should fallback to DIRECT).eroman@chromium.org2010-02-054-51/+26
| | | | | | | | | | | | To make it more testable, I had to move the fallback code in question from HttpNetworkTransaction to ProxyService. Although I think this is a better fit for that code anway, so it should be an overall readability improvement. BUG=32316 TEST=ProxyServiceTest.ProxyFallback_BadConfig, ProxyServiceTest.ProxyResolverFails Review URL: http://codereview.chromium.org/556087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38177 0039d316-1c4b-4281-b951-d872f2087c98
* More work on diagnostics modecpu@chromium.org2010-02-054-43/+106
| | | | | | | | | | | | | | | | - Clean up a bit, reduce windows specific code - Add disk space test - Add Chrome version test - Make OS version readable, cross platform mostly This concludes the minimal sanity tests. BUG=27885 TEST= run chrome with --diagnostics , no test should fail. Review URL: http://codereview.chromium.org/561078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38176 0039d316-1c4b-4281-b951-d872f2087c98
* Relaxes the suppression rule for a leak in WorkerThreadableWebSocketChannel ↵hbono@chromium.org2010-02-051-2/+0
| | | | | | | | | | | (Take 2). BUG=32644 TBR=ukai TEST=none Review URL: http://codereview.chromium.org/572028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38175 0039d316-1c4b-4281-b951-d872f2087c98
* Now showing the browser action image (including badge) when dragging andfinnur@chromium.org2010-02-053-9/+36
| | | | | | | | | | | | showing the badge in the overflow menu. BUG=26990 TEST=Browser actions in container/overflow should show image and badge and also while dragging back and forth. Review URL: http://codereview.chromium.org/575016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38174 0039d316-1c4b-4281-b951-d872f2087c98
* System toast was trying to launch the per-user chromecpu@chromium.org2010-02-056-7/+11
| | | | | | | | | | | | | - forgot to pass along the system_install flag. BUG=32474 TEST=see bug for instructions, you need to simulate a system level install. TBR=huanr Review URL: http://codereview.chromium.org/561080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38172 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 38166 - Added Star button to compact navigation mode.pkasting@chromium.org2010-02-0511-220/+240
| | | | | | | | | | | | | BUG=32326 TEST=Switch Chrome to compact mode by pressing CtrlShiftC. Test that Star icon works. Review URL: http://codereview.chromium.org/543215 TBR=avayvod@chromium.org Review URL: http://codereview.chromium.org/561081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38171 0039d316-1c4b-4281-b951-d872f2087c98
* Add specific error codes for when SOCKS connect fails.eroman@chromium.org2010-02-056-21/+46
| | | | | | | | | | | | | This also fixes HttpNetworkTransaction to fallback to the next proxy after a failure is encountered using a SOCKS proxy server. Note that I decided against using finer granularity error codes, since it just adds a higher maintenance cost to ReconsiderProxyAfterError(). Power users can get better information on the cause of the failure by looking at the LoadLog anyway. BUG=34386 Review URL: http://codereview.chromium.org/567030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38170 0039d316-1c4b-4281-b951-d872f2087c98
* linux: Use gtk-cursor-blink from GtkSettings to set the caret blink intervaljoel@chromium.org2010-02-054-1/+31
| | | | | | | | | BUG=20772 TEST=Open gnome-keyboard-properties. Un-set the "Cursor Blinking" checkbox. Open a new tab in chromium and the cursor should not blink. Do the same with the slider, and the rate of blinking should vary. Review URL: http://codereview.chromium.org/398003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38168 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression that broke the --disable-ipv6 command line flag.eroman@chromium.org2010-02-053-32/+298
| | | | | | | | | | | | BUG=34632 TEST= HostResolverImplTest.SetDefaultAddressFamily_IPv4 HostResolverImplTest.SetDefaultAddressFamily_IPv6 HostResolverImplTest.SetDefaultAddressFamily_Synchronous Review URL: http://codereview.chromium.org/577010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38167 0039d316-1c4b-4281-b951-d872f2087c98
* Added Star button to compact navigation mode.avayvod@chromium.org2010-02-0511-240/+220
| | | | | | | | | | BUG=32326 TEST=Switch Chrome to compact mode by pressing Ctrl-Shift-C. Test that Star icon works. Review URL: http://codereview.chromium.org/543215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38166 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 33130 by checking whether the tab is closed whenhuanr@chromium.org2010-02-051-2/+3
| | | | | | | | | | | closing login propmt BUG=33130 TEST=existing test passes Review URL: http://codereview.chromium.org/576010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38165 0039d316-1c4b-4281-b951-d872f2087c98
* Bug 34167: GPU plugins' output initially placed incorrectly on pagekbr@google.com2010-02-054-0/+40
| | | | | | | | | | | | | | | | Added call to RenderView::DidMovePlugin upon creating the command buffer so the nested delegate is initially placed properly on the page; thanks to jam for this suggestion. Added necessary accessor to fetch the plugin window handle from the nested delegate, which is the "fake" GPU plugin window handle on Mac OS X. Verified that Pepper 3D test plugin initially shows up in the correct place. BUG=34167 TEST=none (ran Pepper test plugin on Mac and Linux) Review URL: http://codereview.chromium.org/561068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38164 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Set fixed maximum line height in Omnibox.viettrungluu@chromium.org2010-02-052-1/+22
| | | | | | | | | | | (Otherwise, e.g., Arabic text can make the line shift downwards.) BUG=31115 TEST=Make sure Omnibox works/looks/feels normal (and that normal text is displayed in it correctly). Then paste in something containing appropriate Arabic characters (see bug report for some samples); make sure text doesn't shift down. Review URL: http://codereview.chromium.org/573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38163 0039d316-1c4b-4281-b951-d872f2087c98
* Implement RemoveChars, a function to remove a list of characters from a ↵jhawkins@chromium.org2010-02-054-1/+69
| | | | | | | | | | string, and use it in PhoneNumber to remove extra phone number characters. BUG=none TEST=StringUtilTest.RemoveChars Review URL: http://codereview.chromium.org/572015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38162 0039d316-1c4b-4281-b951-d872f2087c98
* Add a dump of the currently outstanding jobs when enabling DNS tracing.eroman@chromium.org2010-02-051-0/+33
| | | | | | | | Before it would just output the count. Review URL: http://codereview.chromium.org/565051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38161 0039d316-1c4b-4281-b951-d872f2087c98
* Make the side tabstrip participate in the layout of the BrowserView.ben@chromium.org2010-02-058-48/+69
| | | | | | | | | | | | Turn on the side tabstrip by default when --enable-vertical-tabs is specified, for ease of testing/debugging. Adjust glass rendering in this mode. http://crbug.com/34509 TEST=none Review URL: http://codereview.chromium.org/570029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38160 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some goofiness when arrowing around the popup with control down by ↵pkasting@chromium.org2010-02-051-1/+18
| | | | | | | | | | canceling control-enter once the user starts moving around the popup. BUG=32547 TEST=Type something in the omnibox, hold control, arrow down to a different entry, release control, press enter. You should visit the entry that's selected, not something else. Review URL: http://codereview.chromium.org/577008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38159 0039d316-1c4b-4281-b951-d872f2087c98
* Additional Chromium icon resolutions for better Linux desktop integration.mmoss@google.com2010-02-056-0/+4
| | | | | | | | BUG=34320 Review URL: http://codereview.chromium.org/575013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38158 0039d316-1c4b-4281-b951-d872f2087c98
* Implement FormManager, a class that manages forms in a RenderView.jhawkins@chromium.org2010-02-056-0/+628
| | | | | | | | BUG=18201 TEST=FormManagerTest Review URL: http://codereview.chromium.org/577009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38157 0039d316-1c4b-4281-b951-d872f2087c98
* Fix StringPrintf that is now brokencpu@chromium.org2010-02-051-2/+2
| | | | | | | | | | | | | | - command line for chrome is not working BUG=none TEST=now toast test with --inactive-user-toast=0 should work TBR=huanr Review URL: http://codereview.chromium.org/570037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38156 0039d316-1c4b-4281-b951-d872f2087c98
* quota-tracking.html will change in the WebKit repository soon. Skip itdumi@chromium.org2010-02-051-0/+2
| | | | | | | | | | | | until the new version is pulled into Chromium and is rebaselined. BUG=none TEST=none Review URL: http://codereview.chromium.org/571011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38155 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 38140 - "Roll DEPS for WebKit 54340:54361", since the Mac tests went ↵senorblanco@chromium.org2010-02-052-7/+1
| | | | | | | | | | | | all pear-shaped. BUG=none TEST=none TBR=tc Review URL: http://codereview.chromium.org/570036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38154 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: unbreak right click on bookmark bar folders.estade@chromium.org2010-02-042-3/+7
| | | | | | | | | BUG=34416 TEST=right, middle, and left click on bookmark bar folder all do what they should Review URL: http://codereview.chromium.org/576008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38151 0039d316-1c4b-4281-b951-d872f2087c98
* Fix description of onImportBegan to ensure people use it safely.feldstein@chromium.org2010-02-041-1/+1
| | | | | | | | When observers listen to onImportBegan, they can only safely ignore handleCreated. handleDeleted, handleMoved, etc must still be handled immediately to avoid holding on to stale pointers. Review URL: http://codereview.chromium.org/570017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38149 0039d316-1c4b-4281-b951-d872f2087c98
* Adds link to flash settings on clear browser data panel.sky@chromium.org2010-02-045-19/+99
| | | | | | | | | | BUG=none TEST=bring up clear browsing data dialog and make sure it has a link to flash storage settings. Review URL: http://codereview.chromium.org/570030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38148 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up third_party/cld.jshin@chromium.org2010-02-0491-2532/+276
| | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Remove files we don't use that come from toolbar 2. Simplify the directory structure by removing the redundant intermediary directories bar/toolbar/cld/i18n This will bring CLD a step closer to where it can be open-sourced separately (or along with CED for encoding detection.). It's not there yet. In addition to the clean-up, change |LanguageCode*| return 'nb', 'he', 'fil' instead of 'no', 'iw', and 'tl'. Also, use LanguageCodeWithDialects instead of LanguageCode to get 'zh-CN' instead of 'zh'. This is to simplify the 3-way mapping between Chrome's UI locale code, CLD's language code and what's accepted by Google Translate. It's also another preparation for open-sourcing because we'd better use the standard code rather than the obsolete code like 'iw' when open-sourcing. BUG=32759, 33613 TEST=third_party/cld builds on all platforms and pass the following tests: - unit_tests: Extension*.DetectTabLanguage and CompactLangDetTest.* - browser_tests: ExtensionBrowserTest.Toolstrip git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38146 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for the IE File->Save As command. This eventually ends up in ↵ananta@chromium.org2010-02-048-3/+24
| | | | | | | | | | | | | | | | Chrome via the new automation message AutomationMsg_SaveAsAsync. Rest of the changes are to plumb this message across from IE to Chrome. Fixes bug http://code.google.com/p/chromium/issues/detail?id=24039 Bug=24039 Test=Launch IE with OptinUrls set to *. Navigate to google.com and select File->Save As. The dialog should popup. Review URL: http://codereview.chromium.org/563025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38145 0039d316-1c4b-4281-b951-d872f2087c98
* Reorganize chrome_frame_unittest.h/ccamit@chromium.org2010-02-0412-2113/+2162
| | | | | | | | | | | | | | Split this monsterinto 4 different h/cc files based on the type of tests. No real code changes. Things should become easier to find/manage now. BUG=None TEST=None Review URL: http://codereview.chromium.org/574006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38144 0039d316-1c4b-4281-b951-d872f2087c98
* Sandbox: Finish the interception manager support for x64.rvargas@google.com2010-02-0424-155/+347
| | | | | | | | | | | | | | Unit tests and integration tests run (as long as they don't depend on IPCs), both regular and under SANDBOX_EXPORTS. The interception agent is there, but no EAT interceptions yet. BUG=27218 TEST=unit tests/ integration tests. Review URL: http://codereview.chromium.org/565026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38143 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed some of UI issues with AutofillSettings dialog: separators, preview ↵georgey@chromium.org2010-02-041-16/+37
| | | | | | | | | | | and indents should be correct. Sizes and alignments should be mostly correct. Known issue is large size of the month field in credit view. TEST=general autofill test, all functionality is there BUG=33026 Review URL: http://codereview.chromium.org/567038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38142 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for WebKit 54340:54361.senorblanco@chromium.org2010-02-042-1/+7
| | | | | | | | | BUG=none TEST=none TBR=tc git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38140 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fix crash deleting bookmark while bookmark editor is open.snej@chromium.org2010-02-046-6/+197
| | | | | | | | | | (xib change: enable 'preserve selection' in NSOutlineView.) BUG=33333 TEST=BookmarkEditorBaseControllerTest.SelectedFolderDeleted et al Review URL: http://codereview.chromium.org/566005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38139 0039d316-1c4b-4281-b951-d872f2087c98
* Remove CRLF from http_auth_handler_negotiate_posix.cccbentzel@chromium.org2010-02-041-45/+45
| | | | | | | | | BUG=NONE TEST=Built Review URL: http://codereview.chromium.org/578005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38138 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing paint issue with browser actions not being updated in one window when ↵finnur@chromium.org2010-02-041-0/+1
| | | | | | | | | | | dragged around in another. BUG=34506 TEST=See bug (make sure you specify a zip code for the weather extension when testing). Review URL: http://codereview.chromium.org/570028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38137 0039d316-1c4b-4281-b951-d872f2087c98
* regular_expression_unittest to only use WebKit API.yaar@chromium.org2010-02-041-57/+67
| | | | | | Review URL: http://codereview.chromium.org/548077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38136 0039d316-1c4b-4281-b951-d872f2087c98
* Adding drag-drop support in and out of the Browser Action overflow menu.finnur@chromium.org2010-02-049-33/+294
| | | | | | | | | BUG=26990 TEST=Drag icons into and out of (and within) both the Browser Action container and its overflow menu. Review URL: http://codereview.chromium.org/570014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38135 0039d316-1c4b-4281-b951-d872f2087c98
* Browser action for compact loc bar, plus several visual fixes.oshima@chromium.org2010-02-045-23/+58
| | | | | | | | | | | | | - added browser action container to compact location bar - use toolbar background to match with bookmark bar (when visible) - use given bounds to compute window edge BUG=32327 TEST=none Review URL: http://codereview.chromium.org/573017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38133 0039d316-1c4b-4281-b951-d872f2087c98
* Handle a case where the document is being served up from cache. In that ↵tommi@chromium.org2010-02-041-1/+26
| | | | | | | | | | | case we have to get to the browser service object via a different set of QS calls. TEST=This is a part of the onhttpequiv effort. For now there won't be any visible changes since onhttpequiv is disabled but once it becomes enabled again, CF will be detected for cached pages as well as non-cached. BUG=none Review URL: http://codereview.chromium.org/573012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38132 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor chromeos login files into subdir 'login'chocobo@chromium.org2010-02-049-32/+33
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/577007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38130 0039d316-1c4b-4281-b951-d872f2087c98
* Add a notion of 'eof' to UploadDataStream, replacing the use of its size ↵vandebo@google.com2010-02-049-11/+176
| | | | | | | | | | | | | | | property for detecting when an upload is finished. While this does prevent the crash described in the bug from occurring, this doesn't fully solve the problem as now the affected uploads don't complete. Fully resolving the issue will require implementing the chunked transfer encoding for requests. Patch from Vernon Tang <vt@foilhead.net>, original review: http://codereview.chromium.org/555194 BUG=33501 TEST=Create a file with a non-zero size and select that file in an HTML-based uploader. Before starting the upload, remove read permissions from that file. Check that the upload doesn't cause the browser to crash or hang. net_unittests: HttpNetworkTransactionTest.UploadFileSmallerThanLength, UploadDataStreamTest.* Review URL: http://codereview.chromium.org/578004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38129 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 12:05:41 +0000