summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Rename ExtensionsService to ExtensionService.tfarina@chromium.org2010-12-14154-832/+832
| | | | | | | | | BUG=61409 TEST=trybots Review URL: http://codereview.chromium.org/5730004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69117 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 611.0 to 612.0chrome-release@google.com2010-12-141-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69115 0039d316-1c4b-4281-b951-d872f2087c98
* Add /media to whitelist so it can be accessed with file:// protocol on ChromeOS.achuith@chromium.org2010-12-141-0/+1
| | | | | | | | | BUG=chromium-os:3412,chromium-os:3292 TEST=On a ChromeOS device, file://media should now be accessible. Review URL: http://codereview.chromium.org/5785002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69113 0039d316-1c4b-4281-b951-d872f2087c98
* PrepopulateRespectBlank working, lets check the other test that was disabledfinnur@chromium.org2010-12-142-98/+52
| | | | | | | | | | | | | | | | | | | | | at the same time. I am removing traces from two tests since I think the problem with those tests have been fixed. By suppressing the crash server window on the try servers and ensuring Chrome is in the foreground it looks like the test now works. I went back in time through pages of try server logs and it seems to work. I am also enabling my other test that was disabled at the same time, since I think that test will probably work now. I moved the window caption check to that file, so we can see if we still have the same problem when it fails. BUG=62936, 62937 TEST=This CL is all about tests. Review URL: http://codereview.chromium.org/5769003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69112 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly ignore return value of sk_SSL_COMP_delete.hans@chromium.org2010-12-141-1/+1
| | | | | | | | | | | | Explicitly cast the returned value into the void. Clang complains about this unused return value otherwise. BUG=none TEST=flip_in_mem_edsm_server Review URL: http://codereview.chromium.org/5727003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69111 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress remoting_ Valgrind leaks; ↵timurrrr@chromium.org2010-12-141-9/+16
| | | | | | | | | | | s/21ResourceMessageFilter/19RenderMessageFilter to fix the massive memory waterfall redness after r69076 TBR=glider TEST=./tools/valgrind/waterfall.sh BUG=66808 Review URL: http://codereview.chromium.org/5777003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69110 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress Heapchecker memory leaks in remoting_unitteststimurrrr@chromium.org2010-12-141-0/+6
| | | | | | | | | BUG=66808 TBR=glider TEST=heapchecker bot should go greener Review URL: http://codereview.chromium.org/5748007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69109 0039d316-1c4b-4281-b951-d872f2087c98
* Build fixsatish@chromium.org2010-12-141-1/+2
| | | | | | TBR=thakis git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69108 0039d316-1c4b-4281-b951-d872f2087c98
* Make members of Singleton<T> private and only visible to the singleton type. ↵satish@chromium.org2010-12-1460-388/+532
| | | | | | | | | | | | | | | This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69107 0039d316-1c4b-4281-b951-d872f2087c98
* Reland part of r62043 that got reverted.willchan@chromium.org2010-12-141-3/+4
| | | | | | | | | | | I tried to repro this bug and could not. Seems to work. BUG=58553,28083 TEST=python chrome/test/functional/cookies.py cookies.CookiesTest.testCookiesFile Review URL: http://codereview.chromium.org/5721007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69106 0039d316-1c4b-4281-b951-d872f2087c98
* - Add bug 66795 to known_crashes.txt.csilv@chromium.org2010-12-141-1/+4
| | | | | | | | | | | - Shorten the signature for the crash in bug 66741. TBR=thestig@chromium.org BUG=66795 TEST=none Review URL: http://codereview.chromium.org/5697009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69105 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeFrame test failures caused by the change to support about:plugins ↵ananta@chromium.org2010-12-141-3/+4
| | | | | | | | | | | | | in full tab mode. BUG=66118 TBR=none Review URL: http://codereview.chromium.org/5707009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69104 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeFrame perf test builder redness by delay loading nspr4.dll. We ↵ananta@chromium.org2010-12-141-1/+5
| | | | | | | | | | | | | | need to investigate where this dependency comes from. TBR=amit TEST=none BUG=none Review URL: http://codereview.chromium.org/5757004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69103 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded includes of chrome/browser/cert_store.h and ↵thestig@chromium.org2010-12-148-8/+0
| | | | | | | | | | chrome/browser/defaults.h. BUG=none TEST=none Review URL: http://codereview.chromium.org/5767004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69102 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for gcf:about:plugins in chrome frame full tab mode. The URL ↵ananta@chromium.org2010-12-1417-120/+350
| | | | | | | | | | | | | | | | | | | validation code path in ChromeFrame now takes in an interface NavigationConstraints which allows the delegateslike the ActiveX, ActiveDocument and the NPAPI plugins to control the navigation decisions. We no longer refer to the InternetSecurityManager interface which is IE only for performing zone decisions in the ChromeFrame NPAPI plugin. Fixes bug http://code.google.com/p/chromium/issues/detail?id=66118 BUG=66118 TEST=Covered by additional CanNavigate unit tests. Review URL: http://codereview.chromium.org/5698005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69101 0039d316-1c4b-4281-b951-d872f2087c98
* Use heartbeat interval received from the bot.sergeyu@chromium.org2010-12-143-26/+96
| | | | | | | | | BUG=None TEST=Unittests Review URL: http://codereview.chromium.org/5510006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69096 0039d316-1c4b-4281-b951-d872f2087c98
* Revert valgrind suppression added in r65660.willchan@chromium.org2010-12-141-16/+0
| | | | | | | | | | | I don't see this on the ChromiumOS bots anymore. I'm hoping it's either gone away, or it will turn a bot red quickly so I can analyze the problem. BUG=62674 TEST=none Review URL: http://codereview.chromium.org/5737006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69095 0039d316-1c4b-4281-b951-d872f2087c98
* Fix pyauto downloads tests to trigger dangerous downloads to match expectationnirnimesh@chromium.org2010-12-143-23/+51
| | | | | | | | | | | | | | | | It used to be possible to navigate to a dnagerous file type to trigger its download. Not anymore. Now all downloads where the user initiated it (by navigating to a URL or clicking on a link) are not marked unsafe even for unsafe filetypes. Update the tests to trigger dangerous downloads by navigating to a file which in turn triggers the dangerous files to download. BUG=66081, 57875 Review URL: http://codereview.chromium.org/5781006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69093 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Roll 73909:73942jianli@chromium.org2010-12-141-1/+1
| | | | | | | | | TBR=pfeldman BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69091 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69088 - Before starting translation reset cache in AutoFillManager. ↵dhollowa@chromium.org2010-12-145-234/+91
| | | | | | | | | | | | | | To call Reset() function, append Reset() virtual function in RenderViewHostDelegate::AutoFill and derive it from AutoFillManager. BUG=58576 TEST= 1.launch English version Chrome 2. make sure autofill is enable and there is autofill data entry in settings 3.navigate to a non-English website e.g.: https://secure.fnac.pt/Account/Logon/LogonNewAccount.aspx?NID=-15&RNID=-15&PrevNID=0&pagepar=SID%3d22120814-4186-d926-4f7b-0dece96fade2|Origin%3dFnacAff|OrderInSession%3d1|TTL%3d070420110015|bl%3dHGAChead&PageRedir=https://www2.fnac.pt/Account/Profil/default.asp&PageAuth=yes&LogonType=ACCOUNT 4. when translation infobar show up, click "Translate" to translate to English 5. focus in "E-mail" field 6. press Down arrow 7. select the autofill data entry by double click on it 8. autofill data should be fill in all text boxes Review URL: http://codereview.chromium.org/5322001 TBR=dhollowa@chromium.org Review URL: http://codereview.chromium.org/5682012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69090 0039d316-1c4b-4281-b951-d872f2087c98
* Remove BrowserFileSystemContext class and merge it into ↵kinuko@chromium.org2010-12-1425-141/+154
| | | | | | | | | | | SandboxedFileSystemContext BUG=60243 TEST=none Review URL: http://codereview.chromium.org/5633008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69089 0039d316-1c4b-4281-b951-d872f2087c98
* Before starting translation reset cache in AutoFillManager. To call Reset() ↵dhollowa@chromium.org2010-12-145-91/+234
| | | | | | | | | | | function, append Reset() virtual function in RenderViewHostDelegate::AutoFill and derive it from AutoFillManager. BUG=58576 TEST= 1.launch English version Chrome 2. make sure autofill is enable and there is autofill data entry in settings 3.navigate to a non-English website e.g.: https://secure.fnac.pt/Account/Logon/LogonNewAccount.aspx?NID=-15&RNID=-15&PrevNID=0&pagepar=SID%3d22120814-4186-d926-4f7b-0dece96fade2|Origin%3dFnacAff|OrderInSession%3d1|TTL%3d070420110015|bl%3dHGAChead&PageRedir=https://www2.fnac.pt/Account/Profil/default.asp&PageAuth=yes&LogonType=ACCOUNT 4. when translation infobar show up, click "Translate" to translate to English 5. focus in "E-mail" field 6. press Down arrow 7. select the autofill data entry by double click on it 8. autofill data should be fill in all text boxes Review URL: http://codereview.chromium.org/5322001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69088 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill suggested dropdown list should be closed with unmatched namesdhollowa@chromium.org2010-12-141-5/+7
| | | | | | | | | | | This change adds an explicit call to |hidePopups| when no username/password completion matches the contents of the username text field. BUG=65985 TEST=Manual, according to bug steps. Review URL: http://codereview.chromium.org/5726007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69087 0039d316-1c4b-4281-b951-d872f2087c98
* Rename the OS specific ResourceMessageFilter files as well.jam@chromium.org2010-12-144-3/+3
| | | | | | Review URL: http://codereview.chromium.org/5745006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69086 0039d316-1c4b-4281-b951-d872f2087c98
* Split the layout tests run in the appcache ui tests into two groups, PHP ↵michaeln@chromium.org2010-12-141-32/+58
| | | | | | | | | | | dependent vs non-dependent. Also remove some tests that are racey from the layout tests run in these test cases. BUG=54717 TEST=yes Review URL: http://codereview.chromium.org/4858003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69085 0039d316-1c4b-4281-b951-d872f2087c98
* Deinline even more destructors.erg@google.com2010-12-14138-428/+1009
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5794003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69084 0039d316-1c4b-4281-b951-d872f2087c98
* Using WebFrame::createAssociatedURLLoader() instead of ↵annacc@chromium.org2010-12-142-6/+4
| | | | | | | | | | | | | | | WebFrame::dispatchWillSendRequest(...) According to, http://codesearch.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/third_party/WebKit/WebKit/chromium/public/WebFrame.h WebFrame::dispatchWillSendRequest is now deprecated. Updating to use createAssociatedURLLoader() instead. BUG=65806 TEST=media Review URL: http://codereview.chromium.org/5515008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69083 0039d316-1c4b-4281-b951-d872f2087c98
* This adds some plumbing for propagating the status and error code of a ↵gspencer@chromium.org2010-12-1462-238/+560
| | | | | | | | | | | | | | | | | | | | | renderer process that went away so that we can tell at the UI level what happened to the tab: did it crash, or was it killed by the OOM killer (or some other reason). This is in preparation for implementing a new UI for when a process is killed by the OOM on ChromeOS which handles it differently from a crash. Most of the changes are modifications of the argument list to include a status and error code for the exited process, but in addition the following was done: - Changed the name of DidProcessCrash to GetTerminationStatus. - Added TerminationStatus enum in process_util.h, so it can be used as the status returned by GetTerminationStatus. - Improved process_util_unittest to actually test for crashing and terminated processes on all platforms. - Added a new notification for renderers that were killed. - Added error code information to crash notification. - Added status and error code information to renderer IPC message for RenderViewGone. - Added a UMA histogram count for number of renderer kills. BUG=http://crosbug.com/8505 TEST=ran new unit test. Test passes on try servers. Review URL: http://codereview.chromium.org/5172009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69082 0039d316-1c4b-4281-b951-d872f2087c98
* Cookies tree js code touch up.xiyuan@chromium.org2010-12-141-5/+16
| | | | | | | | | BUG=none. TEST=No behavior change. Review URL: http://codereview.chromium.org/5685008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69081 0039d316-1c4b-4281-b951-d872f2087c98
* Add crash 66741 to the known crashes.csilv@chromium.org2010-12-141-0/+3
| | | | | | | | BUG=66741 TEST=none Review URL: http://codereview.chromium.org/5746006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69080 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r68893 after fixing allowing blocking IO on shutdown.willchan@chromium.org2010-12-145-0/+29
| | | | | | | | | | | | | | | | | | This time I just turned off the checking for Chrome/Windows because Chrome/Windows shutdown is a clusterf***. TODO(willchan): Give a shit about Windows, get a machine that runs Windows, debug Chrome shutdown on Windows, enable this ThreadRestrictions for Chrome/Windows. Consider PlatformThread::Join() to be blocking IO. Marks PlatformThread::Join() as blocking IO using ThreadRestrictions. Whitelists existing spots where we join on the UI/IO threads. Also noteworthy is I allow blocking IO on shutdown. BUG=65530, 66077, 66082 TEST=existing Review URL: http://codereview.chromium.org/5750003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69079 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust perf expectations after v8 and ref roll.chase@chromium.org2010-12-141-10/+10
| | | | | | | | | | | | | | | | | | | | | mac-release-10.5/intl1/times/t mac-release-10.5/intl2/times/t mac-release-10.5/startup/times/t mac-release-10.5/v8_benchmark/score/score mac-release-10.6/v8_benchmark/score/score vista-release-dual-core/v8_benchmark/score/score xp-release-dual-core/intl1/times/t xp-release-dual-core/intl2/times/t xp-release-dual-core/morejs/times/t xp-release-dual-core/v8_benchmark/score/score BUG=none TEST=perf steps are green TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/5781007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69078 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Eliminiate @interface NoOp from base.thakis@chromium.org2010-12-141-17/+3
| | | | | | | | | | | I don't think eliminating _all_ objc from base is the right answer -- the remaining objc has to move out of the static libbase. But if it's easy to have fewer objc to move, that's good. BUG=46929 TEST=One fewer duplicate symbol is reported when loading the pdf plugin. Review URL: http://codereview.chromium.org/5716007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69077 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ResourceMessageFilter to RenderMessageFilter, since that's what it ↵jam@chromium.org2010-12-1427-323/+317
| | | | | | | | actually is. I will add a ResourceMessageFilter just for resource IPCs in a future change. Review URL: http://codereview.chromium.org/5701004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69076 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix.evan@chromium.org2010-12-141-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69075 0039d316-1c4b-4281-b951-d872f2087c98
* webkit: use string16 in ContextMenuParamsevan@chromium.org2010-12-1410-11/+18
| | | | | | | | | BUG=23581 TEST=compiles Review URL: http://codereview.chromium.org/5712003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69074 0039d316-1c4b-4281-b951-d872f2087c98
* Fix extension packer command-line code for Mac. Instead of blocking in a ↵andybons@chromium.org2010-12-137-101/+109
| | | | | | | | | | | | | janky way by running the message loop, I added an option to run the extension packer job synchronously. One thing to note as it pertains to the bug report is that the path must be fully qualified. ~/ for home directories doesn't work for me. BUG=65645 TEST=none Review URL: http://codereview.chromium.org/5703004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69073 0039d316-1c4b-4281-b951-d872f2087c98
* Add a browser test for safebrowsing service.lzheng@chromium.org2010-12-137-35/+455
| | | | | | | | BUG=none TEST=safe_browsing_service_browsertest Review URL: http://codereview.chromium.org/5544008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69072 0039d316-1c4b-4281-b951-d872f2087c98
* Added 'dry run' tag to the print job, to test proxy health without wasting ↵gene@google.com2010-12-1310-9/+76
| | | | | | | | | | | paper/ink. BUG=none TEST=Make sure 'dry run' jobs does not get printed. Review URL: http://codereview.chromium.org/5736004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69071 0039d316-1c4b-4281-b951-d872f2087c98
* An attempt to fix the flakiness with the ChromeFrame Javascript window open ↵ananta@chromium.org2010-12-131-1/+1
| | | | | | | | | | | | | test on IE9. We receive multiple NavigateComplete notifications at times. BUG=none TEST=none Review URL: http://codereview.chromium.org/5703005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69070 0039d316-1c4b-4281-b951-d872f2087c98
* emacs: use curl to fetch trybot output, improve mac performanceevan@chromium.org2010-12-132-209/+1877
| | | | | | | | | | | | | By using a command to fetch trybot output, we can pipe the result through a sed script that trims down the Mac output. This makes the output small enough so that compilation-mode can handle it. While I'm at it, I can use file:/// URLs to unify more of the "real" and "test" code paths. Review URL: http://codereview.chromium.org/5737005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69069 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix stuck hover state in bookmark buttonsail@chromium.org2010-12-131-10/+42
| | | | | | | | | | | | | | | | Bookmark buttons would get stuck with a hover state if they were obscured while the mouse was inside the button. The problem was that the hover state only tracked the mouse entered and exited events. Unfortunately if the button is obscured because it has been removed from the window then a mouse exited event is not sent. Fix was to also update the hover state in the -[NSCell resetCursorRect:inView:] event. This change also improves the mouse tracking code by checking if the mouse is already in over the button. BUG=27073 TEST=Changed tabs with the mouse over a bookmark button. Verified that the hover effect was no longer there after closing the new tab. Did a similar test by entering full screen. Verified that the hover effect was no longer there. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69068 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux] Workaround issue 45478: IME dysfunctional after BACKSPACEsuzhe@google.com2010-12-132-15/+38
| | | | | | | | | | | | | | The reason of the issue is ibus intercepts all key events and does not forward them to chrome at all, while webkit relies on key events to reset one of its internal flag. This CL just fakes key down/up events if the input method intercepts all key events. BUG=45478 TEST=see bug report. Review URL: http://codereview.chromium.org/5787004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69067 0039d316-1c4b-4281-b951-d872f2087c98
* Improve filtering for false positive crashesamit@chromium.org2010-12-133-61/+42
| | | | | | | | | | | | | | | ...by inspecting if the module with the crash has the topmost handler in the SEH chain. If that's the case then the exception will very likely be handled. This covers the case of IsBadReadPtr adn family without any special code. It also lets us address IsValidInterface, an internal helper in urlmon. BUG=64348 TEST=covered by existing unit tests Review URL: http://codereview.chromium.org/5622006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69066 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Rename PasswordsException* to PasswordManager*.jhawkins@google.com2010-12-1311-82/+83
| | | | | | | | | BUG=59282 TEST=none Review URL: http://codereview.chromium.org/5810002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69065 0039d316-1c4b-4281-b951-d872f2087c98
* Single deinlining in first_run.{cc,h}erg@google.com2010-12-132-8/+18
| | | | | | | | | | | (This used to break chrome_frame linking, but after rebasing, there doesn't seem to be any issue.) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5708004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69064 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Fix Shift+Ctrl selection of the list for Windows.arv@chromium.org2010-12-131-1/+2
| | | | | | | | | | | | | BUG=64964 TEST=1. On Windows go to Bookmarks manager. 2. Go to a folder with multiple bookmarks. 3. Select a bookmark 4. Hold down Shift and Ctrl. Click on another bookmark. All the bookmarks between the items should also be selected. Review URL: http://codereview.chromium.org/5780002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69063 0039d316-1c4b-4281-b951-d872f2087c98
* Update OTR icon; deeper shadows match the other platforms better.avi@chromium.org2010-12-131-189/+261
| | | | | | | | | BUG=none TEST=OTR icon's glasses are near-black, not gray Review URL: http://codereview.chromium.org/5808002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69062 0039d316-1c4b-4281-b951-d872f2087c98
* mac output cleanup script: fix match for "nothing to do" make outputevan@chromium.org2010-12-131-1/+1
| | | | | | | | Shoulda written a test! Review URL: http://codereview.chromium.org/5739006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69061 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where icon is not displayed in extension install bubblesaa@chromium.org2010-12-134-8/+22
| | | | | | | | | | | | when installed from store. BUG=65346 TEST=Install any extension from the web store. Should see icon in install success bubble. Review URL: http://codereview.chromium.org/5690004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69060 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 21:03:26 +0000