| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
- Include browser_thread.h instead of chrome_thread.h in more 65 files.
BUG=56926
TEST=trybots
Review URL: http://codereview.chromium.org/3717003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add strings for CA cert import, server cert import, server trust editing.
Standandize some terms "Certification Authority" vs "Certificate Authority",
"Code Signing" vs "Object Signing".
BUG=19991
TEST=none
Review URL: http://codereview.chromium.org/3689003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for tests. Also cleaned up some of the method names in service_process_utils.cc to make them clearer.
BUG=None.
TEST=Browser tests.
Review URL: http://codereview.chromium.org/3727002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
only on a mouse down event. This will allow us to click on instant results without dismissing the omnibox popup.
BUG=56385
TEST=No visible impact, yet.
TEST=Should still be able to tab from the omnibox into webpages.
TEST=Clicking on a webpage should transfer focus to the page.
Review URL: http://codereview.chromium.org/3535015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a very rough cut. Many things are still unfinished and will be fixed in future CLs:
- Clicking on instant results clears the results.
- Suggestions do not work yet.
- The omnibox popup overlaps with instant results.
- HTTP auth dialogs cause crashes.
BUG=56385
TEST=No visible impact when --enable-match-preview is not set on the command line.
TEST=Instant results should appear when typing in the omnibox.
TEST=Instant results should disappear when clicking outside the browser window or clicking on devtools or the sidebar.
Review URL: http://codereview.chromium.org/3624001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=57492
Review URL: http://codereview.chromium.org/3673005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=58795
Review URL: http://codereview.chromium.org/3685003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=58326
TEST=none
Review URL: http://codereview.chromium.org/3729002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updated BackgroundModeManager to keep the browser process alive until extensions finish loading.
This fixes a race condition with the previous implementation of --no-startup-window which
would let chrome exit if the message loop was re-entered before background apps were loaded.
BUG=58083
TEST=run with --no-startup-window, make sure chrome starts
Review URL: http://codereview.chromium.org/3664001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=58772
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/3670003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3412014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=check deps
Review URL: http://codereview.chromium.org/3647005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ESET products (anti-virus) and NetNanny can intercept HTTPS connections. However,
they're False Start intolerant. Rather than have connections hang
forever, we detect them by the leaf certificate's issuer common name
and give a helpful error message.
BUG=58152
TEST=Install ESET anti-virus. Configure to intercept HTTPS connections. Goto https://mail.google.com. Confirm that a helpful error page appears.
Review URL: http://codereview.chromium.org/3723001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Make the template url model load before attempting to set it up.
2. Try extra keywords for this case as well so that the user isn't left clicking something and wondering why no UI appears (which would happen without this change).
BUG=38475
TEST=unit_tests.exe --gtest_filter=TemplateURLFetcherTest*
Review URL: http://codereview.chromium.org/3660004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I also moved some basic logic from tab_contents to TemplateURLFetcher to make it easier to unit test it.
BUG=38475
TEST=unit_tests.exe --gtest_filter=TemplateURLFetcherTest*
Review URL: http://codereview.chromium.org/3710001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Include browser_thread.h instead of chrome_thread.h in files
under dom_ui and download.
BUG=56926
TEST=trybots
Review URL: http://codereview.chromium.org/3700002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
handles are available.
Don't create a console, just attach to any existing console.
R=cpu
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3574008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on http://codereview.chromium.org/3673002/show.
BUG=38475
TEST=Next patch changes the callback mechanism TemplateURLFetcher to make it much more testable and adds tests. (I kept it out of this one to make this more focused.)
Review URL: http://codereview.chromium.org/3652003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3645003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
are re-opened
and address profile created identical to existing address profile should not be saved
BUG=56308,49708
TEST=in the bugs
Review URL: http://codereview.chromium.org/3611015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
integration. This phase hooks up the InMemoryURLIndex to the HistoryQuickProvider which is itself made active during the autocomplete process. A small amount of refactoring was done to liberate some common functionality from the history_url_provider.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3375002
TBR=mrossetti@chromium.org
Review URL: http://codereview.chromium.org/3660007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We weren't drawing the new chromium scrollbars exactly the same
as webkit had, causing layout test failures.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/3697003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Document with the dialog: http://sites.google.com/a/chromium.org/dev/developers/design-documents/chromium-search-provider-js-support
BUG=38475
TEST=Used a custom html page which calls window.external.AddSearchProvider(url, true).
Review URL: http://codereview.chromium.org/3673002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also track corruption separately for old and new file formats.
BUG=58552
TEST=none
Review URL: http://codereview.chromium.org/3632004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58567
TEST=none
Review URL: http://codereview.chromium.org/3710002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the authentication dialog is active, we have to re-layout because
the in-process text put on the button might be larger.
When setting up the desciption for enabled or disabled state, get the
containing scroll view to do the layout, because the height of the
description may have changed. Be nice to the user and make sure the
right things are visible again after that layout.
BUG=none
TEST=use a really long username to enable the cloud print proxy such that the description text wraps to 3 lines. The UI should stay all visible with nothing clipped.
Review URL: http://codereview.chromium.org/3701003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of methods that add and navigate tabs in Browser.
This function is intended to replace at least the following:
Browser::OpenURLAtIndex
Browser::AddTabWithURL
Browser::AddNewContents
... as well as the myriad other functions that call into these.
Right now it's just a standalone thing with a set of unit tests.
A TBD for me is to support singleton tabs. I'm going to work on that next.
BUG=none
TEST=unit tests
Review URL: http://codereview.chromium.org/3591011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- explicitly invalidate the tab contents (makes appearance of drop shadow less delayed/janky)
- correct color of closing infobar arrow
- correct color of infobar arrow after the top infobar was closed and a lower one of a different color took its place
BUG=48996
TEST=manual (see above)
Review URL: http://codereview.chromium.org/3656001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This phase hooks up the InMemoryURLIndex to the HistoryQuickProvider which is itself made active during the autocomplete process. A small amount of refactoring was done to liberate some common functionality from the history_url_provider.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3375002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Add FileUtilProxy::Create that does not leave a file_handle opened.
2. Update the file_util_operation to use FileUtilProxy::Create instead of FileUtilProxy::CreateOrOpen so that no other tasks get queued in before we close the handle.
BUG=58424,58473
TEST=fast/filesystem/
Review URL: http://codereview.chromium.org/3717001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58712
TEST=Sign in to sync with two-step verification account. SigninManagerTest.
Review URL: http://codereview.chromium.org/3702002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes issue 55475 (the Bookmarks manager being blocked with --disable-extensions)
BUG=55475
TEST=ExtensionsServiceTest
Review URL: http://codereview.chromium.org/3711002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows, only hide server data delete if switch is not set. Mirror to r62147.
nib changes:
- for the five "clear server data" items, hidden bound to !owner.isSyncVisible
- for the "clear server data" button, enabled bound to owner.isSyncEnabled, enabled2 bound to !isClearing
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3674005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=56749,56750,57041,57185
TEST=none
TBR=patrick
Review URL: http://codereview.chromium.org/3667004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the relay_channel and syncer_event_channel in favor of having
listeners live on the SyncSessionContext and be notified
directly.
Remove some unnecessary event types and variables.
BUG=26339
TEST=sync_unit_tests
Review URL: http://codereview.chromium.org/3538011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
in a timely manner, avoiding a subtle bug wherein enabling datatypes does not cause a resync.
BUG=56416
TEST=Disable all but one datatype, wait until last sync time is not "just now", re-enable. A resync should happen.
Review URL: http://codereview.chromium.org/3609004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is triggered by the secure infobars on the new tab page when toggling the floating bookmark bar. The reason it comes up is because it applies in the CairoShowRect() case, but not in the XShowRect() case.
BUG=none
TEST=manual; perf bots (after landing)
Review URL: http://codereview.chromium.org/3644001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Open Chat Manager and a chat panel. Type in the panel until it reaches its max height. Roster and panel ht should match
Review URL: http://codereview.chromium.org/3721001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ppapi r282 fixes a clang warning. This should get the clang/mac bot green.
BUG=None
TEST=None
TBR=brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
try to make the shadow follow the arrow's contour better with some fuzzy math.
BUG=48996
TEST=visual
Review URL: http://codereview.chromium.org/3674003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3650002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(ERR_INTERNET_DISCONNECTED)
on Windows and Mac.
BUG=56457
TEST=manual
Review URL: http://codereview.chromium.org/3714001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=green bots
TBR=ajwong@chromium.org
Review URL: http://codereview.chromium.org/3669004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, we lumped the intranet host warning in with mixed content warning. This calls it out as a separate warning.
BUG=58162
TEST=None
Review URL: http://codereview.chromium.org/3536019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Open a page with an accelerated plugin (e.g., Unity). The pugin should not visibily animated to full size from the lower-left corner.
Review URL: http://codereview.chromium.org/3649003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is where the interesting is. The rest is something about video deinterlacing. It also speeds it up a bit.
Also formatted vendor and device IDs as hex since that is how they are usually presented.
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/3652001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62176 0039d316-1c4b-4281-b951-d872f2087c98
|