| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename CompletionCallback to OldCompletionCallback in preparation for introducing a new CompletionCallback based on base::Callback.
Also renames other CompletionCallback types like CancelableCompletionCallback and TestCompletionCallback and CompletionCallbackImpl. All using sed with s/CompletionCallback/OldCompletionCallback/g.
BUG=98719
TEST=none
Review URL: http://codereview.chromium.org/8070013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Split out NotificationPromo helper class for PromoResourceService to handle promo notification.
* Support for views/max_views.
* NotificationPromo has data members for all the prefs fields (start, end, build, time_slice,
max_group, max_views, group, views, text and closed).
* Move notification parsing methods from PromoResourceService to NotificationPromo.
* NotificationPromo can be initialized from json when the promo resource is parsed, or from prefs,
when CanShowNotificationPromo is called.
* NotificationPromo now only writes out prefs upon detecting a new notification.
* NotificationPromo has a Delegate class, useful for testing.
* Static helper methods introduced for extracting time from DictionaryValue, string and prefs.
These may be easily unit-tested in the future.
* Number of additional tests to more thoroughly test parsing, CanShow logic, and static helper
functions like GetNextQuestionValue and NewGroup.
* NewGroup now uses RandInt instead of rand(), so this CL passes lint with no complaints.
* Some additional cleanup of PromoResourceService, esp GetChannel and IsBuildTargeted.
BUG=96290
TEST=Unit tests pass. Use
--promo-server-url='http://achuithz600.mtv.corp.google.com/www/files/promoresource2?hl='
to see the promo. If you exceed 5 views, you have to reset the views count (ntp.promo_views)
in your Preferences.
Review URL: http://codereview.chromium.org/8045012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=96998
TEST=no
Review URL: http://codereview.chromium.org/8086023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=96998
TEST=no
Review URL: http://codereview.chromium.org/8082024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
g_browser_process->file_thread()->PostDelayedTask
with
BrowserThread::PostDelayedTask(BrowserThread::FILE
The former would create the file thread, while the later wouldn't. I changed it back.
BUG=98756
TBR=jar
Review URL: http://codereview.chromium.org/8098021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
because it was initialized before the browser threads were started.
BUG=98756
Review URL: http://codereview.chromium.org/8102017
TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/8101012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=98538
TEST=
Review URL: http://codereview.chromium.org/8083022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=60100
TEST=none
Review URL: http://codereview.chromium.org/8101004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original attempt (crrev.com/103572) was reverted as it broke brower_tests.
We shouldn't have returned fake values from GetMachineStatistic() as there is
a piece of code in customization_document.cc that sets locale, timezone,
keyboard based on values returned from StatisticsProvider. In this patch,
GetMachineStatistic() is changed to just return false.
This will silence spurious error messages like below.
out/Release/chrome --enable-logging=stderr --login-manager
...
[10361:10361:1375055823758:WARNING:name_value_pairs_parser.cc(77)] /usr/bin/crossystem not found. Maybe running on Linux desktop?
[10361:10361:1375055827762:WARNING:name_value_pairs_parser.cc(102)] Error excuting: /bin/cat /tmp/machine-info
[10361:10361:1375055832942:WARNING:name_value_pairs_parser.cc(102)] Error excuting: /bin/cat /var/log/vpd_2.0.txt
TEST=confirm that the errors are gone from Linux desktop, and the functionality works on chrome os (add --vmodule=name_value_pairs_parser=1 and check the log).
BUG=chromium-os:21080
Review URL: http://codereview.chromium.org/8103019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
browser threads were started.
BUG=98756
Review URL: http://codereview.chromium.org/8102017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Will's implementation of NeedsScopedRefptrButGetsRawPtr checks for refcounting by testing for converability of the pointer values to base::RefCounted and base::RefCountedThreadsafe. This happens to tolerate incomplete types in a sane way on linux where the check is enabled.
UnsafeBindtoRefCountedArg's impelmentation relies on introspecting the type for the existence of a member function. Though this will catch refcounted objects with a refcount API that are not derived from base::RefCounted and base::RefCountedThreadsafe it requires complete types which places too strong of a constraint on what kinds of arguments can be bound.
Since the majority (all?) refcounted types in Chromium are derived from base::RefCounted and base::RefCountedThreadsafe, this should be just as good of a guarantee.
Bug filed to see if there's a way to adapt UnsafeBindtoRefCountedArg.
BUG=94995,98732
TEST=new unittest.
Review URL: http://codereview.chromium.org/8101008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents a NOTREACHED from being reached when clearing
history right after starting a page load.
BUG=86829
TEST=HistoryBackendTest.DeleteAllThenAddData
Review URL: http://codereview.chromium.org/8086012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This means we no longer use libcros to handle the screen brightness.
The brightness changed signal is handled in power_manager_client.cc,
rather than in libcros.
TEST=confirm that brightness change keys work as before.
BUG=chromium-os:18904
Review URL: http://codereview.chromium.org/8044034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Remove JsOnlyV8Extensions since we can just create instances of ChromeV8Extension where necessary.
Instead of using made-up names like "chrome/extensionprocessbindings", standardize on the path to the file as the name of an extension.
Review URL: http://codereview.chromium.org/8100014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'll leave the infrastructure in place to make it easier to
land another such experiment (where the query string is modified).
There has already been discussion of other experiments, so it
seems worth leaving it.
r=pkasting
BUG=97345
Review URL: http://codereview.chromium.org/7981018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This temporarily undoes r102971.
[Trying to get metrics services working again. Will also revert 102971 and
102421.... but too many conflicts in process is making me look for underlying
cause as a simpler approach.]
BUG=17863,98294
TEST=With the Totem plugin installed, launch Chromium and go to about:plugins. You have plugins.
Review URL: http://codereview.chromium.org/8059039
TBR=rsesek@chromium.org
Review URL: http://codereview.chromium.org/8102016
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8093015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
temporarily undoes r102971.
[Trying to get metrics services working again. Will also revert 102971 and 102421]
BUG=17863,98294
TEST=With the Totem plugin installed, launch Chromium and go to about:plugins. You have plugins.
Review URL: http://codereview.chromium.org/8059039
TBR=rsesek@chromium.org
Review URL: http://codereview.chromium.org/8102016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
tests.
BUG=chromium-os:18185
TEST=None
Review URL: http://codereview.chromium.org/8095022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This broke many tests in browser_tests.
--
This will silence spurious error messages like below.
out/Release/chrome --enable-logging=stderr --login-manager
...
[10361:10361:1375055823758:WARNING:name_value_pairs_parser.cc(77)] /usr/bin/crossystem not found. Maybe running on Linux desktop?
[10361:10361:1375055827762:WARNING:name_value_pairs_parser.cc(102)] Error excuting: /bin/cat /tmp/machine-info
[10361:10361:1375055832942:WARNING:name_value_pairs_parser.cc(102)] Error excuting: /bin/cat /var/log/vpd_2.0.txt
TEST=confirm that the errors are gone from Linux desktop, and the functionality works on chrome os (add --vmodule=name_value_pairs_parser=1 and check the log).
BUG=chromium-os:21080
Review URL: http://codereview.chromium.org/8098006
TBR=satorux@chromium.org
Review URL: http://codereview.chromium.org/8098018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=41781
TEST=Manual test in ppapi/examples/mouse_lock.
Review URL: http://codereview.chromium.org/8072011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
content\public\renderer.
BUG=98716
Review URL: http://codereview.chromium.org/8100013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I don't see any reason for this method to exist.
It was part of the following call stack:
TaskManagerDialogImpl::OpenHtmlDialog from
ui/webui/task_manager_dialog.cc calls
Browser::BrowserShowHtmlDialog() from ui/browser.cc,
which calls
BrowserView::ShowHTMLDialog() from ui/views/frame/browser_view.cc,
which calls
browser::ShowHtmlDialog() from ui/views/html_dialog_view.cc,
which calls
browser::CreateViewsWindow() from ui/views/window.cc,
which calls
chromeos::BubbleWindow::Create()
(with a hardcoded parameter that I want to change.) :-(
No functional changes intended.
BUG=chromium-os:20998
TEST=built and ran it
Review URL: http://codereview.chromium.org/8083024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refuse to lock the mouse if the security origin of the document containing the requesting pepper plugin cannot access the security origin of the main frame document.
BUG=41781
TEST=None
Review URL: http://codereview.chromium.org/8070011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=75037
TBR=dmaclach@chromium.org
Review URL: http://codereview.chromium.org/8095024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to top-most.
It borked Linux Touch and Linux Views compile
This could happen when we try to make the window top-most after it has been
created without activation. This seems to be a bug or feature on Windows that
some users have been complaining about.
To fix this problem, I changed BrowserFrame::InitBrowserFrame to pass the
keep_on_top flag when the panel is to be created.
I have also added windows specific testing code to check the styles in the
browser test.
BUG=none
TEST=browser test
Review URL: http://codereview.chromium.org/8098007
TBR=jianli@chromium.org
Review URL: http://codereview.chromium.org/8103017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dmaclach@chromium.org
BUG=98751
Review URL: http://codereview.chromium.org/8094014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Similar to AudioDecoderConfig that was introduced in r102183, add Initialize() and IsValidConfig() to VideoDecoderConfig and update documentation. This helps pave the way to remove DemuxerStream::GetAVStream().
Since natural_size isn't used by neither VideoDecoderConfig nor VideoDecodeEngines, remove it from both and replace VideoCodecInfo with a bool.
Review URL: http://codereview.chromium.org/8084021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This could happen when we try to make the window top-most after it has been
created without activation. This seems to be a bug or feature on Windows that
some users have been complaining about.
To fix this problem, I changed BrowserFrame::InitBrowserFrame to pass the
keep_on_top flag when the panel is to be created.
I have also added windows specific testing code to check the styles in the
browser test.
BUG=none
TEST=browser test
Review URL: http://codereview.chromium.org/8098007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=91402
TEST=None
Review URL: http://codereview.chromium.org/8038054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It borked linux x64 browser_tests
Review URL: http://codereview.chromium.org/8072017
TBR=dimich@chromium.org
Review URL: http://codereview.chromium.org/8102015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
file.
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/7966030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8095021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
profiles without name info.
BUG=98280
TEST=none
Review URL: http://codereview.chromium.org/8068014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=vivianz@chromium.org
BUG=85310
TEST=
Review URL: http://codereview.chromium.org/8094012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change https://bugs.webkit.org/show_bug.cgi?id=69144
uses SkCreateCGImageRefWithColorspace which is present in
third_party/skia/include/utils/mac/SkCGUtils.h. This path
is not visible to WebCore.gyp, so make it visible here.
BUG=97830
TEST=none
Review URL: http://codereview.chromium.org/8095009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=98116
TEST=
Review URL: http://codereview.chromium.org/8094004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org,ajwong@chromium.org
Review URL: http://codereview.chromium.org/8070007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/src/webkit/plugins/npapi/webplugin_delegate_impl.h.
BUG=97131
TEST=none
Review URL: http://codereview.chromium.org/8100006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Change-Id: Ie68832491806e0414193b445cdd5a5e02313ea08
BUG=chromium-os:21063
TEST=See issue (dragging panel on ChromeOS shouldn't crash)
Review URL: http://codereview.chromium.org/8095014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The elfutils package is available on every Linux variant, is not very
large, and simply adds new utilities called eu-* without affecting anything
else. Packaging changes I hope to land later will need to have eu-strip
available on the buildbots that do official release builds.
BUG= none
TEST= none
R=bradnelson@google.com
Review URL: http://codereview.chromium.org/8083023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
enterprise.EnterpriseTest.testAlwaysAuthorizePlugins
BUG=97179
TEST=NONE
Review URL: http://codereview.chromium.org/8093007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103588 0039d316-1c4b-4281-b951-d872f2087c98
|