| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
logic when the user tries to launch the app. This also adds a chrome://extension-icon endpoint that provides easy access to extension and app icons.
BUG=61270
TEST=ExtensionIconSourceTest.IconsLoaded
Review URL: http://codereview.chromium.org/6495002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/6453001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:7843
TEST=built and ran a new image, also ran smoke test suite on the vm.
Review URL: http://codereview.chromium.org/6594095
Patch from Gaurav Shah <gauravsh@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
regularly.
BUG=74612
TEST=Turn on prerender, do a query for "Google Trends", click on top link, and icon appears.
Review URL: http://codereview.chromium.org/6588120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6588006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=antonm
Review URL: http://codereview.chromium.org/6591110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6597083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
expect actions
which correspond to user gesture like downloads, external protocol launches, etc. Actions
occurring in the context of user input need to be allowed. To achieve this we send over
the WM_PARENTNOTIFY message to the RVH window which turns on user gesture. As per msdn
this message should be received automatically which does not appear to be the case.
All this means that we trust the plugin. However this does not add a new attack vector
as the plugin can send messages to other windows in the desktop anyway.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=41157
BUG=41157
TEST=As described in the bug.
Review URL: http://codereview.chromium.org/6592092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Running chrome with sudo will change the owner of chrome's config files. This
is really bad and more people accidentally run 'sudo chrome' once and then
screw their profile up.
Inspired by a real life support case this morning and rereading jwz's take on
the issue on evanm@'s blog.
BUG=74594
TEST='sudo chrome' pops up a nice error message and all the files in the profile directory aren't owned by root.
Review URL: http://codereview.chromium.org/6591083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Note that I didn't need to adjust many callers on the Windows
side because wstring and string16 are compatible on Windows.)
BUG=23581
Review URL: http://codereview.chromium.org/6596087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=antonm
Review URL: http://codereview.chromium.org/6591107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable the WATCHDOG thread that monitors browser threads for their
responsiveness using ping-pong messaging. WACTHDOG thread also
collects statistics for response time for each thread via histograms.
This CL was approved http://codereview.chromium.org/6588039
BUG=71378, 73915, 73844, 73975
TEST=performance tests
TBR=jar
Review URL: http://codereview.chromium.org/6591091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Always validate a truncated entry. Furthermore, given
that a server can say not-modified (304), followed by
200 when actually asked for the final range, now we
validate truncated entries by asking for the next byte
that we need.
- If a server refuses to serve a byte range and instead
sends the whole resource, we just cache the response as
if nothing was stored before.
- If we receive a network error while reading from the
net, we don't discard the cached entry right away. Now
we wait until the transaction is closed, and attempt to
mark the entry as truncated.
BUG=48468
TEST=net_unittests
Review URL: http://codereview.chromium.org/6588105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=74468
TEST=Perform a search, display an overlay, close the overlay. Search should still be active.
Review URL: http://codereview.chromium.org/6594093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This can reduce 5ms on cr48 when loading page.
BUG=8632
TEST=load the page build.chromium.org and make sure the spinner cursor is used for content area.
Review URL: http://codereview.chromium.org/6588121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6594120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The volume indicator is moved up, 'Speak now' text comes in the middle and when recognition
is in progress we show only the spinner with no text. When showing error messages, include
a hyperlink to launch the microphone settings UI. Also includes a bunch of spacing changes
to look like in the mocks.
Also changed usage of BrowserThread::PROCESS_LAUNCHER to BrowserThread::FILE per John's suggestion in an earlier review.
BUG=69886
TEST=manual, start speech input on windows and verify the bubble UI looks similar to the mocks.
Review URL: http://codereview.chromium.org/6604006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
class). It is used to retrieve different printing contexts (based on the platform and user preferences).
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/6544028
TBR=dpapad@chromium.org
Review URL: http://codereview.chromium.org/6594121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to retrieve different printing contexts (based on the platform and user preferences).
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/6544028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=avi
Review URL: http://codereview.chromium.org/6596103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:7943
TEST=manual (see bug description)
Review URL: http://codereview.chromium.org/6602083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6598083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the same as the last bounds the popup wouldn't show.
BUG=73984
TEST=make sure omnibox popup shows up correctly.
Review URL: http://codereview.chromium.org/6602065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Chromeos doesn't use them, but this takes 10ms to update the title string
BUG=chromium-os:8632
TEST=none
Review URL: http://codereview.chromium.org/6574054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=74614
TEST=valgrind bots don't go red because of SpeechRecognizer
Review URL: http://codereview.chromium.org/6604005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=70296
TEST=See bug for exact steps.
Review URL: http://codereview.chromium.org/6594087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is no referrer when an SSL page prerenders a non-SSL page.
Note that this patch is most of patch http://codereview.chromium.org/6580041
(reverted http://src.chromium.org/viewvc/chrome?view=rev&revision=76304).
The only difference is the redirect test is not modified to use plugins.
After the patch, the buildbots were periodically failing
PrerenderBrowserTest.PrerenderRedirect with lock errors (2 times out of 10+
runs). See, e.g.
http://build.chromium.org/p/chromium/builders/Linux%20Tests%20x64/builds/5976/steps/browser_tests/logs/PrerenderRedirect
(Note that the percents in the URL are incorrectly escaped by the
codereview page, so the URL has to be copied and pasted to be used).
I believe the issue is that the other prerender browser test that uses plugins
is not shutting down the plugin process properly. I want to see if I can
reproduce the issue locally and fix it, not because the change I reverted
is so important, but because if I'm right, it could be a cause of future
test flake.
BUG=73170
TEST=PrerenderBrowserTest.PrerenderNoSSLReferrer
Review URL: http://codereview.chromium.org/6591068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
"NavigateToURL" in ErrorPageTest.Page404
BUG=36558
TEST=ErrorPageTest.Page404
Review URL: http://codereview.chromium.org/6591044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:11381
TEST=built chrome
Review URL: http://codereview.chromium.org/6596068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
entries by path
If we have two cache entries :
< 'example.com', userA, realmA, paths=[ '/' ] > and
< 'example.com', userB, realmB, paths=[ '/foo/' ] >
Then a LookupByPath() for '/foo/bar/baz' should return the cache entry for userB rather than userA.
BUG=73294
TEST=net_unittests --gtest_filter=HttpAuthCacheTest.Basic
Review URL: http://codereview.chromium.org/6596076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6592090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Temporarily add test_expectations for passing strict mode tests that
have wrong expectations upstream. Martin Maly is landing new baselines
in WebKit after which we can remove the temporary expectations.
Review URL: http://codereview.chromium.org/6604004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
mini installer tests don't cry when they evaluate M10 builds.
BUG=74561
TEST=make sure this works: mini_installer_test.exe -clean -force --build=10.0.648.119 --gtest_filter=*FullInstallerUser
Review URL: http://codereview.chromium.org/6602086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
substrings of others (IDS_INSTALL_HIGHER_VERSION and IDS_INSTALL_HIGHER_VERSION_CF, for example) were being sorted incorrectly. Now they aren't.
As a bonus, installer_util_strings now depends on create_string_py, so changes to the scipt no longer require a clobber. Yay
BUG=73884
TEST=build installer_util_strings then look at the generated .h and .rc files and notice that they are sorted properly
Review URL: http://codereview.chromium.org/6594108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:12571
TEST=Chrome no longer crashes on ChromeOS login.
Review URL: http://codereview.chromium.org/6592039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6592083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Start Chrome with prerender explicitly enabled, use a prerendered page, ensure that Prerender.TimeUntilUsed shows up in about:histograms
Review URL: http://codereview.chromium.org/6596079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previous behaviour for git-svn repositories is to return git hash (this hash then appears on about:version page and can be copy-pasted into bugreport).
However for developer branches with local modifications this hash bears no information to the outside world.
Now we return svn revision for trunk git-svn checkouts and svn-revision plus "-dirty" suffix for git branches.
The magic required to run git on cygwin is factored out into separate function.
BUG=chromium:70909
TEST=Manual
Review URL: http://codereview.chromium.org/6474044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/6596107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=glider
TEST=The gtest exclude filter paths look better on Windows too.
Review URL: http://codereview.chromium.org/6602084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Try to open chrome.admx on Windows Server 2008 with gpedit
Review URL: http://codereview.chromium.org/6602082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61179
TBR=rtenneti,jar
TEST=TSan bots should remain green
Review URL: http://codereview.chromium.org/6597103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/6591099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also, print human-readable paths for gtest filter files.
BUG=74663
TBR=glider
Review URL: http://codereview.chromium.org/6597102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76520 0039d316-1c4b-4281-b951-d872f2087c98
|