summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Move pref_{member,service} and important_file_writer from chrome/commonphajdan.jr@chromium.org2010-02-19217-252/+252
| | | | | | | | | | | | | to chrome/browser. This is a part of an effort to remove bad dependency of chrome/common on chrome/browser. TEST=unit_tests and ui_tests, just moving code BUG=none Review URL: http://codereview.chromium.org/621004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore titlebar drags if the window is maximized and matches the screentony@chromium.org2010-02-191-4/+12
| | | | | | | | | | | | | size. This is to work around a case that would normally fullscreen the window. BUG=23480 TEST=maximize chrome on a desktop w/o gnome panels and try to drag the area behind the tabs. nothing should happen. Review URL: http://codereview.chromium.org/651005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39425 0039d316-1c4b-4281-b951-d872f2087c98
* Protect against re-entering OnThrottleMessage thru CallWindowProc.darin@chromium.org2010-02-192-19/+24
| | | | | | | | | | | | This is a speculative fix for a crash that showed up on the reliability bot. R=jam BUG=36188 TEST=none Review URL: http://codereview.chromium.org/646051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39424 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 39421 - Switch to putting appversion at top level of XMLjar@chromium.org2010-02-191-1/+1
| | | | | | | | | | | | | | This change puts appversion at the same level as buildtime, and so it is avalable (now) for use in histogram versioning, as well as stability versioning (or user metrics versioning). r=huanr Review URL: http://codereview.chromium.org/646056 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/651012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39423 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to putting appversion at top level of XMLjar@chromium.org2010-02-191-1/+1
| | | | | | | | | | | This change puts appversion at the same level as buildtime, and so it is avalable (now) for use in histogram versioning, as well as stability versioning (or user metrics versioning). r=huanr Review URL: http://codereview.chromium.org/646056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39421 0039d316-1c4b-4281-b951-d872f2087c98
* Update some win/linux baselines aftertony@chromium.org2010-02-196-32/+17
| | | | | | | | | | | http://trac.webkit.org/changeset/54933 . BUG=36110 TBR=eseidel Review URL: http://codereview.chromium.org/651010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39420 0039d316-1c4b-4281-b951-d872f2087c98
* Pulled out Callback code into base/callback.h. This is the first step ↵akalin@chromium.org2010-02-19195-313/+503
| | | | | | | | | | | | | towards redoing the Callback interfaces. Added and removed includes as needed. BUG=35223 TEST=trybots Review URL: http://codereview.chromium.org/646061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39419 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r39417: "Implement NetworkChangeNotifierLinux."willchan@chromium.org2010-02-192-182/+4
| | | | | | | | | It broke the chromium arm build. BUG=26156 Review URL: http://codereview.chromium.org/651006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39418 0039d316-1c4b-4281-b951-d872f2087c98
* Implement NetworkChangeNotifierLinux.willchan@chromium.org2010-02-192-4/+182
| | | | | | | | | BUG=26156 TEST=Browse a bit. Observe about:net-internals/hostresolver.hostcache to note that the cache is populated with data. sudo /sbin/ifconfig lo down; sudo /sbin/ifconfig lo up. Observe about:net-internals/hostresolver.hostcache to note that the cache should now be empty (or almost empty, since other host resolutions may have happened in the meanwhile). Review URL: http://codereview.chromium.org/645001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39417 0039d316-1c4b-4281-b951-d872f2087c98
* Disable IPv6 in FTP until we have implemented the IPv6 extensions for FTPwtc@chromium.org2010-02-191-1/+4
| | | | | | | | | | | | specified in RFC 2428. R=eroman,phajdan.jr BUG=32945 TEST=ftp://ftp.netbsd.org/ should work on a machine with dual IPv4/IPv6 connectivity. Review URL: http://codereview.chromium.org/592001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39416 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a Chrome crash caused in a ChromeFrame instance while displaying the ↵ananta@chromium.org2010-02-193-50/+49
| | | | | | | | | | | | | | | | | | | inspector window. The inspector window uses the browser view which instantiates the whole view including the ToolBar, which in turn instantiates the Autocomplete edit bar which uses Richedit on Windows. The auto complete edit bar dynamically loads and unloads the richedit control and it uses ATL to superclass the richedit control. If the rich edit dll loads at a different base address it causes a crash in Chrome while creating the window as ATL caches the wndproc address for a class. Fix is to setup an implicit dependency on the riched20.dll and not load and free it all the time. To achieve this we use #pragma comment for the riched20.lib and a dummy call to the CreateTextServices function exported by the dll to ensure that the linker does not discard the import. Fixes bug http://code.google.com/p/chromium/issues/detail?id=33308 Bug=33308 Review URL: http://codereview.chromium.org/646043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39415 0039d316-1c4b-4281-b951-d872f2087c98
* Requesting C++ readability review for these classes and unit tests.kbr@chromium.org2010-02-196-107/+102
| | | | | | | | | | | | | The arena allocator is designed for optimized allocation and deallocation of small temporary objects, and is used by the augmentable red-black tree. In a subsequent checkin, the red-black tree will be augmented into an interval tree, which is a key data structure for efficient implementation of one of the algorithms in the forthcoming code in this directory. Review URL: http://codereview.chromium.org/596093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39414 0039d316-1c4b-4281-b951-d872f2087c98
* Added a specialized triangulator which creates triangles filling thekbr@chromium.org2010-02-196-0/+808
| | | | | | | | | | | | | | convex hull of the four control points of a cubic curve segment. It also computes a path along the filled side of the curve segment, which will be used to fill the interior region of closed shapes with a general tessellation algorithm. BUG=none TEST=LocalTriangulatorTest Review URL: http://codereview.chromium.org/646048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39413 0039d316-1c4b-4281-b951-d872f2087c98
* check if ModelNeutralExecuteImpl succeeded before running ↵dantasse@chromium.org2010-02-194-7/+13
| | | | | | | | | | | ModelChangingExecuteImpl BUG:36200 TEST:manual Review URL: http://codereview.chromium.org/646078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39412 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Refactor omnibox popup to fix click-drag display.shess@chromium.org2010-02-192-111/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | Fix the confusion between highlighted and selected cells by overriding |-mouseDown:| and directly implementing the desired behaviors. Which are: - while mouse is down in the view, the item under the mouse looks selected, like it would if you used the arrow keys to move it around (rather than highlighted). - dragging off with mouse down reverts to previous selection (the one matching the field's contents). - releasing while mouse is off-view reverts to previous selection. - dragging back with mouse still down selects the cell under the mouse. Additionally, refactor to remove useless utility object. The custom matrix now just messages the C++ object directly. BUG=25435 TEST=See bug. Review URL: http://codereview.chromium.org/646063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39411 0039d316-1c4b-4281-b951-d872f2087c98
* Extracted non-XRender painting path from BackingStoreX into PutARGBImage().scherkus@chromium.org2010-02-193-90/+108
| | | | | | | | | BUG=n/a TEST=everything should stay the same Review URL: http://codereview.chromium.org/647062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39410 0039d316-1c4b-4281-b951-d872f2087c98
* Instead of using a single template file and leaving some parts of it out, ↵johnnyg@chromium.org2010-02-196-20/+86
| | | | | | | | | | | use template files for each configuration. this allows for better presentation of small notifications without a lot of empty space. BUG=36081 TEST=create notification with a short string Review URL: http://codereview.chromium.org/628010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39409 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when installing an extension from incognito mode.mpcomplete@chromium.org2010-02-191-3/+6
| | | | | | | | BUG=36077 Review URL: http://codereview.chromium.org/646072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39408 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Delete the disk cache if it is substantially biggerrvargas@google.com2010-02-193-18/+41
| | | | | | | | | | | | | | | | | | than the desired max size, and adjust eviction to avoid having long periods without it. There's a few users with caches that are too big, and it looks like the problem is that eviction could be stopped forever, while still adding new items to the cache. Now we only allow one minute (at a time) with eviction suspended. BUG=none TEST=none Review URL: http://codereview.chromium.org/647054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39407 0039d316-1c4b-4281-b951-d872f2087c98
* Fix dock icon while downloading.avi@chromium.org2010-02-191-4/+2
| | | | | | | | | BUG=http://crbug.com/35791 TEST=paste on a new app icon, download something, switch between apps, app icon should always be right Review URL: http://codereview.chromium.org/646036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39406 0039d316-1c4b-4281-b951-d872f2087c98
* Support dragging a virtual file out of the browser on Linux. This is based ↵jianli@chromium.org2010-02-198-74/+252
| | | | | | | | | | | on the discussion of drag-out feature on whatwg: http://list.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-August/022122.html BUG=none TEST=To test, drag an element that adds the DownloadURL format data via event.DataTransfer.setData, to the desktop or a folder. Review URL: http://codereview.chromium.org/600154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39405 0039d316-1c4b-4281-b951-d872f2087c98
* Marking the FullTabModeIE_ReferrerTest as FLAKY as this still intermittently ↵ananta@chromium.org2010-02-191-1/+3
| | | | | | | | | | | fails. Bug=34812 TBR=tommi Review URL: http://codereview.chromium.org/646073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39404 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in about:memory that resulted in showing null for browser ifsky@chromium.org2010-02-181-1/+3
| | | | | | | | | | | | | | you had a crashed tab or phantom tab. BUG=none TEST=create two tabs, pin one, close it (so that it goes phantom), navigate to about:memory and make sure you don't see an entry for the phantom tab. Review URL: http://codereview.chromium.org/646035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39399 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dead code from safe_browsing_util.h/cc.shess@chromium.org2010-02-185-647/+73
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/630012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39398 0039d316-1c4b-4281-b951-d872f2087c98
* Have rlz record first search event in a corner casecpu@chromium.org2010-02-181-6/+7
| | | | | | | | | | | | | | | | 1- start chrome do nothing for 90+ seconds 2- close chrome 3- relaunch chrome 4- type in the omnimbox before 90 seconds 5- observe (with debuger) that first search event is not recorded BUG=b\1812626 TEST=see bug for testing details. Review URL: http://codereview.chromium.org/646031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39397 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 33138: Clicking on the extension name for an extension downloadedfinnur@chromium.org2010-02-181-1/+8
| | | | | | | | | | | | | | off the web (non-gallery) goes to the Gallery page (and shows id not found). We now disable this link for non-gallery extensions. BUG=33138 TEST=Download an extension from a non-gallery source. Right click the icon, the name menu item should be grayed out. For extensions from the gallery, it should not be grayed out. It should link to the gallery. Review URL: http://codereview.chromium.org/646026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39396 0039d316-1c4b-4281-b951-d872f2087c98
* Expose more functionality to pyautonirnimesh@chromium.org2010-02-184-3/+68
| | | | | | | | | | | | Additions include some low-hanging fruits: - create tabs - activate a tab by index - apply any accelerator (like IDC_BACK, IDC_REFRESH) - install and load an extension Review URL: http://codereview.chromium.org/647006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39394 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the command line flag --testing-fixed-host.eroman@chromium.org2010-02-183-25/+3
| | | | | | | | | | | | This has been superceded by --host-resolver-rules. (Instead of --testing-fixed-host="foobar" one would use --host-resolver-rules="MAP * foobar") BUG=36053 Review URL: http://codereview.chromium.org/647005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39393 0039d316-1c4b-4281-b951-d872f2087c98
* The PromptDelegate needs to delete itself once it gets a reply.darin@chromium.org2010-02-181-3/+11
| | | | | | | | | | R=jorlow BUG=none TEST=none Review URL: http://codereview.chromium.org/646021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39392 0039d316-1c4b-4281-b951-d872f2087c98
* Adds new API to process_utils to launch a new app as a user in a specified ↵gwilson@google.com2010-02-183-2/+18
| | | | | | | | | | | | | desktop. Also modifies toast behavior to use this API instead. R=huanr,cpu BUG=none TEST=Run system-level toast with an attached user, toast should be visible. Review URL: http://codereview.chromium.org/596087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39391 0039d316-1c4b-4281-b951-d872f2087c98
* Client-side SSL cert support for Mac.snej@chromium.org2010-02-1810-124/+459
| | | | | | | | | | This includes sending an existing identity cert, and asking the user which cert to use. Doesn't yet handle SSL renegotiation, or key-gen. BUG=16831 TEST=none Review URL: http://codereview.chromium.org/604067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39389 0039d316-1c4b-4281-b951-d872f2087c98
* We need to traverse the infobars with a reverse loop asjcampan@chromium.org2010-02-181-1/+1
| | | | | | | | | | | | | | | | | we remove them (as after removal the index is pointing too far by 1, so the next immediate infobar won't be removed). BUG=None TEST=Get to a page with 2 infobars (for ex: crash the browser and restart (so you get the browser crashed infobar and make it not your default browser so you get the default browser infobar), kill the page process with the task manager. The sad page should be shown and the infobars should disappear. Review URL: http://codereview.chromium.org/646045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39388 0039d316-1c4b-4281-b951-d872f2087c98
* Added computation of three-dimensional texture coordinates for thekbr@chromium.org2010-02-183-0/+289
| | | | | | | | | | | | | | | | control points of cubic curves. It's difficult if not impossible to write a unit test for this part of the algorithm, since the texture coordinates aren't precisely defined for any particular inputs. The forthcoming system tests will exercise these code paths. BUG=none TEST=none Review URL: http://codereview.chromium.org/647041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39386 0039d316-1c4b-4281-b951-d872f2087c98
* Adding @@extension_id reserved message to l10n message map for extension.cira@chromium.org2010-02-186-9/+15
| | | | | | | | | | | | | | | | | | | | | It's added outside of ExtensionMessageBundle so that non-localized extensions can use it. Developer doesn't have to define default_locale in the manifest in order to get it working. With this change every extension css file will go through message replacement process (only localized extensions went through that before). This change will allow following construct in extension css: body { background-image:url('chrome-extension://__MSG_@@extension_id__/background.png'); } BUG=35208 TEST=Add an background image to your extension, and refer to it from css file using __MSG_@@extension_id__. Image should show up in the background. Review URL: http://codereview.chromium.org/628009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39385 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes switching the target back to the original languagejcampan@chromium.org2010-02-185-49/+52
| | | | | | | | | | | | | revert the translation. It also simplifies the page translator logic. We are initializing the PageTranslator states when a new page is translated. Further translations reuse the text nodes already retrieved. Also an unused method has been removed from RenderView. BUG=36073 TEST=See bug. Thoroughly test the translation feature. Review URL: http://codereview.chromium.org/647030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39384 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for referrer flakyness. There were two problems:tommi@chromium.org2010-02-185-28/+74
| | | | | | | | | | | | | | | Grabbing the referrer header when the request is made and not in BeforeNavigate2. The request headers aren't always available in BeforeNavigate2. Mshtml provides these headers in IHttpNegotiate::BeginningTransaction, which is where we now grab them. There was a race in chrome_frame_automation.cc where we use std::string to store the referrer url and then access that string from different threads. This was causing the referrer URL to be missing at some times and at other times be sent over to chrome as bad string (e.g. containing embedded nulls) and subsequently be deemed an invalid URL and dropped. TEST=Fixes referrer header flakyness. BUG=34812 Review URL: http://codereview.chromium.org/646013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39383 0039d316-1c4b-4281-b951-d872f2087c98
* Mac fullscreen: prevent mouse clicks on overlay from passing through to content.viettrungluu@chromium.org2010-02-181-0/+18
| | | | | | | | | | | Also make it so that double-clicks on overlay should (theoretically) minimize. BUG=36108 TEST=Enter fullscreen mode. With content having links or similar (e.g., NTP bookmark bar), click at various locations on the (slide-down) overlay bar. Clicks should not pass through. Mouse cursor should not reflect web content underneath. Review URL: http://codereview.chromium.org/646004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39382 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all infobars from a tab when its renderer crashes.jcampan@chromium.org2010-02-181-0/+4
| | | | | | | | | | | | | They are irrelevant in the sad tab. BUG=36035 TEST=Navigate to a foreign page so the translate infobar shows up. From the task manager, kill the renderer process for that page. The translate infobar should disappear. Review URL: http://codereview.chromium.org/646023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39381 0039d316-1c4b-4281-b951-d872f2087c98
* Add crasher in webplugindelegateimpl to list of known crashers.mirandac@chromium.org2010-02-181-0/+3
| | | | | | | | BUG= 36188 TEST= none Review URL: http://codereview.chromium.org/646038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39378 0039d316-1c4b-4281-b951-d872f2087c98
* Update utimes suppression with the upstream bugstuartmorgan@chromium.org2010-02-181-11/+8
| | | | | | | | | BUG=none TEST=valgrind bots Review URL: http://codereview.chromium.org/647042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39376 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 39366 - Initial Geolocation implementationbulach@chromium.org2010-02-1834-1385/+60
| | | | | | | | | | | | | | Adds IPC plumbing. Adds Infobar buttons for requesting permission TEST=geolocation_browsertest.cc Review URL: http://codereview.chromium.org/548188 TBR=bulach@chromium.org Review URL: http://codereview.chromium.org/646027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39374 0039d316-1c4b-4281-b951-d872f2087c98
* Added classifier which determines the type of a cubic curve input.kbr@chromium.org2010-02-185-0/+419
| | | | | | | | | | | | Its output will be used by the forthcoming texture coordinate generator. BUG=none TEST=CubicClassifierTest Review URL: http://codereview.chromium.org/626015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39373 0039d316-1c4b-4281-b951-d872f2087c98
* Double variance for Dromaeo overall score to account for 'natural' variance.antonm@google.com2010-02-181-1/+1
| | | | | | Review URL: http://codereview.chromium.org/646018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39372 0039d316-1c4b-4281-b951-d872f2087c98
* Move valgrind uninitialized data suppression from mac into general ↵mirandac@chromium.org2010-02-182-15/+10
| | | | | | | | | | suppressions file. BUG= none TEST= none Review URL: http://codereview.chromium.org/647029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39371 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes a bug in the 2d particle shader that madegman@chromium.org2010-02-181-2/+3
| | | | | | | | them ignore transform orientation. Review URL: http://codereview.chromium.org/647008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39370 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude some failing valgrind tests from Mac OS.mirandac@chromium.org2010-02-181-0/+6
| | | | | | | | BUG= 36161, 36163 TEST= none Review URL: http://codereview.chromium.org/647026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39369 0039d316-1c4b-4281-b951-d872f2087c98
* Test SetAcrossInstances crashed on Mac also. Disabling.finnur@chromium.org2010-02-181-2/+2
| | | | | | | | | | BUG=36068 TEST=None TBR=joth Review URL: http://codereview.chromium.org/647025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39368 0039d316-1c4b-4281-b951-d872f2087c98
* Add suppression for false valgrind error on Mac.jochen@chromium.org2010-02-181-0/+15
| | | | | | | | | BUG=none TEST=base unittest should work Review URL: http://codereview.chromium.org/647024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39367 0039d316-1c4b-4281-b951-d872f2087c98
* Initial Geolocation implementationbulach@chromium.org2010-02-1834-60/+1385
| | | | | | | | | | | Adds IPC plumbing. Adds Infobar buttons for requesting permission TEST=geolocation_browsertest.cc Review URL: http://codereview.chromium.org/548188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39366 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes close other tabs regression. It needed to check overall tabsky@chromium.org2010-02-181-1/+1
| | | | | | | | | | | count too. BUG=35576 TEST=see bug Review URL: http://codereview.chromium.org/629006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39365 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 08:08:01 +0000