| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
need, and modify MockKeychain slightly to allow unit testing it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/146002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
correct fix is).
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/145023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Run browser_tests.exe from the command line from a directory that is not the directory containing it.
Review URL: http://codereview.chromium.org/146018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/141008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=davemoore
BUG=none
TEST=build works
Review URL: http://codereview.chromium.org/146033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11650
TEST=none
Review URL: http://codereview.chromium.org/140010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Cannot reproduce locally but fails consistently on the mac buildbot in debug mode.
TBR=kasperl@chromium.org
Review URL: http://codereview.chromium.org/148001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
ScopeChainPropertiesSection is refactored to support scope resolution
Review URL: http://codereview.chromium.org/147012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=evan
BUG=10953 "IME support"
BUG=11226 "Dead keys and accents input not working"
BUG=13604 "Hotkeys not working in non-us keyboard layout"
TEST=none
Review URL: http://codereview.chromium.org/147010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/146023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This version contains a couple of regular expression bugfixes as well
as a string analysis bug fix. Also, there are a number of general
performance improvements.
Review URL: http://codereview.chromium.org/147009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
saving/retrieving/adjusting window positions.
TEST=Open Chrome windows and see if they are placed properly.
TESTED=gcl try, manually
BUG=none
Review URL: http://codereview.chromium.org/141039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If LOAD_VERIFY_EV_CERT is requested on load_flags
and revokation checking is performed, Verify() peforms
EV certificate verification as well, and sets
CERT_STATUS_IS_EV in verify_result.
Eliminate X509Certificate::IsEV()
BUG=3592
TEST=net_unittests with ALLOW_EXTERNAL_ACCESS=1, \
visit https://www.thawte.com/ and shows EV info.
Review URL: http://codereview.chromium.org/125120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensions.enable pref was not being honored. Add tests.
This is intended to be submitted after:
http://codereview.chromium.org/132003
BUG=13467
TEST=Added unit tests
Review URL: http://codereview.chromium.org/132045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
implements signal handers of the GtkIMContext object to support IMEs and dead-keys. Also, to improve compatibility with Windows Chrome, this change emulates IPC messages sent on Windows when we input characters and fixes Issue 13604 as well as Issue 10953 and 11226. Even though I notice we need more work for fixing edge cases (e.g. disabling IMEs on a password input) on Linux, I think this is the good starting point. (Supporting edge-cases requires complicated code and it makes hard to review.)
BUG=10953 "IME support"
BUG=11226 "Dead keys and accents input not working"
BUG=13604 "Hotkeys not working in non-us keyboard layout"
TEST=Open a web page which contains an <input> form (e.g. <http://www.google.com/>), type a '[{' key and an 'A' key on a Canadian-French keyboard, and see a Latin character "U+00E2" is displayed in the <input> form.
TEST=Open a web page which contains an <input> form (e.g. <http://www.google.com/>), enable an Chinese Pinyin IME, type a 'W' key, type an 'O' key, and see a Chinese character is displayed in the <input> form.
TEST=Change the keyboard layout to Hebrew (or Russian), open a web page which contains an <input> form, input some characters in the <input> form, type control+a, and see the text in the <input> form is selected.
Review URL: http://codereview.chromium.org/126118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is mainly intended to be pulled to the 3.0 branch. It won't be submitted until another corresponding change to
undo the damage is ready.
BUG=13467
TEST=Added unit tests
Review URL: http://codereview.chromium.org/132003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/144001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
includes socks4, socks4a
TEST=change proxy settings to use proxy and set only the socks proxy fields (others must remain blank). Use CCProxy for windows or 'ssh -D' for linux / cygwin if trying it via localhost.
Browser should successfully open both http and https URLs.
tests are also at HttpNetworkTransactionTest.SOCKS*
BUG=none
Review URL: http://codereview.chromium.org/113811
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
removed downsampling factor as that wasn't quite doing anything for it (other than making the image smaller and hence the number of different pixels a lot smaller.
Review URL: http://codereview.chromium.org/146013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
rather than being derived from it. This reduces the spaghetti somewhat. Also decouples the notion of a native view hierarchy from the location in TabContents::PageHasOSDD where the template URL fetcher is spawned. The Template URL Fetcher now simply retains a reference to the TabContents that created it. If the TabContents is destroyed before the fetch completes, we just discard the data retrieved without adding a keyword.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/140054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
own TabContentsView implementation.
BUG=14469
TEST=none
Review URL: http://codereview.chromium.org/146010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
crome/browser/gtk/gtk_chrome_link_button.cc needs stdlib.h for free and malloc
on gcc-4.3
patch by Joel Stan <joel.stan@gmail.com>
original review: http://codereview.chromium.org/147002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
in the tree.
Review URL: http://codereview.chromium.org/144016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of manually formatting it.
BUG=14878
TEST=Open a new window with at least 2 tabs. Close it and go to the
NTP and it should say "2 tabs" under recently closed.
Review URL: http://codereview.chromium.org/144022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=covered by test case.
BUG=13809 (http://crbug.com/13809)
Review URL: http://codereview.chromium.org/146008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
moves over the window.
BUG=none
TEST=Open two browser windows with multiple tabs. Make sure the windows overlap. Drag a tab from the top-level window into the frame of the other window. The lower window should be raised after a delay.
Review URL: http://codereview.chromium.org/146004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
This is (cleaned up) code from Breakpad's /client/linux/handler/minidump_generator.cc.
Review URL: http://codereview.chromium.org/146001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/145015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
but didn't update the code that compensated for their previously-different heights.
BUG=13812
Review URL: http://codereview.chromium.org/145017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/145025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/144021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The decoder needs a concept of state to know when it should just stop attempting to decode. This is because ffmpeg will sometimes gives spurious frames back, which plays badly with the time presentation timestamp calculation logic.
Review URL: http://codereview.chromium.org/132013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not implemented but it is time to get this submitted and iron out the
remaining issues.
BUG=13362
TEST=Start chrome with --new-new-tab-page and look at play arouind with
the new tab page.
Review URL: http://codereview.chromium.org/132027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the call stack.
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/145007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov,amanda
BUG=14951 (http://crbug.com/14951)
TEST=covered by test case
Review URL: http://codereview.chromium.org/144017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
This is code from Breakpad's /client/linux/handler/minidump_generator.cc.
Review URL: http://codereview.chromium.org/144002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/144009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/145022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Ignore the expected_crashes_ since Linux doesn't have crash_service.
Review URL: http://codereview.chromium.org/144014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the PNG library, and it turns on some functionality that O3D needs for manipulating PNG files: It removes the definition of PNG_NO_WRITE_FILLER, PNG_NO_READ_FILLER, PNG_NO_SEQUENTIAL_READ_SUPPORTED, and PNG_NO_INFO_IMAGE from pngusr.h so that the functions used by O3D to read images progressively and for filler bytes for pixel expansion (RGB -> RGBX) are available.
BUG=none
TEST=successful trybot run for all platforms.
Review URL: http://codereview.chromium.org/140074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13838
TEST=Open two browser windows. Drag one of the tabs into the other tabstrip. The first browser window should disappear and the browser should not crash.
Review URL: http://codereview.chromium.org/145019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=14113
TEST=the navigation hotkeys now work in fullscreen mode. Make sure the follownig all work:
{ GDK_Left, IDC_BACK, GDK_MOD1_MASK },
{ GDK_BackSpace, IDC_BACK, GdkModifierType(0) },
{ XF86XK_Back, IDC_BACK, GdkModifierType(0) },
{ GDK_Right, IDC_FORWARD, GDK_MOD1_MASK },
{ GDK_BackSpace, IDC_FORWARD, GDK_SHIFT_MASK },
{ XF86XK_Forward, IDC_FORWARD, GdkModifierType(0) },
{ GDK_r, IDC_RELOAD, GDK_CONTROL_MASK },
{ GDK_F5, IDC_RELOAD, GdkModifierType(0) },
{ GDK_F5, IDC_RELOAD, GDK_CONTROL_MASK },
{ XF86XK_Reload, IDC_RELOAD, GdkModifierType(0) },
{ XF86XK_Refresh, IDC_RELOAD, GdkModifierType(0) },
key: { button, action, modifier }, where MOD1 = alt
Review URL: http://codereview.chromium.org/145020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=14946 (http://crbug.com/14946)
TEST=covered in test case
Review URL: http://codereview.chromium.org/145021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/14518
TEST=middle click on an infobar link, it should open in a new tab
Review URL: http://codereview.chromium.org/145013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The BrowserWindow creates the task manager UI directly, which uses the TaskManager to populate itself.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/140044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and added accessors.
Review URL: http://codereview.chromium.org/140080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/145001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=paul
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/144011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/141059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Test=none
BUG=none
Review URL: http://codereview.chromium.org/144007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18969 0039d316-1c4b-4281-b951-d872f2087c98
|