| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
Enable back_forward_menu_model_unittest on linux.
Review URL: http://codereview.chromium.org/21522
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
gtk_window_get_position includes the window decoration, so it was the wrong
function to use.
Also, switch to using the requisition rather than getting the top-level size,
as that is what we use elsewhere.
Review URL: http://codereview.chromium.org/21515
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20503
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
look different because of differences in anti-aliasing lines and our
diffuse shadows are slightly different than that of CG.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/20507
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21523
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21520
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
on a notification, which is impossible to track down since I don't know who
added it.
Review URL: http://codereview.chromium.org/20502
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21497
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
tests whose expectations have changed upstream since the 1.0
launch. This is an effort to focus on actual regressions
before cutting the next release.
I avoided deferring any CRASH/TIMEOUT expectations as it seems those are worth making a priority of fixing.
Review URL: http://codereview.chromium.org/21491
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
BUG=NONE
Review URL: http://codereview.chromium.org/20506
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=brettw
BUG=NONE
Review URL: http://codereview.chromium.org/21513
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=maruel
Review URL: http://codereview.chromium.org/21518
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
automation code.
TBR=nsylvain
Review URL: http://codereview.chromium.org/20501
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- revised my guesstimate of 25 MB per renderer to 40MB, which I think is more appropiate for long lived tabs, since short lived tabs don't really matter here.
- the lower end (< 1GB) has less total renderers
- the middle has about the same
- the upper end (> 2GB) has more renderers
- added test to open 34 tabs.
Review URL: http://codereview.chromium.org/21484
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
coming in from the renderer.
A failed HTTP navigation like a 404 response to a request is followed by two responses. The first one which is associated with the failed response. This does not send over any information about the failure to the browser and thus appears as a normal navigation.The second response is for the actual 404 page being loaded.
For network errors the browser does get notified via RenderView::DidFailProvisionalLoadWithError. However due to a prototype mismatch the corresponding function in WebContents is never invoked.
Added a new automation message AutomationMsg_NavigationFailed, which carries information about failed navigations to automation clients.The changes to the navigation controller include sending over the http status code and the URL to observers.
The ExternalTabContainer also subscribes to the FAIL_PROVISIONAL_LOAD_WITH_ERROR notification, so it can inform clients about errors. We also ignore the next NAV_ENTRY_COMMITTED notification after an error due to the reasons mentioned above.
Review URL: http://codereview.chromium.org/21495
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- remove slave threads and use HostResolver in asynchronous mode instead (while still limiting number of concurrent lookups)
- make the implementation portable and make DnsMaster unit test compile and pass on Linux
- add more tests to DnsMaster unit test to simulate various shutdown scenarios, concurrent lookups, and to verify that we don't exceed our limit of concurrent lookup requests)
- remove some tests which relied on specifics of slaves' inner working
- adjust initialization and shutdown of dns prefetching (now it relies on the IO message loop being present)
Bonus: shutdown is almost instant now, no need to have a timeout.
BUG=5687, 6683
Review URL: http://codereview.chromium.org/15076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20497
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21512
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=maruel
Review URL: http://codereview.chromium.org/20496
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/20475
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
At present this checks the following:
- No tabs in source files
- The words "DO-NOT-SUBMIT" (without the dashes) do not appear in the CL
description or in files in the change
- No CRLF in source files (.cc, .h, .mm, .py)
Limitations:
- The general limitations of the current presubmit API implementation
apply. One of these is that gcl only walks up to the checkout root
searching for presubmit files, so if you've mapped stuff into your
client using DEPS, it will only walk up to where the root of that
mapping.
Patch contributed by Jói.
Review: http://codereview.chromium.org/20474
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This needs the port numbers, since they now get properly inferred.
TBR=wtc@chromium.org
Review URL: http://codereview.chromium.org/20490
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20487
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/20485
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added the support class ProxyServer to avoid losing the proxy server's type information (http, socks) when populating the list.
The format of the configuration strings has been extended accordingly to include an optional [<scheme>"://"] prefix.
(i.e. "http://", "socks4://", "socks5://").
Review URL: http://codereview.chromium.org/20398
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
of passing. Rebaselined some regexp tests where our behavior is
deliberately different from safari.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Renamed "user_scripts" back to "content_scripts"
and "files" to "js". The latter I'm a bit unsure
about and would like feedback on.
Frequently, authors only need to inject CSS, not
JS (witness usersstyles.org and the Stylish
Firefox extension). Making CSS injection first-
class allows us to tighten permissions for that
case and gives a fast path when that is all
authors want to do.
So I renamed "files" to "js" so that we could
someday have "css", too.
Review URL: http://codereview.chromium.org/21422
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
never getting set. Includes a new unit test, along with new
mocks for a video decoder and video renderer.
Review URL: http://codereview.chromium.org/20326
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also port TabContentsFactory.
Review URL: http://codereview.chromium.org/21496
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(I just want to see when pages are loading, y'know...)
Review URL: http://codereview.chromium.org/21500
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=agl
Review URL: http://codereview.chromium.org/21499
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21498
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
No code changes. This change just changes the CRLF line endings found by your change to make your change work on Mac and Linux trybots.
Review URL: http://codereview.chromium.org/21445
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20481
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20479
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=5836
TEST=see bug
Review URL: http://codereview.chromium.org/21490
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21488
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20480
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In a shutdown scenario, the default context may already be nulled out,
and hence we need to avoid trying to get dictionaries at that late
juncture.
r=darin
Review URL: http://codereview.chromium.org/21462
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21480
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21486
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes since original http://codereview.chromium.org/16207 :
- use Release rather than delete on reference counted objects
- Preserve bool WaitToFinish(int milliseconds)
and std::wstring GetDataDirectory() at Tommi's request,
and add unit test for WaitToFinish().
Review URL: http://codereview.chromium.org/20444
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
are flakey. I'll watch the bot to see where they are failing after
landing. Also fixes leaks in the tests I noticed when run under Purify.
BUG=6495
TEST=none
Review URL: http://codereview.chromium.org/20477
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
headless mode. This is not done accross UI
tests because automated UI only runs in
ChromeBot.
Review URL: http://codereview.chromium.org/20476
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
in-application EULA dialog.
Review URL: http://codereview.chromium.org/21437
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=7616
Review URL: http://codereview.chromium.org/21482
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Trade in some old wstrings for FilePaths.
- Remove some unnecessary headers.
Review URL: http://codereview.chromium.org/21466
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9986 0039d316-1c4b-4281-b951-d872f2087c98
|