summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Revert "This is the first of probably several patches trying to clean up the ↵erg@google.com2009-06-0317-790/+671
| | | | | | | | | | | BlockedPopupContainer into something that can be cross-platform." This reverts commit 0247f4d628f8f56c0a42ab44efd1d29058167a11 (r17483). Review URL: http://codereview.chromium.org/118166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17485 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo in the UMR filter file from:erikkay@google.com2009-06-031-18/+18
| | | | | | | | | | http://codereview.chromium.org/118139 TBR=aa Review URL: http://codereview.chromium.org/119084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17484 0039d316-1c4b-4281-b951-d872f2087c98
* This is the first of probably several patches trying to clean up the ↵erg@google.com2009-06-0317-671/+790
| | | | | | | | | | | BlockedPopupContainer into something that can be cross-platform. - BlokedPopupContainers are no longer ConstrainedWindows. - There is now a cross platform base class that contains most of the model/controller logic. The view now inherits from it. This is an improvement. Review URL: http://codereview.chromium.org/119006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17483 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Windows compile.phajdan.jr@chromium.org2009-06-031-0/+1
| | | | | | | | TBR=maruel Review URL: http://codereview.chromium.org/119083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17480 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in base/phajdan.jr@chromium.org2009-06-0336-22/+64
| | | | | | | | Also adds more explicit #includes for needed things. Review URL: http://codereview.chromium.org/118162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17479 0039d316-1c4b-4281-b951-d872f2087c98
* Fix client coordinates when forwarding mouse events to RenderWidgetHostView ↵erikkay@google.com2009-06-031-1/+12
| | | | | | | | | | | | | | parents. A commit on behalf of tangjie: (already reviewed) http://codereview.chromium.org/113671 BUG=http://code.google.com/p/chromium/issues/detail?id=11901 TEST=click anywhere in the extension bar and note whether this also gets counted as a click on the tab that's directly above it veritcally. Review URL: http://codereview.chromium.org/119065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17478 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented a large chunk of the "user data" panel. Hooked the "under the ↵pinkerton@chromium.org2009-06-033-198/+478
| | | | | | | | | | hood" view into the window. BUG=13151 TEST=enabled portions of the user data panel. Review URL: http://codereview.chromium.org/119060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17475 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Catch up with InspectorController changes.pfeldman@chromium.org2009-06-038-2/+123
| | | | | | Review URL: http://codereview.chromium.org/119077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17474 0039d316-1c4b-4281-b951-d872f2087c98
* Implement InspectorClient's Settings API.pfeldman@chromium.org2009-06-0316-7/+157
| | | | | | | | | | | | | | | This CL implements InspectorClient's API for reading / writing inspector settings. Here is how this is done: - inspector_client_impl.cc caches / serializes preferences into raw strings. It supports all kinds of settings except for string vector. I did not implement it since a) it requires more escaping b) I think we should get rid of it upstream. It then passes serialized settings string over IPC. - There is a dedicated IPC message called UpdateInspectorSettings that takes care of settings update. Two things I don't like: 1) reading settings and writing settings follow different paths: WebPreferences interface for read, delegate -> IPC for write. WebPreferences on read is used since these settings are needed very early in the page cycle. delegate -> IPC on write is the only option. 2) this looks like too much code on the Chrome side for functionality like this. Is there a more generic way of settings and persisting WebKit's preferences in Chrome? Should there be one? Review URL: http://codereview.chromium.org/119041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17473 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the base for the BookmarkBubble UI.deanm@chromium.org2009-06-035-22/+94
| | | | | | | | | | | Additionally set the transient on the InfoBubble dialog window. BUG=11738 Review URL: http://codereview.chromium.org/119042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17472 0039d316-1c4b-4281-b951-d872f2087c98
* Make LinkButtonGtk into a real widget (GtkChromeLinkButton).deanm@chromium.org2009-06-039-190/+217
| | | | | | | | | | This means there are no longer two objects to keep around, the widget and the wrapper C++ object. This simplifies ownership in hierarchies. Review URL: http://codereview.chromium.org/118116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17471 0039d316-1c4b-4281-b951-d872f2087c98
* Headers cleanup in chrome/browser/phajdan.jr@chromium.org2009-06-0357-47/+76
| | | | | | | | | | | - reduce header dependencies - miscellanous cleanups (add missing includes for OS_ defines etc) Further changesets may follow. I was only looking at header files up to character_encoding.h. Review URL: http://codereview.chromium.org/118072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17470 0039d316-1c4b-4281-b951-d872f2087c98
* Removes the following deprecated functions:ojan@chromium.org2009-06-034-50/+29
| | | | | | | | | | | | | | | | file_util::InsertBeforeExtension(wstring*, wstring&) file_util::PathComponents(wstring&, vector<wstring>*) file_util::ReplaceExtension(wstring*, wstring&) BUG=none TEST=manual test for importing IE bookmarks with some sub-directories. Original patch by tkent@google.com. See http://codereview.chromium.org/118109 r=ojan,estade git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17469 0039d316-1c4b-4281-b951-d872f2087c98
* Revert last checkin to fix resources in Release builds.sgk@chromium.org2009-06-0312-61/+65
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/119075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17468 0039d316-1c4b-4281-b951-d872f2087c98
* Convert to gyp generation of chrome_resources and chrome_strings.sgk@chromium.org2009-06-0312-65/+61
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/119061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17467 0039d316-1c4b-4281-b951-d872f2087c98
* Convert hunspell.lib to gyp generation.sgk@chromium.org2009-06-034-484/+18
| | | | | | | | | | Convert convert_dict to gyp generation. Combine Linux and Windows convert_dict targets. BUG=none TEST=none Review URL: http://codereview.chromium.org/114071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17466 0039d316-1c4b-4281-b951-d872f2087c98
* Convert crash_service and generate_profile to gyp generation.sgk@google.com2009-06-033-321/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/114074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17465 0039d316-1c4b-4281-b951-d872f2087c98
* Local text file with spaces in filename is urlencoded in tab titlemhm@chromium.org2009-06-0313-65/+107
| | | | | | | | | | | | | | When viewing a local text file with spaces in filename, it is still urlencoded. Filename should be displayed with spaces, not with urlencoding. It would be more user-friendly. Since net::FormatURL is already implemented, using it would be great. But it doesn't escape SPACES, just NORMAL, it doesn't even escape unicode. I plumbed out a unescapeurl that could be used whether we allow conversion of spaces or not. BUG=8775 (http://crbug.com/8775) TEST=Tested whether the input is escaped in the navigational context and ran the net tests New Review: http://codereview.chromium.org/118059 Review URL: http://codereview.chromium.org/56053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17462 0039d316-1c4b-4281-b951-d872f2087c98
* Stop compulsive crasher in respawn dialogcpu@google.com2009-06-032-21/+34
| | | | | | | | | | | | | | | - Users with CursorXP or FontExporer crash in MessageBoxW - leads to many crash reports within seconds solution: eat the fatal exception and exit silently. TEST = see the bug for instructions BUG = 12162 Review URL: http://codereview.chromium.org/118148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17461 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable DeleteURLAndFavicon test.agl@chromium.org2009-06-032-2/+2
| | | | | | | | | | This test was disabled because it started failing, however it's passing on the tryservers now so we'll give it another chance. BUG=9600 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17460 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/119067crogers@google.com2009-06-031-0/+13
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17459 0039d316-1c4b-4281-b951-d872f2087c98
* Refactored queue of audio_renderer_base to use scoped_refptrscherkus@chromium.org2009-06-032-9/+3
| | | | | | | -Changed typedef declaration for queue to deque of scoped_refptr to Buffers-Eliminated now unnecessary calls to AddRef() and Release()Original patch by kylep@google.comhttp://codereview.chromium.org/118122 Review URL: http://codereview.chromium.org/118147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17458 0039d316-1c4b-4281-b951-d872f2087c98
* Putting dependency on locales from chrome_exe.bradnelson@google.com2009-06-031-1/+1
| | | | | | | | | | | | This will allow people to hit f5 to build chrome.exe and get the locales too. BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/112091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17457 0039d316-1c4b-4281-b951-d872f2087c98
* Updating googleurl from 104 to 105.tommi@chromium.org2009-06-031-1/+1
| | | | | | | | This is to pull in change 118062 (http://codereview.chromium.org/118062). Review URL: http://codereview.chromium.org/119059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17454 0039d316-1c4b-4281-b951-d872f2087c98
* Switching gcapi to be gyp generated.bradnelson@google.com2009-06-034-275/+0
| | | | | | | | | | BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/118141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17453 0039d316-1c4b-4281-b951-d872f2087c98
* Convert worker.vcproj to gyp generation.sgk@google.com2009-06-032-172/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/118133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17452 0039d316-1c4b-4281-b951-d872f2087c98
* Cancel pending changes when navigating away from the NTP.jcampan@chromium.org2009-06-031-0/+2
| | | | | | | | BUG=12426 TEST=From the New Tab Page (NTP), click the Remove thumbnails link, remove thumbnails but don't press the Done button. Navigate to a URL (ex: www.google.com). Navigate to the NTP again, the thumbnails removed previously should still be showing. Also test that removal works properly when pressing the Done button. Review URL: http://codereview.chromium.org/118119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17451 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back this part of my earlier test. Looks like these tests are still ↵ben@chromium.org2009-06-021-2/+2
| | | | | | | | | | | | badly affected. TBR=sky BUG=none TEST=none Review URL: http://codereview.chromium.org/118140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17450 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix libevent bug.agl@chromium.org2009-06-021-1/+1
| | | | | | | | | | | | | r17436 exposed a libevent bug where an array is not resized to a large enough size when it's one element too short. This bug will be upstreamed to libevent. http://codereview.chromium.org/112089 BUG=11999 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17449 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few test_expectations related to my skia CL.senorblanco@chromium.org2009-06-021-0/+4
| | | | | | | | | BUG=http://crbug.com/13218 TEST=make tree greener TBR=tc git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17448 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing flush_cache (there were 2!!!!)bradnelson@google.com2009-06-021-26/+11
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/119064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17446 0039d316-1c4b-4281-b951-d872f2087c98
* -. Fix svn add in rebaselining tool and add more output warning messagesvictorw@chromium.org2009-06-023-6/+13
| | | | | | | | | | | -. Do not output failure if a test is rebaselining and missing expected files. BUG=none TEST=rebaselining tool Review URL: http://codereview.chromium.org/112083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17445 0039d316-1c4b-4281-b951-d872f2087c98
* Shush purify. This is a known bug in zlib.aa@chromium.org2009-06-021-0/+18
| | | | | | Review URL: http://codereview.chromium.org/118139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17444 0039d316-1c4b-4281-b951-d872f2087c98
* Converting flush_cache to be gyp generated.bradnelson@google.com2009-06-022-149/+0
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/118132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17443 0039d316-1c4b-4281-b951-d872f2087c98
* Adds linux2 variable and change to WidgetGtk to make it compile.sky@chromium.org2009-06-023-1/+8
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/119057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17442 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Update 44342:44372.dglazkov@google.com2009-06-022-2/+2
| | | | | | | | | | TBR=dimich BUG=none TEST=no compile or layout test failures. Review URL: http://codereview.chromium.org/118138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17441 0039d316-1c4b-4281-b951-d872f2087c98
* Properly initialize the native wrapper to NULL to avoid a crash. Also ↵ben@chromium.org2009-06-022-3/+3
| | | | | | | | | | re-enables tests I disabled last night when trying to find this. http://crbug.com/13200 TEST=Start chrome with --first-run. Review URL: http://codereview.chromium.org/118136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17440 0039d316-1c4b-4281-b951-d872f2087c98
* Enable gyp generation of utility.lib.sgk@chromium.org2009-06-022-156/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/118130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17439 0039d316-1c4b-4281-b951-d872f2087c98
* Enable test for timers in workers. The code that enabled that was checked in ↵dimich@google.com2009-06-021-1/+0
| | | | | | | | | | earlier. BUG=10271 TEST=none, this enables an existing test. Review URL: http://codereview.chromium.org/118134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17437 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: stop libevent from pre-allocating huge arrays.agl@chromium.org2009-06-021-12/+2
| | | | | | | | | | | | | | | | | | | Currently, libevent allocates two structures of size RLIMIT_NOFILE (which is 8192 on Ubuntu) and so these end up being several hundred kB of memory for each MessageLoopIO. This patch changes the default size to 32. If the thread watches a file descriptor greater than 32, the arrays will be grown as needed, doubling each time. Also fixes a typo in the upstream code. A bug report for this has been sent upstream. http://codereview.chromium.org/118126 BUG=11999 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17436 0039d316-1c4b-4281-b951-d872f2087c98
* Support for searching bookmarks for IDN.brettw@chromium.org2009-06-028-38/+105
| | | | | | | | | | | | | | The main part of this change is DoesBookmarkContainWords() in bookmark_utils.cc. It tries to match a query words to IDN and %-decoded strings as well as ASCII URL. BUG=3991 TEST=add a unit test, check for IDN in the search box of Bookmark Manager. Checked in for tkent@google.com. Original review: http://codereview.chromium.org/113815 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17435 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS to skia r198. This picks up a number of bugfixes for layout tests,senorblanco@chromium.org2009-06-0214-11/+8
| | | | | | | | | | | | | | and font stuff for Linux. Rebaselines affected tests, adjusts test_expectations, and removes an extraneous include dir. (Also sets the svn:mime-type prop on some of the linux PNG files; they still diff as text in rietveld this time, but I think they should be happier for next time.) BUG=http://crbug.com/12002 TEST=If it builds, and layout tests pass, you're happy. Review URL: http://codereview.chromium.org/118128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17434 0039d316-1c4b-4281-b951-d872f2087c98
* Rename the breakpad file to match the app name instead of just branding name.thomasvl@chromium.org2009-06-021-1/+11
| | | | | | | Build a tar.bz2 out of the .dsym for archiving. Review URL: http://codereview.chromium.org/118129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17433 0039d316-1c4b-4281-b951-d872f2087c98
* Pasted links opened with alt-enter were opened next to the current tab ↵pkasting@chromium.org2009-06-022-109/+133
| | | | | | | | instead of at the end of the strip. This was because the LINK transition type triggered the TabStripModel to apply heuristics about where to open the URL, even though all URLs opened from the address bar should bypass these heuristics. There were already hooks on the low-level functions to bypass the heuristics, I just had to expose them one level higher. This meant an expansion to one of the TabContentsDelegate function's argument list, hence the number of files touched. (This seems like a good capability to expose anyway, though.)BUG=6797TEST=Have multiple tabs in your tab strip. Select the first tab, paste in a URL, and hit alt-enter. The newly opened tab should appear at the far end of the strip. Review URL: http://codereview.chromium.org/118038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17432 0039d316-1c4b-4281-b951-d872f2087c98
* Allow themes to change the background of the new tab page. Adds support for ↵glen@chromium.org2009-06-0217-66/+344
| | | | | | | | | | | display properties to themes (stored internally as ints/enums, but parsed from text). BUG=12768 TEST=Install a theme with an new tab page background and verify that the background appears on the new tab page. Review URL: http://codereview.chromium.org/115910 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17431 0039d316-1c4b-4281-b951-d872f2087c98
* Enable TR1 in windows build for gmock's use in VS2008 SP1.ajwong@chromium.org2009-06-022-2/+2
| | | | | | Review URL: http://codereview.chromium.org/115977 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17430 0039d316-1c4b-4281-b951-d872f2087c98
* Display a tooltip when mousing over a tab title.jeremy@chromium.org2009-06-023-0/+26
| | | | | | | | This allows a user to see the full page title. Review URL: http://codereview.chromium.org/118095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17429 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the blue tab titles on GTK by hooking up the browser theme provider to thebrettw@chromium.org2009-06-022-0/+14
| | | | | | | | browser frame. Review URL: http://codereview.chromium.org/118088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17428 0039d316-1c4b-4281-b951-d872f2087c98
* Add functions to glue to get the full html of the page and also to check if ↵sverrir@google.com2009-06-024-0/+57
| | | | | | | | | | | the user has selected something. This is for enhanced printing support (in progress). Review URL: http://codereview.chromium.org/119043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17427 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac build.tc@google.com2009-06-021-1/+0
| | | | | | | | | TBR=erg Review URL: http://codereview.chromium.org/114068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17426 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 09:08:02 +0000