| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/170002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and real bugs filed.
TEST=None
BUG=None
TBR=mbleshe@chromium.org
Review URL: http://codereview.chromium.org/169005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=maruel
Review URL: http://codereview.chromium.org/165547
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165537
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16089,16579
TEST=green
Review URL: http://codereview.chromium.org/165544
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
removed "Status" sections (since this isn't a design doc
any more), ... Also added a few styles.
No meaningful changes to anything except packaging.html.
I did an editing pass on that page but didn't change the
content significantly.
TBR=aa, rafaelw
Review URL: http://codereview.chromium.org/165535
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
consumers use executeCommand.
Patch by Marshall Greenblatt
R=darin
BUG=19270
TEST=covered by unit tests
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This purify filter is already in the unit_tests.exe_UMR_flakey.txt file, so this is just bringing that hack to base.
BUG=http://crbug.com/18795
Review URL: http://codereview.chromium.org/165540
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
bundle names we use for the helpers.
TEST=page cycler tests should show memory for the renderers again.
BUG=19021
Review URL: http://codereview.chromium.org/165531
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to http://build.chromium.org/buildbot/waterfall/builders/Webkit%20Linux/builds/8895
and http://build.chromium.org/buildbot/waterfall/builders/Webkit%20Linux/builds/8896
The culprit is either 23407 or 23408. I'm trying 23408 first.
TBR=estage
TEST=webkit linux webkit_tests
BUG=none
Review URL: http://codereview.chromium.org/165534
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jam
BUG=none
TEST=reliability
Review URL: http://codereview.chromium.org/165532
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165530
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164557
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164556
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Sorry I forgot removing a fprint() call used for debug.
TBR=brettw
BUG=18184
TEST=run unit_test on Mac
Review URL: http://codereview.chromium.org/164554
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change fixes my new unit-test "SpellCheckTest.SpellCheckTest" breaks on Mac.
The system dictionaries of Mac spellchecker don't have the following words included in hunspell:
* en-AU (Australia): "organize" (which is a typo of "organise");
* en-GB (United Kingdom): "organize" (which is a typo of "organise");
* pt-BT (Brazil): "Google";
* pt-PT (Portugal): "Google".
This change removed "Google" from a couple of texts and fixed a couple of typos. Also, this change adds a language for Spanish (Spain), which I forgot adding.
TBR=brettw
BUG=18184
TEST=run unit_tests on Mac
Review URL: http://codereview.chromium.org/164553
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change adds a new unit test "SpllCheckTest.SpellCheckText" for testing our spellchecker with all available dictionaries.
BUG=18184 "Add more spellcheck tests with languages other than en-US"
TEST=run unit_test.exe
Review URL: http://codereview.chromium.org/159906
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165526
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
chrome.self page and replace missing bookmarks entries in left
nav.
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation for creating an SSLClientSocketPool.
ClientSocketPoolBase is now templated. Most of the implementation has moved to ClientSocketPoolBaseHelper which is not templated.
In order to make this possible, ClientSocketPoolBaseHelper's internal data structures do not use the full concrete Request type, but rather use a pointer to Request.
ClientSocketPoolBase takes a SocketParams as a template argument, primarily to allow RequestSocket to take a templated parameter that contains all the information necessary to connect the socket (be it TCP or SSL or whatever).
ClientSocketPool::RequestSocket() and ClientSocketHandle::Init() have been templated as well to handle this case.
I've left adding run-time type safety checks as a TODO.
TEST=net_unittests
BUG=http://crbug.com/13289
Review URL: http://codereview.chromium.org/160621
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
crash is being investigated.
BUG=http://crbug.com/19335
TEST=None
Review URL: http://codereview.chromium.org/164549
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I also renamed the MakeFoo classes to FooBuilder so that it would be
more clear at the call sites that you are dealing with a class.
I then translated the ToBar functions to also be BarBuilder classes.
I just did this for consistency with the FooBuilders.
For reference, "Foo" refers to WebCore Platform*Event classes and
"Bar" refers to WebInputEvent subclasses :-)
R=jorlow
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164524
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were 2 places that did
namespace Foo {
class Bar;
}
So I just spaced these in. I feel like from now on we should just go ahead and
use the latter format.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/165521
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Auto-updating of extension blacklist.
2. Handle extensions in the blacklist. If an extension is in the blacklist,
a. browser will not load the extension at start time;
b. browser will unload the extension at running time;
c. browser will not install the extension;
BUG=12118
TEST=Verify behavior described above works (they should be covered in the unittests in this change).
Review URL: http://codereview.chromium.org/165164
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
getTabContentses().
This lands http://codereview.chromium.org/159067.
Raf, the only thing you need to look at is the changes to extensions_process_bindings.js and extension_api.json.
BUG=13577
TEST=Browser tests added
Review URL: http://codereview.chromium.org/164458
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We're still figuring out what to do about strict aliasing and V8. In
the mean time, V8 (and other parts of the code) are unbuildable with
GCC 4.4 and strict aliasing. Adding this flag at the request of fta.
http://codereview.chromium.org/164538
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I had to move the locks from PluginService to PluginList, so that a lock (which can block other threads) isn't held while loading the plugins.
BUG=17938
TEST=added asserts which crash if plugins loaded on IO thread, current UI tests exercise them
Review URL: http://codereview.chromium.org/164305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164531
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165519
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The tests for HostResolver are responsible for making sure it doesn't choke on inputs, so really the purpose of this test should just be to verify that HostResolver is in fact being called.
Review URL: http://codereview.chromium.org/165520
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18969,18970
TEST=none
Review URL: http://codereview.chromium.org/164356
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
infrastructure closes a dialog is a bit different from what I was simulating in this
test. It goes 1) obtain handlers from delegate. 2) delete delegate. 3) delete handlers.
Also add a virtual dtor to TestBrowserWindow.
BUG=19002
TEST=SyncSetupWizardTest
Review URL: http://codereview.chromium.org/164494
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I added TIMEOUT to one video test that I missed in r23407.
Also, added some temporary exceptions to test_expectations.txt
while I investigate and fix or file appropriate bugs.
TEST=None
BUG=None
TBR=mbelshe@chromium.org
Review URL: http://codereview.chromium.org/165515
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The functionality in load_log_util.h is currently unused, but since it motivates the implementation of LoadLog, figured it should be included with this review.
Note that I decided against defining the loggable event types as LoadStates, since I wanted more flexibility in adding crazy stuff, and they really seem too implementation specific to be in LoadStates.
BUG=http://crbug.com/14478
TEST=net_unittests
Review URL: http://codereview.chromium.org/165404
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It seems that Tab2OutOfTabStrip is failing consistently after this change.
BUG=None
TEST=None
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/164543
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the parent window around.
BUG=19305 (http://crbug.com/19305)
TEST=Make the download shelf and/or bookmark bar visible. Clicking
and dragging on either one should not move the window around.
Review URL: http://codereview.chromium.org/165500
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=19312
Review URL: http://codereview.chromium.org/165511
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/47214 remove timeout handling
that was happening within the test and now it uses relies on
the normal code path. In other words, these were timing out before
but now test shell knows they are timing out.
BUG=None, These tests already had bug on them.
TEST=None
Review URL: http://codereview.chromium.org/165509
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
reduce a dependency on ATL.
BUG=5023
TEST=Uninstall flash. Visit hulu.com and install the flash plugin.
Review URL: http://codereview.chromium.org/165469
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CID=5739
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164533
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
GetResource() returns NULL when ContainsHandle() returns true? I can't repro locally and there is no try server for this.
Review URL: http://codereview.chromium.org/165510
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/19200
Review URL: http://codereview.chromium.org/164504
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a pitch which allows you to send a sub rect of
a source rectangle.
Also fixed a bug in UPDATE_TEXTRE2D so it works
as it used to. They used to send 1280x199+200 bytes
to update the first 320x200 area of a 1280x720 texture.
I broke that in a previous build.
Finally I changed the declarations in message_command.h
to be C++ compatible. The offsetof macro does not work if
a class has a constructor.
Review URL: http://codereview.chromium.org/165503
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=estade
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
The layout test failures happened on other platforms too.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
(take two, this caused layout test failures which I missed the first time.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165493
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23396 0039d316-1c4b-4281-b951-d872f2087c98
|