summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* This CL fixes issue 8684 -- RTL Regression: Text should be right aligned for ↵xji@chromium.org2009-03-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | RTL languages on "Bookmark Manager" (http://crbug.com/8684) The problem is canvas.DrawStringWithHalo() within BookmarkTableView::PaintAltText() always use left alignment. The fix is to pass the correct canvas text alignment when DrawStringWithHalo(). Test: 1. Run Hebrew Chrome 2. Hit Ctrl + Shift + B go to "Bookmark Manager" dialog 3. Select "Search" 4. Observe Without the fix: Text "Enter a query in the text field above to search your bookmarks" is left aligned With the fix: The above text is right aligned Hebrew Review URL: http://codereview.chromium.org/43146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11639 0039d316-1c4b-4281-b951-d872f2087c98
* Revert a change made to try and make purify errors go away now that Erik Kay ↵pkasting@chromium.org2009-03-131-5/+2
| | | | | | | | has disabled purify runs for the relevant tests. Review URL: http://codereview.chromium.org/42162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11638 0039d316-1c4b-4281-b951-d872f2087c98
* Merge WebDocumentLoaderImpl into WebDataSourceImpl. They are peers, and it isdarin@chromium.org2009-03-1312-326/+103
| | | | | | | | | | | | | really silly to have them be separate classes. I chose to eliminate WebDocumentLoaderImpl in favor of WebDataSourceImpl since the interface that the outside world sees is named WebDataSource. R=dglazkov Review URL: http://codereview.chromium.org/46028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11637 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup AutocompleteEditViewGtk's resources and widgets.deanm@chromium.org2009-03-131-0/+19
| | | | | | | Review URL: http://codereview.chromium.org/46034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11636 0039d316-1c4b-4281-b951-d872f2087c98
* Move HTMLDocument functions from v8_custom to V8HTMLDocumentCustom.mbelshe@google.com2009-03-134-81/+5
| | | | | | | | Remove NAMED_PROPERTY_SETTER interceptor for HTMLDocument. Review URL: http://codereview.chromium.org/42157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11635 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when with chrome-ui://about/" or anything invalidamit@chromium.org2009-03-131-4/+4
| | | | | | | | | | | | If DOMUIContents::InitCurrentUI returns true then current_ui_ should always be valid. Changed logic inside to make sure that this is the case. Review URL: http://codereview.chromium.org/46009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11634 0039d316-1c4b-4281-b951-d872f2087c98
* Stats for the renderers are all broken, because of this change:davemoore@chromium.org2009-03-131-6/+14
| | | | | | | | | | | | | | | | http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_dll_main.cc?r1=6627&r2=6626&pathrev=6627 line 236 We are appending the pid to the name of the shared memory object, which causes each renderer to get its own uninitialized copy of the stats counters, breaking the sharing. So then the about:stats code can't find the counters created and updated by these processes. This includes all the V8 counters and timers. Original issue: http://codereview.chromium.org/40012/show Review URL: http://codereview.chromium.org/42130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11632 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent system WebCore.framework from not working due to collisions withmark@chromium.org2009-03-131-2/+31
| | | | | | | | Objective-C names in our libwebcore.a by giving our Objective-C WebCore classes alternate names. Review URL: http://codereview.chromium.org/43094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11631 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded includes.maruel@chromium.org2009-03-133-8/+6
| | | | | | Review URL: http://codereview.chromium.org/43091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11629 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some browser shutdown issues on Linux.deanm@chromium.org2009-03-132-8/+27
| | | | | | | | | | | | | The previous code ended up destroying the BrowserWindow (removing it from BrowserList) while BrowserList was in the middle of iterating. Push the deletion onto the message loop (using DeleteSoon) to emulate what I'm guessing happens on Windows (the message is queue instead of processed right away). This fixes a second bug involving re-entrancy issues with Close() and window_, we now make sure to set window_ to NULL before any events might fire. BUG=8712 Review URL: http://codereview.chromium.org/43135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11628 0039d316-1c4b-4281-b951-d872f2087c98
* Call into the IM hooks from the Linux Omnibox keyboard handling.deanm@chromium.org2009-03-131-14/+28
| | | | | | | | | This should give input methods the proper chance to handle enter and escape. Review URL: http://codereview.chromium.org/43149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11627 0039d316-1c4b-4281-b951-d872f2087c98
* - Provide Rpc classes with unique ids so that their message id spaces do not ↵pfeldman@chromium.org2009-03-1316-985/+1162
| | | | | | | | | | | intersect; - Implement tests for DevToolsRpc - Do not import PlatformString in headers Review URL: http://codereview.chromium.org/43141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11626 0039d316-1c4b-4281-b951-d872f2087c98
* Another attempt at correctly marking the large expression stackager@chromium.org2009-03-131-2/+6
| | | | | | | | | overflow test. TBR=kmillikin@chromium.org Review URL: http://codereview.chromium.org/46031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11625 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to fix an assertion that does not hold.ager@chromium.org2009-03-132-1/+8
| | | | | | | | | Add test that tests arbitrary limits on expressions that can be handled without stack overflows to the test list. I have filed a bug report and Kevin is investigating. Review URL: http://codereview.chromium.org/46029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11624 0039d316-1c4b-4281-b951-d872f2087c98
* Add some newly added test to the failure list for Mac and Linux.levin@chromium.org2009-03-131-0/+6
| | | | | | | | | Both pass for windows when given a new baseline which maybe all they need for these OSes as well. Review URL: http://codereview.chromium.org/46027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11623 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 1.1.1.ager@chromium.org2009-03-136-3/+287
| | | | | | | | | Contains a couple of layout tests rebaselines. This time contains an updated gyp file for the mac build. Review URL: http://codereview.chromium.org/43134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11622 0039d316-1c4b-4281-b951-d872f2087c98
* Allow PRESUBMIT.py to handle deleted files.thestig@chromium.org2009-03-132-4/+19
| | | | | | | This is a follow up to Issue 43098. Review URL: http://codereview.chromium.org/42086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11619 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded platform_thread.h includes. Reduces number of includes from ↵thestig@chromium.org2009-03-136-6/+1
| | | | | | | | 598 to 511. Review URL: http://codereview.chromium.org/42165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11617 0039d316-1c4b-4281-b951-d872f2087c98
* Argh, incorrect usage of Intersect.jam@chromium.org2009-03-131-3/+1
| | | | | | | | BUG=6317 Review URL: http://codereview.chromium.org/46022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11616 0039d316-1c4b-4281-b951-d872f2087c98
* Don't leak visited site information from original profile to OTR profile.abarth@chromium.org2009-03-133-7/+7
| | | | | | | | | BUG=8388 R=brettw Review URL: http://codereview.chromium.org/42114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11613 0039d316-1c4b-4281-b951-d872f2087c98
* Improve my last change about informing google update about eula.cpu@google.com2009-03-132-2/+3
| | | | | | | | | | | | - Feedback from ddorwin: 1- Use the right set of permisions for the reg key 2- Only touch the key if user acepted the eula BUG=1594565 Review URL: http://codereview.chromium.org/42168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11610 0039d316-1c4b-4281-b951-d872f2087c98
* Update DEPS to 11608, which fixes build bustage.aa@chromium.org2009-03-131-1/+1
| | | | | | Review URL: http://codereview.chromium.org/42171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11609 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 41588:41613 (Chromium side).levin@chromium.org2009-03-1320-830/+140
| | | | | | | | | | | | | | | | | | webkit\port\bindings\v8, webkit\build files These are all adjustments to use the recently upstreamed V8Events files. percent-top-value-with-relative-position-expected This is a new test that has the same result in chromium but uses a slightly different font to display it, so pixels and coordinates were also different. search-field-cancel-expected This is a new test that verifies the visual aspects of the search field. Since chromium doesn't implement this field in a special way, chromium's results are expected to be different. Review URL: http://codereview.chromium.org/42163 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11606 0039d316-1c4b-4281-b951-d872f2087c98
* Add some more flaky tests. TBRojan@google.com2009-03-131-4/+16
| | | | | | Review URL: http://codereview.chromium.org/46021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11605 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for repositioning/resizing a tab window. This is needed as the ↵ananta@chromium.org2009-03-136-0/+113
| | | | | | | | | | SetWindowPos call can fail on Vista if the caller is running under low IL. Review URL: http://codereview.chromium.org/42150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11604 0039d316-1c4b-4281-b951-d872f2087c98
* Checkin files I missed.jam@chromium.org2009-03-132-4/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11602 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the gears in renderer process code. This allows me to do some ↵jam@chromium.org2009-03-1318-828/+16
| | | | | | | | cleanup in how resource dispatching happens in a future cl. Review URL: http://codereview.chromium.org/42158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11601 0039d316-1c4b-4281-b951-d872f2087c98
* This test is not a regression, I don't think we ever passed it.jcampan@chromium.org2009-03-131-2/+2
| | | | | | | | | | | | I believe it fails because we are not painting after a load has completed in a frame as DumpRenderTree does. I am still not sure though why it passes on Linux/Mac. I put my findings in http://crbug.com/8729. Review URL: http://codereview.chromium.org/42160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11600 0039d316-1c4b-4281-b951-d872f2087c98
* Temp fix for reliablity crashes.jam@chromium.org2009-03-131-0/+3
| | | | | | Review URL: http://codereview.chromium.org/46017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11599 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk dialogs, first cut.estade@chromium.org2009-03-128-11/+209
| | | | | | | | Only the Save As file selection dialog is implemented for now. Review URL: http://codereview.chromium.org/42152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11594 0039d316-1c4b-4281-b951-d872f2087c98
* Remove logging.h from cc files that don't use it.thestig@chromium.org2009-03-1266-69/+2
| | | | | | Review URL: http://codereview.chromium.org/42155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11593 0039d316-1c4b-4281-b951-d872f2087c98
* Some minor cleanup in WebDataSource and WebResponse.darin@chromium.org2009-03-127-183/+30
| | | | | | | | R=dglazkov Review URL: http://codereview.chromium.org/42156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11591 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded uses of logging.h in header files.thestig@chromium.org2009-03-1243-25/+37
| | | | | | Review URL: http://codereview.chromium.org/43148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11590 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up our fix for bug 7338 and bug 8473, which wentwtc@chromium.org2009-03-123-9/+16
| | | | | | | | | | through several iterations. R=abarth BUG=7338,8473 Review URL: http://codereview.chromium.org/42148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11589 0039d316-1c4b-4281-b951-d872f2087c98
* Implement WebSandboxSupport.darin@chromium.org2009-03-1211-47/+55
| | | | | | | | R=dglazkov Review URL: http://codereview.chromium.org/42146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11588 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 'inspect element' crash when hosted in external tabamit@chromium.org2009-03-121-5/+6
| | | | | | | | | | | | | | If chrome tab is hosted in an external tab and 'inspect element' is invoked via GUI (as opposed to sending an automation request for AutomationMsg_InspectElement), we get a crash in AutomationProvider::ReceivedInspectElementResponse BUG=1694650 Review URL: http://codereview.chromium.org/43102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11587 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a layout test, by rebaselining because trailing whitespaces now always ↵jparent@chromium.org2009-03-122-2/+2
| | | | | | | | get their own linebox. The change that caused this was http://trac.webkit.org/changeset/41569/trunk and you can see that they re-baselined all tests that had trailing whitespaces there. For this test, regular webkit does not select a trailing whitespace (they only select "foo" on double click, we select "foo "), so this wasn't rebased by them. Review URL: http://codereview.chromium.org/46005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11586 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline a test that only differs by font and form controls.pkasting@chromium.org2009-03-124-1/+14
| | | | | | Review URL: http://codereview.chromium.org/46007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11585 0039d316-1c4b-4281-b951-d872f2087c98
* Make wrapper-context.html faster by eliminating timeouts.pam@chromium.org2009-03-123-29/+28
| | | | | | | | BUG=4391 TEST=covered by layout tests Review URL: http://codereview.chromium.org/42097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11584 0039d316-1c4b-4281-b951-d872f2087c98
* Add more flaky mac tests. One day we'll have them all and theojan@google.com2009-03-121-3/+6
| | | | | | | mac build will actually stay green. Review URL: http://codereview.chromium.org/42151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11582 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using one ResourceDispatcher per render process, and move it to ↵jam@chromium.org2009-03-1211-120/+81
| | | | | | | | ChildThread so that the same code is used by the plugin process (and soon, workers). Review URL: http://codereview.chromium.org/42108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11581 0039d316-1c4b-4281-b951-d872f2087c98
* Add copies of *.pak files that need to be installed for execution.sgk@google.com2009-03-121-1/+24
| | | | | | Review URL: http://codereview.chromium.org/42131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11580 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline 2 layout tests on windows. The text files are updated in previous ↵jianli@chromium.org2009-03-125-4/+3
| | | | | | | | merge, but not image files. Review URL: http://codereview.chromium.org/42149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11579 0039d316-1c4b-4281-b951-d872f2087c98
* Defer a test that tests a feature we don't support.pkasting@chromium.org2009-03-121-1/+5
| | | | | | Review URL: http://codereview.chromium.org/42145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11578 0039d316-1c4b-4281-b951-d872f2087c98
* Use a fixed revision for GYP in DEPSmark@chromium.org2009-03-121-1/+1
| | | | | | Review URL: http://codereview.chromium.org/46001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11577 0039d316-1c4b-4281-b951-d872f2087c98
* Don't rely on subview ordering to be equivalent to tab ordering. Allows us ↵pinkerton@chromium.org2009-03-125-52/+129
| | | | | | | | to correctly set z-order on tabs. Add animation to tabs closing. Fix issue where new tab button would not draw correctly by pulling it from the nib. Fix memory leak in TabController. Fix console output about missing image. Review URL: http://codereview.chromium.org/43144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11575 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot to remove fixed tests from tests_fixable.txt in a previous CL.jcampan@chromium.org2009-03-121-7/+0
| | | | | | Review URL: http://codereview.chromium.org/46002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11574 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up Website junk in sln files.bradnelson@google.com2009-03-124-1192/+0
| | | | | | Review URL: http://codereview.chromium.org/42143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11573 0039d316-1c4b-4281-b951-d872f2087c98
* Update test list with latest state of mac builders.ojan@google.com2009-03-121-5/+13
| | | | | | Review URL: http://codereview.chromium.org/43152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11572 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SessionRestoreUITest.TwoTabsSecondSelected in single process mode.jam@chromium.org2009-03-121-13/+12
| | | | | | | | This is admitedly a little hacky, but I don't care as much since it's single-process mode and I don't think there's another way to solve it. The problem is that SiteInstance::GetProcess should always reuse an existing renderer "process", but GetExistingProcessHost() won't return the in-process renderer until RenderProcessHost::Init is called, which is after the second GetProcess call. So since we generate the in-process 'pid', I do it in the constructor instead of in Init. Review URL: http://codereview.chromium.org/42144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11571 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 13:23:21 +0000