summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Revert 12739, 12740, and 12741 because we're going to fix Issue 7448 purely ↵abarth@chromium.org2009-04-0815-46/+3
| | | | | | in WebKit. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13343 0039d316-1c4b-4281-b951-d872f2087c98
* Move location bar bridge out of tab_contents_controller.shess@chromium.org2009-04-086-75/+149
| | | | | | | | | | [So that I don't keep getting conflicts as I work to finish the omnibox change http://codereview.chromium.org/50074 ] Review URL: http://codereview.chromium.org/63096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13342 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid Google Chrome/Chromium default browser conflict by renaming ↵kuchhal@chromium.org2009-04-082-41/+32
| | | | | | | | | | | Capabilities key. BUG=9697 Review URL: http://codereview.chromium.org/62100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13341 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary fix for omnibox crash.estade@chromium.org2009-04-083-4/+60
| | | | | | | | BUG=9760 Review URL: http://codereview.chromium.org/63095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13340 0039d316-1c4b-4281-b951-d872f2087c98
* DNS prefetch experiment extension: Consider different connection count limitsjar@chromium.org2009-04-084-11/+50
| | | | | | | | | | | | This CL both enables selection of a run-time selected limit on the number of connections to a single host, and varies that limit to see how it relates to DNS prefetch latency in connections. r=wtc Review URL: http://codereview.chromium.org/62083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13339 0039d316-1c4b-4281-b951-d872f2087c98
* Mark test failures from merge until I fix them.brettw@chromium.org2009-04-081-0/+3
| | | | | | Review URL: http://codereview.chromium.org/63112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13338 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome side of WEbKit merge 42244:42287.brettw@chromium.org2009-04-083-5/+13
| | | | | | Review URL: http://codereview.chromium.org/63110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13337 0039d316-1c4b-4281-b951-d872f2087c98
* Stuff needed for alert info bars.estade@chromium.org2009-04-081-16/+4
| | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/63111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13336 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Linux: warning when not running most recent test_shell"agl@chromium.org2009-04-081-23/+1
| | | | | | | | | This reverts commit r13333. PathFromBase throws an exception when the path isn't there. Sigh. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13335 0039d316-1c4b-4281-b951-d872f2087c98
* linux: don't crash on alert infobars.evan@chromium.org2009-04-081-6/+1
| | | | | | | | | | estade didn't sufficiently test his change. Luckily, the fix is trivial. TBR=estade Review URL: http://codereview.chromium.org/62138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13334 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: warning when not running most recent test_shellagl@chromium.org2009-04-081-1/+23
| | | | | | | | | With the scons GYP switch, you now have to pass --debug to run_layout_tests.sh to run the debug build otherwise you'll silently be running the wrong binary. Warning loudly about this. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13333 0039d316-1c4b-4281-b951-d872f2087c98
* posix: implement AutomationWindowTracker.evan@chromium.org2009-04-084-23/+37
| | | | | | Review URL: http://codereview.chromium.org/62135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13331 0039d316-1c4b-4281-b951-d872f2087c98
* More flaky tests.ojan@google.com2009-04-081-0/+8
| | | | | | Review URL: http://codereview.chromium.org/63108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13330 0039d316-1c4b-4281-b951-d872f2087c98
* More info bar implementation.estade@chromium.org2009-04-082-16/+101
| | | | | | Review URL: http://codereview.chromium.org/62136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13329 0039d316-1c4b-4281-b951-d872f2087c98
* Use cpus instead of cpus+1 for webkit tests.ojan@google.com2009-04-081-3/+2
| | | | | | | | | | | | | This changes the runtime from 7mins to 8m20s on my quad-core mac. Still running the test on my dual-core windows to see the perf hit. Hopefully this will reduce flakiness. Once we flesh out more of the flakiness we can up this back to cpus+1. Review URL: http://codereview.chromium.org/63105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13328 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: layout test fixagl@chromium.org2009-04-081-1/+5
| | | | | | | | | | | I need another round trip land a patch in WebKit to fix it correctly, but noones's around now and I probably won't get a chance before the merge tomorrow morning TBR=evanm git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13327 0039d316-1c4b-4281-b951-d872f2087c98
* Support the new popup and new window dispositions in the external tab ↵ananta@chromium.org2009-04-084-2/+34
| | | | | | | | | | | | | | | | container. Disabled the TRACK_HWND_DESTRUCTION macro in render_widget_host_view_win.cc as it fires consistently for the external tab container probably due to multiple WM_DESTROY messages received for the container, when the parent window is destroyed. Fixes bug http://b/issue?id=1747547 Bug=1747547 Review URL: http://codereview.chromium.org/63074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13326 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash on tab closure. We now use our own model data and check that ↵jhawkins@chromium.org2009-04-081-4/+5
| | | | | | | | | the hovering index is not out of bounds. BUG=9803 Review URL: http://codereview.chromium.org/62133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13325 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an issue found by purify with my previous submission.michaeln@google.com2009-04-081-0/+2
| | | | | | Review URL: http://codereview.chromium.org/62122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13324 0039d316-1c4b-4281-b951-d872f2087c98
* Reimplement the bookmark bar to use a GtkToolbar.erg@google.com2009-04-082-29/+294
| | | | | | | | | | Add all bookmark buttons to a GtkToolbar. All bookmark buttons are draggable, though we don't accept drops yet since I still need to figure out how to communicate with the model. Review URL: http://codereview.chromium.org/63099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13322 0039d316-1c4b-4281-b951-d872f2087c98
* hclam: picked you for this review based on the revision log of ↵aa@chromium.org2009-04-083-6/+32
| | | | | | | | | | | | | | ChromeURLRequestContext, but feel free to redirect if there is someone better. Fix leak of media_request_context_. This is kind of a nasty fix though. I think that ChromeURLRequestContext needs to be refactored more, but not sure exactly how right now. If you don't like this fix, I won't feel bad nuking it and letting someone working on this area handle it. Review URL: http://codereview.chromium.org/63073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13320 0039d316-1c4b-4281-b951-d872f2087c98
* Increase default timeout for webkit tests to 20seconds.ojan@google.com2009-04-082-9/+12
| | | | | | | | | | | | | | | I'm pretty confident that we're hitting this because the CPUs are overloaded and tests that are on the verge of timing out do actually timeout. Long term, we should track how long each test takes to run and spit out the longest running ones. Then we should provide a way to do per test timeouts and mark those tests appropriately in the test_expectations file. Review URL: http://codereview.chromium.org/63102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13318 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS to pickup Skia fHeight changeagl@chromium.org2009-04-081-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13317 0039d316-1c4b-4281-b951-d872f2087c98
* Skia: remove fHeight (retry)agl@chromium.org2009-04-083-12/+8
| | | | | | | | | | | | Skia was previously calculating the leading value incorrectly, leading us to add fHeight to get the height of a line of text. Now that Skia is calculating fLeading correctly, we can remove fHeight. http://codereview.chromium.org/62123 https://bugs.webkit.org/show_bug.cgi?id=25083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13316 0039d316-1c4b-4281-b951-d872f2087c98
* posix: move lack of printing into a bug.evan@chromium.org2009-04-081-18/+18
| | | | | | Review URL: http://codereview.chromium.org/63103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13314 0039d316-1c4b-4281-b951-d872f2087c98
* Greatly reduce the race window in ProcessSingletoncpu@google.com2009-04-081-8/+14
| | | | | | | | | | | - fix only for windows - Anantha has a good test to be commited RSN BUG=9593 Review URL: http://codereview.chromium.org/57082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13313 0039d316-1c4b-4281-b951-d872f2087c98
* Skeleton setup for new Automated UI test framework.huanr@chromium.org2009-04-088-72/+221
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - Add automated_ui_test_base.{cc,h} that defines an AutomatedUITestBase class. This class can be used for both UI test suites and automated UI test running on ChromeBot. - Add automated_ui_test_test and include it in UI test suite so we can individually test all commands provided in AutomatedUITestBase. - Change AutomatedUITest to be a subclass of AutomatedUITestBase. Move RunCommandAsync(), RunCommand(), and NewTab() from AutomatedUITest to AutomatedUITestBase. The plan is moving all individual UI command functions (after they are converted to sync mode) to AutomatedUITestBase so they can be shared by UI test suites and automated UI test. - In automation_provider.cc, add a mapping mechanism from command to notification type. This will make it easy to add more command types. Review URL: http://codereview.chromium.org/56190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13312 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused database code.paulg@google.com2009-04-082-33/+0
| | | | | | | | | The new storage system doesn't check URLs on the DB thread any longer, so this code is never called. Review URL: http://codereview.chromium.org/62110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13311 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the findbar crash.tc@google.com2009-04-078-42/+40
| | | | | | | | | | | | | | | | FindBarController is no longer owned by the BrowserWindow, it is owned by Browser. So we can remove the FindBarController code in BrowserWindowGtk. Also, go ahead and implement BrowserWindow::CreateFindBar (which creates the gtk widget and adds it to the gtk widget hierarchy) and enable the code on linux. Since the widgets are created and added to the hierarchy later, we attach the signals after the widgets have been "realized". Review URL: http://codereview.chromium.org/62126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13310 0039d316-1c4b-4281-b951-d872f2087c98
* Add a few more flaky tests and sort the tests in their groupsojan@google.com2009-04-071-48/+52
| | | | | | | for easier reading. :) Review URL: http://codereview.chromium.org/62130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13309 0039d316-1c4b-4281-b951-d872f2087c98
* roll DEPS to pick up agl's revert in third_party/WebKitdarin@chromium.org2009-04-071-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13308 0039d316-1c4b-4281-b951-d872f2087c98
* Add back in a test that's still timing out on Mac, for an unknown reason.pam@chromium.org2009-04-071-0/+1
| | | | | | | TBR=darin Review URL: http://codereview.chromium.org/62124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13306 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using WebDragData in WebView and WebViewDelegate.darin@chromium.org2009-04-0737-308/+419
| | | | | | | | | | | | | | | | | | | | | | | | | | I also cleaned up some of the WebView and WebViewDelegate methods to pass WebPoint instead of pairs of ints or gfx::Point. With this change, I am keeping webkit/glue/webdropdata.{h,cc}, which is what Chrome uses to pass around the equivalent data. Now, it is possible to construct a WebDropData from a WebKit::WebDragData and to also get a WebKit::WebDragData from a WebDropData. Hence, the conversion between WebDropData and ChromiumDataObject (see clipboard_conversion.{h,cc}) is now removed in favor of conversion between WebDropData and WebKit::WebDragData. Conversion between WebKit::WebDragData and WebCore::ChromiumDataObject is very cheap (just reference counting). Finally, this change also brings in WebData, which is now used by the return value of WebKitClient::loadResource. As a companion to that change, I also changed webkit_glue::GetDataResource to return StringPiece instead of std::string. That also saves on an unnecessary buffer copy. R=dglazkov Review URL: http://codereview.chromium.org/63084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13305 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing v8 settings to fix startup_tests regression.bradnelson@google.com2009-04-072-1987/+2032
| | | | | | Review URL: http://codereview.chromium.org/62121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13304 0039d316-1c4b-4281-b951-d872f2087c98
* linux: pass a bunch more ui tests.evan@chromium.org2009-04-0710-52/+60
| | | | | | | | Mostly random portability fixes: use portable functions, use FilePath, etc. Review URL: http://codereview.chromium.org/62117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13302 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Skia: remove fHeight"agl@chromium.org2009-04-074-9/+13
| | | | | | | | This reverts r13300 and r13299. Something clearly went wrong with the layout tests that I didn't notice. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13301 0039d316-1c4b-4281-b951-d872f2087c98
* Linux build fix.agl@chromium.org2009-04-071-1/+1
| | | | | | | (Was building test_shell, not chrome and forgot about chrome_font.cc) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13300 0039d316-1c4b-4281-b951-d872f2087c98
* Skia: remove fHeightagl@chromium.org2009-04-073-12/+8
| | | | | | | | | | | | Skia was previously calculating the leading value incorrectly, leading us to add fHeight to get the height of a line of text. Now that Skia is calculating fLeading correctly, we can remove fHeight. http://codereview.chromium.org/62123 https://bugs.webkit.org/show_bug.cgi?id=25083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13299 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some tests that have been sent upstream and brought back down in WebKit.pam@chromium.org2009-04-077-221/+0
| | | | | | | | | | These were split into various fast/dom/Window/Location/ tests. BUG=4391 TEST=covered by layout tests Review URL: http://codereview.chromium.org/63094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13298 0039d316-1c4b-4281-b951-d872f2087c98
* Add more flaky tests. TBRojan@google.com2009-04-071-0/+7
| | | | | | Review URL: http://codereview.chromium.org/63097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13296 0039d316-1c4b-4281-b951-d872f2087c98
* Skia: break XRange into XMax and XMinagl@chromium.org2009-04-073-8/+9
| | | | | | | | | | | | | This is one of Mike Reed's requests for upstreaming this work since he has a use for the XMin value. (also pulls in the WebKit side of this change) http://codereview.chromium.org/62118 https://bugs.webkit.org/show_bug.cgi?id=25081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13295 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent test shell editing events from getting to the webview delegate after ↵estade@chromium.org2009-04-071-7/+8
| | | | | | | | | | test shell shutdown. BUG=9486 Review URL: http://codereview.chromium.org/63091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13294 0039d316-1c4b-4281-b951-d872f2087c98
* For two layout tests that were split into pieces to allow us to pass most ofpam@chromium.org2009-04-077-204/+16
| | | | | | | | | | | | their test cases, re-baseline the pieces we pass and WONTFIX the pieces we won't. Also remove the corresponding pending/ test now that the change has been upstreamed. BUG=4391 TEST=covered by layout tests Review URL: http://codereview.chromium.org/62120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13292 0039d316-1c4b-4281-b951-d872f2087c98
* Add gyp-generated SCons files to svn:ignore.sgk@google.com2009-04-070-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13291 0039d316-1c4b-4281-b951-d872f2087c98
* Fix sorting of test lists.ojan@google.com2009-04-071-1/+1
| | | | | | Review URL: http://codereview.chromium.org/63092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13290 0039d316-1c4b-4281-b951-d872f2087c98
* Move loadtimes extension out of the extensions directory.davemoore@chromium.org2009-04-075-12/+12
| | | | | | | | | This directory is only for extensions in service of the chrome extensions system, not all chrome related V8 extensions Review URL: http://codereview.chromium.org/63066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13289 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some threading issues and some refactoring in AudioRendererHosthclam@chromium.org2009-04-0711-240/+471
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. AudioRendererHost should not wait on IO thread. Calling AudioOutputStream::Start requests some audio packets by calling IPCAudioSource::OnMoreData, resulting in a deadlock. I implemented a prefetching logic to solve this problem, source has to know how many internal buffers the implementation of AudioOutputStream is using and prepare the same amount of packets before calling AudioOutputStream::Start. 2. When IPCAudioSource::OnMoreData is waiting for packet to arrive, calling AudioOutputStream::Stop will result in a deadlock since it expects OnMoreData to return. Should wake up all waiting threads before calling AudioOutputStream::Stop. 3. Did some refactoring and move the message handlers completely into AudioRendererHost, it was clumsy to call to AudioRendererHost from ResourceMessageFilter. Also moved all logics of using shared memory for packet passing, prefetching to IPCAudioSource. AudioRendererHost is now merely a container that manages and delegates calls to IPCAudioSource. This refactoring is helpful because the next step is to implement standalone IPC channel for audio. Review URL: http://codereview.chromium.org/57023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13288 0039d316-1c4b-4281-b951-d872f2087c98
* Disable user metrics reporting for chromium builds.rvargas@google.com2009-04-071-2/+9
| | | | | | Review URL: http://codereview.chromium.org/62071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13286 0039d316-1c4b-4281-b951-d872f2087c98
* Cloned from 62030arv@chromium.org2009-04-075-19/+63
| | | | | | | | | | | | | | | Add a "Clear All" link to the downloads page. Fixes jankiness of the blue bar in the download page as it loads. Improve rendering time of the downloads page by chunking the number of download items to do before scheduling the timeout. BUG=9033 Review URL: http://codereview.chromium.org/62115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13285 0039d316-1c4b-4281-b951-d872f2087c98
* More flaky tests.ojan@google.com2009-04-071-6/+14
| | | | | | Review URL: http://codereview.chromium.org/63083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13284 0039d316-1c4b-4281-b951-d872f2087c98