summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Move *Animation to app/ben@chromium.org2009-05-0536-97/+86
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/109001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15275 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the ClipboardService class and header... it is nothing but a ↵ben@chromium.org2009-05-0516-78/+49
| | | | | | | | | | shell around base::Clipboard now. http://crbug.com/11387 Review URL: http://codereview.chromium.org/105011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15274 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_vector.h and stl_util-inl.h to base/ben@chromium.org2009-05-0566-102/+96
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/107001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15272 0039d316-1c4b-4281-b951-d872f2087c98
* implemented API style/convention changes, including:rafaelw@chromium.org2009-05-0511-297/+725
| | | | | | | | | | | | | | | | | | | | | | | | -tabs.update() -tabs.move() -tabs.remove() -tabs.update() -tabs.create() -tabs.get() -all tab events, except onUpdated implemented -tabs.getSelected() -tabs.getAllInWindow() -windows.getCurrent() -windows.getFocused() -windows.getAll(populate) -windows.onFocusedChanged() -ExtensionBrowserEventRouter now uses BrowserList::Observer Review URL: http://codereview.chromium.org/100345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15271 0039d316-1c4b-4281-b951-d872f2087c98
* FindBarView::UpdateForResult is not a good place to finnur@chromium.org2009-05-059-1/+23
| | | | | | | | | | | | | | | | | beep if nothing was found on the page. The reason is that it is gets called when you switch from one tab to the other. I've added a function to FindBar that the controller can call and each platform can implement whatever sound they want to use. BUG=10823 TEST=Open google.com, search for z0, it should beep (no matches). Open new tab, switch back to the old tab and it should not beep. Review URL: http://codereview.chromium.org/99372 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15269 0039d316-1c4b-4281-b951-d872f2087c98
* racy builds meant I didn't see this one... build bustage fix via dependency ↵ben@chromium.org2009-05-051-0/+1
| | | | | | update git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15267 0039d316-1c4b-4281-b951-d872f2087c98
* Bustage fix - forgot to merge this over onto my windows machine from my ↵ben@chromium.org2009-05-051-0/+7
| | | | | | | | | | linux box. Make sure we include gtk as a dependency on Linux. Review URL: http://codereview.chromium.org/105006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15266 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustage - removed this include for some reasonben@chromium.org2009-05-051-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15265 0039d316-1c4b-4281-b951-d872f2087c98
* Adds toplevel app/ directory and moves ResourceBundle into it.ben@chromium.org2009-05-05136-173/+359
| | | | | | | | | | | No changes to resource bundle yet, just the move to keep this CL as compact as possible. Adds new vcproj and gyp file for app dir. http://crbug.com/11387 Review URL: http://codereview.chromium.org/100354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15264 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for handling files containing URLs with a samplingpaulg@google.com2009-05-051-17/+51
| | | | | | | | | weight. Also print out a few more statistics like the number of URLs examined and the number of host + path pairs looked up. Review URL: http://codereview.chromium.org/105005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15263 0039d316-1c4b-4281-b951-d872f2087c98
* Constrain the gtk menu popup to the bounds of the current monitor.jhawkins@chromium.org2009-05-051-4/+9
| | | | | | Review URL: http://codereview.chromium.org/106001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15262 0039d316-1c4b-4281-b951-d872f2087c98
* Add a RENDERER_PROCESS_CLOSED notification that gets sent when we close thempcomplete@google.com2009-05-055-15/+21
| | | | | | | | | | RenderProcessHost's process_. This is similar to RENDER_PROCESS_TERMINATED, but the latter is not always sent since the process could get reused. It also takes the place of RENDERER_PROCESS_CRASHED, where this one contains a boolean Details indicating whether the process crashed (true) or just exited (false). Review URL: http://codereview.chromium.org/100277 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15261 0039d316-1c4b-4281-b951-d872f2087c98
* Make our autoscroll icons a little better.glen@chromium.org2009-05-0510-0/+0
| | | | | | | | | | | | We're constrained by hardcoded icon dimensions (pan_icon.png is limited to 20x20) in WebKit, but in the interest of time, we're going to play within those restrictions. TBR=finnur BUG=11277 TEST=Do some autoscrolling, verify that our icons are different to Safari's. Verify that they don't disappear on black-backgrounded webpages. Review URL: http://codereview.chromium.org/105003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15260 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up full-page zoom menu items and fix that zoomed controls don't draw.thakis@chromium.org2009-05-052-3/+65
| | | | | | | | | BUG=crbug.com/11325 TEST=Open a page with controls, zoom in or out and check that they scale nicely. Also, check that the "mouse down" and "clicked" states appear correctly. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15259 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: enable omni box ui test and automation proxy ui test.estade@chromium.org2009-05-0512-36/+49
| | | | | | | | Enable a lot of (already essentially working) automation code along the way. Review URL: http://codereview.chromium.org/100278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15258 0039d316-1c4b-4281-b951-d872f2087c98
* Port the folder selector portion of the BookmarkEditor to GTK.erg@google.com2009-05-0510-97/+773
| | | | | | | | | | | | | | | Mirrors the BookmarkEditorView method, where the contents of BookmarkModel are copied to a temporary model so changes can be discarded if the user hits Cancel. In the GTK version, we copy not into another BookmarkModel, but into a GtkTreeStore, which serves as a model to the GtkTreeView on screen. Also ports the unit tests. http://crbug.com/11250 Review URL: http://codereview.chromium.org/99361 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15257 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: show the correct cursor when the render view regains focus.estade@chromium.org2009-05-051-1/+2
| | | | | | | | BUG=11407 Review URL: http://codereview.chromium.org/105002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15256 0039d316-1c4b-4281-b951-d872f2087c98
* Highlight the next find result when the return key is pressed in the Linux ↵jhawkins@chromium.org2009-05-052-31/+34
| | | | | | | | find bar. Review URL: http://codereview.chromium.org/99376 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15255 0039d316-1c4b-4281-b951-d872f2087c98
* Various trivial clean-up bits:pkasting@chromium.org2009-05-055-14/+12
| | | | | | | | | | * Fix an 80-column issue * Remove an unused param * Remove an unnecessary setter * Fix a variable capitalization style violation Review URL: http://codereview.chromium.org/100361 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15254 0039d316-1c4b-4281-b951-d872f2087c98
* Removing some duplicate source files and filters from vcprojs.bradnelson@chromium.org2009-05-042-24/+8
| | | | | | Review URL: http://codereview.chromium.org/99369 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15251 0039d316-1c4b-4281-b951-d872f2087c98
* Several minor visual fixes to toolstrips:aa@chromium.org2009-05-046-47/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | * Layout toolstrips on the left of the bookmark bar so that something always obviously happens when you install one. This is in response to some feedback I've gotten demoing toolstrips for various people. * Open the NTP on install if the bookmarkbar isn't visible. Again, I'm trying to make something happen when you install an extension. This won't be the permanent behavior but it seems like doing nothing if you have your bookmark bar detached is likely to confuse people. * Fix a bug where we kept trying to resize the toolstrip back to the width it had when it was first made visible. * Fix a bug where we didn't always repaint the bookmarkbar after the toolstrip preferred width changed. This also seems to fix the issue where the buildbot sample shows up overlayed on top of tab contents, though I didn't mean to fix that with this CL. Review URL: http://codereview.chromium.org/100310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15249 0039d316-1c4b-4281-b951-d872f2087c98
* Specify all the outputs of theme_resources.grd-- it outputstc@google.com2009-05-041-1/+36
| | | | | | | | | | | | | | an extra .h and .cc file. This means I have to split it into it's own action since the other grd files don't create this output. This fixes a dependency in the make build. Review URL: http://codereview.chromium.org/99362 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15248 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug 9812: Remove current RSS code in favor of new more generalizedfinnur@chromium.org2009-05-0425-401/+5
| | | | | | | | | | | | PageAction code that serves the same purpose (and more). BUG=9812 TEST=No test needed, this shouldn't result in any noticable difference since the RSS parsing was disabled. Review URL: http://codereview.chromium.org/100356 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15247 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r15244. Failed tests :(darin@chromium.org2009-05-0420-87/+315
| | | | | | | | TBR=mpcomplete Review URL: http://codereview.chromium.org/99370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15246 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in search provider. It wasn't setting template_url andsky@chromium.org2009-05-042-0/+11
| | | | | | | | | | | correct fill_into_edit for keywords. BUG=11416 TEST=see bug Review URL: http://codereview.chromium.org/100350 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15245 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate webkit/glue/webhistoryitem* in favor of adding adarin@chromium.org2009-05-0420-315/+87
| | | | | | | | | | | | | | NavigateBackForwardSoon method WebViewDelegate. This moves all of the hacky details of how we intercept "history.{back, forward,go}" into the webkit layer. My eventual plan is to teach WebCore how to make this not hacky. BUG=11423 R=mpcomplete Review URL: http://codereview.chromium.org/100353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15244 0039d316-1c4b-4281-b951-d872f2087c98
* mac valgrind: remove special case in python script.dkegel@google.com2009-05-041-49/+13
| | | | | | | | | Also have --generate_suppressions output to normal log file for now. Review URL: http://codereview.chromium.org/99356 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15243 0039d316-1c4b-4281-b951-d872f2087c98
* mac valgrind: media_tests: add suppression for second trace in ↵dkegel@google.com2009-05-041-0/+8
| | | | | | | | http://crbug.com/11327 Review URL: http://codereview.chromium.org/99359 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15242 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/99349 for Ryan.sky@chromium.org2009-05-044-1/+17
| | | | | | | | | | | | | | Comments from Ryan: Some small changes to get chromium building on ARM. I tested these using the standard Linux tool chain and crosstools-ng. BUG=none TEST=none Review URL: http://codereview.chromium.org/99365 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15241 0039d316-1c4b-4281-b951-d872f2087c98
* media player movie functions to bind WTL menu events to pipeline.fbarchard@chromium.org2009-05-043-6/+192
| | | | | | Review URL: http://codereview.chromium.org/102002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15240 0039d316-1c4b-4281-b951-d872f2087c98
* Added media player File->Last to play the most recent movie again.fbarchard@chromium.org2009-05-044-15/+17
| | | | | | Review URL: http://codereview.chromium.org/100149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15239 0039d316-1c4b-4281-b951-d872f2087c98
* Undo part of brettw's WebContents refactor that removed TabContentsDelegatempcomplete@google.com2009-05-043-7/+112
| | | | | | | | | code from HtmlDialogView. BUG=http://code.google.com/p/chromium/issues/detail?id=9884 Review URL: http://codereview.chromium.org/99305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15238 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple of aesthetic nits about infobars that have been broken since I ↵ben@chromium.org2009-05-042-6/+30
| | | | | | | | | | | | redid them a few months back. - close button is properly centered horizontally - animation looks correct - layout no longer dependent on current frame height http://crbug.com/11389 Review URL: http://codereview.chromium.org/99332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15237 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land r15232 with a warnings fix:tc@google.com2009-05-043-670/+1399
| | | | | | | | | | | | | | | | | | | Merge latest changes from http://www.netlib.org/fp/dtoa.c into dtoa.cc This should fix the gcc 4.4. strict aliasing issues. More info here: http://patrakov.blogspot.com/2009/03/dont-use-old-dtoac.html Also update gcc_warnings.patch to match. BUG=9104 Original change by Craig Schlenter via http://codereview.chromium.org/99315 Review URL: http://codereview.chromium.org/99367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15236 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a browser crash when reading the disk cache experiment datarvargas@google.com2009-05-041-5/+6
| | | | | | | | | | | after failing to map the index file. BUG=11414 TEST=none Review URL: http://codereview.chromium.org/100349 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15235 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux ui tests broken by r15112.estade@chromium.org2009-05-042-16/+8
| | | | | | | | | | also re-enable tests that I disabled in an attempt to green the bot TBR=tony Review URL: http://codereview.chromium.org/100351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15234 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Merge latest changes from http://www.netlib.org/fp/dtoa.c into dtoa.cc"tc@google.com2009-05-043-1390/+670
| | | | | | | | | This reverts commit r15232. Review URL: http://codereview.chromium.org/99366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15233 0039d316-1c4b-4281-b951-d872f2087c98
* Merge latest changes from http://www.netlib.org/fp/dtoa.c into dtoa.cctc@google.com2009-05-043-670/+1390
| | | | | | | | | | | | | | | | | This should fix the gcc 4.4. strict aliasing issues. More info here: http://patrakov.blogspot.com/2009/03/dont-use-old-dtoac.html Also update gcc_warnings.patch to match. BUG=9104 Original change by Craig Schlenter <craig.schlenter@gmail.com> via http://codereview.chromium.org/99315 Review URL: http://codereview.chromium.org/99364 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15232 0039d316-1c4b-4281-b951-d872f2087c98
* Make buildbot sample more compact.aa@chromium.org2009-05-041-18/+53
| | | | | | | | | Only shows the text "tree: (open|closed)" initially now. When you hover over it, it animates open to show the entire bar. Review URL: http://codereview.chromium.org/100315 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15231 0039d316-1c4b-4281-b951-d872f2087c98
* revert r15223 to see if it fixes the security-context-with-base-tag.html crashdarin@chromium.org2009-05-042-9/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15230 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable failing ui tests on linux.estade@chromium.org2009-05-041-0/+12
| | | | | | | | TBR=cpu Review URL: http://codereview.chromium.org/100348 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15229 0039d316-1c4b-4281-b951-d872f2087c98
* Fix BackSpace not working in Find box.finnur@chromium.org2009-05-041-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | This regressed with: http://codereview.chromium.org/99161 I think more work is needed, such as: 1) Figure out if more combinations need to be added. 2) Figure out if we can consolidate the code into one function, so that we don't need to keep three ShouldLookupAccelerators in sync (one in TextField, one in LocationBarView and potentially one in AutocompleteEditViewWin as well (OnKeyDownOnlyWritable). I'm not sure what all those magic keyboard constants like 0xBB do, so I think I'll leave the rest of the work to the person who created the changelist noted above. BUG=11326 TEST=Open google.com, press About link, press Ctrl+F, press e, press BackSpace. Chrome should not navigate back. Review URL: http://codereview.chromium.org/100347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15228 0039d316-1c4b-4281-b951-d872f2087c98
* Revert bug fix because interactive_ui_tests are failing.mbelshe@google.com2009-05-044-71/+4
| | | | | | Review URL: http://codereview.chromium.org/99358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15227 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes focus issues when browsing on Mac.rohitrao@chromium.org2009-05-042-2/+8
| | | | | | | | | | http://crbug.com/10032 TEST=Open a new tab and browse to www.google.com. Type something and check that focus is correctly set to the text field. Review URL: http://codereview.chromium.org/99327 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15226 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: tweak find bar.estade@chromium.org2009-05-048-27/+28
| | | | | | | | | - (attempt to) fix find bar z ordering in a simpler way - get "close without animation" right. Review URL: http://codereview.chromium.org/100286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15225 0039d316-1c4b-4281-b951-d872f2087c98
* Don't analyze incomplete valgrind log files (as the parser crashes),dkegel@google.com2009-05-041-11/+20
| | | | | | | | make timeout global instead of per-file, shorten it. Review URL: http://codereview.chromium.org/100340 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15224 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a WillDestroyFrame(WebFrame*) notification method to WebViewDelegate thatdarin@chromium.org2009-05-042-0/+9
| | | | | | | | | | | | | | | | | | gets called from WebFrameLoaderClient::frameLoaderDestroyed(). The Chromium Embedded Framework needs this notification to properly clean up memory associated with specific WebFrame instances (for example, custom NPObject types bound to the WebFrame via BindToWindowObject()). This patch was contributed by Marshall Greenblatt. R=aa,darin Review: http://codereview.chromium.org/99283 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15223 0039d316-1c4b-4281-b951-d872f2087c98
* Rebase valgrind suppressions, add one for http://crbug.com/11130dkegel@google.com2009-05-041-2/+15
| | | | | | Review URL: http://codereview.chromium.org/100341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15222 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate wstring version of PathService::Get() in unit tests.thestig@chromium.org2009-05-047-51/+47
| | | | | | Review URL: http://codereview.chromium.org/100292 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15221 0039d316-1c4b-4281-b951-d872f2087c98
* Lands the fix for bug 8088 from m0 (http://codereview.chromium.org/100022).sky@chromium.org2009-05-042-16/+5
| | | | | | | | | | | | | | | | | | | | | | | | | Here's his description: Mouse hover out of context menu should un-select menu item. All Context Menu's which are implemented with ChromeMenu is not properly un-selecting the menu item when out of focus. The areas where this is affected are: * Tabs * Bookmark bar * Bookmark managerThe others uses winapi for context menus. Doesn't use ChromeMenu, uses HMENU, that explanes why the others work. For this fix, I had to make sure that the MenuPart is always NONE when the mouse is moved outside of the context menu regions, and that is always the case. Hence, we can assure to remove selection. The same way it has been done for SetSelection, I have used the same technique for this, but simpler. BUG=8088 TEST=For the above mentioned affected areas, I brought up the context menu by right clicking, and hovered over a menu item, then move the mouse horizontally outside the context menu region, it deselected the item. Review URL: http://codereview.chromium.org/102025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15220 0039d316-1c4b-4281-b951-d872f2087c98