| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
on a handle that we already closed.
BUG=8070
Review URL: http://codereview.chromium.org/40195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(I had rebaselined before adam's patch yesterday)
TBR=pamg
Review URL: http://codereview.chromium.org/40204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests\fast\text\drawBidiText.html
The text metrics don't match, otherwise the bidi order of the text matches the one in Safari and text size matches the same page in IE (but IE has apparently incorrect bidi order)
LayoutTests\fast\css\rtl-ordering.html
The test verifies the ordering of rtl characters and it matches the Safari and expected result. The font metrics match IE (except default margin values that are differrent in IE).
LayoutTests\fast\encoding\denormalised-voiced-japanese-chars.html
The rendering is correct (denormalized unicode for Hiragana is composed back into correct glyphs) and matches Safari. The text metrics match IE.
Review URL: http://codereview.chromium.org/40198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
called in RendererMainThread's dtor, not Thread's, otherwise the vtable lookup won't use RendererMainThread's CleanUp function.
Review URL: http://codereview.chromium.org/40199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I think the new baseline is correct. Because the containing UL
has a 1 pixel border, the marker should be offset by 1 pixel.
I'm not sure why this changed :(
Review URL: http://codereview.chromium.org/40193
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the Value% color picker slider is in a very slight different shade.
Review URL: http://codereview.chromium.org/39227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Delete DownloadDestinationContextMenu, which is not used anywhere.
* Delete the unused download menu item types from the ContextMenuCommands enum.
* Merge BaseContextMenu and DownloadShelfContextMenu, move them from download_util.{h,cc} to download_shelf.{h,cc}
* Take the windows-specific code from the new DownloadShelfContextMenu and put it in DownloadShelfContextMenuWin in download_item_view.cc (the only place it's used). DownloadShelfContextMenuWin extends DownloadShelfContextMenu and Menu::Delegate.
Review URL: http://codereview.chromium.org/40184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I downloaded the test data "no-ads.pac" from <http://ap.coova.org/wpad.dat>.
BUG=2764
Review URL: http://codereview.chromium.org/40149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
drag-in-iframe: Says we just need to rebaseline and the test
hasn't timed out in a long time.
no_transform_hit_testing: New test. Only difference is we
anti-alias fonts on linux.
BUG=8439
Review URL: http://codereview.chromium.org/39230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=ian
BUG=4150
Review URL: http://codereview.chromium.org/39213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) If the Find textfield is populated when the Find box is shown, the FindPrevious and FindNext buttons should also be enabled. (issue 8369)
2) If you search for something that is not on the page, you get "0 of 0" in red. Press Esc and Ctrl+F and the label is gone but the red background color for the label remains (no bug on file, found during testing).
BUG=8369
TEST=Open about:blank in Chrome. Press Ctrl+F, search for 'e' (get 0 of 0), close the Find box, reopen the Find box. Observe 'e' is in box, it is highlighted and no red is visible. Also, FindPrevious and FindNext buttons should be enabled.
Review URL: http://codereview.chromium.org/39233
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Some output was missing due to calling finishTesting too early.
Review URL: http://codereview.chromium.org/40196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=2304
Review URL: http://codereview.chromium.org/39209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
too often. I filed bug 8444.
Review URL: http://codereview.chromium.org/39226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=3828
Review URL: http://codereview.chromium.org/40161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
pending/fast/repaint/bugzilla-6473.html, but it has problems that need to be resolved before it can be upstreamed. See https://bugs.webkit.org/show_bug.cgi?id=21536
Bug 982608: test had a wrong result for one condition
Pending test needs work before sending upstream.
Review URL: http://codereview.chromium.org/40186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and posix implementations.
Review URL: http://codereview.chromium.org/40133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fast/text/international/complex-character-based-fallback.html
fast/text/international/hindi-spacing.html
fast/text/international/thai-line-breaks.html
These tests were incorrectly rebaselined recently (ClearType was turned on when the baseline was generated) and this gets them back to where they were.
svg/css/getComputedStyle-basic.svg:
This test is dumping computed styles for a couple of simple svg objects. Our output differs from the mac output in two ways:
1) The font-family for the two objects is not specified and gets reported as 'times new roman' for us instead of 'Times'. This looks normal to me; if I create a div and specify no font-family I get 'times new roman' on Chrome & Safari on Windows, but in Safari on Mac I get 'Times'.
2) Our output doesn't contain the property -webkit-dashboard-region.
NOTE: This is essentially the same test as fast/css/computed-style.html which has a baseline that differs in exactly the same way. See:
http://codereview.chromium.org/12457 (font-family)
http://codereview.chromium.org/4602 (webkit-dashboard)
Review URL: http://codereview.chromium.org/39220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
p13n related features.
Review URL: http://codereview.chromium.org/39029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=darin
Review URL: http://codereview.chromium.org/40189
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
make them get destructed after browser shutdown, make them a member variable of BrowserRenderProcessHost.
Review URL: http://codereview.chromium.org/39218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
have already impacted Window itself, but a NULL check was already inserted in that code.
http://crbug.com/4355
Review URL: http://codereview.chromium.org/40183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
HTTP version in the http_version_ member. Pass NULL to
EnumerateHeader.
R=eroman
Review URL: http://codereview.chromium.org/40137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/39216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This means we will no longer get "missing expected output".
The tests are surely still failing.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The FileDescriptor API is clearly too hard to use. It's the only IPC
data type which is non-POD and serialising an invalid file descriptor
is fatal to Chrome on POSIX. The use of Maybe is possibly non-obvious
to non-functional programmers.
This patch merges Maybe and FileDescriptor so that serialising invalid
file descriptors is permitted and results in -1 at the other end.
(Serialising /closed/ a file descriptor is still fatal.) Also, it adds
a pointer in base/file_descriptor.h to instructions for its use with
IPC. Although it's generally bad practice to mention IPC in base, in
this case I cannot find another suitable location.
Review URL: http://codereview.chromium.org/39208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
call functions in the rest of Chromium code without having to go through ChromiumBridge (which now lives upstream in the WebKit repository).
R=darin,mbelshe
Review URL: http://codereview.chromium.org/40132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeFont::GetExpectedTextWidth to use dlu_base_x _or_ average
character width (depending on which one is smaller).
BUG=8331
TEST=Open About box in all languages and make sure it is roughly
the same size as it was in 1.0.
Review URL: http://codereview.chromium.org/39214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
deleted.
BUG=8217
R=kuchhal
Review URL: http://codereview.chromium.org/27307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and actually looked better than the baseline.
Review URL: http://codereview.chromium.org/40181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
would not focus the location bar.
DOM UI now by default focus the page.
The NTP one focus the location bar.
Also removed some unused fields from the history and download DOM UI.
BUG=8356
TEST=Open NTP, focus should be on location bar
Review URL: http://codereview.chromium.org/39173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Split the lines >80 cols. (Part 1)
Review URL: http://codereview.chromium.org/39206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
between Windows and Mac.
Review URL: http://codereview.chromium.org/40180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
different - the diagonal lines are anti-aliased in a slightly different shade, and the text is drawn differently.
Review URL: http://codereview.chromium.org/39053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11028 0039d316-1c4b-4281-b951-d872f2087c98
|