| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR to fix mac build break.
Review URL: http://codereview.chromium.org/9430
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in base, net and sandbox:
* Remove by-hand Install() and Alias() calls.
* Set $COMPONENT_PROGRAM_GROUPS and $COMPONENT_TEST_PROGRAM_GROUPS
(with in each foo\foo.scons file) so executables get added
automatically to the appropriate Alias.
* Set $TESTS_DIR and $STAGING_DIR so executables get linked
directly in their final resting place ($TARGET_ROOT).
Review URL: http://codereview.chromium.org/9188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the user types text in a text field in a form, the renderer queries the browser for suggestion based on the entered text and displays the suggestions in a popup.
Listeners are set on the form text field in a similar fashion than for password save.
The popup showing the suggestion uses the same mechanism as the select popup. Note that a difference between the select and the autofill popup is that the autofill should not take focus, so the page still has focus and the user can still type in while it shows.
The creation of the render widget was modified for that purpose so we can specify the popup should not be focused when shown.
Review URL: http://codereview.chromium.org/8885
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
fixed.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- automation provider was moving mouse pointer to position in client coords, not
screen coords as required.
- TabStrip was allowing drags to occur in invalid conditions.
This doesn't completely fix the underlying broken-ness of the SimulateDrag
function, however I've not yet been able to get a version of it using SendInput
working.
http://crbug.com/4067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
unfork ColorCG.cpp, and pick up the Chromium standard focus ring color. May
be superceded at some point if the color becomes a per-theme attribute.
Review URL: http://codereview.chromium.org/9185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Explicitly set_delegate(NULL) before releasing a TabContents. (I think
the order messages are getting handled is different from XP; this only
seems neccessary under Vista.)
- r4523 and someone elses change added entries to theme_resources.rc at
roughly the same time, causing happy fun crashes.
- Roll in sgk's SConscript fix.
Review URL: http://codereview.chromium.org/9373
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9376
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9423
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is also hanging because of the "dummy activation window".
Unfortunately we used to skip the hung plugin notification
dialog for this window. I'm changing this behavior to display
it even for this window.
We don't know what plugin it is, so we just display "an
unknown plugin", but this is better than nothing.
This is a potential fix for 3383.
I do not expect to completely fix 3383 with it, but it
should help minimize the problem.
bug:3383
Review URL: http://codereview.chromium.org/9386
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9419
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9416
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
where content_changed is false). These calls to repaint are safe to ignore
given our painting architecture.
BUG=4108
R=brettw
Review URL: http://codereview.chromium.org/9174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
chrome\browser\bookmarks\bookmark_drop_info.cc
chrome\browser\importer\toolbar_importer.cc
chrome\views\view_constants.cc
Review URL: http://codereview.chromium.org/9387
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
chrome, as well as the 1MB regression in chrome.dll size.
Review URL: http://codereview.chromium.org/8226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Pressing enter when more than one folder is selected opens them all.
. Show in folder is only enabled when it makes sense: you've selected a
bookmark in the table and the table is showing recently bookmarked
or search results.
BUG=4034 4044
TEST=see bugs
Review URL: http://codereview.chromium.org/9367
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9397
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
unsafe usage of string shapes.
Review URL: http://codereview.chromium.org/9413
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This patch blocks all the extensions that we register.
R=nsylvain
BUG=1463961
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Adding fix to targets_msvs to work with chrome hammer.bat in depot_tools.
Review URL: http://codereview.chromium.org/9149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=3650
Review URL: http://codereview.chromium.org/8065
Patch from James Vega.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Forward declarations can't simply use "class $namespace::$class;" syntax. Instead one needs to use "namespace $namespace { class $class; }" syntax.
Review URL: http://codereview.chromium.org/8722
Patch from James Vega.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9378
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=b/1330770
Review URL: http://codereview.chromium.org/9332
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
make it more foolproof. Updated all clients and unittests. Mac port by jeremy@chromium.org
Review URL: http://codereview.chromium.org/9154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
contents types.
BUG=2855
Review URL: http://codereview.chromium.org/9141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
since doing so conflicts with the way we build the .pch file
(and our explicit settings for the rest of object files).
Review URL: http://codereview.chromium.org/9380
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9379
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also corrects a style problem in r4624 (comment order does not match expression order).
Review URL: http://codereview.chromium.org/9369
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
From 'chrome %1' to 'chrome -- %1'. For more information see r4016 and crbug.com/3808
Review URL: http://codereview.chromium.org/8988
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The key was to update paint_rect_ during the DidInvalidateRect.
I also added some code for bookkeeping needed for optimized
scrolling, but haven't actually hooked it up yet. Most of the
other changes were to get more inline with the Windows code.
Review URL: http://codereview.chromium.org/9151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9291
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
installs we need to use a different version of the Omaha updater.2. http://b/issue?id=1447951 For Vista we need to elevate while performing the update operation. This only applies to machine installs. Update checks also instantiate the same COM object. However it does not need elevation.Bug=1447957, 1447951R=finnur, kuchhal
Review URL: http://codereview.chromium.org/8221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
it can be shared by first run and set up. There is no functionality
change in this CL.
Review URL: http://codereview.chromium.org/9338
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- button press, release
- mouse move
- wheel scroll
Review URL: http://codereview.chromium.org/9355
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=3094
TBR=laforge
Review URL: http://codereview.chromium.org/9341
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
click the mouse we would crash. This is the same fix as you first saw,
I couldn't repro interactive ui test anymore.
BUG=4047
TEST=see bug
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9354
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4657 0039d316-1c4b-4281-b951-d872f2087c98
|