| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
TBR=dglazkov
Review URL: http://codereview.chromium.org/113008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tbr=thestig
Review URL: http://codereview.chromium.org/113006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
Review URL: http://codereview.chromium.org/113005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
Review URL: http://codereview.chromium.org/114001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
Review URL: http://codereview.chromium.org/113004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
longer exists.
TBR=ojan
Review URL: http://codereview.chromium.org/113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
/cry
TBR=dglazkov
Review URL: http://codereview.chromium.org/108043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mark
Review URL: http://codereview.chromium.org/108039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=11439
Review URL: http://codereview.chromium.org/108038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=tony
Review URL: http://codereview.chromium.org/109048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/109042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=tony
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
removed.
BUG=11381
TEST=in opt mode: download something, go to downloads tab, clear all, go back to tab with downloaded item. The shelf should be gone.
Review URL: http://codereview.chromium.org/100366
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/108035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=jam
Review URL: http://codereview.chromium.org/109028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Reland of r15025 which was reverted in r15095. |exit| has been
changed to |_exit| to save running the onexit handlers while another
thread is still in V8 code.)
On POSIX one can install an unload handler which loops forever and
leave behind a renderer process which eats 100% CPU forever.
This is because the terminate signals (ViewMsg_ShouldClose and the
error from the IPC channel) are routed to the main message loop but
never processes (because that message loop is stuck in V8).
One could make the browser SIGKILL the renderers, but that leaves open
a large window where a browser failure (or a user, manually
terminating the browser because "it's stuck") will leave behind a
process eating all the CPU.
On Windows we don't have this issue because all the processes are in a
job so when the parent dies, all the children are killed too.
http://codereview.chromium.org/100222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
correct object. This change also adds an initial DraggedTabControllerGtk.
Review URL: http://codereview.chromium.org/99371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This allows the browser to start up without ever showing the first run UI, regardless of whether the First Run sentinel file is present. Quite useful for automated testing ;-)
Review URL: http://codereview.chromium.org/99344
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Workaround for rdar://6857649 - NSGradient fails when using LAB Colorspace
* Update sandbox config file for 10.6
BUG=11265
TEST=Open Chrome on 10.6, it should have tabs and the tab title should reflect
the title of the page that's currently loaded.
Review URL: http://codereview.chromium.org/109032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/108025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
for anything; it will be used for whitelisting popups by hostname.
BUG=11440
Review URL: http://codereview.chromium.org/105004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/109033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
when it's selected.
Review URL: http://codereview.chromium.org/109036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On the user-visible side this change enables mouse hover (the item
under the mouse is highlighted), and lays out the text omnibox v2
style. Only hover really needed the control change, but I have
another change queued up to style the popup text. It uses different
colors and shades, and really looked horrible with the NSTableView
highlighting. [Which is why this part of the CL is coming first.]
TEST=Omnibox popup works and shows highlighting under the mouse in addition to the keyboard-selected item.
Review URL: http://codereview.chromium.org/99310
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Since we set the background color, we can't go letting the theme choose the text color unless we want to potentially end up with white on yellow.
Review URL: http://codereview.chromium.org/108034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I moved the image down 2px as well as adjusted the margins. I tried keeping
the image at 0px but it looks better when moved down slightlty :-)
http://crbug.com/10057
Review URL: http://codereview.chromium.org/99286
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/108026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/99311
TBR=yusukes
Review URL: http://codereview.chromium.org/109030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99373
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=estade
Review URL: http://codereview.chromium.org/108029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This module contains all event handling for menus in the Media Player.
The implementation is WTL (Windows Template Library) based.
The main menu is:
File Edit View Play Options Help
File opens/closes movies and has print features.
Edit has copy/paste features.
View has spatial controls, such as scaling, and tool and status bars and a properties dialogue box.
Play has temporal controls, such as play speed and pause.
Options controls details such as Audio and Video on/off.
Help is just an about box.
Right clicking brings up a context menu with edit and view items.
A tool bar exposes the most common menu items as buttons.
Hotkeys (accelerators) are mapped to most menu items.
A .RC file is used to edit the menus using the resource editor in visual studio.
Dialogue boxes are each handled by a different .h. ie props.h for properties.
Mainfrm.h does some minor dialogue boxes directly, such as the file selector and alert boxes for errors.
Review URL: http://codereview.chromium.org/99087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=aa
Review URL: http://codereview.chromium.org/110001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
for http://crbug.com/6547 and http://crbug.com/11462,
and loosen up another couple a bit.
Review URL: http://codereview.chromium.org/108001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/110004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
in fact are methods. Show the method names for them.
Review URL: http://codereview.chromium.org/108018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/108023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The memory leak was introduced by BufferedDataSource, the cause of the leak:
1. Some video files have read patterns that BufferedResourceLoader cannot
provide data buffer with, thus a large amount of BufferedResourceLoader
is created and destroyed.
2. In the destruction of BufferedResourceLoader, it cancels the resource
request and immediately deletes the ResourceLoaderBridge.
3. The request canceled in the renderer process isn't cancalled immediately
in the browser process, at the mean time browser process still sends
shared memory buffers to the renderer process.
4. When these shared memory buffers arrived at the renderer process, the
ResourceLoaderBridge associated with the requst has already been destroyed,
ResourceDispatcher can't find the associated ResourceLoaderBridge and simply
delete the message. But the IPC message is not POD, it contains the handle
to shared memory that should be closed.
5. End result is a lot of memory are shared to the renderer process but they
are not closed.
Solutions:
1. Delete ResourceLoaderBridge only at OnCompletedResponse.
Delete ResourceLoaderBridge at OnCompletedResponse, it is guranteed that
no more shared memory buffer will arrive after this point, so it's safe
to delete ResourceLoaderBridge. The downside is the lifetime of
BufferedResourceLoader is prolonged until OnCompletedResponse is received,
which may never is received in case of timeout for certain protocol..
2. Inside ResourceDispatcer, close the handles to shared memory even if
ResourceLoaderBridge is not found.
I'm going for route 1. The problem I mentioned in 2 also sounds like a bug in
ResourceDispatcher, will talk to erickay or eroman to find a solution.
Review URL: http://codereview.chromium.org/100302
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the URL path.
Inspector will work again after we pull in r43185 from upstream
webkit (I tested by patching it in locally).
Review URL: http://codereview.chromium.org/106003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
my build machine, they are evidently still failing on the bots.
TBR=thomasvl
Review URL: http://codereview.chromium.org/110003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11463
TEST=see bug
Review URL: http://codereview.chromium.org/108019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
non-Mac platforms
TBR=thomasvl
Review URL: http://codereview.chromium.org/110002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/108016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
and other recent changes.
BUG=10312,10339,10348,10372,10447,10451,10662
Review URL: http://codereview.chromium.org/109024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
tear down. This is an effor to reduce random
failure due to browser crash with multiple window
open during shutdown.
Review URL: http://codereview.chromium.org/100363
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/109014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/109010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/108009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This contains a bug fix for the disappearing external strings bug
(http://crbug.com/9746) as well as a couple of other bug fixes.
In addition to bug fixes, this version of V8 allows the call as
function handler registered on non-function objects to be called in
construct calls.
BUG=9746
Review URL: http://codereview.chromium.org/109011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=evan
Review URL: http://codereview.chromium.org/109008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15288 0039d316-1c4b-4281-b951-d872f2087c98
|