summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Attempt 2 at landing this patch. It broke the Mac/linux builds. Fix for now isananta@chromium.org2008-10-096-4/+58
| | | | | | | | | | | | | | | | | | | | | | to add the offending code in np_v8object.cpp in a ifdef OS_WIN This fixes http://code.google.com/p/chromium/issues/detail?id=2472, which is an issue with popups displayed by the flash plugin in response to a user click, getting blocked. The plugin invokes NPN_Evaluate to execute the javascript. It also invokes the NPN_PushPopupEnabledState/NPN_PopupEnabledState API's to set the popup enabled stack for the duration of the call. The fix is to add the plumbing in NPN_Evaluate to pass in a flag indicating whether popups are allowed for the duration of the call. Bug=2472 R=jam Review URL: http://codereview.chromium.org/6379 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3119 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge hits the SCons build, the sequel:sgk@google.com2008-10-0911-292/+596
| | | | | | | | | | | | | | | | | * Un-revert r3063 (basic file list updates). * Un-revert r3079 (os-win32 subdirectory). * Add icu.lib to the npapi_test_plugin.dll link. * Add libpng.lib to the port.lib link. * Updates for recently un-forked files. * Incorporate Linux fixes from phajdan.jr (many thanks): * Add libxml/linux/include to relevant CPPPATH lists. * Use -Wno-error to suppress warnings-as-errors. * Re-order lines in ExceptionContext. * Remove unused WebCore::SharedBuffer declaration in SkiaUtils.h. * Spelling fix: V8CSSSTyleDeclaration.h => V8CSSStyleDeclaration.h Review URL: http://codereview.chromium.org/7024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3118 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the About box according to mockups. Basically, we now want to have ↵finnur@google.com2008-10-0947-74/+289
| | | | | | | | a paragraph of text with embedded links (to the Chromium project, credits and terms of service). Review URL: http://codereview.chromium.org/6563 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3117 0039d316-1c4b-4281-b951-d872f2087c98
* Linux build fix: wchar_t is different on different platforms, use the char16 ↵erg@google.com2008-10-093-5/+5
| | | | | | | | | | that is defined and is the same on windows and unix Review URL: http://codereview.chromium.org/6425 Patch from icefox. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3116 0039d316-1c4b-4281-b951-d872f2087c98
* Another attempt at fixing standard non-client area overpainting.ben@chromium.org2008-10-093-8/+20
| | | | | | | | http://crbug.com/3264 Review URL: http://codereview.chromium.org/7022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3115 0039d316-1c4b-4281-b951-d872f2087c98
* Move |result_| and |latest_result_| to the autocomplete controller.pkasting@chromium.org2008-10-0920-533/+530
| | | | | | | This purposefully does not change the communication interface between the edit and the popup; that's coming in a subsequent pass. As a result, right now the popup isn't really much simpler. That should eventually change. Review URL: http://codereview.chromium.org/6596 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3113 0039d316-1c4b-4281-b951-d872f2087c98
* Makes sure the network usage is also reported for non tabs (right now only ↵jcampan@chromium.org2008-10-091-12/+11
| | | | | | | | | | the browser process). BUG=1282443 TEST=Open the task manager, type in something in the location bar. The network usage for the browser process should show some activity. Review URL: http://codereview.chromium.org/7019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3112 0039d316-1c4b-4281-b951-d872f2087c98
* KJS::Lock constructor now takes a bool. Fix 1 build error!ojan@google.com2008-10-091-1/+1
| | | | | | Review URL: http://codereview.chromium.org/7020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3111 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an include that no longer exists.ojan@google.com2008-10-091-27/+18
| | | | | | Review URL: http://codereview.chromium.org/7018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3110 0039d316-1c4b-4281-b951-d872f2087c98
* Compile fix on Linuxerg@google.com2008-10-092-6/+8
| | | | | | | | | | | | | GURL constructor takes std::string or UTF16String not std::wstring Remove the windows function _wtoi and use the cross platform function StringToInt from string_util.h for converting the string to an int Review URL: http://codereview.chromium.org/5202 Patch from icefox. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3109 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes the task manager columns sortable.jcampan@chromium.org2008-10-092-93/+300
| | | | | | | | | | | It ensures the CPU usage is only computed once per periodic update. Also it now posts tasks instead of using a timer, as timers can fire erraticly if the thread is really busy. BUG=95 TEST=Open the task manager. Click on the columns to sort. Review URL: http://codereview.chromium.org/7016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3108 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust mac project to accommodate http://codereview.chromium.org/6368,amanda@chromium.org2008-10-0910-4263/+7
| | | | | | | remove files from pending that are no longer referred to by any platform. Review URL: http://codereview.chromium.org/6388 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3107 0039d316-1c4b-4281-b951-d872f2087c98
* Update gears.dll to 0.4.24.0 in preparation for Geolocation launch next week.mpcomplete@google.com2008-10-092-0/+0
| | | | | | Review URL: http://codereview.chromium.org/6350 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3106 0039d316-1c4b-4281-b951-d872f2087c98
* Disallow recursive locking via the Lock classjar@google.com2008-10-092-113/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | Change contract so that Posix locks (which deadlock on attempts by a single thread to acquire a mutex recursively) and windows critical sections can both be used to implement the Lock() cass, by disallowing recursive locking. In DEBUG mode only, we watch for (now) illegal use of recursive locking. Also remove a pile of cruft that has built up in this file as various folks have re-re-refactored and moved around code. Note that Window's condition variable implementation still uses the AutoUnlock() helper class, but now the implementation (sans nested locking) is very trivial. Posix will probably use their own CV implementation. r=mbelshe Review URL: http://codereview.chromium.org/5630 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3105 0039d316-1c4b-4281-b951-d872f2087c98
* Let mini_installer pass any arbitrary command line flags to setup.exe. This ↵kuchhal@chromium.org2008-10-092-18/+71
| | | | | | | | | | will let us run setup.exe in verbose logging mode without mucking around in the registry to keep setup.exe around after mini_installer finishes. Also replace mini_installer black box icon with installer icon of setup.exe. Review URL: http://codereview.chromium.org/2992 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3104 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land this earlier change. Will deal with dist crashes as they arise.ben@chromium.org2008-10-091-0/+3
| | | | | | | | | | | | | | Make sure the frame is set to the foreground when: - opening from a shortcut when an existing frame is already open - pressing Ctrl+T from an app window http://crbug.com/2477 R=jcampan git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3103 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes the pending/plugins/destroy-stream-twice layout test, which ↵ananta@chromium.org2008-10-092-18/+3
| | | | | | | | | | | | regressed during the merge with the upstream layout test plugin code. We were invoking the onStreamLoad function twice in the test, which caused this test to fail. R=deanm Review URL: http://codereview.chromium.org/6383 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3102 0039d316-1c4b-4281-b951-d872f2087c98
* For the filter "Chrome Ignore > IPR_delayLoadHelper2 (winsock2 dll load)",wtc@google.com2008-10-091-0/+0
| | | | | | | | | | | | change the match criterion (range of the function's offset from the top in the call stack) from "1-2" to "0-2" because the new HTTP stack generates a call stack with the function _tailMerge_WS2_32_dll at the top. TBR=pamg BUG=b/1101168 Review URL: http://codereview.chromium.org/7003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3101 0039d316-1c4b-4281-b951-d872f2087c98
* Fix weird painting of elements of the non-client area.ben@chromium.org2008-10-093-24/+54
| | | | | | | | http://crbug.com/3264 Review URL: http://codereview.chromium.org/7007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3100 0039d316-1c4b-4281-b951-d872f2087c98
* One more link that needs drag and drop disabled in the malware blocking page.jcampan@chromium.org2008-10-091-1/+1
| | | | | | | BUG=3235 Review URL: http://codereview.chromium.org/6360 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3099 0039d316-1c4b-4281-b951-d872f2087c98
* Revert both 3079 and 3063 because they caused linux and mac breakage.maruel@google.com2008-10-098-571/+283
| | | | | | Review URL: http://codereview.chromium.org/7015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3098 0039d316-1c4b-4281-b951-d872f2087c98
* Use #if ENABLE_feature and not #if defined(ENABLE_feature) in idl files.mark@chromium.org2008-10-091-8/+8
| | | | | | | | Features to be disabled are still defined, but with a value of 0. Restores local change r2804 and follows the principle of upstream WebKit r37362. Review URL: http://codereview.chromium.org/6385 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3097 0039d316-1c4b-4281-b951-d872f2087c98
* Grouped a failing layout test with another layout test bothsgjesse@chromium.org2008-10-091-2/+5
| | | | | | | | failing due to bug 852346: Tests link coloring and needs a history dataLayoutTests. Review URL: http://codereview.chromium.org/7012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3096 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to get the layout test harness running on mac.pinkerton@google.com2008-10-097-26/+232
| | | | | | Review URL: http://codereview.chromium.org/5614 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3095 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a couple of tests that were fixed by DOMWindow ager@google.com2008-10-091-5/+0
| | | | | | | lookup changes. Review URL: http://codereview.chromium.org/7010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3094 0039d316-1c4b-4281-b951-d872f2087c98
* Added a comment to a failing test pointing to a newly created bug.sgjesse@chromium.org2008-10-091-1/+4
| | | | | | Review URL: http://codereview.chromium.org/7009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3093 0039d316-1c4b-4281-b951-d872f2087c98
* Merge Document.idl and DOMWindow.idl properly. Diffing our forkedager@google.com2008-10-097-145/+192
| | | | | | | | | | | | | | | versions agains the WebKit ones it is now easy to see the differences. The lookup on the window object has changed slightly. We can now get rid of our v8OnProto annotations in DOMWindow.idl. I have generated the new expected file for lookup-precedence for JSC using a webkit nightly build. Also, a couple of extra constructors have been added to the IDL file and the CROSS_DOCUMENT_MESSAGING define is gone. Review URL: http://codereview.chromium.org/6382 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3092 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize string to the empty string to avoid 'undefinedXXX' when appending ↵sgjesse@chromium.org2008-10-092-3/+3
| | | | | | | | | | | XXX. Format frame numbers with two digits when presenting the output from teh f command. BUG=1304224 Review URL: http://codereview.chromium.org/6079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3091 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to get the webkit debug tester green.ager@google.com2008-10-091-0/+5
| | | | | | Review URL: http://codereview.chromium.org/6380 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3090 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Mac build bustage caused by r3029 by providing a temporary stub method.mark@chromium.org2008-10-092-0/+48
| | | | | | | | | This isn't the ultimate fix: we should port and use port/platform/graphics/GraphicsContextSkia.cpp, but we were formerly using a stub just like this one, so this is fine to fix the burning. Review URL: http://codereview.chromium.org/7008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3089 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r3074 due to Mac build bustagemark@chromium.org2008-10-096-55/+4
| | | | | | Review URL: http://codereview.chromium.org/6378 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3088 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back changes to the client area size calculation, since this fix didn't ↵ben@chromium.org2008-10-092-32/+27
| | | | | | work. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3087 0039d316-1c4b-4281-b951-d872f2087c98
* Adding savedebuglog flag to reliability test. When the flag is huanr@chromium.org2008-10-091-2/+66
| | | | | | | | specified, reliability test saves chrome and v8 debug log per url. Review URL: http://codereview.chromium.org/6231 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3086 0039d316-1c4b-4281-b951-d872f2087c98
* Generate expected results for all tests that don't have pixel results.tc@google.com2008-10-0916-9/+84
| | | | | | | | | Most tests were fine except for font differences. The ones that are still broken are updated accordingly. tests_*.txt are probably the only files worth reviewing. Review URL: http://codereview.chromium.org/6373 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3085 0039d316-1c4b-4281-b951-d872f2087c98
* New default brandcode.cpu@google.com2008-10-091-1/+1
| | | | | | | | BUG=1397407 Review URL: http://codereview.chromium.org/6597 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3084 0039d316-1c4b-4281-b951-d872f2087c98
* Porting changes in webkit/glue/plugins/testevanm@google.com2008-10-093-29/+40
| | | | | | | | | | | | | Not too much, 2 files actually, but still something. Please test this on Windows. BUG=1949 Review URL: http://codereview.chromium.org/4249 Patch from Paweł Hajdan jr <phajdan.jr@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3083 0039d316-1c4b-4281-b951-d872f2087c98
* Optimize the mime sniffer based on UMA data and move closer to the HTML 5 spec.abarth@chromium.org2008-10-092-75/+30
| | | | | | | | | | | | | | Removed over 50% of the heuristics while returning the same result 99.996% of the time. Each heuristic we remove reduces the attack surface that honest sites have to worry about when the serve third-party content. (with typo fix this time) R=darin git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3082 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show the wdiff link if we're not running with the --wdiff flag.tc@google.com2008-10-092-3/+13
| | | | | | | Also doesn't ever show the link on the simplified diff line. Review URL: http://codereview.chromium.org/6371 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3081 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a bunch of files from KJSBindings.vcproj that are no longer ↵pkasting@chromium.org2008-10-091-1109/+65
| | | | | | | | referenced in the upstream vcprojs, and no longer exist in the tree. Review URL: http://codereview.chromium.org/7001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3080 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux build breakage from the webkit merge.sgk@google.com2008-10-091-8/+19
| | | | | | Review URL: http://codereview.chromium.org/7004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3079 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in BrowserAccessibilityManager destructor (see ↵klink@chromium.org2008-10-094-12/+14
| | | | | | | | | | CPBrowsingContextManager for example of this type of fix). Also fixes small style issue, to be consistent with other Singleton implementations. Review URL: http://codereview.chromium.org/6282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3078 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ICU build problems under Linux.erg@google.com2008-10-081-0/+4
| | | | | | | Review URL: http://codereview.chromium.org/6370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3077 0039d316-1c4b-4281-b951-d872f2087c98
* Move window_resources.h to chrome/views to remove bad dependency of ↵ben@chromium.org2008-10-087-9/+9
| | | | | | | | | | chrome/views on chrome/browser http://crbug.com/2395 Review URL: http://codereview.chromium.org/7002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3076 0039d316-1c4b-4281-b951-d872f2087c98
* Kinder, gentler (half-way-done) unforking.dglazkov@google.com2008-10-082-10/+10
| | | | | | | | See 6353 for its rougher, meaner twin. Review URL: http://codereview.chromium.org/6368 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3075 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes http://code.google.com/p/chromium/issues/detail?id=2472, whichananta@chromium.org2008-10-086-4/+55
| | | | | | | | | | | | | | | | | | is an issue with popups displayed by the flash plugin in response to a user click, getting blocked. The plugin invokes NPN_Evaluate to execute the javascript. It also invokes the NPN_PushPopupEnabledState/NPN_PopupEnabledState API's to set the popup enabled stack for the duration of the call. The fix is to add the plumbing in NPN_Evaluate to pass in a flag indicating whether popups are allowed for the duration of the call. Bug=2472 Review URL: http://codereview.chromium.org/6562 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3074 0039d316-1c4b-4281-b951-d872f2087c98
* Allow lang to be blank in the renderer and plugin if running intc@google.com2008-10-081-2/+5
| | | | | | | single process mode. Review URL: http://codereview.chromium.org/5602 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3073 0039d316-1c4b-4281-b951-d872f2087c98
* Constrained window title text colors are inverted.ben@chromium.org2008-10-081-1/+1
| | | | | | | http://crbug.com/3249 Review URL: http://codereview.chromium.org/6367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3072 0039d316-1c4b-4281-b951-d872f2087c98
* Always position and size the toolbar view, since it's used to position other ↵ben@chromium.org2008-10-081-17/+18
| | | | | | | | | | elements. Regression from changelist earlier today. Review URL: http://codereview.chromium.org/6365 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3071 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Gears build:mpcomplete@google.com2008-10-082-1/+5
| | | | | | | | | - remove accidental print statement. - add a check that the p4 tree is checked out where we expect it, and if not, exit. Review URL: http://codereview.chromium.org/6598 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3070 0039d316-1c4b-4281-b951-d872f2087c98
* Add a flaky layout test to exceptions.ericroman@google.com2008-10-081-1/+2
| | | | | | Review URL: http://codereview.chromium.org/6599 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3069 0039d316-1c4b-4281-b951-d872f2087c98