| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL handles the chromium subdir, but not google_chrome.
pngcrush v1.7.15 removes txt/xml/time chunks with switches:
-reduce -brute -rem iTXt -rem tEXt -rem zTXt -rem tIME
pngslim v1.0.1 runs a battery of compression operations.
The size difference reported uploading Patch Set 2 is:
Before: 1,293,629 bytes
After: 966,999 bytes
Delta: 326,630 bytes
Rietveld diff and try job patches fail, local build is fine.
BUG=76282
TEST=same images, less bytes.
Review URL: http://codereview.chromium.org/7782022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7859003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this mainly just fixes the bookmark header bar
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/7854003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is temporary. I think having them in a separate file is too much
maintenance overhead. So I plan on following up with extending grit to handle
this. I want to go ahead and get this in to fix people's build and
so the encoding change for pak files can go in.
Review URL: http://codereview.chromium.org/7856001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61753
TEST=none
Review URL: http://codereview.chromium.org/7849009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=89295
TEST=none
Review URL: http://codereview.chromium.org/7845014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also check return value of GetWindowPlacement()
BUG=95538
TEST=Dr. Memory no longer reports errors on PreferenceServiceTest.PreservedWindowPlacementIsMigrated
Review URL: http://codereview.chromium.org/7847025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=63182
TEST=none
Review URL: http://codereview.chromium.org/7851015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=95357
TEST=Launch Chrome and confirm when ntp4 bubble is not shown, there is no console warning for missing value.
Review URL: http://codereview.chromium.org/7754021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
flaky. Fixes for flakiness in other tests have fixed the
known causes for its flakiness, and it has not had a failure
on the flakiness dashboard for over a week.
TEST=PrerenderBrowserTest.PrerenderInfiniteLoop
BUG=83170
Review URL: http://codereview.chromium.org/7837036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:17308
TEST=manual
Review URL: http://codereview.chromium.org/7850013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
State wasn't getting translated into classic state for drawing.
BUG=88930
TEST=Put Windows into classic theme (hey, some people do), press on a scrollbar arrow - before, nothing, after this change, gets pressed.
Review URL: http://codereview.chromium.org/7849007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=dennisjeffrey@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7853002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:90037
TEST=manual
Review URL: http://codereview.chromium.org/7808001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=87821
TEST=Try the app in another language.
Review URL: http://codereview.chromium.org/7795063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
loading of cookies from the IO thread.
They are now loaded on the DB thread. Cookie operations received in the meantime are queued and executed, on the IO thread, in the order they were received, when loading completes.
A few straggler clients are updated to use the asynchronous CookieStore/CookieMonster API as part of this CL, as the synchronous API is removed.
BUG=68657
TEST=net_unittests / DeferredCookieTaskTest.* and CookieMonsterTest.*
Review URL: http://codereview.chromium.org/7833042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move libcros calls from ImplBase::DeleteRememberedNetwork to ImplCros
* change NOTREACHED to warning (getting triggered on non-fatal flimflam restart)
* add DCHECK to callbacks to help track down crosbug.com/20099
BUG=none
TEST=tests + autotests pass
Review URL: http://codereview.chromium.org/7848005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IsTypeEncrypted() and IsSynced() are both changed when by a
WriteTransaction on the syncer thread. When IsTypeEncrytped() gets
toggled from false to true, that should imply that IsSynced() is false
(at least until a sync cycle comes along and commits the changes to
the server).
Sometimes the thread executing this code will see the value of IsSynced()
before the transaction (true) and IsTypeEncrypted after the transaction
(true). This is bad, because we end up inside the if branch when
IsSynced() is false, which is not the intent of this code.
A proper fix might involve wrapping the entire if condition in a
ReadTrasaction. An easier fix is to swap the order in which the
conditions are evaluated, and that's what this commit does.
BUG=95619
TEST=
Review URL: http://codereview.chromium.org/7847010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
since r63609.
BUG=32356
TEST=none
TBR=hclam@chromium.org
Review URL: http://codereview.chromium.org/7849022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
added for bug 95760).
BUG=89942,95760
R=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/7850022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=19983
TEST=see bug description
Review URL: http://codereview.chromium.org/7834024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=estade
TEST=pass check_perms buildbot.
BUG=None
Review URL: http://codereview.chromium.org/7846021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove unnecessary includes from ui/base/models/accelerator.h.
BUG=93945
TEST=none
Review URL: http://codereview.chromium.org/7848011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome as these are sent and processed by
chrome. These messages are now prefixed with "Chrome"
To handle the ChromeViewMsg_GetFPS message in the ChromeRenderViewObserver object we need to expose the value
of the filtered_time_per_frame member in the RenderWidget class. Added a getter to achieve that.
Continuing changes to ensure that IPCs don't span across content and chrome.
BUG=87335
Review URL: http://codereview.chromium.org/7754004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
disabled in the NaCl repo, so that on NaCl-side we could re-enable
them to gather info from the NaCl bots.
Review URL: http://codereview.chromium.org/7795039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
OfflineMessageScreen's offline/online event handle triggers extension reload. This could come in before automation's injected login comes back and disrrupt automation. Since extension already has a logic to reload Gaia, this logic is redundant and thus remove it.
BUG=chromium-os:20167
TEST=Verify suite_Smoke no longer has login flakyness.
Review URL: http://codereview.chromium.org/7847029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a simple, non-localized debug page to show the output of
the OOM-adjust algorithm, in preparation for discarding a tab in
low memory situations. See "Out of memory handling" Chrome OS
design doc for details.
BUG=chromium-os:18375
TEST=open 3 tabs and navigate to web pages, wait 10 seconds, then open a tab to "about:discards". It should list 3 tabs and itself. Order is unimportant for now.
Review URL: http://codereview.chromium.org/7754002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
notifying the UI layer of the failure which then calls ShutDown.
BUG=93313
TEST=manually by simulating a store load failure.
Review URL: http://codereview.chromium.org/7846005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7828019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. bring device back to normal from bad state by querying all controls.
2. call ioctl with VIDIOC_TRY_FMT twice.
3. incorporate change from http://codereview.chromium.org/7753002/. "Improve stability when using a Logitech 9000 camera on Linux.
Changed so that the device driver is opened and closed on the same thread as all the v4l2 calls."
BUG=94134
TEST=
Review URL: http://codereview.chromium.org/7743002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:18744
TEST=manual
Review URL: http://codereview.chromium.org/7739028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also fix file permissions.
Review URL: http://codereview.chromium.org/7850004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=19987
TEST=See bug description.
Review URL: http://codereview.chromium.org/7800030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also made the animation faster as requested in the bug.
BUG=chromium-os:19686
TEST=manual
Review URL: http://codereview.chromium.org/7754012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove cookies both when entering and leaving the enrollment screen.
BUG=None
TEST=Enrollment still works.
Review URL: http://codereview.chromium.org/7835034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=95601
TEST=tree green, no thread IO op violation in debug build.
Review URL: http://codereview.chromium.org/7840034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Linux clang bot goes green
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/7848023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7850017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
mmap it in a 32-bit process with PIE on. There may not be a big enough gap in
the address space to mmap it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7840040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
about:rotate?right. The about handler fires orientation events that the TouchBrowserFrameView is listening for. When notified, the TBFV either rotates itself, or the views desktop (if it is active). The animation code lives in views/animation and knows nothing about sensors.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7273073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=81825
TEST=none
Review URL: http://codereview.chromium.org/7837038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Most were already marked as flaky, but they're still
turning the tree red. Also update the bug number.
BUG=95246
TEST=WebstoreInlineInstallTest.*
Review URL: http://codereview.chromium.org/7846016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a style guide violation where classes were inheriting from more than one non-pure interface. This refactoring is in preparation for having OSX use a similar code path.
Also some minor fixes to GLXImageTransportSurface:
- disable vsync in OnMakeCurrent because we are actually rendering offscreen via XComposite
- wait for SwapBuffersACK before processing more commands for flow control
BUG=none
TEST=3D CSS on TOUCH_UI build
Review URL: http://codereview.chromium.org/7839033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The code in question that was suppressed no longer exists in the current version.
BUG=46420
TEST=none
Review URL: http://codereview.chromium.org/7754013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=95641
TEST=none
Review URL: http://codereview.chromium.org/7795047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dialogs. This restriction is imposed by not being able to merge tab
contents with a pending navigation (auth dialogs result in a pending
navigation until the user authenticates).
BUG=89439
TEST=with instant enabled try a page that loads an auth dialog, make
sure you only see the dialog when you press enter.
R=cbentzel@chromium.org,jam@chromium.org
Review URL: http://codereview.chromium.org/7848007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=bruening
TEST=remove all DrM suppressions, then `tools\valgrind\chrome_tests.bat --tool drmemory -t base --gtest_filter="ToolsSanity*"`
Review URL: http://codereview.chromium.org/7849014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=95502
TEST=The leak isn't reported again
Review URL: http://codereview.chromium.org/7754009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=92264
TEST=None
R=willchan@chromium.org
Review URL: http://codereview.chromium.org/7846007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=47049
TEST=DatabaseTrackerTest.DatabaseTrackerClearSessionOnlyDatabasesOnExit
Review URL: http://codereview.chromium.org/7800040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100135 0039d316-1c4b-4281-b951-d872f2087c98
|