summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Adds cleanup code to RLZ so that we don't leak an OmniBoxUsageObserversky@google.com2009-01-283-1/+29
| | | | | | | | | | | | on shutdown. This came up in running in process ui tests through purify. BUG=none TEST=none Review URL: http://codereview.chromium.org/19428 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8830 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in adding a menu item. As far as I can tellsky@google.com2009-01-281-0/+9
| | | | | | | | | | | | | | | l10n_util::GetString(IDS_TASK_MANAGER) is returning "". Tony, myself and Rahul don't think this should be possible, yet we have crashes indicating otherwise. If IDS_TASK_MANAGER returns an emtpy string then menu derefs NULL and we crash. BUG=6206 TEST=no way to directly test this, instead just make sure menus still work. Review URL: http://codereview.chromium.org/19434 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8829 0039d316-1c4b-4281-b951-d872f2087c98
* Better control over window creation of external tabsjoshia@google.com2009-01-288-18/+44
| | | | | | | | | | | Improving automation interface to offer better control over window creation of external tabs. The changes allow us to specify a parent window, initial size and window style. Review URL: http://codereview.chromium.org/19048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8828 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 8822.brettw@chromium.org2009-01-285-167/+83
| | | | | | Review URL: http://codereview.chromium.org/19439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8827 0039d316-1c4b-4281-b951-d872f2087c98
* This prevents an occasional DCHECK seen during the SSL UI test that happenedcreis@google.com2009-01-284-17/+42
| | | | | | | | | | | | | | | | | | | | | | because of the unresponsive tab logic. If we are short-cutting a slow beforeunload handler, we now avoid a redundant call to SetNavigationsSuspended. Also clarified a few comments, removed what appeared to be an unnecessary call to DidNavigateMainFrame, and re-enabled tests that were likely disabled due to this issue. BUG=6950 BUG=6698 TEST=SSLUITest.TestHTTPSExpiredCertAndDontProceed --single-process TEST=SSLUITest.TestHTTPWithBrokenHTTPSResource TEST=SSLUITest.TestOKHTTPS TEST=SSLUITest.TestHTTPSExpiredCertAndProceed Review URL: http://codereview.chromium.org/19006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8826 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS to pick up eol-style changes.dglazkov@google.com2009-01-281-1/+1
| | | | | | | | TBR=glen Review URL: http://codereview.chromium.org/19440 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8825 0039d316-1c4b-4281-b951-d872f2087c98
* Add ScopedTempDir - a class that manages the lifetime of a temporary directory.erikkay@google.com2009-01-287-0/+177
| | | | | | Review URL: http://codereview.chromium.org/19411 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8824 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out the common parts of the about network dialog. I will be using thisbrettw@chromium.org2009-01-285-83/+167
| | | | | | | for the about IPC dialog next. Review URL: http://codereview.chromium.org/19433 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8822 0039d316-1c4b-4281-b951-d872f2087c98
* Disconnect the "browser controlled printing" and always delegate the control ↵maruel@chromium.org2009-01-287-73/+21
| | | | | | | | | flow to the renderer. Followup changes will remove more parts that are not needed anymore. Review URL: http://codereview.chromium.org/18860 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8821 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that windowed plugins get keyboard focus in WM_MOUSEACTIVATe. This ↵ananta@chromium.org2009-01-281-0/+3
| | | | | | | | | | | | | | regressed with the introduction of the Plugin wrapper window which parents the actual plugin window in the plugin process. We need to set focus to the actual plugin window when we receive a WM_MOUSEACTIVATE in the browser caused by a click on the plugin window. This fixes http://code.google.com/p/chromium/issues/detail?id=7143 Bug=7143 Review URL: http://codereview.chromium.org/19626 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8820 0039d316-1c4b-4281-b951-d872f2087c98
* Make WebContentsView portable by using the native view types.brettw@chromium.org2009-01-286-35/+40
| | | | | | Review URL: http://codereview.chromium.org/19632 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8819 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the ctor since it's in the shared file.thomasvl@chromium.org2009-01-281-4/+0
| | | | | | Review URL: http://codereview.chromium.org/19634 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8818 0039d316-1c4b-4281-b951-d872f2087c98
* Remove extrenuous DLOG from VisitedLinkMaster::InitFromFile()jeremy@chromium.org2009-01-281-3/+1
| | | | | | | | since it prints a confusing message on first run. Review URL: http://codereview.chromium.org/19429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8817 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of unnecessary region code from spellcheck language/locale codes. ↵sidchat@google.com2009-01-282-42/+69
| | | | | | | | | Fix of Linux by using ARRAYSIZE_UNSAFE instead of arraysize. Issue=Issue=6329 Review URL: http://codereview.chromium.org/18567 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8816 0039d316-1c4b-4281-b951-d872f2087c98
* Context menus for text selections in editable boxes and links should include ↵pkasting@chromium.org2009-01-2811-157/+138
| | | | | | | | the Search menu item. Original patch by Brian Duff (see http://codereview.chromium.org/16510 ), r=me. BUG=1925 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8815 0039d316-1c4b-4281-b951-d872f2087c98
* Some tests I rebaselined on Windows are now passing on Linux.finnur@google.com2009-01-281-7/+0
| | | | | | | | Marking as such. Review URL: http://codereview.chromium.org/19629 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8814 0039d316-1c4b-4281-b951-d872f2087c98
* Add RenderProcessHost to the mac build (it's already in Linux).brettw@google.com2009-01-281-15/+29
| | | | | | Review URL: http://codereview.chromium.org/19627 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8813 0039d316-1c4b-4281-b951-d872f2087c98
* This test checks the JS notifications when loading a frame.jcampan@chromium.org2009-01-282-2/+2
| | | | | | | | This CL reverts the previous base-lining in the results, as the notifications order is now as expected. We still need to have a baseline because of some font related size inaccuracies in the DOM dump. Review URL: http://codereview.chromium.org/19406 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8811 0039d316-1c4b-4281-b951-d872f2087c98
* Makes unit tests depend upon chrome_exe.sky@google.com2009-01-283-0/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/19432 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8810 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/19042jcampan@chromium.org2009-01-281-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8809 0039d316-1c4b-4281-b951-d872f2087c98
* Sorts the sln files. chrome_kjs is already sorted, just not chrome.sky@google.com2009-01-281-1753/+1753
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/19430 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8808 0039d316-1c4b-4281-b951-d872f2087c98
* In WebKit r39791 Glenn Wilson changed radio buttonsfinnur@google.com2009-01-282-2/+7
| | | | | | | | | | | | | | so that they can be checked even if they don't have a name. Before, they were matching IE6 and early versions of IE7 but now match current IE7, IE8 and FF. Therefore, our expected results must reflect that the user can now focus the radio button.. Review URL: http://codereview.chromium.org/19408 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8807 0039d316-1c4b-4281-b951-d872f2087c98
* Write some basic RenderWidgetHost unittests for the more tricky behavior.brettw@chromium.org2009-01-286-1/+318
| | | | | | Review URL: http://codereview.chromium.org/19419 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8806 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of Pipeline and FilterHost interfaces. This is a large ↵ralphl@chromium.org2009-01-2817-152/+989
| | | | | | | | | | | | change, but all of the objects are interrelated. I am also checking in a basic unit test that creates pipeline, and the data source hangs during initialization. The test sleeps one second and then stops the pipeline. Andrew has already done a first pass on this, and the code has come largely from our working experimental branch. Review URL: http://codereview.chromium.org/18546 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8805 0039d316-1c4b-4281-b951-d872f2087c98
* Add portable keyboard codesphajdan.jr@chromium.org2009-01-285-0/+419
| | | | | | Review URL: http://codereview.chromium.org/19021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8804 0039d316-1c4b-4281-b951-d872f2087c98
* Update mac tests based on last 24 hours of build bot runs.thomasvl@chromium.org2009-01-281-15/+18
| | | | | | Review URL: http://codereview.chromium.org/19426 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8803 0039d316-1c4b-4281-b951-d872f2087c98
* Allow undefined as the script name in the debugger test.ager@google.com2009-01-281-1/+3
| | | | | | Review URL: http://codereview.chromium.org/19423 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8802 0039d316-1c4b-4281-b951-d872f2087c98
* It seems that the old version of the selection-functions test is stillager@google.com2009-01-281-0/+4
| | | | | | | | | used on the buildbot. The new version of the test cannot generate the output that is in the results downloaded from the buildbot. Marking as failing until the buildbot can be updated. Review URL: http://codereview.chromium.org/19621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8801 0039d316-1c4b-4281-b951-d872f2087c98
* Remove extraneous uses of the --enable-user-scriptaa@chromium.org2009-01-284-31/+11
| | | | | | | | | | switch. It's better to check this at one chokepoint (initialization) and let the rest of the code work the same, but end up as no-ops. Review URL: http://codereview.chromium.org/18401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8800 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing returns in setters for selectionStart and selectionEnd.ager@google.com2009-01-283-23/+19
| | | | | | | | | Added error messages to exceptions. Remove passing test from test list. Review URL: http://codereview.chromium.org/19421 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8799 0039d316-1c4b-4281-b951-d872f2087c98
* Add sqlite to list of things to build.thestig@chromium.org2009-01-282-2/+11
| | | | | | | | Follow up to issue 19041/r8767. Building with SHARED=1 --mode=opt got errors with missing sqlite. Move sqlite append from chrome/SConscript to build/SConscript.main. Review URL: http://codereview.chromium.org/19615 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8798 0039d316-1c4b-4281-b951-d872f2087c98
* Safe browsing cleanup:estade@chromium.org2009-01-2817-58/+94
| | | | | | | | | * wstring -> FilePath * create versions of WriteFile/ReadFile with FilePath signatures Review URL: http://codereview.chromium.org/19610 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8797 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a variable indicating whether resources should be deleted onsky@google.com2009-01-282-1/+8
| | | | | | | | | | | | | shutdown. Normally it's true, but I'm going to set it to false for in process ui tests. I can't delete the ResourceBundle for these tests as many classes cache SkBitmaps from the resource bundle in statics. BUG=none TEST=none Review URL: http://codereview.chromium.org/19609 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8795 0039d316-1c4b-4281-b951-d872f2087c98
* Rolback r8793: Remove extraneous uses of the --enable-user-scriptmal@chromium.org2009-01-283-7/+29
| | | | | | | | | | | | | switch. It's better to check this at one chokepoint (initialization) and let the rest of the code work the same, but end up as no-ops. This seems to break ui_tests. Review URL: http://codereview.chromium.org/19418 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8794 0039d316-1c4b-4281-b951-d872f2087c98
* Remove extraneous uses of the --enable-user-scriptaa@chromium.org2009-01-283-29/+7
| | | | | | | | | | switch. It's better to check this at one chokepoint (initialization) and let the rest of the code work the same, but end up as no-ops. Review URL: http://codereview.chromium.org/18401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8793 0039d316-1c4b-4281-b951-d872f2087c98
* Move Windows specific backing-store functions into backing_store_win.ccagl@chromium.org2009-01-283-258/+7
| | | | | | | | | | | A previous change forked backing_store.cc into backing_store_win.cc. This patch trims both to leave the platform-independent functions in backing_store.cc and the Windows specific functions in backing_store_win.cc. Review URL: http://codereview.chromium.org/19605 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8792 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the localized oem html resources to setupcpu@google.com2009-01-282-12/+15
| | | | | | | | | | | - Only the ones required at this point - Requires official build BUG=1468838 Review URL: http://codereview.chromium.org/19416 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8791 0039d316-1c4b-4281-b951-d872f2087c98
* Process the EULA distro param, to direct chrome to show the EULA dialogcpu@google.com2009-01-281-0/+29
| | | | | | | | | | | | | - This is the EULA post installation case. Other cases possible. - Chrome waits forever until user dismises the dialog - Chrome will exit ipso-facto if user declines. BUG=1468838 Review URL: http://codereview.chromium.org/19601 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8790 0039d316-1c4b-4281-b951-d872f2087c98
* restore setting the netresource callbacktc@google.com2009-01-282-2/+3
| | | | | | | | | | this is needed in both the windows and linux build for loading directory listings. Review URL: http://codereview.chromium.org/19616 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8789 0039d316-1c4b-4281-b951-d872f2087c98
* More break fixesjrg@chromium.org2009-01-281-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8787 0039d316-1c4b-4281-b951-d872f2087c98
* Another merge conflictjrg@chromium.org2009-01-281-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8786 0039d316-1c4b-4281-b951-d872f2087c98
* Merge conflict (crossed wires; this file was added somewhere else)jrg@chromium.org2009-01-281-1/+0
| | | | | | Review URL: http://codereview.chromium.org/19415 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8785 0039d316-1c4b-4281-b951-d872f2087c98
* Use fully qualified path to make it play nice on the buildbot.nsylvain@chromium.org2009-01-281-3/+3
| | | | | | http://codereview.chromium.org/19612 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8784 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline three tests that I baselined on Windows yesterday.tc@google.com2009-01-2812-104/+142
| | | | | | | | | | | Remove one test from the list that seem to be passing on the buildbot. Mark one test as flakey-- It doesn't seem to have anything to do with the merge according to the ~sandholm/layout/WebkitLinux_flips.html. Review URL: http://codereview.chromium.org/19402 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8783 0039d316-1c4b-4281-b951-d872f2087c98
* Unit test addition, cleanup for render_process/thread.jrg@chromium.org2009-01-289-29/+96
| | | | | | Review URL: http://codereview.chromium.org/19606 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8782 0039d316-1c4b-4281-b951-d872f2087c98
* Make purify happy by fixing memory leak that shows up during shutdown.kuchhal@chromium.org2009-01-281-0/+8
| | | | | | | | | BUG=6528 Review URL: http://codereview.chromium.org/19407 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8780 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac build after WebKit merge.jeremy@chromium.org2009-01-282-18/+22
| | | | | | Review URL: http://codereview.chromium.org/19608 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8779 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome side of WebKit Merge 40165:40297playmobil@google.com2009-01-2813-30/+123
| | | | | | Review URL: http://codereview.chromium.org/19603 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8776 0039d316-1c4b-4281-b951-d872f2087c98
* Add FilePath version of ReadFileToString.erikkay@google.com2009-01-282-1/+7
| | | | | | Review URL: http://codereview.chromium.org/19401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8774 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability to have browser windows shown with a specificsky@google.com2009-01-282-0/+16
| | | | | | | | | | | | state. I need this for in process ui tests. I can move this to be private and make the test a friend if you prefer. BUG=none TEST=none Review URL: http://codereview.chromium.org/19404 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8773 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-09 04:21:13 +0000