summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix for crash when changing frame on non-DWM systems.glen@chromium.org2009-06-031-0/+7
| | | | | | | | | BUG=13075 TEST=Reset the theme on XP and verify that it doesn't crash. Review URL: http://codereview.chromium.org/118171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17503 0039d316-1c4b-4281-b951-d872f2087c98
* Theme the download bar. Mostly this is just changing the background color to ↵glen@chromium.org2009-06-0340-4/+7
| | | | | | | | | | | match the toolbar, and making the button images transparent. BUG=11703 TEST=Verify that the download bar matches the theme that is installed. Review URL: http://codereview.chromium.org/119088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17502 0039d316-1c4b-4281-b951-d872f2087c98
* Increase cookie limit to 3000. This matches Firefox 3.5 and Firefox ↵pkasting@chromium.org2009-06-032-6/+6
| | | | | | | | trunk.BUG=8850 Review URL: http://codereview.chromium.org/118011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17501 0039d316-1c4b-4281-b951-d872f2087c98
* Theme our bookmark bar buttons.glen@chromium.org2009-06-033-6/+50
| | | | | | | | | BUG=12467 TEST=Apply a theme and verify that bookmark bar text colors changes. Review URL: http://codereview.chromium.org/112092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17500 0039d316-1c4b-4281-b951-d872f2087c98
* Removed focus manager references from the external tab container as we don't ↵ananta@chromium.org2009-06-032-26/+11
| | | | | | | | | | | | | need the focus manager to achieve tabbing in and out of the chrome frame widget. The other change is to add a check for a NULL container window when the tab contents is being freed. This causes an assert to fire in the focus manager code while trying to unsubclass the window. Review URL: http://codereview.chromium.org/119074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17499 0039d316-1c4b-4281-b951-d872f2087c98
* Disable -mdynamic-no-pic, the equivalent of enabling -fPIC, to allow most ofmark@chromium.org2009-06-031-0/+1
| | | | | | | | | | | the app to be moved into a framework in support of the multi-app-bundle approach. BUG=8044 TEST=-mdynamic-no-pic absent from build log, all tests pass Review URL: http://codereview.chromium.org/119090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17498 0039d316-1c4b-4281-b951-d872f2087c98
* Port 2 more unit tests. Just small differences between platforms.tc@google.com2009-06-033-8/+13
| | | | | | | | | | This allows password_form_manager_unittest.cc and search_provider_unittest.cc to run on linux/mac. Review URL: http://codereview.chromium.org/118137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17497 0039d316-1c4b-4281-b951-d872f2087c98
* Prepare V8NPObject.h/cpp for upstreaming.tim@chromium.org2009-06-034-215/+231
| | | | | | Review URL: http://codereview.chromium.org/115972 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17496 0039d316-1c4b-4281-b951-d872f2087c98
* Need to unpack setup.exe patch first before applying it to setup.exe.kuchhal@chromium.org2009-06-033-27/+63
| | | | | | | | | | BUG=12832 TEST=Build a mini_installer that has setup.exe patch only and make sure the installer still works. Review URL: http://codereview.chromium.org/118144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17495 0039d316-1c4b-4281-b951-d872f2087c98
* Make mini_installer changes for 3 stage updates.kuchhal@chromium.org2009-06-034-160/+231
| | | | | | | | | | BUG=12832 TEST=Build a mini_installer that has setup.exe patch only and make sure the installer still works. Review URL: http://codereview.chromium.org/115839 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17494 0039d316-1c4b-4281-b951-d872f2087c98
* Modify script that creates differntial installer to support 3stage update ↵kuchhal@chromium.org2009-06-033-125/+179
| | | | | | | | | | | | installer. BUG=12832 TEST=While building mini_installer try various values of DiffAlgorithm and SetupExeFormat property and make sure generated installer works. Review URL: http://codereview.chromium.org/114073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17493 0039d316-1c4b-4281-b951-d872f2087c98
* Fix browser hang due to plugin deadlockamit@chromium.org2009-06-037-30/+111
| | | | | | | | | | | | | | | | | | | | | This involves two plugin instances with second instance making sync calls to the renderer while the first one is still servicing an incoming sync request. Our logic to unblock the renderer during the sync call fails since the 'in_dispatch_' counter is maintained per plugin channel (each plugin instance uses its own separate channel). Making 'in_dispatch_' counter static member of PluginChannelBase fixes this deadlock. Added a new NPAPI UI test for this scenario. BUG=12624 TEST=MultipleInstancesSyncCalls Review URL: http://codereview.chromium.org/119052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17492 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor print functionality in RenderView. Moved most of the print ↵sverrir@google.com2009-06-036-238/+393
| | | | | | | | | | | functionality to a new class that will later be the base for asynchronous printing support. This is to make further changes to printing easier. There is no functional change and the code continues to be tested through the RenderView tests. Review URL: http://codereview.chromium.org/99368 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17491 0039d316-1c4b-4281-b951-d872f2087c98
* Remove fixed crash 13078 from known list.huanr@chromium.org2009-06-031-6/+0
| | | | | | Review URL: http://codereview.chromium.org/119087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17490 0039d316-1c4b-4281-b951-d872f2087c98
* Linux bookmark manager first cut.estade@chromium.org2009-06-0314-56/+434
| | | | | | | | Also add icons to bookmark tree model. Review URL: http://codereview.chromium.org/118150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17489 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "This is the first of probably several patches trying to clean up the ↵erg@google.com2009-06-0317-790/+671
| | | | | | | | | | | BlockedPopupContainer into something that can be cross-platform." This reverts commit 0247f4d628f8f56c0a42ab44efd1d29058167a11 (r17483). Review URL: http://codereview.chromium.org/118166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17485 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo in the UMR filter file from:erikkay@google.com2009-06-031-18/+18
| | | | | | | | | | http://codereview.chromium.org/118139 TBR=aa Review URL: http://codereview.chromium.org/119084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17484 0039d316-1c4b-4281-b951-d872f2087c98
* This is the first of probably several patches trying to clean up the ↵erg@google.com2009-06-0317-671/+790
| | | | | | | | | | | BlockedPopupContainer into something that can be cross-platform. - BlokedPopupContainers are no longer ConstrainedWindows. - There is now a cross platform base class that contains most of the model/controller logic. The view now inherits from it. This is an improvement. Review URL: http://codereview.chromium.org/119006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17483 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Windows compile.phajdan.jr@chromium.org2009-06-031-0/+1
| | | | | | | | TBR=maruel Review URL: http://codereview.chromium.org/119083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17480 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in base/phajdan.jr@chromium.org2009-06-0336-22/+64
| | | | | | | | Also adds more explicit #includes for needed things. Review URL: http://codereview.chromium.org/118162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17479 0039d316-1c4b-4281-b951-d872f2087c98
* Fix client coordinates when forwarding mouse events to RenderWidgetHostView ↵erikkay@google.com2009-06-031-1/+12
| | | | | | | | | | | | | | parents. A commit on behalf of tangjie: (already reviewed) http://codereview.chromium.org/113671 BUG=http://code.google.com/p/chromium/issues/detail?id=11901 TEST=click anywhere in the extension bar and note whether this also gets counted as a click on the tab that's directly above it veritcally. Review URL: http://codereview.chromium.org/119065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17478 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented a large chunk of the "user data" panel. Hooked the "under the ↵pinkerton@chromium.org2009-06-033-198/+478
| | | | | | | | | | hood" view into the window. BUG=13151 TEST=enabled portions of the user data panel. Review URL: http://codereview.chromium.org/119060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17475 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Catch up with InspectorController changes.pfeldman@chromium.org2009-06-038-2/+123
| | | | | | Review URL: http://codereview.chromium.org/119077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17474 0039d316-1c4b-4281-b951-d872f2087c98
* Implement InspectorClient's Settings API.pfeldman@chromium.org2009-06-0316-7/+157
| | | | | | | | | | | | | | | This CL implements InspectorClient's API for reading / writing inspector settings. Here is how this is done: - inspector_client_impl.cc caches / serializes preferences into raw strings. It supports all kinds of settings except for string vector. I did not implement it since a) it requires more escaping b) I think we should get rid of it upstream. It then passes serialized settings string over IPC. - There is a dedicated IPC message called UpdateInspectorSettings that takes care of settings update. Two things I don't like: 1) reading settings and writing settings follow different paths: WebPreferences interface for read, delegate -> IPC for write. WebPreferences on read is used since these settings are needed very early in the page cycle. delegate -> IPC on write is the only option. 2) this looks like too much code on the Chrome side for functionality like this. Is there a more generic way of settings and persisting WebKit's preferences in Chrome? Should there be one? Review URL: http://codereview.chromium.org/119041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17473 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the base for the BookmarkBubble UI.deanm@chromium.org2009-06-035-22/+94
| | | | | | | | | | | Additionally set the transient on the InfoBubble dialog window. BUG=11738 Review URL: http://codereview.chromium.org/119042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17472 0039d316-1c4b-4281-b951-d872f2087c98
* Make LinkButtonGtk into a real widget (GtkChromeLinkButton).deanm@chromium.org2009-06-039-190/+217
| | | | | | | | | | This means there are no longer two objects to keep around, the widget and the wrapper C++ object. This simplifies ownership in hierarchies. Review URL: http://codereview.chromium.org/118116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17471 0039d316-1c4b-4281-b951-d872f2087c98
* Headers cleanup in chrome/browser/phajdan.jr@chromium.org2009-06-0357-47/+76
| | | | | | | | | | | - reduce header dependencies - miscellanous cleanups (add missing includes for OS_ defines etc) Further changesets may follow. I was only looking at header files up to character_encoding.h. Review URL: http://codereview.chromium.org/118072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17470 0039d316-1c4b-4281-b951-d872f2087c98
* Removes the following deprecated functions:ojan@chromium.org2009-06-034-50/+29
| | | | | | | | | | | | | | | | file_util::InsertBeforeExtension(wstring*, wstring&) file_util::PathComponents(wstring&, vector<wstring>*) file_util::ReplaceExtension(wstring*, wstring&) BUG=none TEST=manual test for importing IE bookmarks with some sub-directories. Original patch by tkent@google.com. See http://codereview.chromium.org/118109 r=ojan,estade git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17469 0039d316-1c4b-4281-b951-d872f2087c98
* Revert last checkin to fix resources in Release builds.sgk@chromium.org2009-06-0312-61/+65
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/119075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17468 0039d316-1c4b-4281-b951-d872f2087c98
* Convert to gyp generation of chrome_resources and chrome_strings.sgk@chromium.org2009-06-0312-65/+61
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/119061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17467 0039d316-1c4b-4281-b951-d872f2087c98
* Convert hunspell.lib to gyp generation.sgk@chromium.org2009-06-034-484/+18
| | | | | | | | | | Convert convert_dict to gyp generation. Combine Linux and Windows convert_dict targets. BUG=none TEST=none Review URL: http://codereview.chromium.org/114071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17466 0039d316-1c4b-4281-b951-d872f2087c98
* Convert crash_service and generate_profile to gyp generation.sgk@google.com2009-06-033-321/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/114074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17465 0039d316-1c4b-4281-b951-d872f2087c98
* Local text file with spaces in filename is urlencoded in tab titlemhm@chromium.org2009-06-0313-65/+107
| | | | | | | | | | | | | | When viewing a local text file with spaces in filename, it is still urlencoded. Filename should be displayed with spaces, not with urlencoding. It would be more user-friendly. Since net::FormatURL is already implemented, using it would be great. But it doesn't escape SPACES, just NORMAL, it doesn't even escape unicode. I plumbed out a unescapeurl that could be used whether we allow conversion of spaces or not. BUG=8775 (http://crbug.com/8775) TEST=Tested whether the input is escaped in the navigational context and ran the net tests New Review: http://codereview.chromium.org/118059 Review URL: http://codereview.chromium.org/56053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17462 0039d316-1c4b-4281-b951-d872f2087c98
* Stop compulsive crasher in respawn dialogcpu@google.com2009-06-032-21/+34
| | | | | | | | | | | | | | | - Users with CursorXP or FontExporer crash in MessageBoxW - leads to many crash reports within seconds solution: eat the fatal exception and exit silently. TEST = see the bug for instructions BUG = 12162 Review URL: http://codereview.chromium.org/118148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17461 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable DeleteURLAndFavicon test.agl@chromium.org2009-06-032-2/+2
| | | | | | | | | | This test was disabled because it started failing, however it's passing on the tryservers now so we'll give it another chance. BUG=9600 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17460 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/119067crogers@google.com2009-06-031-0/+13
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17459 0039d316-1c4b-4281-b951-d872f2087c98
* Refactored queue of audio_renderer_base to use scoped_refptrscherkus@chromium.org2009-06-032-9/+3
| | | | | | | -Changed typedef declaration for queue to deque of scoped_refptr to Buffers-Eliminated now unnecessary calls to AddRef() and Release()Original patch by kylep@google.comhttp://codereview.chromium.org/118122 Review URL: http://codereview.chromium.org/118147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17458 0039d316-1c4b-4281-b951-d872f2087c98
* Putting dependency on locales from chrome_exe.bradnelson@google.com2009-06-031-1/+1
| | | | | | | | | | | | This will allow people to hit f5 to build chrome.exe and get the locales too. BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/112091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17457 0039d316-1c4b-4281-b951-d872f2087c98
* Updating googleurl from 104 to 105.tommi@chromium.org2009-06-031-1/+1
| | | | | | | | This is to pull in change 118062 (http://codereview.chromium.org/118062). Review URL: http://codereview.chromium.org/119059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17454 0039d316-1c4b-4281-b951-d872f2087c98
* Switching gcapi to be gyp generated.bradnelson@google.com2009-06-034-275/+0
| | | | | | | | | | BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/118141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17453 0039d316-1c4b-4281-b951-d872f2087c98
* Convert worker.vcproj to gyp generation.sgk@google.com2009-06-032-172/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/118133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17452 0039d316-1c4b-4281-b951-d872f2087c98
* Cancel pending changes when navigating away from the NTP.jcampan@chromium.org2009-06-031-0/+2
| | | | | | | | BUG=12426 TEST=From the New Tab Page (NTP), click the Remove thumbnails link, remove thumbnails but don't press the Done button. Navigate to a URL (ex: www.google.com). Navigate to the NTP again, the thumbnails removed previously should still be showing. Also test that removal works properly when pressing the Done button. Review URL: http://codereview.chromium.org/118119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17451 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back this part of my earlier test. Looks like these tests are still ↵ben@chromium.org2009-06-021-2/+2
| | | | | | | | | | | | badly affected. TBR=sky BUG=none TEST=none Review URL: http://codereview.chromium.org/118140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17450 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix libevent bug.agl@chromium.org2009-06-021-1/+1
| | | | | | | | | | | | | r17436 exposed a libevent bug where an array is not resized to a large enough size when it's one element too short. This bug will be upstreamed to libevent. http://codereview.chromium.org/112089 BUG=11999 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17449 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few test_expectations related to my skia CL.senorblanco@chromium.org2009-06-021-0/+4
| | | | | | | | | BUG=http://crbug.com/13218 TEST=make tree greener TBR=tc git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17448 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing flush_cache (there were 2!!!!)bradnelson@google.com2009-06-021-26/+11
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/119064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17446 0039d316-1c4b-4281-b951-d872f2087c98
* -. Fix svn add in rebaselining tool and add more output warning messagesvictorw@chromium.org2009-06-023-6/+13
| | | | | | | | | | | -. Do not output failure if a test is rebaselining and missing expected files. BUG=none TEST=rebaselining tool Review URL: http://codereview.chromium.org/112083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17445 0039d316-1c4b-4281-b951-d872f2087c98
* Shush purify. This is a known bug in zlib.aa@chromium.org2009-06-021-0/+18
| | | | | | Review URL: http://codereview.chromium.org/118139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17444 0039d316-1c4b-4281-b951-d872f2087c98
* Converting flush_cache to be gyp generated.bradnelson@google.com2009-06-022-149/+0
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/118132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17443 0039d316-1c4b-4281-b951-d872f2087c98
* Adds linux2 variable and change to WidgetGtk to make it compile.sky@chromium.org2009-06-023-1/+8
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/119057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17442 0039d316-1c4b-4281-b951-d872f2087c98