| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=67514
TEST=
In the preview tab, note added options for printing headers and footers. Toggle with the checkbox and ensure that the correct headers and footers are displayed.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97219
Review URL: http://codereview.chromium.org/7348010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apparently it's possible to have empty BlockedRequestLists. When a profile (like the incognito profile) goes away, we iterate through the BlockedRequestLists making the assumption that the lists cannot be empty, and dereference the first element. Since this assumption is false, this causes a dereference of garbage. Therefore we fix this by checking for empty lists.
BUG=90200
TEST=See 90200 comment 7 for instructions on how to repro
Review URL: http://codereview.chromium.org/7627006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=vitalyr
Review URL: http://codereview.chromium.org/7671026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Instant field trial only triggers when UMA reporting is enabled, so there's
no need to set this preference anymore.
BUG=none
TEST=SearchProviderTest.*
Review URL: http://codereview.chromium.org/7649030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
Review URL: http://codereview.chromium.org/7670034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
as well as on URLRequestJob's NotifyDone event.
The primary motivation of this change is to log
CONTENT_DECODING_FAILED errors to the NetLog.
BUG=89648
TEST=none
Review URL: http://codereview.chromium.org/7604043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Skia
BUG=67514
TEST=
In the preview tab, note added options for printing headers and footers. Toggle with the checkbox and ensure that the correct headers and footers are displayed.
Review URL: http://codereview.chromium.org/7348010
TBR=aayushkumar@chromium.org
Review URL: http://codereview.chromium.org/7670045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:19284
TEST=Verify fix for chromium-os:19284.
Review URL: http://codereview.chromium.org/7669027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MockKeychain on Mac only allows for the deletion of passwords from the
end of the store (the last added password). This causes several of the
password sync integration tests to fail.
This patch selectively disables the tests that fail until MockKeychain
is fixed.
BUG=89808
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/7631031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
request_context_getter_.
New integration test to validate it will come later...
BUG=92334
Review URL: http://codereview.chromium.org/7583051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=92576
TEST=change policy from traversal enabled -> disabled while host is running and make sure it disconnects.
Review URL: http://codereview.chromium.org/7664006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=67514
TEST=
In the preview tab, note added options for printing headers and footers. Toggle with the checkbox and ensure that the correct headers and footers are displayed.
Review URL: http://codereview.chromium.org/7348010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Renamed nacl_helper to nacl_helper.so to reflect its true nature.
Attempt to add nacl_helper to chrome installer.
BUG=92964,nativeclient:480,nativeclient:2131
TEST=manual for now
Review URL: http://codereview.chromium.org/7624017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hidden behind -enable-web-intents commandline flag
BUG=none
TEST=Run Chromium with -enable-web-intents, go to content settings/manage exceptions, see UI
Review URL: http://codereview.chromium.org/7645034
TBR=groby@chromium.org
Review URL: http://codereview.chromium.org/7631030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
As is, if the policy is changed while we are reading the individual values from the registry, the notification will be silently dropped causing us to have a stale policy.
BUG=93146
TEST=none
Review URL: http://codereview.chromium.org/7671008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=91715
TEST=no
Review URL: http://codereview.chromium.org/7631026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=93260
TEST=None
TBR=ddorwin@chromium.org,dmichael@chromium.org
Review URL: http://codereview.chromium.org/7655029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
if present, PDF.plugin.
BUG=58310
TEST=none
Review URL: http://codereview.chromium.org/7659007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
bookmarks bar is toggled.
An example error:
Uncaught ReferenceError: bookmarkBarDetached is not defined
BUG=none
Review URL: http://codereview.chromium.org/7675001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This pulls in the following Native Client changes:
r6448: (dschuff) Optionally build llc and lli using nacl-gcc
r6449: (mseaborn) x86-64 Windows exception patch: Fix to use the correct patch sequence size
r6450: (dschuff) Fix bit name in naclsdk.py
r6451: (bbudge) Modify sel_memory functions to support pre-reserved sandbox memory on 32 bit
r6452: (bradnelson) Adding --nacl-newlib-only option to download toolchains to allow just newlib
r6453: (halyavin) Extend IRT with nacl_irt_resource_open interface.
r6454: (khim) bce41 Remove temporary DSO hack. Use open-resource call.
r6455: (bradnelson) Switch method use to check for toolchain revision so that it works on python2.5
r6458: (mseaborn) x86-64 Windows: Use a more correct assembly-code TLS access sequence
r6459: (halyavin) Updating dynamic library test for DSO
BUG=none
TEST=nacl_integration
Review URL: http://codereview.chromium.org/7655026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
request.
R=agl@chromium.org,rkn@chromium.org
BUG=88782
TEST=none
Review URL: http://codereview.chromium.org/7590017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
icon. Instead have it inform the download manager delegate, which asks the status updater for the progress.
BUG=82782
Review URL: http://codereview.chromium.org/7655022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ObjectProxy is used to access remote objects.
ExportedObject is used to export objects to other D-Bus
BUG=90036
TEST=run unit tests. The code is not yet used in Chrome.
Review URL: http://codereview.chromium.org/7491029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- The version of a updated componnent was not being updated upon succesful install
- a small memory leak.
BUG=61602
TEST=test included
Review URL: http://codereview.chromium.org/7631018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A minor change to the way we output the headers. This change moves the
defines which are used to name the interfaces and thier versions to the
top of the header, moving out of the @file block. This prevents them
from being 'spewed' in the documentation.
BUG= none
TEST= none
Review URL: http://codereview.chromium.org/7669001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=visual
Review URL: http://codereview.chromium.org/7661027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=93173
TEST=manual
Review URL: http://codereview.chromium.org/7655011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For a detailed description see part #1, http://codereview.chromium.org/6478005/
This CL fixes the bug fully on Mac.
BUG=61062
TEST=unit_tests, possibly more
Review URL: http://codereview.chromium.org/7660004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
hidden behind -enable-web-intents commandline flag
BUG=none
TEST=Run Chromium with -enable-web-intents, go to content settings/manage exceptions, see UI
Review URL: http://codereview.chromium.org/7645034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new user link in the avatar menu bubble wasn't working. The problem was that it hadn't been hooked up.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7671023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=glider
BUG=19775,92389,92571,93245,93250
Review URL: http://codereview.chromium.org/7624026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Implement SyncableServices in TemplateURLService. Add related unittests.
TEST=Ensure all TemplateURLService related unit tests pass. Ensure the HeapBots are happy!
BUG=15548
Review URL: http://codereview.chromium.org/7566036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first phase towards being able to replace Bookmark Editor with the WebUI Bookmark Manager as part of the GTK removal effort on ChromeOS. It does not yet have a means of selecting a folder to bookmark all of your tabs in and as such can't yet replace all calls to BookmarkEditor::Show.
BUG=None
TEST=Tested editing bookmarks from the popup bubble and bookmark bar in Linux and TouchUI builds.
Review URL: http://codereview.chromium.org/7572022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
preliminary spec.
BUG=92121
TEST=browser_tests --gtest_filter=FormStructureBrowserTest.DataDrivenHeuristics01
Review URL: http://codereview.chromium.org/7669014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=92667
TEST=manual
Review URL: http://codereview.chromium.org/7672006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 96593 (Original review URL http://codereview.chromium.org/7489019)
Fix up various browser tests not to use WaitForNavigation.
Now with corrected pdf browsertest
R=phajdan.jr@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7645001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's just one:
webkit/tools/test_shell/test_shell_mac.mm:311:26: error: incompatible pointer types sending 'WindowDelegate *' to parameter of type 'id<NSWindowDelegate>'
[-Werror,-Wincompatible-pointer-types]
[m_mainWnd setDelegate:[[WindowDelegate alloc] initWithWebView:web_view]];
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
webkit/tools/test_shell/test_shell_mac.mm:102:1: note: instance method 'initWithWebView:' is assumed to return an instance of its receiver type ('WindowDelegate *')
- (id)initWithWebView:(TestShellWebView*)view;
^
1 error generated.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7621034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when multiple
navigations are performed within IE + CF with some originating from IE and others within Chrome.
The CF active document implementation had some code to reuse the active document instance in case
a new CF navigation occurred within the current tab. This was for optimization, i.e. to ensure that
we don't tear down and create a new instance of Chrome. This basically messed up the document destruction
order causing the IE tab history to get populated with information coming from deleted active document
instances at times.
In any case this optimization is no longer necessary as we have a proxy cache maintained in the automation
client in CF which ensures that we don't inadvarently tear down and create new chrome instances.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=90424
BUG=90424
Review URL: http://codereview.chromium.org/7627005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=green mem bots
Review URL: http://codereview.chromium.org/7655025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DoTexImage2D. This fixes a regression where redefinition using
glTexImage2D of a texture that did not fit in the command buffer would
be silently skipped.
Thanks to gman for help with the unit test.
BUG=93150
TEST=GLES2DecoderTest.TexImage2DRedefinitionSucceeds
Review URL: http://codereview.chromium.org/7670033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=63443
TEST=unit_tests --gtest_filter=CreditCardFieldTest.*
Review URL: http://codereview.chromium.org/7655015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This pulls in the following Native Client changes:
r6425: (jvoung) Add tests for pnacl coordinator's error handling and tweak the error messages
r6426: (jvoung) Fix a bug in llc size tracker that made it only track the size of the first arch in the argument list.
r6427: (pdox) Add -r (-relocatable) support to pnacl-ld.
r6428: (ncbray) Defensively initialize NaClSrpcChannel data structures with NULL pointers.
r6429: (mseaborn) Ensure nacl_thread[] entry is not left set if thread creation fails
r6430: (khim) Bump DEPS to pull GLIBC with .so version != 6.
r6431: (eugenis) Update libc sonames in valgrind interceptors.
r6432: (mseaborn) x86-32 sandbox: Factor out duplicated code in nacl_syscall_32.S
r6433: (mark) Set mac_real_dsym to 1 for ppGoogleNaClPluginChrome.plugin in Breakpad-enabled
r6434: (dschuff) Update Chrome DEPS in NaCl
r6435: (kschimpf) Make 'ncval' and 'ncval_annotate' command line tools (for all platforms)...
r6436: (ncbray) nacl_integration: clean up SCons invocations
r6437: (kschimpf) Separate the (partial) decoder of the x86_32 validator into a separate library.
r6438: (mcgrathr) Get rid of IRT's private sbrk
r6439: (jvoung) Disable the bad_pexe_undefined_syms in pnacl_bad_test.html until
r6440: (krasin) service_runtime: remove unused max_data_alloc field from NaClApp.
r6441: (kschimpf) Generates a set of decoder tables targeted to the needs of the
r6442: (jvoung) Fix typo in toolchain perf graph format. Otherwise we can't track
r6444: (krasin) service_runtime: remove unused NaClClosure and nacl_closure.c.
r6445: (thestig) Cleanup - base/scoped_ptr.h -> base/memory/scoped_ptr.h.
r6446: (dschuff) Loosen perf regression bounds on Linux MakeDynText time
r6447: (mcgrathr) Make chrome_browser_tests work with irt=0 again
BUG=none
TEST=nacl_integration
Review URL: http://codereview.chromium.org/7655007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Link is no longer necessary as discussed in email thread. Users can just switch away from the page or install an app to make the promo go away.
BUG=92524
TEST=manual
Review URL: http://codereview.chromium.org/7662001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=87457
TEST=none
R=dilmah
TBR=zea
Review URL: http://codereview.chromium.org/7624007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=91397
TEST=
Review URL: http://codereview.chromium.org/7637008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
inside the keys.
Also shorten the descriptions for Ctrl+Left and Ctrl+Right.
BUG=chromium-os:19022
TEST=Manually on chromebook
Review URL: http://codereview.chromium.org/7669015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=88613
TEST=Visit google.com. Type "foo@google.com" into the address bar and make sure the default action is search, not navigate.
Review URL: http://codereview.chromium.org/7606020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97165 0039d316-1c4b-4281-b951-d872f2087c98
|