summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Remove an unused bool member variable "opened_" from StatsTable.deanm@chromium.org2009-03-181-6/+6
| | | | | | | Review URL: http://codereview.chromium.org/48129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11956 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 11946 since it is causing a build breakage on full rebuild. The maruel@chromium.org2009-03-183-6/+128
| | | | | | | | | | sandbox project wasn't copying wow_helper.exe anymore, causing a build breakage on x64 platforms only. TBR=bnelson Review URL: http://codereview.chromium.org/42328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11955 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 11953.hbono@chromium.org2009-03-1815-241/+1
| | | | | | Review URL: http://codereview.chromium.org/48121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11954 0039d316-1c4b-4281-b951-d872f2087c98
* A tricky fix for Issue 1845.hbono@chromium.org2009-03-1815-1/+241
| | | | | | | | | | | | | | | | | This change is a very tricky fix for Issue 1845 in chromium: cant alignt text to the right using right shift and right ctrl.This change consists of two parts listed below. 1. Emulating the implementation of Safari that changes the text-direction of an input element. Safari uses context menus to change the text direction. This change adds an IPC message 'ViewMsg_SetTextDirection', which notifies the new text direction. Also, it adds two functions: RenderWidgetHost::UpdateTextDirection() and RenderWidgetHost::NotifyTextDirection(). They encapsulate the new IPC message so that we can use them both when we presses a set of keys and when we add context-menu items which change the text direction. 2. Calling the above interface when pressing right-shift and right-control keys, or when left-shift and left-control keys. This modifies the RenderWidgetHostViewWin::OnKeyEvent() function and call the above text-direction interfaces when a user finishes pressing the keys. As you can imagine, if we send an IPC message every time when we receive a WM_KEYDOWN event, we continue sending IPC messages while a user is pressing the keys. BUG=1845 Review URL: http://codereview.chromium.org/39252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11953 0039d316-1c4b-4281-b951-d872f2087c98
* Make worker constructor return error if it is enabled by the flag.jianli@chromium.org2009-03-184-1/+23
| | | | | | | This is to move corresponding files out of http://codereview.chromium.org/48106/ so that this can be checked in before the change to enable worker. The reason for doing this is to avoid build break since the already checked-in third_party/WebKit/WebKit/chromium/src/WebKit.cpp has the ifdef guarded code depend on this. Review URL: http://codereview.chromium.org/42313 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11952 0039d316-1c4b-4281-b951-d872f2087c98
* Quick fix to prevent double launch of chrome at install.cpu@google.com2009-03-181-1/+3
| | | | | | | | | | | - According to docs we should not be writing InstallerSuccessLaunchCmdLine - Might affect gcapi BUG=1719600 Review URL: http://codereview.chromium.org/48120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11950 0039d316-1c4b-4281-b951-d872f2087c98
* Moving sbox to gyp on windows.bradnelson@google.com2009-03-183-128/+6
| | | | | | | | | (Also fixing missing property on sdch.) Review URL: http://codereview.chromium.org/42317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11946 0039d316-1c4b-4281-b951-d872f2087c98
* - Modify DOM checker automation to use DOM Automation Controller instead ofpatrick@chromium.org2009-03-1810-143/+737
| | | | | | | | | | | | | | | | | cookie values to get results back to the test executable. This fixes an issue where the test could not be automated to run from local disk - that required file cookies, which causes the DOM checker test to fail. This is also a cleaner approach. - Add test to run DOM checker automation from local disk. - Add code to optionally disable file cookies in UI tests. Disable them in the DOM checker tests. - Add a function to the UITest class that allows a test to wait for a JavaScript condition in the test page. BUG=6274 Review URL: http://codereview.chromium.org/48055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11945 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing subtle dependency on client name on my last change to chrome.sln.bradnelson@google.com2009-03-181-1/+1
| | | | | | Review URL: http://codereview.chromium.org/48119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11944 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline fail. Marking LayoutTests/fast/forms/searchfield-heights.html fixableaa@chromium.org2009-03-181-0/+1
| | | | | | | | | again. TBR Review URL: http://codereview.chromium.org/42315 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11943 0039d316-1c4b-4281-b951-d872f2087c98
* Switching net over to use gyp on windows.bradnelson@google.com2009-03-1815-2353/+1752
| | | | | | Review URL: http://codereview.chromium.org/48108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11942 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak in GetCertSubjectAltNamesOfType(). Found by valgrind.dkegel@google.com2009-03-181-0/+1
| | | | | | | | | | | | ERROR:root:Leak_DefinitelyLost malloc (ome/kcc/depot2-kcc-ts_valgrind-client/google_vendor_src_branch/valgrind/trunk/coregrind/m_replacemalloc/vg_replace_malloc.c:207) ... CERT_FindCertExtension (/usr/lib32/libnss3.so.1d) net::(anonymous namespace)::GetCertSubjectAltNamesOfType(CERTCertificateStr*, CERTGeneralNameTypeEnum, std::vector<std::string, std::allocator<std::string> >*) (net/base/x509_certificate_nss.cc:134) Review URL: http://codereview.chromium.org/48097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11941 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline LayoutTests\fast\forms\searchfield-heights-expected. Text input boxesaa@chromium.org2009-03-184-3/+2
| | | | | | | seem to be off by a tiny bit. Review URL: http://codereview.chromium.org/42304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11940 0039d316-1c4b-4281-b951-d872f2087c98
* Remove bogus DCHECKabarth@chromium.org2009-03-181-3/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11938 0039d316-1c4b-4281-b951-d872f2087c98
* SSLPolicy Fix: Step 8.abarth@chromium.org2009-03-184-144/+267
| | | | | | | | | | | Cleanup the SSLPolicy API. This should be the last reorganization patch. The next step should be the substantive changes. R=jcampan BUG=8706 Review URL: http://codereview.chromium.org/48091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11937 0039d316-1c4b-4281-b951-d872f2087c98
* Mac bookmark work. jrg@chromium.org2009-03-1832-240/+815
| | | | | | | | | | | | | | | | | | | | | - The bookmark menu is populated dynamically with bookmarks, including subfolders --> submenus. E.g. star something --> shows up in menu. Menu items are disabled but always present and current. - Always Show Bookmarks" menu now live; reads from / writes to preference, and shows correct "toggle state". - Bookmark bar on each tab, present if requested. (Currently an empty box). - Random stuff; e.g. bookmark prefs init moved to a x-plat location. This CL does not contain Cole's views. Bried english description of the nib file changes: - add a new view for the bookmark bar in the tab; hook it up to the controller - Many tag sets (e.g. View-->Always Show Bookmarks Bar now 40009) - Remove dummy bookmark menu items Review URL: http://codereview.chromium.org/46078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11936 0039d316-1c4b-4281-b951-d872f2087c98
* Pre-upstream cleaning of files - changing them to follow WebKit coding style.dimich@google.com2009-03-174-448/+416
| | | | | | Review URL: http://codereview.chromium.org/42308 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11935 0039d316-1c4b-4281-b951-d872f2087c98
* Mark LayoutTests/svg/custom/foreignObject-crash-on-hover.xml as DEFER.patrick@chromium.org2009-03-171-5/+5
| | | | | | Review URL: http://codereview.chromium.org/48104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11933 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r11926 which accidentally enabled workers.dimich@google.com2009-03-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11931 0039d316-1c4b-4281-b951-d872f2087c98
* Get v8_collection.h to match webkit coding standards inlevin@chromium.org2009-03-172-237/+205
| | | | | | | | preparation for upstreaming. Review URL: http://codereview.chromium.org/42294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11930 0039d316-1c4b-4281-b951-d872f2087c98
* Defers three more svg tests. I couldn't get coords-units-01-b.svg to crash, ↵sky@google.com2009-03-171-9/+7
| | | | | | | | | | | and it doesn't look like it has crashed on the bots recently either. BUG=none TEST=none Review URL: http://codereview.chromium.org/48107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11929 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded uses of base/hash_tables.h.thestig@chromium.org2009-03-174-4/+0
| | | | | | Review URL: http://codereview.chromium.org/48098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11928 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where an extension toolstrip would sometimes get added twice to thempcomplete@google.com2009-03-171-3/+11
| | | | | | | | | bookmark bar. The problem was that sometimes the EXTENSIONS_LOADED notification would get sent before we initialized the bookmark view (which adds the initial extension toolstrips). Review URL: http://codereview.chromium.org/42252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11927 0039d316-1c4b-4281-b951-d872f2087c98
* Remove exclusion on worker files on Mac and Linux since they are not ↵dimich@google.com2009-03-171-6/+1
| | | | | | | | | platform-specific. The Worker feature is still not enabled (ENABLE_WORKERS=0) Review URL: http://codereview.chromium.org/48101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11926 0039d316-1c4b-4281-b951-d872f2087c98
* Merge DOMUIContents into WebContents.brettw@chromium.org2009-03-1748-1226/+1189
| | | | | | | I did a lot of cleanup of the DOM UI system as part of this. Review URL: http://codereview.chromium.org/42227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11925 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash on showing info bubble.sky@google.com2009-03-171-6/+4
| | | | | | | | | BUG=8854 TEST=see bug Review URL: http://codereview.chromium.org/42302 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11924 0039d316-1c4b-4281-b951-d872f2087c98
* Re-baseline LayoutTests\security\block-test-expected.txt.patrick@chromium.org2009-03-173-4/+134
| | | | | | | | | | This test differs in type names, error codes, and GURL canonicalization. Allow the test to fail on Linux and Mac because it requires an FTP implementation. Review URL: http://codereview.chromium.org/46025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11923 0039d316-1c4b-4281-b951-d872f2087c98
* Remove pending/fast/events. There's no tests left here. :)ojan@google.com2009-03-171-15/+0
| | | | | | Review URL: http://codereview.chromium.org/48051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11922 0039d316-1c4b-4281-b951-d872f2087c98
* Roll deps to bring in latest webkit.sky@google.com2009-03-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11921 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaselines the test LayoutTests/fast/block/positioning/001.html . sky@google.com2009-03-173-2/+3
| | | | | | | | | | | | The test was rebaselined upstream, see http://trac.webkit.org/browser/trunk/LayoutTests/platform/mac/fast/block/positioning/001-expected.png . BUG=none TEST=none Review URL: http://codereview.chromium.org/42305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11920 0039d316-1c4b-4281-b951-d872f2087c98
* Minor DCHECK cleanups in libevent.willchan@chromium.org2009-03-171-2/+3
| | | | | | | | DCHECK=>DCHECK_EQ where possible. Change a DCHECK not to fire on write() returning -1 && errno==EAGAIN, since this happens normally under heavy load. Review URL: http://codereview.chromium.org/42295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11919 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug in WebMediaPlayerDelegateImpl that stalls video playbackhclam@chromium.org2009-03-171-8/+8
| | | | | | | | | | NotifyWebMediaPlayerTask is not calling WebMediaPlayerDelegateImpl::DidTask so new tasks are never scheduled. Also Changed NotifyWebMediaPlayerTask a bit so it can call DidTask. Review URL: http://codereview.chromium.org/48093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11918 0039d316-1c4b-4281-b951-d872f2087c98
* Roll gyp DEPS to pickup this change:agl@chromium.org2009-03-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | --------------------------------------------------------------------- r372 | agl@chromium.org | 2009-03-17 15:11:24 -0700 (Tue, 17 Mar 2009 Change 'options' argument to 'params' Previously the generator function took a final argument called 'options', which was the command lin eoptions dict from optparse. With this change, that argument becomes 'params', which is a dict with these keys: options: the old options structure build_files: the list of build files passed on the command line generator_flags: a list of strings. These strings are taken from the --generator-flags command line argument. For example, if the command line includes "--generator-flags=opt,foo,bar" then this list will be ['opt', 'foo', 'bar'] Review URL: http://codereview.chromium.org/48099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11917 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes build breakage on Linux.klink@chromium.org2009-03-171-1/+1
| | | | | | | | TBR=estade (fixing broken Linux build) Review URL: http://codereview.chromium.org/42307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11915 0039d316-1c4b-4281-b951-d872f2087c98
* Renames AccessibleWrapper to ViewAccessibilityWrapper for clarity. klink@chromium.org2009-03-179-295/+434
| | | | | | | | Reorders the functions in ViewAccessibility to match the order used in BrowserAccessibility, accessibility.h and in Glue/WebKit. Review URL: http://codereview.chromium.org/46011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11914 0039d316-1c4b-4281-b951-d872f2087c98
* Roll GYP's deps to get the newer additions on the mac.thomasvl@chromium.org2009-03-171-1/+1
| | | | | | Review URL: http://codereview.chromium.org/42301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11913 0039d316-1c4b-4281-b951-d872f2087c98
* Find the 32-bit libs in the right place on 32-bit buildbot.mmoss@chromium.org2009-03-171-15/+20
| | | | | | | Review URL: http://codereview.chromium.org/42300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11912 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug 7550: We still refer to the Java beta when suggesting plugins to ↵finnur@chromium.org2009-03-171-1/+1
| | | | | | | | | | download, even though we point the user to the main download Java page which contains a released version of the Java plugin. I only update plugins2.xml, since plugins.xml looks deprecated. BUG=7550 TEST=Uninstall Java plugin, if installed. Open a page that uses Java (ie. http://www.java.com/en/download/help/testvm.xml) and make sure the message says "download Java" not "download Java something something (Beta)". Review URL: http://codereview.chromium.org/48080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11911 0039d316-1c4b-4281-b951-d872f2087c98
* Some upstream code assumes that the executable path from the path service isthomasvl@chromium.org2009-03-172-18/+21
| | | | | | | | | | | | | | | | standardized, but NSBundle makes not such promise, so we standardize it ourselves. While here, remove the app data dir support since it seems the installer and windows sandbox are the only things that need it. Moved that code upstream to the chrome paths... Directly handle the user data dir w/in the chrome path service call back, return different things for chrome vs. chromium. Review URL: http://codereview.chromium.org/48089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11910 0039d316-1c4b-4281-b951-d872f2087c98
* Second stab at applying http://codereview.chromium.org/43138/show.robertshield@google.com2009-03-1716-11/+387
| | | | | | | | Removing the (not really needed) dependency on chrome\VERSION which works on the try server but breaks on buildbot. Review URL: http://codereview.chromium.org/42289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11909 0039d316-1c4b-4281-b951-d872f2087c98
* Add --gtest_filter option to valgrind_test.pydkegel@google.com2009-03-171-3/+5
| | | | | | | | Also exit with nonzero status if valgrind errors are found in log -- else tree is falsely shown as green. Review URL: http://codereview.chromium.org/48085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11908 0039d316-1c4b-4281-b951-d872f2087c98
* One more NSS suppression needed. With this change, base is green.dkegel@google.com2009-03-171-1/+7
| | | | | | Review URL: http://codereview.chromium.org/48081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11907 0039d316-1c4b-4281-b951-d872f2087c98
* Revert tree bustage cause by r11904.hclam@chromium.org2009-03-1738-679/+1871
| | | | | | TBR=agl git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11906 0039d316-1c4b-4281-b951-d872f2087c98
* Removes test from tests_fixable that is already listed in tests_ignored.sky@google.com2009-03-171-2/+0
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/48086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11905 0039d316-1c4b-4281-b951-d872f2087c98
* andrew's patchhclam@chromium.org2009-03-1738-1871/+679
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11904 0039d316-1c4b-4281-b951-d872f2087c98
* These tests were rebased with the merge and needojan@google.com2009-03-171-0/+19
| | | | | | | rebase on linux. Review URL: http://codereview.chromium.org/42297 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11902 0039d316-1c4b-4281-b951-d872f2087c98
* Use anonymous shared memory for VisitedLinks.agl@chromium.org2009-03-172-20/+4
| | | | | | | | | | | | | | We already pass a handle to the shared memory via IPC but, when we create it, we create a named segment. These segments are not garbage collected on POSIX. Since nobody actually uses the name of the segment, use an anonymous segment instead and remove the functions. Review URL: http://codereview.chromium.org/48087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11900 0039d316-1c4b-4281-b951-d872f2087c98
* This test only passed if RLZTracker::InitRlz hadn't been called, levin@chromium.org2009-03-171-3/+11
| | | | | | | | | | so it failed when the test run order happened to change. This change fixes that. Review URL: http://codereview.chromium.org/42283 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11899 0039d316-1c4b-4281-b951-d872f2087c98
* Add LINUX and MAC to platforms on which the xhr test fails. levin@chromium.org2009-03-171-1/+1
| | | | | | | | | It was without platforms before my change and I mistakenly only added WIN, but it should have been all platforms. Review URL: http://codereview.chromium.org/48084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11898 0039d316-1c4b-4281-b951-d872f2087c98
* Use "org.chromium" in place of "com.google.chrome" in posix temporary file ↵estade@chromium.org2009-03-171-0/+4
| | | | | | | | names for non-chrome builds. Review URL: http://codereview.chromium.org/46087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11897 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-10 22:49:38 +0000