summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* POSIX: Don't allow onunload handlers to hang a renderer forever.agl@chromium.org2009-05-054-0/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | (Reland of r15025 which was reverted in r15095. |exit| has been changed to |_exit| to save running the onexit handlers while another thread is still in V8 code.) On POSIX one can install an unload handler which loops forever and leave behind a renderer process which eats 100% CPU forever. This is because the terminate signals (ViewMsg_ShouldClose and the error from the IPC channel) are routed to the main message loop but never processes (because that message loop is stuck in V8). One could make the browser SIGKILL the renderers, but that leaves open a large window where a browser failure (or a user, manually terminating the browser because "it's stuck") will leave behind a process eating all the CPU. On Windows we don't have this issue because all the processes are in a job so when the parent dies, all the children are killed too. http://codereview.chromium.org/100222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15332 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Linux tabs as widgets. This moves tab input handling into the ↵jhawkins@chromium.org2009-05-0511-744/+980
| | | | | | | | correct object. This change also adds an initial DraggedTabControllerGtk. Review URL: http://codereview.chromium.org/99371 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15330 0039d316-1c4b-4281-b951-d872f2087c98
* Adding first run bypass command line flag.robertshield@google.com2009-05-053-1/+11
| | | | | | | This allows the browser to start up without ever showing the first run UI, regardless of whether the First Run sentinel file is present. Quite useful for automated testing ;-) Review URL: http://codereview.chromium.org/99344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15329 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for 10.6jeremy@chromium.org2009-05-052-5/+37
| | | | | | | | | | | | | * Workaround for rdar://6857649 - NSGradient fails when using LAB Colorspace * Update sandbox config file for 10.6 BUG=11265 TEST=Open Chrome on 10.6, it should have tabs and the tab title should reflect the title of the page that's currently loaded. Review URL: http://codereview.chromium.org/109032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15328 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors HWNDView into two classes for reuse on GTK.sky@chromium.org2009-05-056-174/+278
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/108025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15327 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb the creator URL for popups up to the browser. We don't yet use this ↵pkasting@chromium.org2009-05-0519-28/+60
| | | | | | | | | for anything; it will be used for whitelisting popups by hostname. BUG=11440 Review URL: http://codereview.chromium.org/105004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15326 0039d316-1c4b-4281-b951-d872f2087c98
* Remove uses of deprecated version of PathService::Get() in the installer.thestig@chromium.org2009-05-0513-142/+152
| | | | | | Review URL: http://codereview.chromium.org/109033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15325 0039d316-1c4b-4281-b951-d872f2087c98
* Move the shared JS and CSS out of the HTML files and into separate files.arv@chromium.org2009-05-056-117/+113
| | | | | | Review URL: http://codereview.chromium.org/99151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15323 0039d316-1c4b-4281-b951-d872f2087c98
* The bookmark bar app menu item should have a checkbox displayed next to it ↵jhawkins@chromium.org2009-05-051-1/+1
| | | | | | | | when it's selected. Review URL: http://codereview.chromium.org/109036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15322 0039d316-1c4b-4281-b951-d872f2087c98
* Convert autocomplete to use a custom matrix and button cell.shess@chromium.org2009-05-053-130/+226
| | | | | | | | | | | | | | | On the user-visible side this change enables mouse hover (the item under the mouse is highlighted), and lays out the text omnibox v2 style. Only hover really needed the control change, but I have another change queued up to style the popup text. It uses different colors and shades, and really looked horrible with the NSTableView highlighting. [Which is why this part of the CL is coming first.] TEST=Omnibox popup works and shows highlighting under the mouse in addition to the keyboard-selected item. Review URL: http://codereview.chromium.org/99310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15321 0039d316-1c4b-4281-b951-d872f2087c98
* Set infobar text to black (overriding system default color).estade@chromium.org2009-05-051-0/+5
| | | | | | | | Since we set the background color, we can't go letting the theme choose the text color unless we want to potentially end up with white on yellow. Review URL: http://codereview.chromium.org/108034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15320 0039d316-1c4b-4281-b951-d872f2087c98
* Center the download progress meter behind the icon.arv@chromium.org2009-05-051-4/+4
| | | | | | | | | | | | I moved the image down 2px as well as adjusted the margins. I tried keeping the image at 0px but it looks better when moved down slightlty :-) http://crbug.com/10057 Review URL: http://codereview.chromium.org/99286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15319 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to green mac layout test bots.estade@chromium.org2009-05-051-2/+6
| | | | | | Review URL: http://codereview.chromium.org/108026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15318 0039d316-1c4b-4281-b951-d872f2087c98
* Landing the CL from Yusukes.jcampan@chromium.org2009-05-053-0/+18
| | | | | | | | | See http://codereview.chromium.org/99311 TBR=yusukes Review URL: http://codereview.chromium.org/109030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15317 0039d316-1c4b-4281-b951-d872f2087c98
* Style fixes for webkit upstreaming.ajwong@chromium.org2009-05-051-57/+45
| | | | | | Review URL: http://codereview.chromium.org/99373 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15316 0039d316-1c4b-4281-b951-d872f2087c98
* Mark a couple FAILs as FAIL CRASH in an attempt to green the treeamanda@chromium.org2009-05-051-2/+2
| | | | | | | TBR=estade Review URL: http://codereview.chromium.org/108029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15312 0039d316-1c4b-4281-b951-d872f2087c98
* Media Player mainfrm.hfbarchard@chromium.org2009-05-056-22/+775
| | | | | | | | | | | | | | | | | | | | | | | This module contains all event handling for menus in the Media Player. The implementation is WTL (Windows Template Library) based. The main menu is: File Edit View Play Options Help File opens/closes movies and has print features. Edit has copy/paste features. View has spatial controls, such as scaling, and tool and status bars and a properties dialogue box. Play has temporal controls, such as play speed and pause. Options controls details such as Audio and Video on/off. Help is just an about box. Right clicking brings up a context menu with edit and view items. A tool bar exposes the most common menu items as buttons. Hotkeys (accelerators) are mapped to most menu items. A .RC file is used to edit the menus using the resource editor in visual studio. Dialogue boxes are each handled by a different .h. ie props.h for properties. Mainfrm.h does some minor dialogue boxes directly, such as the file selector and alert boxes for errors. Review URL: http://codereview.chromium.org/99087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15311 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=11200rafaelw@chromium.org2009-05-0516-332/+331
| | | | | | | | R=aa Review URL: http://codereview.chromium.org/110001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15310 0039d316-1c4b-4281-b951-d872f2087c98
* Add valgrind suppressions for a well-known fontconfig leak anddkegel@google.com2009-05-051-5/+36
| | | | | | | | | | for http://crbug.com/6547 and http://crbug.com/11462, and loosen up another couple a bit. Review URL: http://codereview.chromium.org/108001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15309 0039d316-1c4b-4281-b951-d872f2087c98
* Update Gears in Chromium to 0.5.19.0.jon@chromium.org2009-05-052-0/+0
| | | | | | Review URL: http://codereview.chromium.org/110004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15308 0039d316-1c4b-4281-b951-d872f2087c98
* In OOP-sytle JavaScript programs there are lots of anonymous functions which ↵yurys@google.com2009-05-051-7/+1
| | | | | | | | in fact are methods. Show the method names for them. Review URL: http://codereview.chromium.org/108018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15306 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r15294 that causes crash spike in chromebot.huanr@chromium.org2009-05-052-26/+6
| | | | | | Review URL: http://codereview.chromium.org/108023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15305 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak that happen on some video fileshclam@chromium.org2009-05-051-8/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The memory leak was introduced by BufferedDataSource, the cause of the leak: 1. Some video files have read patterns that BufferedResourceLoader cannot provide data buffer with, thus a large amount of BufferedResourceLoader is created and destroyed. 2. In the destruction of BufferedResourceLoader, it cancels the resource request and immediately deletes the ResourceLoaderBridge. 3. The request canceled in the renderer process isn't cancalled immediately in the browser process, at the mean time browser process still sends shared memory buffers to the renderer process. 4. When these shared memory buffers arrived at the renderer process, the ResourceLoaderBridge associated with the requst has already been destroyed, ResourceDispatcher can't find the associated ResourceLoaderBridge and simply delete the message. But the IPC message is not POD, it contains the handle to shared memory that should be closed. 5. End result is a lot of memory are shared to the renderer process but they are not closed. Solutions: 1. Delete ResourceLoaderBridge only at OnCompletedResponse. Delete ResourceLoaderBridge at OnCompletedResponse, it is guranteed that no more shared memory buffer will arrive after this point, so it's safe to delete ResourceLoaderBridge. The downside is the lifetime of BufferedResourceLoader is prolonged until OnCompletedResponse is received, which may never is received in case of timeout for certain protocol.. 2. Inside ResourceDispatcer, close the handles to shared memory even if ResourceLoaderBridge is not found. I'm going for route 1. The problem I mentioned in 2 also sounds like a bug in ResourceDispatcher, will talk to erickay or eroman to find a solution. Review URL: http://codereview.chromium.org/100302 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15304 0039d316-1c4b-4281-b951-d872f2087c98
* Fix inspector in test_shell. AppendASCII doesn't like the leading '/'tc@google.com2009-05-051-1/+1
| | | | | | | | | | | | in the URL path. Inspector will work again after we pull in r43185 from upstream webkit (I tested by patching it in locally). Review URL: http://codereview.chromium.org/106003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15303 0039d316-1c4b-4281-b951-d872f2087c98
* Added back a few more tests that I removed in 15295, since while they pass onamanda@chromium.org2009-05-051-1/+7
| | | | | | | | my build machine, they are evidently still failing on the bots. TBR=thomasvl Review URL: http://codereview.chromium.org/110003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15302 0039d316-1c4b-4281-b951-d872f2087c98
* Makes closed window icon appear on right side when rtl.sky@chromium.org2009-05-051-0/+4
| | | | | | | | | BUG=11463 TEST=see bug Review URL: http://codereview.chromium.org/108019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15300 0039d316-1c4b-4281-b951-d872f2087c98
* Add back some tests that were removed in r15295 but still fail onamanda@chromium.org2009-05-051-7/+14
| | | | | | | | non-Mac platforms TBR=thomasvl Review URL: http://codereview.chromium.org/110002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15299 0039d316-1c4b-4281-b951-d872f2087c98
* Pulling in newer version of gyp.bradnelson@chromium.org2009-05-051-1/+1
| | | | | | Review URL: http://codereview.chromium.org/108016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15297 0039d316-1c4b-4281-b951-d872f2087c98
* Update test_expectations.txt to reflect text metrics upstream fixesamanda@chromium.org2009-05-051-290/+59
| | | | | | | | | and other recent changes. BUG=10312,10339,10348,10372,10447,10451,10662 Review URL: http://codereview.chromium.org/109024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15295 0039d316-1c4b-4281-b951-d872f2087c98
* Close browser window synchronously during UI testhuanr@chromium.org2009-05-052-6/+26
| | | | | | | | | | tear down. This is an effor to reduce random failure due to browser crash with multiple window open during shutdown. Review URL: http://codereview.chromium.org/100363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15294 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: localize window title, append inspected tab url there.pfeldman@chromium.org2009-05-0510-12/+53
| | | | | | Review URL: http://codereview.chromium.org/109014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15292 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Bugfixes for the round of sanity testing.pfeldman@chromium.org2009-05-056-8/+34
| | | | | | Review URL: http://codereview.chromium.org/109010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15291 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 1.2.2.1 to fix the mac chromium build.ager@chromium.org2009-05-051-1/+1
| | | | | | Review URL: http://codereview.chromium.org/108009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15290 0039d316-1c4b-4281-b951-d872f2087c98
* Push V8 version 1.2.2 to chromium.ager@chromium.org2009-05-053-3/+3
| | | | | | | | | | | | | | This contains a bug fix for the disappearing external strings bug (http://crbug.com/9746) as well as a couple of other bug fixes. In addition to bug fixes, this version of V8 allows the call as function handler registered on non-function objects to be called in construct calls. BUG=9746 Review URL: http://codereview.chromium.org/109011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15289 0039d316-1c4b-4281-b951-d872f2087c98
* Fix hang in DirectoryWatcherTest.WatchCreatedDirectory on Windows.phajdan.jr@chromium.org2009-05-051-2/+4
| | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/109008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15288 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Flash window in Analytics being incorrectly visible.jam@chromium.org2009-05-059-4/+119
| | | | | | | | | | The bug was that we accidentally marked a plugin widget as visible if it's parent was visible, even if it was explicitly set as hidden. BUG=8927 TEST=regression test included, also can verify that analytics doesn't display the gray rectangle per the bug Review URL: http://codereview.chromium.org/106008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15285 0039d316-1c4b-4281-b951-d872f2087c98
* Add more tests for recursive DirectoryWatcher watches.phajdan.jr@chromium.org2009-05-051-30/+114
| | | | | | Review URL: http://codereview.chromium.org/100346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15283 0039d316-1c4b-4281-b951-d872f2087c98
* Don't start the throbber when loading javascript URLs. This fixes abrettw@chromium.org2009-05-052-5/+13
| | | | | | | | | | | | | | | | | regression from my "start the throbber sooner" patch that made JS URLs keep throbbing forever. This patch just adds a check to see if the URL is JS, and doesn't synthesize the load start message. It seems kind of like a hcak, but I think it's the right thing. As I argued in the last patch (the comment for the block I modified here), we really need the throbbing status to be synchronous. This means we need to basically duplicate the logic for when WebKit will do the throbber in this function. BUG=11422 Review URL: http://codereview.chromium.org/105009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15280 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r15278. More unexpected test failures :(darin@chromium.org2009-05-0521-93/+316
| | | | | | | | TBR=mpcomplete Review URL: http://codereview.chromium.org/108005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15279 0039d316-1c4b-4281-b951-d872f2087c98
* Re-do r15244: Fix crash in ~TestWebViewDelegate caused bydarin@chromium.org2009-05-0521-316/+93
| | | | | | | | | | | | | | | | | | shell_ being null. Moved the RevokeDragDrop call to the TestShell destructor instead. Eliminate webkit/glue/webhistoryitem* in favor of adding a NavigateBackForwardSoon method WebViewDelegate. This moves all of the hacky details of how we intercept "history.{back, forward,go}" into the webkit layer. My eventual plan is to teach WebCore how to make this not hacky. BUG=11423 R=mpcomplete Review URL: http://codereview.chromium.org/108004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15278 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustage - file movedben@chromium.org2009-05-051-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15276 0039d316-1c4b-4281-b951-d872f2087c98
* Move *Animation to app/ben@chromium.org2009-05-0536-97/+86
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/109001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15275 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the ClipboardService class and header... it is nothing but a ↵ben@chromium.org2009-05-0516-78/+49
| | | | | | | | | | shell around base::Clipboard now. http://crbug.com/11387 Review URL: http://codereview.chromium.org/105011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15274 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_vector.h and stl_util-inl.h to base/ben@chromium.org2009-05-0566-102/+96
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/107001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15272 0039d316-1c4b-4281-b951-d872f2087c98
* implemented API style/convention changes, including:rafaelw@chromium.org2009-05-0511-297/+725
| | | | | | | | | | | | | | | | | | | | | | | | -tabs.update() -tabs.move() -tabs.remove() -tabs.update() -tabs.create() -tabs.get() -all tab events, except onUpdated implemented -tabs.getSelected() -tabs.getAllInWindow() -windows.getCurrent() -windows.getFocused() -windows.getAll(populate) -windows.onFocusedChanged() -ExtensionBrowserEventRouter now uses BrowserList::Observer Review URL: http://codereview.chromium.org/100345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15271 0039d316-1c4b-4281-b951-d872f2087c98
* FindBarView::UpdateForResult is not a good place to finnur@chromium.org2009-05-059-1/+23
| | | | | | | | | | | | | | | | | beep if nothing was found on the page. The reason is that it is gets called when you switch from one tab to the other. I've added a function to FindBar that the controller can call and each platform can implement whatever sound they want to use. BUG=10823 TEST=Open google.com, search for z0, it should beep (no matches). Open new tab, switch back to the old tab and it should not beep. Review URL: http://codereview.chromium.org/99372 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15269 0039d316-1c4b-4281-b951-d872f2087c98
* racy builds meant I didn't see this one... build bustage fix via dependency ↵ben@chromium.org2009-05-051-0/+1
| | | | | | update git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15267 0039d316-1c4b-4281-b951-d872f2087c98
* Bustage fix - forgot to merge this over onto my windows machine from my ↵ben@chromium.org2009-05-051-0/+7
| | | | | | | | | | linux box. Make sure we include gtk as a dependency on Linux. Review URL: http://codereview.chromium.org/105006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15266 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustage - removed this include for some reasonben@chromium.org2009-05-051-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15265 0039d316-1c4b-4281-b951-d872f2087c98
* Adds toplevel app/ directory and moves ResourceBundle into it.ben@chromium.org2009-05-05136-173/+359
| | | | | | | | | | | No changes to resource bundle yet, just the move to keep this CL as compact as possible. Adds new vcproj and gyp file for app dir. http://crbug.com/11387 Review URL: http://codereview.chromium.org/100354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15264 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 23:10:39 +0000