summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Modifying prefetch to account for multi-profile.rlp@chromium.org2011-09-1032-633/+1255
| | | | | | | | | | | | | | | | | | | | Items of note: - predictor_api is gone. Most functions in predictor_api.cc have moved into the chrome_browser_net::Predictor class or the Profile class. - The predictor state is cleaned up in the Profile dtor. - Predictor is owned by the ProfileIOData of the profile. - InitialObserver class is gone since each profile keeps their own info, the non-OTR don't care if anyone is OTR. - Predictor is created by the profile and then passed to the ProfileIOData. Then its initialization is finished on the IOThread. - ConnectInterceptor now subclasses off of UrlRequestJobFactory::Interceptor. - Updated Profile to create a SimpleShutdownPredictor with limited functionality when in unittests. BUG=89937,90114 TEST=passes existing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97446 Review URL: http://codereview.chromium.org/7467012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100555 0039d316-1c4b-4281-b951-d872f2087c98
* Update .DEPS.gitchrome-admin@google.com2011-09-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100554 0039d316-1c4b-4281-b951-d872f2087c98
* Roll gyp from 1033 -> 1037.ajwong@chromium.org2011-09-101-1/+1
| | | | | | | | | | | | | | | 1037: Fix Ninja Rule generator variable substitution. 1036: Don't use --start-group and --end-group in Android. 1035: Xcode3 gyp file syntax support. 1034: Fix to SHARED_LIB_SUFFIX back in make generator. BUG=none TEST=try bots Review URL: http://codereview.chromium.org/7865006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100553 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 100550 - Refactoring dialogs to add KDE support in a subsequent CL.thestig@chromium.org2011-09-104-167/+97
| | | | | | | | | Review URL: http://codereview.chromium.org/7841026 TBR=dfilimon@google.com Review URL: http://codereview.chromium.org/7862016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100552 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 100542 - Fix memory leak in sync notifier unit testsrlarocque@chromium.org2011-09-102-1/+31
| | | | | | | | | | | | | | | | | | | | | When XmppConnection is deleted, its TaskPump member is not deleted immediately. The destructor equeues a task to the message loop to have it deleted later. A comment in ~XmppConnection that explains why it does this. In the unit tests, the TaskPump would get leaked because the message loop would never get a chance to run that deletion task. This commit fixes the problem by running all pending tasks on that message loop before we exit the test. BUG=80238,79651 TEST=InvalidationNotifierTest Review URL: http://codereview.chromium.org/7863005 TBR=rlarocque@chromium.org Review URL: http://codereview.chromium.org/7867024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100551 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring dialogs to add KDE support in a subsequent CL.dfilimon@google.com2011-09-104-97/+167
| | | | | | Review URL: http://codereview.chromium.org/7841026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100550 0039d316-1c4b-4281-b951-d872f2087c98
* Component updater: Adding test for prodversionmincpu@chromium.org2011-09-102-22/+73
| | | | | | | | BUG=61602 TEST=none Review URL: http://codereview.chromium.org/7849002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100548 0039d316-1c4b-4281-b951-d872f2087c98
* Delete empty gears directory.thestig@chromium.org2011-09-100-0/+0
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100547 0039d316-1c4b-4281-b951-d872f2087c98
* ntp4: relax some CHECKsestade@chromium.org2011-09-102-8/+11
| | | | | | | | | | | | these are CHECKs that could be triggered in certain race conditions (e.g., if an extension were uninstalled by sync right as a user fclicked on it) BUG=96077 TEST=none Review URL: http://codereview.chromium.org/7796012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100546 0039d316-1c4b-4281-b951-d872f2087c98
* Mark OmniboxApiTest.Basic as flaky on Linux too.mihaip@chromium.org2011-09-101-2/+2
| | | | | | | | | BUG=52929 R=maruel@chromium.org Review URL: http://codereview.chromium.org/7867020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100545 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Use empty() accessor to check if node is empty in AddNodeToMenu().tfarina@chromium.org2011-09-101-3/+2
| | | | | | | | R=erg@chromium.org Review URL: http://codereview.chromium.org/7858020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100544 0039d316-1c4b-4281-b951-d872f2087c98
* sync: ensure sync init path doesn't block on CheckTimetim@chromium.org2011-09-102-8/+6
| | | | | | | | | | | | The call to RequestEarlyExit (which calls Abort) only happens if the SyncBackendHost has received the initialization callback from the SyncManager. But during init, the SyncManager could make a call to CheckTime, meaning that call would never be aborted. This patch makes sure to cover that case. BUG=93829 TEST=None at the moment :( Review URL: http://codereview.chromium.org/7862011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100543 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in sync notifier unit testsrlarocque@chromium.org2011-09-102-31/+1
| | | | | | | | | | | | | | | | | | When XmppConnection is deleted, its TaskPump member is not deleted immediately. The destructor equeues a task to the message loop to have it deleted later. A comment in ~XmppConnection that explains why it does this. In the unit tests, the TaskPump would get leaked because the message loop would never get a chance to run that deletion task. This commit fixes the problem by running all pending tasks on that message loop before we exit the test. BUG=80238,79651 TEST=InvalidationNotifierTest Review URL: http://codereview.chromium.org/7863005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100542 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: Enable 'views-desktop' by default.sadrul@chromium.org2011-09-103-23/+48
| | | | | | | | | | | Also add a flag in about:flags to turn it off. BUG=none TEST=manually Review URL: http://codereview.chromium.org/7796019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100541 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Suppress a couple sporadic leaks in the networking code.thestig@chromium.org2011-09-101-0/+29
| | | | | | | | | BUG=96101,96103 TEST=none TBR=jhawkins Review URL: http://codereview.chromium.org/7866023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100540 0039d316-1c4b-4281-b951-d872f2087c98
* Removing suppressions for bug 82716 which appears to be fixed. Suppression ↵bradchen@google.com2011-09-102-30/+0
| | | | | | | | | | | is no longer used in bots. There is no call to new from base::MessageLoopProxy::current BUG=82716 TEST=valgrind memcheck buildbots Review URL: http://codereview.chromium.org/7863020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100539 0039d316-1c4b-4281-b951-d872f2087c98
* Increase the size of mini ("pinned") tabs by 16px, per Cole.rsesek@chromium.org2011-09-101-5/+8
| | | | | | | | | | BUG=96011 TEST=visual Review URL: http://codereview.chromium.org/7780005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100538 0039d316-1c4b-4281-b951-d872f2087c98
* Enable rearrangement of Panels on Mac by dragging.dimich@chromium.org2011-09-099-26/+332
| | | | | | | | TEST=PanelBrowserTest.DragPanels Review URL: http://codereview.chromium.org/7857002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100537 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Add another variant of the TaskClosureAdapter leak; Suppress a new ↵thestig@chromium.org2011-09-091-0/+20
| | | | | | | | | | | leak in net::HttpRequestHeaders::SetHeader. BUG=83609,96090 TEST=none TBR=jhawkins Review URL: http://codereview.chromium.org/7863015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100536 0039d316-1c4b-4281-b951-d872f2087c98
* Missed a tab_contents() check in r100295.mihaip@chromium.org2011-09-091-0/+6
| | | | | | | | | BUG=95713 R=aa@chromium.org Review URL: http://codereview.chromium.org/7865008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100535 0039d316-1c4b-4281-b951-d872f2087c98
* Match main window notification subscription/unsubscription in ↵dcheng@chromium.org2011-09-091-1/+1
| | | | | | | | | | | | | | BookmarkBarController. The notifications became desynced in r82180. BUG=none TEST=none Review URL: http://codereview.chromium.org/7857010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100534 0039d316-1c4b-4281-b951-d872f2087c98
* [ChromeOS] Remove unneeded frame 'load' event handler.xiyuan@chromium.org2011-09-092-9/+7
| | | | | | | | | | | | | | If we need one in the future, we should add it in decorate instead of onBeforeShow. Otherwise, we add multiple event handlers. Also fix a problem that Gaia screen gets accidentally hidden if we get an online event before the offline event's fading animation finishes. BUG=chromium-os:20214 TEST=Verify fix for chromium-os:20214. Review URL: http://codereview.chromium.org/7860020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100531 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the in memory URL index. This is a temporary test to see if it ↵brettw@google.com2011-09-094-8/+16
| | | | | | | | affects crashes in Chrome. Review URL: http://codereview.chromium.org/7796011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100530 0039d316-1c4b-4281-b951-d872f2087c98
* Fix PrerenderBrowserTest.PrerenderInfiniteLoop flake duemmenke@chromium.org2011-09-091-1/+7
| | | | | | | | | | | to process destruction/prerender contents destruction race. TEST=PrerenderBrowserTest.PrerenderInfiniteLoop BUG=83170 Review URL: http://codereview.chromium.org/7866005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100529 0039d316-1c4b-4281-b951-d872f2087c98
* Keep track of the current per-thread context and surface. Addkbr@google.com2011-09-0914-12/+152
| | | | | | | | | | | | | | | | ScopedMakeCurrent to make it easier to briefly make another context current. Use it in AcceleratedSurface implementation and verify in the caller that it is working. This infrastructure would have made it possible to catch http://crbug.com/95492 and similar bugs where the wrong context was current. BUG=95962 TEST=ran CSS 3D example poster-circle; no assertion failures Review URL: http://codereview.chromium.org/7787022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100528 0039d316-1c4b-4281-b951-d872f2087c98
* Print Preview: Open print preview tab in the right position when the source ↵thestig@chromium.org2011-09-092-7/+80
| | | | | | | | | | | is a popup. BUG=95351 TEST=Included. Review URL: http://codereview.chromium.org/7845015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100527 0039d316-1c4b-4281-b951-d872f2087c98
* Move AttributedStringCoder from chrome to content.avi@chromium.org2011-09-0919-39/+38
| | | | | | | | | | Also, move a few Mac-only files to the new content/commmon/mac. BUG=95573 TEST=no change Review URL: http://codereview.chromium.org/7867016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100526 0039d316-1c4b-4281-b951-d872f2087c98
* tcmalloc doubly-linked free-lists for thread cachesbxx@chromium.org2011-09-0910-39/+365
| | | | | | | | | | | | | | | Added the ability for free lists to be built out of doubly-linked lists in tcalloc. TCMALLOC_USE_DOUBLYLINKED_FREELIST flag must be set in order for doubly-linked lists to be used. By default flag is only set in Debug builds. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99515 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100074 Review URL: http://codereview.chromium.org/7671034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100525 0039d316-1c4b-4281-b951-d872f2087c98
* To reenable the test: plugins.PluginsTest.testDisableEnableAllPluginsvenkataramana@chromium.org2011-09-091-2/+0
| | | | | | | | | BUG=87811 Test= plugins.PluginsTest.testDisableEnableAllPlugins Review URL: http://codereview.chromium.org/7865002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100524 0039d316-1c4b-4281-b951-d872f2087c98
* Remove race suppression now that WebKit r94821 has been rolled in.levin@chromium.org2011-09-091-35/+0
| | | | | | | | | TEST=Thread sanitizer run. BUG=93708 Review URL: http://codereview.chromium.org/7865010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100523 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up reliability_tests: they don't need their ownphajdan.jr@chromium.org2011-09-096-166/+111
| | | | | | | | | | | | test suite. This will make it easier to further reorganize chrome/test BUG=90905 Review URL: http://codereview.chromium.org/7859009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100522 0039d316-1c4b-4281-b951-d872f2087c98
* Remove heapcheck suppressions that are obsolete.tony@chromium.org2011-09-091-69/+0
| | | | | | | | | | | | | | | | | Bug 39021 and bug 43775 are for ExtensionAPIClientTest, which was deleted: http://codereview.chromium.org/2847008 Bug 54689 was for a test that was moved from a unit test to a browser test: http://codereview.chromium.org/6291007 Bug 39007 seems to be a catch all for RenderViewTest, but there are no remaining RenderViewTests in unit tests (they are now all browser_tests). BUG=39021,39007,43775,54689 Review URL: http://codereview.chromium.org/7866003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100521 0039d316-1c4b-4281-b951-d872f2087c98
* Fix pyauto test on ChromeOS: ↵dennisjeffrey@chromium.org2011-09-091-4/+1
| | | | | | | | | | | | | | passwords.PasswordTest.testDisplayAndSavePasswordInfobar. Minor edit to a URL used by this test fixes it when run on ChromeOS. Also removed an unnecessary function call from the test. BUG=None TEST=None Review URL: http://codereview.chromium.org/7863008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100520 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate duplicate mem leak suppressions which are intentional.levin@chromium.org2011-09-091-77/+16
| | | | | | | | | | | | The two leaks both are one time initialization of WebKit wide globals related to threading. TEST=valgrind BUG=46162,46144,70924,95106 Review URL: http://codereview.chromium.org/7780009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100517 0039d316-1c4b-4281-b951-d872f2087c98
* Add a global error messages UIsail@chromium.org2011-09-0911-9/+337
| | | | | | | | | | | | This is change adds a new UI to show global error messages. Currenlty this only supports adding a wrench menu badge and wrench menu item. I'll add a buble view in later patches. See the bug for more info. BUG=95146 TEST= Review URL: http://codereview.chromium.org/7792088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100516 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Don't notify the transaction observer of huge mutation sets.zea@chromium.org2011-09-091-3/+18
| | | | | | | | | | | | | | | | | | The transaction observer is currently only used for debug information sent to chrome://sync_internals. When we have large numbers of changes within a single transaction, our mutation set can grow exceedingly large, and the unnecessary copying we perform in sending the data to the transaction observer can result in out of memory crashes. This change limits the size of the mutation sets we copy to 1000 elements. If the size is larger, we send a dummy empty mutation set instead. BUG=90169 TEST=turn on encryption on an account with >1000 items. Ensure none are printed in the events pane of about:sync Review URL: http://codereview.chromium.org/7861005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100515 0039d316-1c4b-4281-b951-d872f2087c98
* Removed now-obsolete suppression; the class has been renamed, and thekbr@chromium.org2011-09-091-13/+0
| | | | | | | | | | | new class isn't showing up in the suppressions. BUG=60662 TEST=none TBR=thestig Review URL: http://codereview.chromium.org/7865009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100514 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind/Heapchecker: Suppress leaks in ↵thestig@chromium.org2011-09-092-1/+22
| | | | | | | | | | | net::CookieMonster::CookieMonsterTask::InvokeCallback. Also widen a related suppression. BUG=96066,96069 TEST=none TBR=jhawkins Review URL: http://codereview.chromium.org/7780010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100513 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes aura chrome build.sky@chromium.org2011-09-091-1/+1
| | | | | | | | | | | TBR=ben@chromium.org BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/7867015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100511 0039d316-1c4b-4281-b951-d872f2087c98
* Use 0x0 size as default for panel bounds in extension api.jennb@chromium.org2011-09-091-6/+17
| | | | | | | | | | BUG=None TEST=Use extension API to open a panel. Do not customize size. Review URL: http://codereview.chromium.org/7855001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100510 0039d316-1c4b-4281-b951-d872f2087c98
* Send the views-desktop flag from the login screen to the incognito session ↵sadrul@chromium.org2011-09-091-0/+1
| | | | | | | | | | | when it's set. BUG=none TEST=manually Review URL: http://codereview.chromium.org/7867014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100508 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert 100494 - Fix bug in SimulateAttrib0."""gman@chromium.org2011-09-092-42/+137
| | | | | | | | | | TEST=none BUG=95625 TBR=apatrick@chromium.org Review URL: http://codereview.chromium.org/7796016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100507 0039d316-1c4b-4281-b951-d872f2087c98
* Don't alert AutofillManager of changes to non-Autofillable fields.isherman@chromium.org2011-09-091-0/+3
| | | | | | | | | | | The AutofillManager expects all notifications to be for "interesting" (aka "fillable") fields, and DCHECKs on this expectation. Living up to the expectation prevents us from crashing. BUG=95965 TEST=Navigate to a fillable form with a password form, type in the password field, don't crash. For example, try with https://www.corp.google.com/~isherman/no_crawl/scratch/crash.html Review URL: http://codereview.chromium.org/7857024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100506 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Refactor to ensure turning on encryption encrypts all data types.zea@chromium.org2011-09-0920-214/+418
| | | | | | | | | | | | | | | | | | Previously we would not automatically encrypt new datatypes (for example when a datatype is added in a new version). This patch addresses this by adding an explicit encrypt_everything field to the nigori node, and putting the cryptographer in charge of handling the decisions aboutwhat datatypes to encrypt. BUG=90924,95286 TEST=Cryptographer unit tests, Session's SingleClientEnableEncryption integration test. Ensuring any previously set up sync account now marks search_engines and sessions as requiring encryption even when they were never enabled. Review URL: http://codereview.chromium.org/7850006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100505 0039d316-1c4b-4281-b951-d872f2087c98
* Merged duplicate functions from tools/data_pack into the ↵adriansc@chromium.org2011-09-0910-16/+114
| | | | | | | | | | | | | | grit/format/data_pack class. Marked tools/data_pack directory for removal when the dependency in third_party file WebKit.gyp has been updated to point to grit. BUG=none TEST=builds Review URL: http://codereview.chromium.org/7795057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100504 0039d316-1c4b-4281-b951-d872f2087c98
* Minor PanelTitlebarView cleanup.dcheng@chromium.org2011-09-092-10/+11
| | | | | | | | | | | | | Remove unused member and access owner window consistently. The one case where we must use [controller_ window] is specially documented as such. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/7860009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100503 0039d316-1c4b-4281-b951-d872f2087c98
* Dispose of NPOject in npobject_identity_test.ccjhorwich@chromium.org2011-09-092-16/+2
| | | | | | | | | BUG= 84233 TEST= Ensure no leak in NPThingy::Allocate under valgrind Review URL: http://codereview.chromium.org/7831079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100502 0039d316-1c4b-4281-b951-d872f2087c98
* Fix BufferedResourceLoaderTest.BufferWindow_SetVeryLargevrk@google.com2011-09-093-2/+11
| | | | | | | | | | | Cap bitrate and playback rate in BufferedResourceLoader to avoid overflow. BUG=95957,60215 TEST=test_shell_tests pass on linux 32 Review URL: http://codereview.chromium.org/7861016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100501 0039d316-1c4b-4281-b951-d872f2087c98
* LOG(WARNING)=>VLOG for SPDY path loggingwillchan@chromium.org2011-09-091-2/+2
| | | | | | | | | BUG=chromium-os:20206 TEST=none Review URL: http://codereview.chromium.org/7860015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100500 0039d316-1c4b-4281-b951-d872f2087c98
* Add a webdriver.DEPS file which pulls the appropriate version of the pythonkkania@chromium.org2011-09-091-0/+5
| | | | | | | webdriver bindings. This is only used by the buildbot master config. Review URL: http://codereview.chromium.org/7859037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100499 0039d316-1c4b-4281-b951-d872f2087c98