| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Items of note:
- predictor_api is gone. Most functions in predictor_api.cc have moved into the chrome_browser_net::Predictor class or the Profile class.
- The predictor state is cleaned up in the Profile dtor.
- Predictor is owned by the ProfileIOData of the profile.
- InitialObserver class is gone since each profile keeps their own info, the non-OTR don't care if anyone is OTR.
- Predictor is created by the profile and then passed to the ProfileIOData. Then its initialization is finished on the IOThread.
- ConnectInterceptor now subclasses off of UrlRequestJobFactory::Interceptor.
- Updated Profile to create a SimpleShutdownPredictor with limited functionality when in unittests.
BUG=89937,90114
TEST=passes existing
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97446
Review URL: http://codereview.chromium.org/7467012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1037: Fix Ninja Rule generator variable substitution.
1036: Don't use --start-group and --end-group in Android.
1035: Xcode3 gyp file syntax support.
1034: Fix to SHARED_LIB_SUFFIX back in make generator.
BUG=none
TEST=try bots
Review URL: http://codereview.chromium.org/7865006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7841026
TBR=dfilimon@google.com
Review URL: http://codereview.chromium.org/7862016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When XmppConnection is deleted, its TaskPump member is not deleted immediately.
The destructor equeues a task to the message loop to have it deleted later. A
comment in ~XmppConnection that explains why it does this.
In the unit tests, the TaskPump would get leaked because the message loop would
never get a chance to run that deletion task. This commit fixes the problem
by running all pending tasks on that message loop before we exit the test.
BUG=80238,79651
TEST=InvalidationNotifierTest
Review URL: http://codereview.chromium.org/7863005
TBR=rlarocque@chromium.org
Review URL: http://codereview.chromium.org/7867024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7841026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=61602
TEST=none
Review URL: http://codereview.chromium.org/7849002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
these are CHECKs that could be triggered in certain race conditions (e.g., if an extension were uninstalled by sync right as a user fclicked on it)
BUG=96077
TEST=none
Review URL: http://codereview.chromium.org/7796012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52929
R=maruel@chromium.org
Review URL: http://codereview.chromium.org/7867020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=erg@chromium.org
Review URL: http://codereview.chromium.org/7858020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The call to RequestEarlyExit (which calls Abort) only happens if the SyncBackendHost has received the initialization callback from the SyncManager. But during init, the SyncManager could make a call to CheckTime, meaning that call would never be aborted. This patch makes sure to cover that case.
BUG=93829
TEST=None at the moment :(
Review URL: http://codereview.chromium.org/7862011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When XmppConnection is deleted, its TaskPump member is not deleted immediately.
The destructor equeues a task to the message loop to have it deleted later. A
comment in ~XmppConnection that explains why it does this.
In the unit tests, the TaskPump would get leaked because the message loop would
never get a chance to run that deletion task. This commit fixes the problem
by running all pending tasks on that message loop before we exit the test.
BUG=80238,79651
TEST=InvalidationNotifierTest
Review URL: http://codereview.chromium.org/7863005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also add a flag in about:flags to turn it off.
BUG=none
TEST=manually
Review URL: http://codereview.chromium.org/7796019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=96101,96103
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/7866023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is no longer used in bots. There is no call to new from base::MessageLoopProxy::current
BUG=82716
TEST=valgrind memcheck buildbots
Review URL: http://codereview.chromium.org/7863020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=96011
TEST=visual
Review URL: http://codereview.chromium.org/7780005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=PanelBrowserTest.DragPanels
Review URL: http://codereview.chromium.org/7857002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
leak in net::HttpRequestHeaders::SetHeader.
BUG=83609,96090
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/7863015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=95713
R=aa@chromium.org
Review URL: http://codereview.chromium.org/7865008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BookmarkBarController.
The notifications became desynced in r82180.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7857010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If we need one in the future, we should add it in decorate instead of onBeforeShow. Otherwise, we add multiple event handlers.
Also fix a problem that Gaia screen gets accidentally hidden if we get an online event before the offline event's fading animation finishes.
BUG=chromium-os:20214
TEST=Verify fix for chromium-os:20214.
Review URL: http://codereview.chromium.org/7860020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
affects crashes in Chrome.
Review URL: http://codereview.chromium.org/7796011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to process destruction/prerender contents destruction race.
TEST=PrerenderBrowserTest.PrerenderInfiniteLoop
BUG=83170
Review URL: http://codereview.chromium.org/7866005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ScopedMakeCurrent to make it easier to briefly make another context
current. Use it in AcceleratedSurface implementation and verify in the
caller that it is working.
This infrastructure would have made it possible to catch
http://crbug.com/95492 and similar bugs where the wrong context was
current.
BUG=95962
TEST=ran CSS 3D example poster-circle; no assertion failures
Review URL: http://codereview.chromium.org/7787022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is a popup.
BUG=95351
TEST=Included.
Review URL: http://codereview.chromium.org/7845015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also, move a few Mac-only files to the new content/commmon/mac.
BUG=95573
TEST=no change
Review URL: http://codereview.chromium.org/7867016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added the ability for free lists to be built out of doubly-linked lists in tcalloc. TCMALLOC_USE_DOUBLYLINKED_FREELIST flag must be set in order for doubly-linked lists to be used. By default flag is only set in Debug builds.
BUG=None
TEST=None
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99515
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100074
Review URL: http://codereview.chromium.org/7671034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=87811
Test= plugins.PluginsTest.testDisableEnableAllPlugins
Review URL: http://codereview.chromium.org/7865002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Thread sanitizer run.
BUG=93708
Review URL: http://codereview.chromium.org/7865010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
test suite.
This will make it easier to further reorganize chrome/test
BUG=90905
Review URL: http://codereview.chromium.org/7859009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug 39021 and bug 43775 are for ExtensionAPIClientTest, which was
deleted: http://codereview.chromium.org/2847008
Bug 54689 was for a test that was moved from a unit test to a browser
test: http://codereview.chromium.org/6291007
Bug 39007 seems to be a catch all for RenderViewTest, but there are
no remaining RenderViewTests in unit tests (they are now all browser_tests).
BUG=39021,39007,43775,54689
Review URL: http://codereview.chromium.org/7866003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
passwords.PasswordTest.testDisplayAndSavePasswordInfobar.
Minor edit to a URL used by this test fixes it when run on ChromeOS.
Also removed an unnecessary function call from the test.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7863008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The two leaks both are one time initialization of WebKit wide globals
related to threading.
TEST=valgrind
BUG=46162,46144,70924,95106
Review URL: http://codereview.chromium.org/7780009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is change adds a new UI to show global error messages. Currenlty this only supports adding a wrench menu badge and wrench menu item. I'll add a buble view in later patches. See the bug for more info.
BUG=95146
TEST=
Review URL: http://codereview.chromium.org/7792088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The transaction observer is currently only used for debug information sent to
chrome://sync_internals. When we have large numbers of changes within a single
transaction, our mutation set can grow exceedingly large, and the unnecessary
copying we perform in sending the data to the transaction observer can result
in out of memory crashes. This change limits the size of the mutation sets
we copy to 1000 elements. If the size is larger, we send a dummy empty mutation
set instead.
BUG=90169
TEST=turn on encryption on an account with >1000 items. Ensure none are printed in the events pane of about:sync
Review URL: http://codereview.chromium.org/7861005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
new class isn't showing up in the suppressions.
BUG=60662
TEST=none
TBR=thestig
Review URL: http://codereview.chromium.org/7865009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
net::CookieMonster::CookieMonsterTask::InvokeCallback. Also widen a related suppression.
BUG=96066,96069
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/7780010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=ben@chromium.org
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7867015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Use extension API to open a panel. Do not customize size.
Review URL: http://codereview.chromium.org/7855001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
when it's set.
BUG=none
TEST=manually
Review URL: http://codereview.chromium.org/7867014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=95625
TBR=apatrick@chromium.org
Review URL: http://codereview.chromium.org/7796016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The AutofillManager expects all notifications to be for "interesting" (aka "fillable") fields, and DCHECKs on this expectation. Living up to the expectation prevents us from crashing.
BUG=95965
TEST=Navigate to a fillable form with a password form, type in the password field, don't crash. For example, try with https://www.corp.google.com/~isherman/no_crawl/scratch/crash.html
Review URL: http://codereview.chromium.org/7857024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously we would not automatically encrypt new datatypes (for example
when a datatype is added in a new version). This patch addresses this by
adding an explicit encrypt_everything field to the nigori node, and putting
the cryptographer in charge of handling the decisions aboutwhat datatypes to
encrypt.
BUG=90924,95286
TEST=Cryptographer unit tests, Session's SingleClientEnableEncryption
integration test. Ensuring any previously set up sync account now marks
search_engines and sessions as requiring encryption even when they were
never enabled.
Review URL: http://codereview.chromium.org/7850006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
grit/format/data_pack class.
Marked tools/data_pack directory for removal when the dependency in third_party file WebKit.gyp has been updated to point to grit.
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/7795057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove unused member and access owner window consistently. The one case where
we must use [controller_ window] is specially documented as such.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/7860009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= 84233
TEST= Ensure no leak in NPThingy::Allocate under valgrind
Review URL: http://codereview.chromium.org/7831079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Cap bitrate and playback rate in BufferedResourceLoader to avoid overflow.
BUG=95957,60215
TEST=test_shell_tests pass on linux 32
Review URL: http://codereview.chromium.org/7861016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:20206
TEST=none
Review URL: http://codereview.chromium.org/7860015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
webdriver bindings. This is only used by the buildbot master config.
Review URL: http://codereview.chromium.org/7859037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100499 0039d316-1c4b-4281-b951-d872f2087c98
|