summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix keyboard accelerator registration issue in views::View.yutak@chromium.org2009-06-064-18/+121
| | | | | | | | | | View should not register the same accelerator target multiple times. BUG=13275 TEST=None Review URL: http://codereview.chromium.org/118242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17810 0039d316-1c4b-4281-b951-d872f2087c98
* Rename BrowserToolbarView->ToolbarView to match file name.ben@chromium.org2009-06-066-541/+548
| | | | | | | | | Reorganize functions in CC to match header and related OCD activities. No logic changes. Review URL: http://codereview.chromium.org/118352 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17809 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash on fallback in HttpNetworkTransaction::ReconsiderProxyAfterError().willchan@chromium.org2009-06-062-1/+48
| | | | | | | | | | If the socket doesn't exist, don't try to Disconnect() it. BUG=http://www.crbug.com/13375 TEST=See bug for repro. Review URL: http://codereview.chromium.org/119228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17808 0039d316-1c4b-4281-b951-d872f2087c98
* Only allow tabs to be dragged between compatible windows.shess@chromium.org2009-06-064-1/+30
| | | | | | | | | | | Right now, this means windows with the same Profile. http://crbug.com/12241 TEST=Open some tabs in incognito and regular windows. Try to drag between. Should be able to drag between like security contexts (incognito to incognito, regular to regular), but not across. Review URL: http://codereview.chromium.org/119266 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17807 0039d316-1c4b-4281-b951-d872f2087c98
* When navigating to a page triggering an interstitial from the NTP, the title ↵jcampan@chromium.org2009-06-061-7/+7
| | | | | | | | | | would still be the NTP's one. http://crbug.com/11998 TEST=See bug. Review URL: http://codereview.chromium.org/119262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17806 0039d316-1c4b-4281-b951-d872f2087c98
* Add dock_info.cc to the linux build.jhawkins@chromium.org2009-06-064-6/+10
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/118344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17804 0039d316-1c4b-4281-b951-d872f2087c98
* Revert pngencoder changes.glen@chromium.org2009-06-052-46/+5
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17803 0039d316-1c4b-4281-b951-d872f2087c98
* Fix pngencoder mac perf errors - the previous code was never actually doing ↵glen@chromium.org2009-06-051-4/+3
| | | | | | | | | | | | an input.empty() check. BUG=none TEST=none TBR=nick Review URL: http://codereview.chromium.org/118343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17801 0039d316-1c4b-4281-b951-d872f2087c98
* Missed a file on checkin for multi-process handling of benchmarking extension.mbelshe@google.com2009-06-051-0/+1
| | | | | | | | BUG=none TEST=non Review URL: http://codereview.chromium.org/118323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17800 0039d316-1c4b-4281-b951-d872f2087c98
* #!/usr/bin/python2.4ericu@google.com2009-06-051-0/+1
| | | | | | | | | | | | # Copyright 2008-9 Google Inc. All Rights Reserved. # version = (major, minor, trunk, patch) plugin_version = (0, 1, 37, 0) sdk_version = plugin_version Review URL: http://codereview.chromium.org/118342 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17799 0039d316-1c4b-4281-b951-d872f2087c98
* Completely miscellaneous minor cleanup. Remove some unneeded class ↵pkasting@chromium.org2009-06-054-15/+12
| | | | | | | | declarations, modify or add a couple comments, change a function name in hopes of greater accuracy. Review URL: http://codereview.chromium.org/119264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17798 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an issue where themes would sporadically fail to install.mpcomplete@google.com2009-06-059-41/+120
| | | | | | | | | | | | | | | | Trying to send decoded images over IPC didn't work too well. Instead, we'll write them to a file and have the browser slurp them in from there. My first instinct was to use SharedMemory, but that would require us to impose a limit on the size of the decoded image data. Also made sure that the undecoded images are deleted when we install. BUG=13455 TEST=Try the repro steps in bug 13455 several times and make sure it works every time. Review URL: http://codereview.chromium.org/119255 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17797 0039d316-1c4b-4281-b951-d872f2087c98
* Move ConvertAcceleratorsFromWindowsStyle into chrome/common/gtk_util.mattm@chromium.org2009-06-055-34/+37
| | | | | | | | | | Use it on the custom startup url buttons. BUG=11507 Review URL: http://codereview.chromium.org/118327 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17796 0039d316-1c4b-4281-b951-d872f2087c98
* Version number bump for releaseericu@google.com2009-06-051-3/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17793 0039d316-1c4b-4281-b951-d872f2087c98
* Retry. I believe the code (with your width() * bbp fix) is correct.glen@chromium.org2009-06-052-5/+47
| | | | | | | | | | | | | The UMR errors occur when the source image contain alpha. I believe the issue comes from webkit glue image decoder, and the reason this only started triggering valgrind errors is that the old ones were masked by the change detailed in bug 12640 Also adds valgrind suppression for the new code. BUG=12891,12640 TEST=none Review URL: http://codereview.chromium.org/118297 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17792 0039d316-1c4b-4281-b951-d872f2087c98
* Give the Go button the correct tooltip based on what's in the omnibox.pkasting@chromium.org2009-06-051-6/+18
| | | | | | | | BUG=6906 TEST=Type "foo" into the Omnibox. Verify the Go button tooltip refers to searching for "foo" using your default engine. Change to "foo.com". Verify the Go button tooltip refers to navigating to foo.com. Change to using some custom search engine (e.g. tab-to-search on yahoo.com) and put in a search term. Verify the Go button tooltip refers to searching for your term on the chosen engine. Review URL: http://codereview.chromium.org/119263 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17791 0039d316-1c4b-4281-b951-d872f2087c98
* Implement and use the -> operator for OwnedWidgetGtk.thestig@chromium.org2009-06-0513-45/+47
| | | | | | | | | | Also change dragged_tabs_gtk's container_ to be a OwnedWidgetGtk just to be on the safe side. BUG=none TEST=none Review URL: http://codereview.chromium.org/119221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17790 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in window shutdown by accessing the Widget via a more unique property.ben@chromium.org2009-06-051-4/+9
| | | | | | | | | http://crbug.com/12156 TEST=none Review URL: http://codereview.chromium.org/118196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17789 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a bunch of #ifs in browser.h and browser.cc. These methods compiletc@google.com2009-06-052-26/+18
| | | | | | | | | | | fine on linux/mac. I disabled the ones that crash right now. Most of the methods just call into browser_window_{gtk,cocoa} and hit a NOTIMPLEMENTED. Review URL: http://codereview.chromium.org/119217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17786 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit_tests (Chrome browser unit tests) to Mac/Linux coverage.jrg@chromium.org2009-06-055-28/+84
| | | | | | | | Minor fixes to coverage related scripts. Review URL: http://codereview.chromium.org/118298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17785 0039d316-1c4b-4281-b951-d872f2087c98
* Add svn:eol-style LF to some file.ericroman@google.com2009-06-051-185/+184
| | | | | | | | | | BUG=NONE TEST=NONE TBR=wtc Review URL: http://codereview.chromium.org/114084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17784 0039d316-1c4b-4281-b951-d872f2087c98
* Implements View::GetXXXDragThreshold on Linux.sky@chromium.org2009-06-051-6/+17
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/118335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17783 0039d316-1c4b-4281-b951-d872f2087c98
* Porting the browser tests to Unix.jcampan@chromium.org2009-06-0517-197/+610
| | | | | | | | | | | | | The browser tests are an alternative to UI tests. They provide a way to exercise the browser from within the test (without having the test and the browser running in different processes). In order to ensure atexit hanlders are run after each tests and static initializers start fresh for each test, each test is run in a new process (on Linux and Mac). On Windows, a DLL containing the test is loaded/unloaded for each tests. BUG=None TEST=Run the browser tests. Review URL: http://codereview.chromium.org/115896 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17781 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the tabstrip we're dragging in to is compatible with the source ↵jhawkins@chromium.org2009-06-053-1/+11
| | | | | | | | | | tabstrip. BUG=none TEST=Drag tabs between tabstrips. Review URL: http://codereview.chromium.org/119258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17780 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build.finnur@chromium.org2009-06-051-18/+22
| | | | | | | | TBR=erikkay Review URL: http://codereview.chromium.org/118337 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17779 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes an issue where the MSAA information was not reported back correctly to ↵klink@chromium.org2009-06-058-42/+17
| | | | | | | | the AT, upon the HWND containing the web content first receiving focus. Note that this is not a full fix for the bug below, but one more piece to resolving it.BUG=13291TEST=none Review URL: http://codereview.chromium.org/118206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17778 0039d316-1c4b-4281-b951-d872f2087c98
* Add this ability to install Extensions using preferences. Also known as: ↵finnur@chromium.org2009-06-056-109/+626
| | | | | | | | | | | | | | | | | | | | | | | port the installation mechanism to other platforms. We already have the ability to install extensions using a registry key. That works only on Windows so this new change adds the same but using preferences instead of the Registry. This will eventually allow us to pre-install certain extensions when we install Chrome. BUG=12060 TEST=Covered by unit tests, but to test manually: close Chrome, open your Preferences file (in your profile) and add this (after substituting all <values> in elbow brackets): "extensions": { "settings": { "<your_extension_id_lowercased>": { "external_crx": "<path_to_crx>", "external_version": "<crx version>" } }, }, ... then start Chrome. Your extension should get installed. Review URL: http://codereview.chromium.org/119195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17777 0039d316-1c4b-4281-b951-d872f2087c98
* Add example .croc file.rspangler@google.com2009-06-051-0/+222
| | | | | | Review URL: http://codereview.chromium.org/119209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17776 0039d316-1c4b-4281-b951-d872f2087c98
* Change the name of chrome\browser\views\blocked_popup_container.{cc,h}sgk@google.com2009-06-055-8/+8
| | | | | | | | | | to blocked_popup_container_view.{cc,h}, to avoid duplication with the same-named files in chrome\browser. BUG=none TEST=successful build Review URL: http://codereview.chromium.org/119253 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17775 0039d316-1c4b-4281-b951-d872f2087c98
* Fix flicker that happened when hitting ctrl while in FORCED_QUERY mode. We ↵pkasting@chromium.org2009-06-051-4/+10
| | | | | | | | | | were comparing an input that had the "?" stripped off to one which didn't and thus never setting |minimal_changes| = true. BUG=13295 TEST=Type "?foo" into the omnibox. Then hit the ctrl key. The box should not flicker at all when pressing and releasing ctrl. Review URL: http://codereview.chromium.org/118325 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17774 0039d316-1c4b-4281-b951-d872f2087c98
* More theme bits for the NTP and window frame.glen@chromium.org2009-06-0512-7/+74
| | | | | | | | | BUG=12768,13352 TEST=Verify that a theme with attribution works on the NTP and a theme with an overlay shows up Review URL: http://codereview.chromium.org/119227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17773 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Report more info from the current experiment.rvargas@google.com2009-06-053-19/+43
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/119218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17772 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Dumping a renderer can traverse an invalid pointer.agl@chromium.org2009-06-053-5/+10
| | | | | | | | | | | | | | | | A ucontext isn't a POD datatype, so we can end up sending it to the browser and then walking an embedded pointer which is only valid in the renderer context. This fix sends the floating point registers (which were at the other end of said pointer) in the context and stops using the pointer in the ucontext. BUG=13465 http://codereview.chromium.org/119249 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17771 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 17758.kuchhal@chromium.org2009-06-0510-185/+54
| | | | | | Review URL: http://codereview.chromium.org/118324 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17770 0039d316-1c4b-4281-b951-d872f2087c98
* Grab the correct element from the match group of the git regex.mmoss@chromium.org2009-06-051-1/+1
| | | | | | | Review URL: http://codereview.chromium.org/119211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17769 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the backend for pinned items on the most visited page.arv@google.com2009-06-053-17/+184
| | | | | | | | | | | | The pinned items are stored in the pref ntp.pinned_urls. TEST=For now this should not change the behavior of the most visited thumbnails. BUG=13362 Review URL: http://codereview.chromium.org/118269 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17766 0039d316-1c4b-4281-b951-d872f2087c98
* Implement custom startup url list. (Recent urls list in the add url dialog notestade@chromium.org2009-06-055-12/+480
| | | | | | | | | | | | implemented yet.) BUG=11507 patch by Matt Mueller (mattm@google.com) http://codereview.chromium.org/118280 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17765 0039d316-1c4b-4281-b951-d872f2087c98
* Use custom strings for importer lock dialog.estade@chromium.org2009-06-051-3/+3
| | | | | | | | | | Also make the text wrap. BUG=13435 Review URL: http://codereview.chromium.org/118318 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17764 0039d316-1c4b-4281-b951-d872f2087c98
* Bumping up version number in trunk to 0.1.36.0vangelis@google.com2009-06-051-1/+1
| | | | | | Review URL: http://codereview.chromium.org/118313 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17763 0039d316-1c4b-4281-b951-d872f2087c98
* The table was deleted after the model and the table accesses the model in ↵jcampan@chromium.org2009-06-051-0/+4
| | | | | | | | | | its destructor, causing a failure in the browser tests. BUG=None TEST=Run the browser tests Review URL: http://codereview.chromium.org/118315 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17762 0039d316-1c4b-4281-b951-d872f2087c98
* Send the "Proxy-Connection: keep-alive" header with HTTP CONNECTwtc@chromium.org2009-06-052-12/+21
| | | | | | | | | | | | | | requests for compatibility with HTTP/1.0 proxies such as Squid. This is required for NTLM authentication. Fix some cpplint.py nits in http_network_transaction_unittest.cc. R=eroman BUG=http://crbug.com/8771 TEST=net_unittests passes all tests Review URL: http://codereview.chromium.org/118316 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17761 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug introduced during menu refactoring. Specifically thesky@chromium.org2009-06-053-4/+16
| | | | | | | | | | | | owner_draw_ was not getting set correctly in one case, resulting in no icons in some menus (like back/forward). BUG=http://crbug.com/12847 TEST=see bug Review URL: http://codereview.chromium.org/112096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17760 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r17673, except for the code cleanup.wtc@chromium.org2009-06-051-6/+38
| | | | | | | | | | | | I will try the real fix (sending the "Proxy-Connection: keep-alive" header with HTTP CONNECT requests) next. R=eroman BUG=http://crbug.com/8771 TEST=none Review URL: http://codereview.chromium.org/114083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17759 0039d316-1c4b-4281-b951-d872f2087c98
* Renamed installer_unittests to util_unittests and added setup_unitests ↵kuchhal@chromium.org2009-06-0510-41/+172
| | | | | | | | | | | project with only one unit test for now. BUG=12849 TEST=none Review URL: http://codereview.chromium.org/118247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17758 0039d316-1c4b-4281-b951-d872f2087c98
* Better behavior for ctrl-k: If we're already in forced_query mode, re-select ↵pkasting@chromium.org2009-06-0510-4/+45
| | | | | | | | | | the query text instead of clearing the box. BUG=6985 TEST=Press ctrl-k, type "foo", press ctrl-k again. The omnibox should show "?foo" with "foo" selected. Review URL: http://codereview.chromium.org/119135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17757 0039d316-1c4b-4281-b951-d872f2087c98
* Don't consider a certificate revoked if we don't havewtc@chromium.org2009-06-051-2/+5
| | | | | | | | | | | | | | | fresh revocation status of the certificate. We haven't written the code for NSS to use our network stack to download CRLs or talk to OCSP responders, so NSS doesn't have any revocation info. R=agl,ukai BUG=http://crbug.com/13336 TEST=none (requires a Linux system with NSS 3.12.3) Review URL: http://codereview.chromium.org/118314 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17756 0039d316-1c4b-4281-b951-d872f2087c98
* Don't prompt before installing a Theme, move existing prompt so that users ↵glen@chromium.org2009-06-054-24/+26
| | | | | | | | | | | | aren't prompted twice in the case when they have extensions disabled. Theme installation confirmation will be done through an infobar (allowing you to preview a lot of themes quickly without dealing with dialogs) - see CL 119235. BUG=none TEST=Install a theme, verify that you don't get prompted. Install an extension and verify that you do get prompted. Review URL: http://codereview.chromium.org/119232 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17755 0039d316-1c4b-4281-b951-d872f2087c98
* Implement some drag-n-drop for the bookmark manager.estade@chromium.org2009-06-059-147/+382
| | | | | | | | | | | | | Factor out shared code into bookmark_utils_gtk.*. Fix a leak with toolbar button dragging. BUG=13110 TEST=Added extra DCHECKs. Also, you can drag between the right half of the bookmark manager and the bookmark bar with no crashes. Review URL: http://codereview.chromium.org/119220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17754 0039d316-1c4b-4281-b951-d872f2087c98
* Improve resizing behavior of options window. Rather than extra whitespace atevan@chromium.org2009-06-053-19/+23
| | | | | | | | | | | the bottom, allow the custom url list to expand. BUG=11507 Review URL: http://codereview.chromium.org/118203 Patch from Matt Mueller <mattm@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17753 0039d316-1c4b-4281-b951-d872f2087c98
* setup.exe doesn't depend on chrome.{exe|dll}kuchhal@chromium.org2009-06-051-6/+0
| | | | | | Review URL: http://codereview.chromium.org/118241 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17752 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 06:50:51 +0000