| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
My change r10071 broke rendering on the Mac. Thanks to eseidel for
letting me use his Mac Pro to debug it.
Sometimes I still manage to stun myself with my own stupidity :(
TBR=pinkerton
Review URL: http://codereview.chromium.org/28018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=erikkay
Review URL: http://codereview.chromium.org/27022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and are causing slowdown in startup.
Review URL: http://codereview.chromium.org/28009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=7625
Review URL: http://codereview.chromium.org/27035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Normally an NPObjectProxy uses the modal dialog event to figure out when it needs to pump window messages in an invoke. However, an NPObjectProxy created by an NPObjectStub never got access to this event, which led to this hang.
BUG=7793
Review URL: http://codereview.chromium.org/20515
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ChildProcess now owns the ChildThread, which removes duplicate code and simplifies things.
Clean up ChildProcess, there really was no need for all the templates and statics in it and its subclasses.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10080
Review URL: http://codereview.chromium.org/21502
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some AV software may actually strip content type as well as content encoding.
As a result, when we propose a dicitonary (suggesting that this will
probably be an SDCH encoded response) we need to be ready to "fix"
the content-encoding string if it is not marked as gzip,sdch.
Note that "fixups" put in tentative decodes, which degrade to pass-through
filters if the content's header is not compatible with the decoding format.
I also added a line of defensive coding in the dictionary fetcher, and
cleaned up a line where I record stats after decoding sdch.
bug=7679
r=openvcdiff,huanr
Review URL: http://codereview.chromium.org/27016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mpcomplete
Review URL: http://codereview.chromium.org/27031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=7921
TBR=agl
Review URL: http://codereview.chromium.org/27030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=7921
TBR=agl
Review URL: http://codereview.chromium.org/27029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20521
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
merge.
Review URL: http://codereview.chromium.org/27010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=erikkay
BUG=7921
Review URL: http://codereview.chromium.org/27026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Scripts) directories during start up if they don't already exists
Review URL: http://codereview.chromium.org/29001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=erikkay
Review URL: http://codereview.chromium.org/27021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
allocated it has a reference count of 0, so calling Release again, does not
free the memory. The fix is to use a scoped_refptr for both the return value
as well as for the local variable.
This failure case is triggered by the purify bot not having the test
certificate installed. We should also fix that so that we run more tests on
the purify bot. Testing this case is also interesting I guess :)
TBR=erikkay
Review URL: http://codereview.chromium.org/27013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(found by purify)
TBR=brettw
Review URL: http://codereview.chromium.org/27012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
It appears that we were previously leaking HANDLEs but when this
changed to objects, purify picked it up.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also fix some gtk memory warnings and enable some code for favicon fetching.
Review URL: http://codereview.chromium.org/21532
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Issue=4782
Review URL: http://codereview.chromium.org/28003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1.7324 -- RTL: Path contains Hebrew is wrong on "Download location" text box
(http://crbug.com/7324)
2. 7326 -- RTL: Folder icon missing on "Download location" text box
(http://crbug.com/7326)
The fix are:
1. force path to have LTR directionality.
2. draw icon in mirrored position in RTL locales.
Steps for test:
1. Create a folder with a Hebrew file name on Hebrew XP
2. Change the download location to the folder created in step 1
3. Observe the path displayed on "Google Chrome Options" --> "Minor Tweaks" --> "Download location" text box
Without the fix:
The path contains Hebrew folder name is wrong. It displayed as "cCBA\:" while the path is "c:\CBA" where "CBA" is a Hebrew folder name.
And there is no folder icon in the "download location" text box.
With the fix:
The path displayed correctly as "c:\CBA" or "c:\CBA\FED" where "FED" is subfolder of "CBA".
And the folder icon showed at the very right.
Review URL: http://codereview.chromium.org/20038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
symbol to be generated to make the Windows try slaves faster.
Review URL: http://codereview.chromium.org/27009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"arabia.msn.com‬"
(http://crbug.com/2674)
The issue is: in RTL locale, the search engine name, if ending with punctuation, might not be displayed correctly in omnibox keyword text and omnibox keyword hint.
Fix: adjust the search engine keyword description (short name) for RTL locale so that the pure LTR search engine name
is marked with LRE-PDF pair to be displayed correctly. For example, "MSN(English)" is displayed as is, not as "(MSN(English".
Reproduce steps:
Looks like the "MSN(English)" is no longer a default search engine name. We can make one by the following steps:
1. Open "customize and control Google Chrome" --> "Options",
2. under "basics" tab, under "Default search:", click "Manage"
3. click on one search engine from the "default search options", then click "edit". For example, pick "AOL".
4. change the "name" from "AOL" to "AOL(English)".
Without the fix, in RTL Chrome, when type in "aol.com" in omnibox, the omni keyword hint shows "(AOL(English - xxxx <tab> yyy" while "xxx" stands for "to search" in Hebrew and "yyy" stands for "press" in Hebrew. After press <tab>, the keyword text in omnibox is ":(AOL(English - zzz" while "zzz" stands for "search" in Hebrew.
With the fix, the name "AOL(English)" is displayed correctly in the above 2 places.
Review URL: http://codereview.chromium.org/21320
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20500
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is an iterative process towards code to be proud of; the previous
code of mine was horrible, this is less bad, and my next attempt at it
will be pretty, I promise.
Review URL: http://codereview.chromium.org/28001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
on printing.
Review URL: http://codereview.chromium.org/27001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Fix printing_unittests dependencies to include gtest.
Review URL: http://codereview.chromium.org/20540
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Make test_shell and chrome_dll dependent on printing.
Review URL: http://codereview.chromium.org/21475
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This follows the same style as on Windows, destroy the native window in Destroy(), not in the destructor.
Review URL: http://codereview.chromium.org/20538
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=7891
TBR=sky
Review URL: http://codereview.chromium.org/23030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20531
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/20539
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
textured window style.
Review URL: http://codereview.chromium.org/21544
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20508
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21542
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=hbono
Review URL: http://codereview.chromium.org/21531
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous startup-off2.json didn't have stack traces. It was also quite large, it was unfiltered and contained every single system call event.
Include a program to filter a JSON data set to only include events that took a worthwhile amount of time. This greatly reduces the size of the JSON data.
A new filtered JSON dataset startup-release.json is included, much smaller and with stack traces.
Added an ignore for checkdeps on traceline/.
Review URL: http://codereview.chromium.org/20535
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20537
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This imports both the hook / event logger (traceline), and the SVG based UI for displaying trace results as a timeline (svgui).
Review URL: http://codereview.chromium.org/20494
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add code routing messages between ToolsAgent and ToolsClient in the browser process.
There is no direct IPC channel between inspected process and developer tools UI so all messages have to be routed through the browser process.
On the side of inspected page there is ToolsAgent existing in all renderers so that we can start inspecting the page at any moment by talking to this object.
On the side of developer tools renderer there is ToolsClient which is created only for RenderView that host developer tools UI.
(darin: tools message representation will be later changed from id+string to just IPC::Message)
Review URL: http://codereview.chromium.org/21510
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
more horizontal space.
Review URL: http://codereview.chromium.org/21511
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Until we properly support windowless plugins, tell plugins that we don't support windowless. The plugins will have to be windowed for now. This allows a lot of wmode flash to play, instead of trying to be windowless and failing.
Review URL: http://codereview.chromium.org/20418
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10088 0039d316-1c4b-4281-b951-d872f2087c98
|