summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Destroy browser/content related C++ object on WM_DESTROY message, rather ↵stoyan@chromium.org2009-05-062-2/+7
| | | | | | | | than OnFinalMessage Review URL: http://codereview.chromium.org/115034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15434 0039d316-1c4b-4281-b951-d872f2087c98
* Re-disable the PrefService PreservedWindowPlacementIsLoaded UI test until I ↵robertshield@google.com2009-05-061-1/+1
| | | | | | | | | | figure out why the official builder doesn't like it. TBR=hclam Review URL: http://codereview.chromium.org/113040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15433 0039d316-1c4b-4281-b951-d872f2087c98
* Have the grit rules depend on the .pak files.tc@google.com2009-05-062-2/+2
| | | | | | | | | | | chrome_resources and chrome_strings was continually rebuilding because it depended on the .h file, but the .h file doesn't get written if there are no changes. The .pak file always gets written. Review URL: http://codereview.chromium.org/115035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15432 0039d316-1c4b-4281-b951-d872f2087c98
* mac valgrind bot: Make running dsymutil an option for now, since it slows ↵dkegel@google.com2009-05-062-11/+22
| | | | | | | | down the run a lot, and causes timeouts. Reenable by default once we have multiple mac bots. Review URL: http://codereview.chromium.org/114003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15431 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: remember user's last selected path for select file dialogs.estade@chromium.org2009-05-061-7/+50
| | | | | | | | | | | | | Note that paths are remembered separately for save and open. This is *not* the same behavior as windows chrome/linux firefox, which remember the same path for both save and open. My justification is the following scenario: 1. User presses ctrl-o, and selects a file from the desktop. 2. One hour later, user presses ctrl-s to save a webpage. 3. User expects to be saving to his default download dir, but instead gets the desktop. 4. Huh? Review URL: http://codereview.chromium.org/115007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15430 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable pref service's PreservedWindowPlacementIsLoaded ui test. robertshield@google.com2009-05-061-11/+11
| | | | | | | | Alter the test to use EXPECT_ instead of ASSERT_ when checking the window placement to not abort the test on data mismatch. Review URL: http://codereview.chromium.org/115027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15429 0039d316-1c4b-4281-b951-d872f2087c98
* Re-baseline and create baselines for tests added in ↵darin@chromium.org2009-05-06199-287/+325
| | | | | | | | | | | http://trac.webkit.org/changeset/43215 BUG=11483 R=dglazkov Review URL: http://codereview.chromium.org/112003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15428 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for a DCHECK regression introduced by http://codereview.chromium.org/112001erikkay@google.com2009-05-061-2/+0
| | | | | | | | | | | | Code was removing itself as an observer for something it was no longer observing. TEST=interactive_ui_tests.exe --gtest_filter=BookmarkBarViewTest1.Basic TBR=sky Review URL: http://codereview.chromium.org/113037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15427 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 4376 -- Press "Tab" key to navigate - Text focus is ↵xji@chromium.org2009-05-061-2/+2
| | | | | | | | | | | | | showing at wrong place in Hebrew and Arabic. (http://crbug.com/4376) When draw focus rectangle, x-axis need to be mirrored in RTL locale. BUG = http://crbug.com/4376 Review URL: http://codereview.chromium.org/109055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15425 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor view from methods to show hung renderer dialog.tc@google.com2009-05-069-95/+92
| | | | | | | | | | This moves the methods into a header that all platforms can use and keeps the windows implementation in hung_renderer_view.cc. Review URL: http://codereview.chromium.org/109039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15424 0039d316-1c4b-4281-b951-d872f2087c98
* Add an extra colon to make inspector work again.dglazkov@chromium.org2009-05-062-2/+2
| | | | | | | | | | | | | This was broken by http://codereview.chromium.org/101026. R=glen BUG=11532 TESt=open inspector. Inspector shouldn't show a blank page. Review URL: http://codereview.chromium.org/113034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15423 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the "pick a new user data dir" dialog on windows.tc@google.com2009-05-063-6/+8
| | | | | | | | | | | | | | | | There were three things to be fixed: 1) We don't need to run a separate message loop after the dialog closes. The MessageLoopForUI handles this properly. 2) When tearing down browser_process_impl, io_loop hasn't been initialized yet, so we check to make sure it exists before using it. 3) We don't call window->Close() because that deletes the dialog class before we're done using it. This means we leak the window, but that's ok because we're going to exit anyway. Review URL: http://codereview.chromium.org/114004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15422 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused chrome switches.tc@google.com2009-05-062-9/+0
| | | | | | | | | I also looked at the test_shell switches, but they are all used. Review URL: http://codereview.chromium.org/108036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15421 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 178.0 to 179.0laforge@chromium.org2009-05-061-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15420 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ChromeCanvas code to respect text alignment in Linux by using pango.willchan@chromium.org2009-05-061-0/+6
| | | | | | Review URL: http://codereview.chromium.org/111004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15418 0039d316-1c4b-4281-b951-d872f2087c98
* Create a separate UI surface for extensions (bottom shelf) and remove them ↵erikkay@google.com2009-05-0612-193/+341
| | | | | | | | | | | | | | from the bookmarks bar (for now). The current implementation doesn't do anything new except for always appear when extensions are loaded. TEST=install an extension and see it show up in the new bottom bar TEST=unit_tests.exe --gtest_filter=ExtensionViewTest.BottomBar Review URL: http://codereview.chromium.org/112001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15417 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a test for a testing that the bug http://crbug.com/9791 is really fixed.jcampan@chromium.org2009-05-064-190/+96
| | | | | | | | | | | | Removing the interstitial UI tests: they test the same functionalities as the unit-tests but are flacky and most of them have been disabled (a new unit-test for the "show interstitial and then navigate back" has been added to cover for a case that the unit-tests were not covering). TEST=Run the unit-tests. BUG=6729,3327 Review URL: http://codereview.chromium.org/109038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15416 0039d316-1c4b-4281-b951-d872f2087c98
* PageActions now work across tabs and windows.finnur@chromium.org2009-05-0612-97/+111
| | | | | | | | | | | The extension system now provides TabId to extensions so it is now possible to activate PageActions in other tabs besides the first in the tab strip. :) BUG=None TEST=None (requires a PageAction extension to test against). Review URL: http://codereview.chromium.org/109046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15415 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a bug where we were inadvertently closing Valgrind-owned FDsrohitrao@chromium.org2009-05-061-23/+30
| | | | | | | | | | | when running under Valgrind. TEST=None http://crbug.com/11412 Review URL: http://codereview.chromium.org/108042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15414 0039d316-1c4b-4281-b951-d872f2087c98
* Re-re-write the logic to elevate uninstaller.kuchhal@chromium.org2009-05-065-118/+140
| | | | | | | | | | | | | | BUG=7178 TEST=Test install/uninstall in various combinations as described below and make sure that files or registry keys are not left behind: Distribution: {Chromium|Google Chrome} Install Level: {system|user} Delete Profile Option: {Selected|Not selected} Default Browser: {set|not set} Review URL: http://codereview.chromium.org/109037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15412 0039d316-1c4b-4281-b951-d872f2087c98
* Changes for upstreaming V8DocumentLocationCustom.cpp.levin@chromium.org2009-05-064-23/+63
| | | | | | | | | BUG=http://bugs.chromium.org/11467 TEST=Verify that Document.location works from javascript. Review URL: http://codereview.chromium.org/108024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15411 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 11479 - RTL Regression: Ellipsis showing at the right ↵xji@chromium.org2009-05-061-1/+1
| | | | | | | | | | | | | | | side of the button on "Google Chrome Options" dialog. (http://crbug.com/11479) This is another regression caused by code refactoring. Instead of assign data member "label_" directly as the input parameter in constructor, calling SetLabel() which takes care of label layout in RTL locale. BUG=http://crbug.com/11479) Review URL: http://codereview.chromium.org/113010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15410 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15399.maruel@chromium.org2009-05-068-12/+27
| | | | | | | broke purify Review URL: http://codereview.chromium.org/115026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15409 0039d316-1c4b-4281-b951-d872f2087c98
* A file list for official builds (what gets picked up for saving)thomasvl@chromium.org2009-05-061-0/+1
| | | | | | Review URL: http://codereview.chromium.org/110006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15408 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Update test expectataions.pfeldman@chromium.org2009-05-061-17/+19
| | | | | | | | BUG=11477 Review URL: http://codereview.chromium.org/113031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15406 0039d316-1c4b-4281-b951-d872f2087c98
* Redraw the location bar on reload. This change is Gtk+ port of 100198.deanm@chromium.org2009-05-061-1/+1
| | | | | | | | | | | http://codereview.chromium.org/100198 Patch by Yusuke Sato. Review URL: http://codereview.chromium.org/106007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15405 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable gconf usage from ProxyConfigServiceLinux because of Glib ↵deanm@chromium.org2009-05-063-0/+8
| | | | | | | | | | | | | races. Patch by Stephane Doyon. BUG=11442 Review URL: http://codereview.chromium.org/109040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15404 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Do not fail on closing WebInspector while on a breakpoint.pfeldman@chromium.org2009-05-065-39/+78
| | | | | | Review URL: http://codereview.chromium.org/108020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15403 0039d316-1c4b-4281-b951-d872f2087c98
* Improvements to Linux InfoBubble and BookmarkBubble.deanm@chromium.org2009-05-064-26/+197
| | | | | | | | | | | - Introduce a delegate to notify when the bubble is closed. - Destroy the objects when the widgets are destroyed. - Cleanup some style issues, add a bunch more comments. Review URL: http://codereview.chromium.org/99276 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15402 0039d316-1c4b-4281-b951-d872f2087c98
* Change Browser::GetIndexOfController to GetIndexOfTabContents. Now that webrettw@chromium.org2009-05-068-27/+12
| | | | | | | | don't have tab contents switching, identifying tabs by their controller is weird, so we should gradually move to only using TabContents*. Review URL: http://codereview.chromium.org/115018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15399 0039d316-1c4b-4281-b951-d872f2087c98
* In process-per-tab mode devtools window may be open for the devtools window ↵yurys@google.com2009-05-062-0/+30
| | | | | | | | using hotkey. This should be useful for development. Review URL: http://codereview.chromium.org/108028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15398 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some unnecessary includes.ben@chromium.org2009-05-064-4/+0
| | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/115016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15397 0039d316-1c4b-4281-b951-d872f2087c98
* Reset the window favicon when the throbber is complete. This fixes the bug usingbrettw@chromium.org2009-05-061-1/+7
| | | | | | | | | the Vista frame for popups that the throbber icon is never replaced. http://crbug.com/8078 Review URL: http://codereview.chromium.org/113024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15396 0039d316-1c4b-4281-b951-d872f2087c98
* Make task_manager.h a bit more independent from views.phajdan.jr@chromium.org2009-05-062-63/+65
| | | | | | | | | | | | | | | Let the internal TaskManagerContents be the DialogDelegate instead of the TaskManager itself. This is a small step towards porting the TaskManager. TEST=Launch chrome.exe, open the Task Manager, close it. Close the browser. Nothing should be broken, the browser should not crash. http://crbug.com/11461 Review URL: http://codereview.chromium.org/111002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15395 0039d316-1c4b-4281-b951-d872f2087c98
* Added FindTabById which finds the Browser, TabStripModel, TabContents & ↵rafaelw@chromium.org2009-05-062-65/+65
| | | | | | | | | | | | | index associated with a given tab_id. tabs.get(), move(), update() & delete() can now find tabs in any window by the tab_id BUG=11200 R=mpComplete Review URL: http://codereview.chromium.org/110005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15393 0039d316-1c4b-4281-b951-d872f2087c98
* honor index in createTab()rafaelw@chromium.org2009-05-0618-88/+110
| | | | | | | | | BUG=11200 R=brettw,beng Review URL: http://codereview.chromium.org/99300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15392 0039d316-1c4b-4281-b951-d872f2087c98
* Gyp updates for webkit build:sgk@google.com2009-05-062-7/+36
| | | | | | | | | | | | | | | * Add missing resources (generated .rc files) to the Windows 'test_shell' sources, with appropriate dependences on the net_resources and webkit_{resources,strings} targets. * Add <(SHARED_INTERMEDIATE_DIR)/webkit to the 'webcore' include_dirs, and in direct_dependent_settings, so webcore and its targets can find the generated webkit/HTMLNames.h. * Only remove build/precompiled_webkit.{cc,h} on non-Windows platforms. * Add the glue/devtools/*.js files to the 'inspector_resources' target so they get copied into resources\inspector. Review URL: http://codereview.chromium.org/100355 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15391 0039d316-1c4b-4281-b951-d872f2087c98
* 'resources' => 'chrome_resources' in the newly-addedsgk@google.com2009-05-061-3/+6
| | | | | | | Windows-only(-for-now) test targets. Review URL: http://codereview.chromium.org/99308 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15390 0039d316-1c4b-4281-b951-d872f2087c98
* Merge two TabContents::InvalidateTypes types and properly update tab ↵estade@chromium.org2009-05-0611-53/+13
| | | | | | | | | | | | download icon. INVALIDATE_FAVICON and INVALIDATE_TITLE become INVALIDATE_TAB. Also removed some dead code. TEST=starting a download in a tab should show the download icon. Closing the dshelf should make the icon disappear. Review URL: http://codereview.chromium.org/109050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15387 0039d316-1c4b-4281-b951-d872f2087c98
* roll DEPS to pick up latest WebKit (no real code changes)darin@chromium.org2009-05-061-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15384 0039d316-1c4b-4281-b951-d872f2087c98
* Find bar:estade@chromium.org2009-05-068-15/+14
| | | | | | | | | - system bell for linux find bar when search not found - move "not found" logic to find bar controller Review URL: http://codereview.chromium.org/112002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15382 0039d316-1c4b-4281-b951-d872f2087c98
* Redo of http://codereview.chromium.org/100097 to make work on Linux and Mac.glen@chromium.org2009-05-068-5/+656
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15380 0039d316-1c4b-4281-b951-d872f2087c98
* Make RestoreTab synchronuous.huanr@chromium.org2009-05-066-10/+28
| | | | | | Review URL: http://codereview.chromium.org/109053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15379 0039d316-1c4b-4281-b951-d872f2087c98
* Change chrome-ui to chrome. I didn't go too far in converting existing ↵glen@chromium.org2009-05-0626-70/+74
| | | | | | | | | | | | | | strings to using the url_constant (shipshipship). Users (such as those on Beta and Dev using session restore) attempting to load the old pages will see a blank white screen. BUG=11272 TEST=Verify that the inspector, debugger, history, downloads and newtab pages load with chrome:// URLS. Verify that replacing the chrome:// with chrome-ui:// does not work. Review URL: http://codereview.chromium.org/101026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15378 0039d316-1c4b-4281-b951-d872f2087c98
* Move Courgette from internal depot to third_party.sra@chromium.org2009-05-0648-0/+8001
| | | | | | Review URL: http://codereview.chromium.org/113009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15377 0039d316-1c4b-4281-b951-d872f2087c98
* Doesn't fix anything at all but make it clearer.maruel@chromium.org2009-05-061-28/+28
| | | | | | Review URL: http://codereview.chromium.org/109051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15375 0039d316-1c4b-4281-b951-d872f2087c98
* fix checkdeps by adding temporary exemption for win_util.hben@chromium.org2009-05-061-0/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15374 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustage - forgot to remove these files from the old vcprojben@chromium.org2009-05-061-8/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15373 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustage - forgot to remove these files from the old vcprojben@chromium.org2009-05-061-8/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15372 0039d316-1c4b-4281-b951-d872f2087c98
* Move: drag_drop_types, favicon_size, icon_util, insets, path, ↵ben@chromium.org2009-05-0692-194/+195
| | | | | | | | | message_box_flags, os_exchange_data to src/app http://crbug.com/11387 Review URL: http://codereview.chromium.org/115012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15371 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 08:39:54 +0000