| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
TBR=pinkerton
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
These files now compile on linux (but they don't link) and they still pass windows. When Pawel gets done with his changes to UI test stuff, we should be able to just enable these tests.
The changes to chrome.gyp are just to fix lint errors.
Review URL: http://codereview.chromium.org/63149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tab strip as it now no longer needs to forward messages for everything. Created a toolbar controller to encapsulate much of the toolbar logic that was in the tab contents controller. Better parameterized the tab strip controller so that it could switch any view, not just the main window's content view, when switching tabs.
Review URL: http://codereview.chromium.org/65011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/65014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Mac build fix) now that
http://src.chromium.org/viewvc/chrome?view=rev&revision=13181 has
landed.
Review URL: http://codereview.chromium.org/62179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/65015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
alert, confirm and onbeforeunload. prompt has a dialog, but there's
no text field. I'll work on that next.
It turns out there's no nested message loop on the windows side,
so there's no nested message loop here either.
BUG=9493
Review URL: http://codereview.chromium.org/63134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/62161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/43095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/64004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/62176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This change depends on v8 change http://codereview.chromium.org/65006/show
Review URL: http://codereview.chromium.org/65007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
gtk which uses utf8 for all its strings.
TBR=evanm
Review URL: http://codereview.chromium.org/62187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/63048
(by Craig Schlenter)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/62172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce new "Preferences" for printer overlays were added in PrefNames:
- printing.page.header.left
- printing.page.header.center
- printing.page.header.right
- printing.page.footer.left
- printing.page.footer.center
- printing.page.footer.right
The prefs file will look like this:
"printing": {
"page": {
"header": {
"left": " ",
"center": " ",
"right": " "
},
"footer": {
"left": "{date}",
"center": " ",
"right": " "
}
}
}
The steps for Printer Preferences:
Step 1:
Introduce some sort of persistence for header/footer which is located
in the Preference file.
Step 2:
Allow PrinterQuery to read those stored preferences and setup
PrinterSettings so that it will apply it when printing.
Step 3:
Create a UI for the print preference, so that the users will easily
change those printing settings.
NOTE: I tested the following approach while doing a simple Hack with
PrintJob (if you see the previous patch), and it works great, with some
bad after effect.
It was done for testing purposes. So I hope we are going in the right
direction.
BUG=947 (http://crbug.com/947)
Patch contributed by Mohamed Mansour <m0.interactive@gmail.com>
Review: http://codereview.chromium.org/60118/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
layer interface. This will help when we move those interfaces into
the WebKit API.
This is a second attempt at r13381, which was already reviewed here:
http://codereview.chromium.org/63126
The only change between that CL and this one is in render_view.h, where I
needed to change a parameter type from gfx::Rect to WebRect.
TBR=dglazkov
Review URL: http://codereview.chromium.org/64005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/65010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/65008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
- Cache 200 resources
- Hide agent functionality behind the flag
Review URL: http://codereview.chromium.org/62183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=7178
Review URL: http://codereview.chromium.org/58019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Don't draw with ChromeCanvas, we will have better text layout by using
Pango directly, and better remote X performance by not blitting a bitmap.
- Text is draw with Pango on top of GDK (no Cairo inbetween).
- Double buffered server side, and just a few GDK operations for rects.
- Improve our handling of InvalidateLine / PaintUpdatesNow. We previously
always invalidated the entire window. We now communicate with the model
the way we should, and only invalidate damaged lines, and then do a sync
paint in PaintUpdatesNow to repaint them.
This is a small step backwards, because we are no longer showing the
description text. This easy to fix, but I'm going to try to implement the
entire new results look and icons at the same time.
Review URL: http://codereview.chromium.org/63119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=6381
This is just duplicate of http://codereview.chromium.org/62142 for committing the change, as I had to switch git clients.
Review URL: http://codereview.chromium.org/65002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/45062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/62182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactored code out of CustomDrawButton into CustomDrawButtonBase to be shared with GoButtonGtk.
Replaced the existing non-togglable go button with GoButtonGtk.
Note that tooltip support isn't done yet, as it changes based on the state of the location bar and the go/stop state.
Add a simple test.
Fix some minor lint errors.
BUG=9381
Review URL: http://codereview.chromium.org/62154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
focused text-field.
It was triggering form autofill or password autofill indiscriminately, causing a regression: double clicking a login text-field would trigger password autofill preventing the expected behavior of selecting the text in the text-field. Only form autofill is expected to be triggered in that case.
BUG=9544
TEST=Open a page with a login form for which you have saved a password. Double-click the login text-field, this should select all the text. Ensure the form autocomplete still works as expected.
Review URL: http://codereview.chromium.org/62143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
clear to me whether my changes to run_webkit tests are
a cause or whether these are just flaky, but they are
flaky. TBR.
Review URL: http://codereview.chromium.org/62177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
response.
Review URL: http://codereview.chromium.org/63130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I give up. Not sure why the filters aren't working, but I
suspect that even if I get them working, they will be becoming
invalid all the time anyway as the codebase changes.
Too bad, because the information we got from purify was useful
(it found a couple memory leaks in other parts of Chrome) but
I really need to get back to work. And I think that having this
unit test running, even without purify, is more valuable than
not.
I created a bug on this and assigned it to myself. Hopefully as
more people do high-level tests like this, the bugs will
slowly be worked out. Otherwise, I'll eventualy get back to it.
Review URL: http://codereview.chromium.org/62173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/62170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/63148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This reverts commit r13397.
Review URL: http://codereview.chromium.org/63150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
always want to delete the cache instance.
Review URL: http://codereview.chromium.org/63138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
have auto-fill, bringing the popup crashes the browser. This is because the WebContentView may not have a delegate.
BUG=None
TEST=Requires code change, adding a select or a text-field to the Gears dialog for example.
Review URL: http://codereview.chromium.org/63146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the linux port because GTK expects UTF8.
Review URL: http://codereview.chromium.org/62166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=9848
Review URL: http://codereview.chromium.org/63145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/62169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/63142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/6138
Review URL: http://codereview.chromium.org/62167
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This brings in support for reading TrueType tables via Skia. This
should allow us to move some of our metrics changes into our WebKit
port and out of Skia.
http://codereview.chromium.org/63133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/62163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Up and Down arrow keys. It doesn't need to - instead the page should scroll even if focus is on the Find bar.
This patch forwards those selected keypresses to the page for its perusal.
Known issues: Just like Firefox, the page doesn't scroll if it has frames.
SONG=I like to fixit fixit. I like to fixit fixit.
BUG=7079
TEST=Open FindInPage on a webpage that has a vertical scrollbar. Press Down, Up, PageDown and PageUp and the page should scroll accordingly. Make sure no ding is heard while doing so. Also make sure this works if focus is on a textfield/textarea when you press Ctrl+F.
Review URL: http://codereview.chromium.org/62129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add a unittest for the below bug.
BUG=9859
Review URL: http://codereview.chromium.org/62162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
Review URL: http://codereview.chromium.org/58018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
changed, and it looks like another occurrence of it showed up (?).
Review URL: http://codereview.chromium.org/63140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- We don't support chromehtml protocol anymore and future installers do not register it
- Avoid stale registry entries to invoke us
BUG=9860
BUG=9862
Review URL: http://codereview.chromium.org/64003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
stability finally. This is the flake for all the runs
since early this morning.
Review URL: http://codereview.chromium.org/63135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13383 0039d316-1c4b-4281-b951-d872f2087c98
|