summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* linux: add mutter to window frame whitelistevan@chromium.org2009-09-251-0/+1
| | | | | | | | | BUG=20381,23109 TEST=it compiles Review URL: http://codereview.chromium.org/235029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27285 0039d316-1c4b-4281-b951-d872f2087c98
* [Relanding erg's change with fix for toolkit_views shortcuts and jcampan@chromium.org2009-09-2517-365/+825
| | | | | | | | | | | | | | | | | | | | | | | | | | | interactive ui tests. Note that this was originally reviewed in http://codereview.chromium.org/217022/show I originally Elliot suggestion of replacing the usage of int for keycode with the bae::Keycode type, but that led to the CL getting out of hands (as this is used in many different places). So this is only the patch set 1 of that CL, I'll replace the type in another CL] Use windows keycodes under linux (and all non-windows platforms). This fixes any place where we use a VKEY_* (RenderWidgetHost, for example) under Linux, but breaks accelerators in TOOLKIT_VIEWS which relied on this wrong behaviour. Previously, keyboard_codes_linux defined all the VKEY_* constants as their GDK_* counterparts, which is wrong since the VKEY_* are supposed to resolve to windows key codes. BUG=22551 TEST=Make sure accelerators still work as expected on Chrome Linux and Chrome Linux with toolkit views. Test when the the accelerators with the focus in the location bar and also with the focus on the page. Review URL: http://codereview.chromium.org/235025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27284 0039d316-1c4b-4281-b951-d872f2087c98
* Rename "xmpp/constants.*" to" xmpp/xmppconstants.*"nick@chromium.org2009-09-2524-24/+26
| | | | | | | | | | The intent is to fix a link error that seems to happen when two compilation units share a filename: there is another constants.cc in p2p/base. Touch xmppconstants.h to work around a git cl upload bug. Review URL: http://codereview.chromium.org/244010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27283 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a few bugs in view/gtk frameworkoshima@chromium.org2009-09-253-11/+50
| | | | | | | | | | | | | | | | | NativeControlGtk * Layout if the visibility is changed after the native view is created. (I also added DCHECK(GetWidget()) to make sure Wiget is available at this point) NativeViewHostGtk * decrement the native_view's ref count only if it still has a parent. * create fixed in AddedToWidget if fixed_ does not exist. This can happen when a view is removed, then added. BUG=none TEST=unit test for last 2 bugs is added to view_unittest.cc (ChangeVisibility). Review URL: http://codereview.chromium.org/219035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27282 0039d316-1c4b-4281-b951-d872f2087c98
* Second attempt at the new syncer thread impl, now with less crashes!tim@chromium.org2009-09-2515-257/+1637
| | | | | | | | | | | | | | | | | Previous one at http://codereview.chromium.org/214033. I had local edits that resulted in initializing the CommandLine for syncapi, but didn't have them as part of the patch, so this was causing a crash whenever SyncerThreadFactory::Create was called. The only diff here is the call to CommandLine::Init in syncapi.cc. This effectively means you can't change the syncer thread impl on linux (we init an empty command line there), but this is OK. Once we link statically we won't need to do this. TEST=ProfileSyncServiceTest, SyncerThreadTest, SyncerThreadWithSyncerTest Review URL: http://codereview.chromium.org/250001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27281 0039d316-1c4b-4281-b951-d872f2087c98
* Remove COMPILER_MSVC flags from gyp files. When we do need it, we cannick@chromium.org2009-09-253-15/+1
| | | | | | | | | | get it from the build/build_config.h. TEST=unit tests BUG=none Review URL: http://codereview.chromium.org/248004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27280 0039d316-1c4b-4281-b951-d872f2087c98
* Enable ExtensionApiTest.Toolstriprafaelw@chromium.org2009-09-251-1/+1
| | | | | | | | | | Need debug output from http://codereview.chromium.org/242012 BUG=22668 Review URL: http://codereview.chromium.org/246011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27277 0039d316-1c4b-4281-b951-d872f2087c98
* Add LOG(INFO) debug output to help track down extension browsertest flakinessrafaelw@chromium.org2009-09-251-0/+4
| | | | | | | | BUG=22668 Review URL: http://codereview.chromium.org/242012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27276 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: remove --google-internal-crash-reporting.agl@chromium.org2009-09-251-0/+3
| | | | | | | | | It's time to kill this. It's been marginally useful, but only marginally. http://codereview.chromium.org/222021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27275 0039d316-1c4b-4281-b951-d872f2087c98
* Currently in full tab mode IE displays the security zone as Unknown. This CL ↵ananta@chromium.org2009-09-252-62/+180
| | | | | | | | | | | | | | | | | | | | | | | fixes that by returning URLZONE_INTERNET for most of the URLs, as we cannot directly map them to internal/external URLs. The reason being Chrome would need to honor the security settings from IE based on the zone. We also disallow navigation in ChromeFrame for restricted URLs. This fixes bug http://b/issue?id=2059403 This CL also fixes the stray issues with cf:attach_external_tab being visible in the tab title at times. This can be easily reproduced if the tabs being opened are background tabs. To set the title we call Exec on the IOleCommandTarget exposed by the frame. This is queried off the IOleInPlaceSite interface which is maintained by the m_spInPlaceSite member variable in CComControlBase. This member is not set when the tab is opened as a background tab and only gets set when it is activated. The fix is to query the IOleInPlaceSite interface from the IOleClientSite interface if the m_spInPlaceSite is not set. This fixes http://b/issue?id=2119243 Bug=2059403,2119243 Review URL: http://codereview.chromium.org/220042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27274 0039d316-1c4b-4281-b951-d872f2087c98
* Validate URLs being navigated to by ChromeFrame in the ↵ananta@chromium.org2009-09-251-4/+7
| | | | | | | | | | | | | | ChromeFrameAutomationClient::InitiateNavigation method as this is a central chokepoint. Should fix http://b/issue?id=1934996 Bug=1934996 Review URL: http://codereview.chromium.org/235017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27273 0039d316-1c4b-4281-b951-d872f2087c98
* Add new projects to help speed up the buildbots.nsylvain@chromium.org2009-09-251-0/+51
| | | | | | Review URL: http://codereview.chromium.org/252006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27272 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline fast/dom/HTMLSelectElement/named-options.html. The upstream ↵japhet@chromium.org2009-09-253-5/+48
| | | | | | | | | | | | expectations include failures, and we pass everything BUG=10859 BUG=10861 TEST=green layout bots Review URL: http://codereview.chromium.org/231009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27271 0039d316-1c4b-4281-b951-d872f2087c98
* Enables WebCache columns on OS X's task manager.jamesr@chromium.org2009-09-251-0/+17
| | | | | | | | | TEST=Enabled the Task Manager context menu, opened, enabled columns and observed values that look reasonable. BUG=16221 Review URL: http://codereview.chromium.org/243006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27270 0039d316-1c4b-4281-b951-d872f2087c98
* Add wifi menu button to status bar of Chrome OS. Currently showing mock data ↵chocobo@google.com2009-09-2520-107/+453
| | | | | | | | | | as we have not hooked it up to ChromeOS shared library wifi code yet. TEST=none BUG=23090 Review URL: http://codereview.chromium.org/231014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27269 0039d316-1c4b-4281-b951-d872f2087c98
* Add basic sqlite error handling to the new sqlite handlerscpu@chromium.org2009-09-255-13/+120
| | | | | | | | | | | | This part is just the plumbing of the error detection and notification. BUG=none TEST=none Review URL: http://codereview.chromium.org/223003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27268 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit update 48734:48747levin@chromium.org2009-09-252-1/+4
| | | | | | | | | | | Add a temporary failure for a newly added test. TEST=none BUG=none Review URL: http://codereview.chromium.org/242005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27267 0039d316-1c4b-4281-b951-d872f2087c98
* Create the download folder if it doesn't exist. That is, the actual download ↵thestig@chromium.org2009-09-255-53/+88
| | | | | | | | | | folder, not the default one. BUG=21759 TEST=none Review URL: http://codereview.chromium.org/219017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27266 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: rafaelw,leizerikkay@chromium.org2009-09-251-1/+3
| | | | | | disable a ExtensionApiTest.Toolstrip which is flaky on linux git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27265 0039d316-1c4b-4281-b951-d872f2087c98
* Disable TestOverrideEncoding test. It's been hanging the XP Tests (dbg)(3) ↵thestig@chromium.org2009-09-251-1/+1
| | | | | | | | | | | ui_test all day. BUG=23121 TEST=none TBR=jnd Review URL: http://codereview.chromium.org/252007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27264 0039d316-1c4b-4281-b951-d872f2087c98
* A change to make popups work correctly in the GTK build brokedavemoore@chromium.org2009-09-251-0/+6
| | | | | | | Chrome OS panels...this fixes them. Review URL: http://codereview.chromium.org/242011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27263 0039d316-1c4b-4281-b951-d872f2087c98
* Make extension installation work when the "ask for destinationaa@chromium.org2009-09-251-2/+7
| | | | | | | | | | | of every download" preference is set. BUG=23011 TEST=Set the preference in question, install an extension. You should not get a save as dialog and it should install correctly. Review URL: http://codereview.chromium.org/252005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27262 0039d316-1c4b-4281-b951-d872f2087c98
* Actually run directory validation code on install.aa@chromium.org2009-09-254-3/+18
| | | | | | | | | BUG=23084 TEST=Install extensions attached to referenced bug. You should get an error dialog, not a crash. Review URL: http://codereview.chromium.org/244012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27261 0039d316-1c4b-4281-b951-d872f2087c98
* linux: port some of the download manager unit testevan@chromium.org2009-09-252-28/+137
| | | | | | | | | | | | Mostly lots of #ifdefs tracking platform behaviors. I tried to make the logic correct for Mac, too, but I didn't enable Mac here. BUG=21632 Review URL: http://codereview.chromium.org/220025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27260 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline tests to adjust for changes upstream.dglazkov@chromium.org2009-09-2523-308/+425
| | | | | | | | | | | | | | | http://trac.webkit.org/changeset/48701 (xhr-related changes) http://trac.webkit.org/changeset/48690 (chromium-only test migration) http://trac.webkit.org/changeset/48699 (chromium-only test migration) R=jparent BUG=none TEST=none Review URL: http://codereview.chromium.org/246002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27259 0039d316-1c4b-4281-b951-d872f2087c98
* Make --show-extensions-on-top look exactly, pixel-for-pixelaa@chromium.org2009-09-253-24/+40
| | | | | | | | | | | | | | | identical to the bookmark bar. Used the same semi-transparent image for the button background that the bookmarkbar uses, so that it will work for themes. The upside of this is that we look the same as the bookmark bar. The downside is that we look the same as the bookmark bar (which currently looks pretty bad with some themes). However, with the default theme, I think that the bookmark bar currently looks better than our toolstrips. The UI team should probably create some images that look good with different themes for the bookmark bar, then we can update this again. Review URL: http://codereview.chromium.org/225025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27258 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few \r\ns I accidentally added to a comment.jamesr@chromium.org2009-09-251-2/+2
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/245006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27257 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: stop the window reconfigure debounce timer when a window is closed.mdm@chromium.org2009-09-251-0/+3
| | | | | | | | | BUG=23085 TEST=none Review URL: http://codereview.chromium.org/245010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27256 0039d316-1c4b-4281-b951-d872f2087c98
* Mark destroy-during-npp-new test as flaky.thestig@chromium.org2009-09-251-0/+1
| | | | | | | | | BUG=21841 TEST=none TBR=senorblanco Review URL: http://codereview.chromium.org/246008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27255 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flaky FTPCacheURLCredentials test.thestig@chromium.org2009-09-251-2/+1
| | | | | | | | | BUG=23108 TEST=none TBR=senorblanco Review URL: http://codereview.chromium.org/243009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27254 0039d316-1c4b-4281-b951-d872f2087c98
* Re-ban chrome:// URLs from being added to history until I can craft a more ↵pkasting@chromium.org2009-09-252-3/+5
| | | | | | | | | | fine-grained solution. BUG=23076 TEST=Hit ctrl-t, then ctrl-h, and verify you didn't just add "New Tab" to your history. Review URL: http://codereview.chromium.org/248005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27253 0039d316-1c4b-4281-b951-d872f2087c98
* Refuse to start if we can't get the user data directory.evan@chromium.org2009-09-252-8/+22
| | | | | | | | | | | The alternative is spewing private user data in random directories. BUG=22277 TEST=chmod -x ~/.config; Chrome should refuse to start Review URL: http://codereview.chromium.org/219043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27252 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Add three simple unit tests to the bookmark bar.erg@google.com2009-09-257-14/+122
| | | | | | Review URL: http://codereview.chromium.org/249004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27251 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb the new mixed content API callbacks to the tab contents. We'll actuallyabarth@chromium.org2009-09-258-2/+47
| | | | | | | | | | | | use these notifications in a future patch. No behavior change. R=agl Review URL: http://codereview.chromium.org/241004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27249 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix depressed baseline in Omnibox.shess@chromium.org2009-09-251-2/+1
| | | | | | | | | | | | | | A previous change converted AutocompleteTextFieldCell to rely more on -drawingRectForBounds: rather than tweaking the baseline in an ad-hoc fashion in many places. This adds a place I missed. http://crbug.com/23096 TEST=Browse to www.google.com. When putting focus in the page the url should stay at the same spot as when focus is in the Omnibox. Review URL: http://codereview.chromium.org/242010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27248 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: work around browser windows that get stuck maximized by the WM.mdm@chromium.org2009-09-253-2/+17
| | | | | | | | | BUG=22807 TEST=none Review URL: http://codereview.chromium.org/218040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27247 0039d316-1c4b-4281-b951-d872f2087c98
* Add an additional test for dnsDomainIs() to verify that it doesn't simply ↵eroman@chromium.org2009-09-251-2/+3
| | | | | | | | | | | | match any substring. This is working correctly, but since it was failing in WinHTTP we should have a regression test. BUG=18511 Review URL: http://codereview.chromium.org/245008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27246 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: initialize created_theme_provider_ in the other constructor.mattm@chromium.org2009-09-251-0/+1
| | | | | | | | | | CID=6160 BUG=none TEST=none Review URL: http://codereview.chromium.org/252002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27245 0039d316-1c4b-4281-b951-d872f2087c98
* Run the unit tests in 5 chunks instead of just 1.nsylvain@chromium.org2009-09-252-8/+50
| | | | | | | BUG:19833 Review URL: http://codereview.chromium.org/212040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27244 0039d316-1c4b-4281-b951-d872f2087c98
* The shadow drawn by the browser window was being drawn over bydavemoore@chromium.org2009-09-252-9/+13
| | | | | | | the status area view. Review URL: http://codereview.chromium.org/249002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27243 0039d316-1c4b-4281-b951-d872f2087c98
* L10N pass through download item and download shelf.thomasvl@chromium.org2009-09-255-79/+282
| | | | | | | | | | | | | - l10n the menus - l10n the dangerous item buttons - make view auto size for the dangerous item buttons TEST=download shelf item buttons and menus are localized BUG=20529 BUG=20530 Review URL: http://codereview.chromium.org/245009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27242 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old Mac First Run Migration code.jeremy@chromium.org2009-09-253-147/+0
| | | | | | | | | We've gone through 2 dev release cycles so most users should be upgraded by now, removing code. Review URL: http://codereview.chromium.org/244011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27240 0039d316-1c4b-4281-b951-d872f2087c98
* Force garbage collection after running any unit tests that initialize WebViews.jorlow@chromium.org2009-09-252-14/+19
| | | | | | | | | | | | | It's quite possible that we just plain shouldn't allow any unit tests to initialize WebKit for philosophical and theoretical reasons. But this does seem to work, so I guess we should just go this route for now. BUG=22971 TEST=none Review URL: http://codereview.chromium.org/240001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27239 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an unnecessary vbox from the widget hierarchy.tony@chromium.org2009-09-252-35/+31
| | | | | | | | | | | | | | | | | | | | | Previously, it was: vbox (window_vbox) ..eventbox ..vbox (content_vbox_) ....eventbox ....eventbox ....eventbox ....eventbox I removed content_vbox_ and just put everything into the window vbox. There was no padding, so it's pretty straight forward. Some points for drawing the custom frame border were taken relative to content_vbox_, so those points are adjusted. Review URL: http://codereview.chromium.org/239007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27238 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up external protocol handler to user gestures to prevent malicious ↵estade@chromium.org2009-09-254-1/+26
| | | | | | | | | | | sites from popping up a lot of dialogs (or in the case of whitelisted protocols, launching a lot of programs). BUG=3628 TEST=test.html from crbug.com/21049 Review URL: http://codereview.chromium.org/240002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27237 0039d316-1c4b-4281-b951-d872f2087c98
* Combining suppressions for linux, win and mac into single file (with ↵dimich@google.com2009-09-252-44/+2
| | | | | | | | | | widening of the call stack). BUG=22923, 22932 TEST=Suppressed tests will work again, when fixed. Review URL: http://codereview.chromium.org/235020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27236 0039d316-1c4b-4281-b951-d872f2087c98
* Shortening a recently-added stack prefix for reliability builder a bit, so ↵senorblanco@chromium.org2009-09-251-1/+1
| | | | | | | | | | | | it covers more crashes. BUG=23043 TEST=green is good TBR=maruel Review URL: http://codereview.chromium.org/252003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27235 0039d316-1c4b-4281-b951-d872f2087c98
* posix: fix a bug estade found in the review but I misunderstood his commentevan@chromium.org2009-09-251-1/+1
| | | | | | We still need the "break;" to happen on all platforms. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27234 0039d316-1c4b-4281-b951-d872f2087c98
* Remove "Remove" from download item context menu on linux.thakis@chromium.org2009-09-251-2/+0
| | | | | | | | | BUG=23078 TEST=Download something, open item's context menu. "Remove from list" should no longer be in there. Review URL: http://codereview.chromium.org/246006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27233 0039d316-1c4b-4281-b951-d872f2087c98
* Cut down on flakiness of automated ui tests by changing message ↵estade@chromium.org2009-09-252-66/+32
| | | | | | | | | | | sending/waiting logic. BUG=none TEST=a lot less flaky on linux Review URL: http://codereview.chromium.org/235019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27232 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 02:16:13 +0000