| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
figure out why.
TBR=ben
Review URL: http://codereview.chromium.org/9353
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also do a little bit of the FilePath rewrite as it pertains to this test.
Review URL: http://codereview.chromium.org/9074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9345
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
click the mouse we would crash.
BUG=4047
TEST=see bug
Review URL: http://codereview.chromium.org/9346
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
existing stored pointer is NULL.
Review URL: http://codereview.chromium.org/9130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9342
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I realised that some of the comments and namespacing does not apply anymore.
patch from Paweł Hajdan jr <phajdan.jr@gmail.com> in
http://codereview.chromium.org/9109
Review URL: http://codereview.chromium.org/9343
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
only build debugger and interactive ui tests on windows
TBR=sgk
Review URL: http://codereview.chromium.org/9131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
asserting when encountering time overflow, use the most distant future or past
time representation possible. This fixes assertions that occur when handling
cookies that expire well in the future.
Review URL: http://codereview.chromium.org/8771
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Rename two SConscript files that needed fixing in response to
environment changes in the calling SConscript hierarchy:
chrome\test\interactive_ui\SConscript => interactive_ui_tests.scons
chrome\browser\debugger\SConscript => debugger.scons
* Add the google_update library to LIBS in the using_google_update.scons file.
Review URL: http://codereview.chromium.org/9309
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
When deleting Keywords, the BrowsingDataRemover class may need to load the TemplateURLModel if it isn't loaded and delete keywords asynchronously from the Observe function. The check to see if we were getting the model with the right profile wasn't taking into account that we might be doing this while incognito, which led to us failing to set the waiting_for_keywords_ flag, resulting in a hang (issue 2145). This fixes that.
Review URL: http://codereview.chromium.org/9333
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=674
TEST=none
Review URL: http://codereview.chromium.org/9042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The situation this protects against is better explained in comment 13:
http://code.google.com/p/chromium/issues/detail?id=3772#c13
Review URL: http://codereview.chromium.org/9088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9304
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9339
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
java plugin installer from Sun.
The chrome_plugins_file.xml has been renamed to plugins2.xml. The older
version of the file (plugins.xml) is also being checked in. This is
needed to support the Chrome version in the field.
R=mal
Review URL: http://codereview.chromium.org/9085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
chrome.exe so there's no need to call anything on Vista and later to activate it.
Review URL: http://codereview.chromium.org/9050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
then renavigating very quickly.
BUG=2855
Review URL: http://codereview.chromium.org/9330
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This patch blocks all the extensions that we register.
R=nsylvain
BUG=1463961
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=mark
Review URL: http://codereview.chromium.org/9081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9265
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
turn the webkit slaves green.
Review URL: http://codereview.chromium.org/9112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Disallow shadowing of window.location using __defineGetter__ and
__defineSetter__.
- Make sure that funtions such as toString on location objects cannot
be overwritten by user functions.
This needs V8 revision 656. This will be put back once we have pushed
that version.
Review URL: http://codereview.chromium.org/8737
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9325
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests\http\tests\security\aboutBlank\xss-DENIED-set-opener.html
LayoutTests\http\tests\security\aboutBlank\xss-DENIED-navigate-opener-document-write.html
LayoutTests\http\tests\security\aboutBlank\xss-DENIED-navigate-opener-javascript-url.html
The original expectations included a security access error where the source was about:blank, but as soon as an about:blank is written to it is supposed to get the URL of the script performing the write. This behaviour matches the error messages seen in Firefox and Internet Explorer.
Review URL: http://codereview.chromium.org/9106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
initialization. This allows the thread to be reused later.
Review URL: http://codereview.chromium.org/9276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9263
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
we'll see if it makes a noticable impact on startup time.
Review URL: http://codereview.chromium.org/9059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
It's accepted (along with the corresponding code change) in the upstream (webkit r36289) and we now have it in our tree.
Review URL: http://codereview.chromium.org/9289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
reflect its rage change."
This issue is caused by my code that cannot extract a target clause from a composition string when there is an input clause after a target clause.
when a user changes the range of a target clause, Japanese IMEs creates a composite clause which consists of a new target clause and an input clause. My IME code treats such composite clause as a target clause and cannot reflect the change.
To fix this problem, this code changes the algorithm which extracts a target clause.
Review URL: http://codereview.chromium.org/8970
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
so that we restore the window if minimized/iconified and give focus to
the search field.
BUG=4038 4044
TEST=see bugs
Review URL: http://codereview.chromium.org/9069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the bookmarks folder tree model to return custom icons for search and
recently bookmarked.
BUG=674
TEST=none
Review URL: http://codereview.chromium.org/9047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
using_KJSBinding.vsprops.
Mismatching causes object layout mismatching, and crashes JSC build right way.
Review URL: http://codereview.chromium.org/9294
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=nsylvain
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=jam
Review URL: http://codereview.chromium.org/9073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9292
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Use using_hunspell.scons and using_wtl.scon instead of
by-hand additions to CPPPATH and CPPDEFINES.
* Only add $CHROME_DIR/tools/build/win on Windows systems.
* Add 'hunspell' to LIBS in using_hunspell.scons so we don't
have to add it by hand.
Review URL: http://codereview.chromium.org/9071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=3912
Review URL: http://codereview.chromium.org/9273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
installer build.
Review URL: http://codereview.chromium.org/9068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NPObject was deallocated by the script controller but WebPluginDelegateProxy wasn't telling NPObjectStub that it's contained object was garbage soon enough.
BUG=1036087
Review URL: http://codereview.chromium.org/9066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Sandbox is currently having a problem with this so it is disabled.
Fixed a few stray items.
Review URL: http://codereview.chromium.org/9259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=paulg
Review URL: http://codereview.chromium.org/9290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(while leaving the HTTP authentication dialog support) and add a new type of constrained window which owns all blocked popups. Rip out dead unit tests.
Review URL: http://codereview.chromium.org/8782
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4523 0039d316-1c4b-4281-b951-d872f2087c98
|