| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12961
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=5109
Review URL: http://codereview.chromium.org/13140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12963
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This lets us set different expecations for the release and debug.
Also, update a test with these expectations.
Review URL: http://codereview.chromium.org/12955
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NPN_RequestRead to initiate seekable byte range requests on the stream. While the contract on the plugins part is not fully clear from the mozilla docs, this is what Firefox does.
This also improves performance greatly as the manual data stream already has most of the data which the plugin requests anyway. I verified this with large PDF files around 14-15MB. We are twice as faster with this fix.
This fixes http://code.google.com/p/chromium/issues/detail?id=5009, which is an issue with the PDF file not loading at times. The problem also occurs at times in Firefox when we set breakpoints and thus slow down the operation.
The Reader plugin displays its UI in child windows on a separate thread in the plugin process. These are parented to the plugin window which lives on the plugin thread. The plugin thread unfortunately is treated as an IO thread by
the plugin and it uses the SendMessage API to send messages to the plugin thread and back. If the plugin fails to receive data for the PDF file in a reasonable time,
it just destroys the PDF window hierarchy causing this issue.
Handing the data off the manual data stream along with the byte range data speeds up the whole operation and thus avoids this issue to a great extent.
Bug=5009
R=jam
Review URL: http://codereview.chromium.org/12960
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
If the user doesn't have wdiff installed, we just write an
error message in place of the diff.
Review URL: http://codereview.chromium.org/13147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
since that header will be added later in
HttpNetworkTransaction::BuildRequestHeaders.
This change prevents POST requests from having a duplicate
Content-Length header.
Review URL: http://codereview.chromium.org/12965
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and mentioned in comments) will arrive in a later patch. The buffers are already checked in under media/base/buffers.h
Review URL: http://codereview.chromium.org/13116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first step to allow the http cache to store additional metadata
for certain entries.
The cache file format changes to version 2.0 so an effect of this cl is
that the borwser will discard the old cache files.
Review URL: http://codereview.chromium.org/12880
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(Equivalent to the mac change in svn diff -r38682:38683 http://svn.webkit.org/repository/webkit/trunk/LayoutTests/platform/mac/editing/deleting/5168598-expected.txt)
Review URL: http://codereview.chromium.org/12966
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12956
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=ojan
Review URL: http://codereview.chromium.org/13144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
FilePaths. Re-enable relevant posix unit tests.
Review URL: http://codereview.chromium.org/12893
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
bug: https://bugs.webkit.org/show_bug.cgi?id=22051
Review URL: http://codereview.chromium.org/10424
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
checks for existing installation, appropriate rights and for past offers for Google Chrome.
The code borrows heavily from similar code written for Toolbar and Desktop (linked to from the bug).
The test executable when run on a machine only makes sure that DLL and lib can be used to invoke the compatibility check function.
BUG=1380504
Review URL: http://codereview.chromium.org/12922
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The x-height isn't really any longer the actual height of an 'x'. Some
faces provide an explicit x-height value in the OS/2 table which we
should use if given.
Review URL: http://codereview.chromium.org/12953
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
page does not hold references to DOM objects.
This should reduce noise of reporting leaked nodes.
Review URL: http://codereview.chromium.org/12936
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Looks like Desktop (and probably new Talk as well) verify for the existence of "URL Protocol" value before using Chrome command to launch browser (see b/1326171).
BUG=1386406
Review URL: http://codereview.chromium.org/13117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
aftermath.
Review URL: http://codereview.chromium.org/13114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12943
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I introduced a regression in my reimplemenation of Find-in-page. The active match ordinal in Find-in-page (also known as "the 7" in "7 of 9") would be just a little off on pages with frames.
Problem A: When you search for something in gmail, for example, the ordinal could start off slightly negative or be 0. I wasn't checking the last_match_count_ of a frame for negative numbers before adding it to the total (it starts off as -1 and remains that way if the frame is not deemed to be worthy of being scoped, i.e. if it is hidden).
Problem B: On pages with multiple matches spread across multiple frames the ordinal would not be subtracted correctly after pressing F3 and Shift-F3 to go back to the frame you were on. We shouldn't be increasing/decreasing the active_match_index for a given frame when FindNext/FindPrevious causes us to jump between frames. We should instead reset it.
I added two tests to catch this in the future. They test ordinal values as you use Find in page (including combinations of frames/no-frames & FindNext/FindPrevious).
Oh, and I also removed some traces that were supposed to expose why a test was flaky, but it turns out to have been something unrelated to the test.
Review URL: http://codereview.chromium.org/13130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
builder green.
Review URL: http://codereview.chromium.org/13136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
languages options menu.
Review URL: http://codereview.chromium.org/12908
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
not give any suggestions.
Issue=1677
Review URL: http://codereview.chromium.org/11285
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
signed/unsigned error in the ipc_message unit test.
Review URL: http://codereview.chromium.org/12946
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a layout test mode flag in some places, and an interactive flag in others. It was especially confusing since interactive = !layout_test_mode.
This should make it much easier to grep for difference between layout test mode and normal "interactive" mode.
Review URL: http://codereview.chromium.org/12940
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
causing some slight font differences between layout test mode and interactive mode.
Review URL: http://codereview.chromium.org/12941
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ASSERT is invalid in the new position and it is causing layout test
failures in debug mode.
TBR=feng
Review URL: http://codereview.chromium.org/13123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This includes Evan's change to use char instead of wchar_t for counter
names.
Also, because of changes to the regexp parser, we need to rebaseline a
couple of tests mainly because of error message changes. Most of the
tests were already rebaselined because of differences in error
messages.
Review URL: http://codereview.chromium.org/12902
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
update underlying gdk window during paint operation.
Review URL: http://codereview.chromium.org/13082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Set svn:eol-style native for .vcproj files.
Set svn:eol-style CRLF for .sln files.
Review URL: http://codereview.chromium.org/12931
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR = tony
Review URL: http://codereview.chromium.org/12932
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need to push the calculation of the x-height into Skia. For one of
the layout tests, it assumes that 2.5ex of Ahem is exactly 32px.
Previously we calculated the x-height of Ahem to be 13px, so 2.5*13 was
33px.
Now we use the 26.6 fixed point number from freetype's hinter and turn
that directly into a floating point value (x-height is the only WebKit
metric which is a floating point value).
This lets us pass LayoutTests/css2.1/t1507-c526-font-sz-02-b-a.html
(although the Windows baseline is wrong)
Review URL: http://codereview.chromium.org/13112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The binding code relies on the type id to cast 'void*' to the right C++ type in order
to call ref() and deref().
Bump third_party/WebKit to 6342 to include depeered RefCounted files and etc.
Review URL: http://codereview.chromium.org/12903
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12929
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6341 0039d316-1c4b-4281-b951-d872f2087c98
|