| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Patch from gmatht, originally reviewed at
http://codereview.chromium.org/160630
Review URL: http://codereview.chromium.org/164091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We should immediately stop the ftp network transaction in such case.
TEST=Covered by net_unittests.
http://crbug.com/18546
Review URL: http://codereview.chromium.org/164067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this patch they are using ExtensionErrorReporter, but I
don't think it's actually useful for users to see them on the
chrome://extensions page.
BUG=http://crbug.com/18565
TEST=You should no longer see messages like "Extension update
manifest parse error: Invalid codebase url"on the
chrome://extensions page.
Review URL: http://codereview.chromium.org/164008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
valgrind run.
Move one suppression from 6547 to new bug 18664 as we widen it, 'cause 6547 was marked closed, and the history was messy.
Also disable ErrorPageTest.DNSError_GoBack2Forward2 -- it hangs often on mac under valgrind, possibly a bug in valgrind.
BUG=6547,16628,18661,18664
TEST=swing mac around your head on its power cord, see if any memory leaks out
Review URL: http://codereview.chromium.org/165076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Fix the bookmark bar to draw the same as the toolbar (tile the background
image and have a transparent background).
2) Fix the tab backgrounds to be offset correctly rather than always drawing
as if we're the first tab.
Some small code cleanup in views/tabs/tab_renderer.h.
Review URL: http://codereview.chromium.org/165078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18643
TEST=turn on num lock. Escape in omnibox resets the address.
Review URL: http://codereview.chromium.org/165079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=hclam
BUG=18461
TEST=tests should be disabled
Review URL: http://codereview.chromium.org/165082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit d98d01314c8b0905ac236d98dc39508ad8acfd05 (r22644).
This should make the linux ui tests green.
Review URL: http://codereview.chromium.org/164086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=18434
TEST=AudioRendererBaseTest.CompleteLifeTime
This patch fixes the busy looping and leaks by ignore the
end-of-stream packet.
Review URL: http://codereview.chromium.org/165023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=included ui test
Review URL: http://codereview.chromium.org/160576
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
255.255.255.255 results in ERR_ADDRESS_UNREACHABLE whereas on Windows it
results in ERR_ADDRESS_INVALID. Map both of these errors to the same value of
-1004 for the sake of matching the layout test behavior of WebKit for the Mac.
This may also fix ChromiumMac, but I haven't tested it there yet.
R=dglazkov
BUG=18665
TEST=none
Review URL: http://codereview.chromium.org/165077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for trace).
BUG=http://crbug.com/18654
TEST=Linux valgrind UI tests greener
Review URL: http://codereview.chromium.org/164082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
version.
Fixes a race condition with file descriptors, and gives the Mac access to the environment-alterning version of LaunchApp
BUG=11174
TEST=Launching render/plugin/utility processes should still work on the Mac
Review URL: http://codereview.chromium.org/165067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Upstream bug was fixed and test did not crash after 100 iterations locally, nor
did valgrind find anything amiss.
http://crbug.com/10439
Review URL: http://codereview.chromium.org/164083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=15267
TBR=pkasting
Review URL: http://codereview.chromium.org/165074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
It turns out that 'settings' is the correct GYP target type for this
sort of thing. Thanks to Evan for pointing out my mistake.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This follows the general style of r21663, which we agreed was the way
to do this.
http://codereview.chromium.org/164080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/18309
Review URL: http://codereview.chromium.org/164010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=scherkus
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebFrameLoaderClient.
This ensures that we never attempt loading an empty URL and fixes the crash in the layout test, mentioned below.
BUG=16754
TEST=LayoutTests/fast/loader/empty-embed-src-attribute.html
R=darin
Review URL: http://codereview.chromium.org/164078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=pkasting
BUG=18665
TEST=none
Review URL: http://codereview.chromium.org/164081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This follows the general style of r21663, which we agreed was the way
to do this.
Note that, currently, one cannot build with system libbz2 on a 64-bit
system since it's not part of the ia32-compat package.
http://codereview.chromium.org/165016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This fixes all the "does not define a type" compile errors.
Review URL: http://codereview.chromium.org/164046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This follows the general style of r21663, which we agreed was the way
to do this.
Note that, currently, one cannot build with system zlib on a 64-bit
system since it's missing a symlink to libz.so in /usr/lib32.
http://codereview.chromium.org/164027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
be able to return the key of an open entry.
Whenever a critical corruption is detected by the disk cache,
the backend disables itself and starts failing all requests
until it's able to re-create the backing store.
Key's longer than 928 bytes are not stored inside the entry
itself, so a file object is required to access them. The backend
will reject any request for a file object after it is disabled,
so a user's request for the key of an open entry will also
fail.
Now we keep a pointer to the related file object (if needed) so
that we don't have to ask the backend for it when the user
requests the current key.
BUG=9952
TEST=unittest
Review URL: http://codereview.chromium.org/165030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Our current GOT patching code is platform specific and fails to work
when V8 is built as a library.
Instead we define global functions for those functions which we wish
to override. Since we will be first in the dynamic resolution order,
the dynamic linker will point callers to our versions of these
functions. However, we have the same binary for both the browser and
the renderers, which means that our overrides will apply in the
browser too.
The global |g_am_zygote_or_renderer| is true iff we are in a zygote or
renderer process. It's set in ZygoteMain and inherited by the
renderers when they fork. (This means that it'll be incorrect for
global constructor functions and before ZygoteMain is called -
beware).
Our replacement functions can check this global and either proxy the
call to the browser over the sandbox IPC
(http://code.google.com/p/chromium/wiki/LinuxSandboxIPC) or they can
use dlsym with RTLD_NEXT to resolve the symbol, ignoring any symbols
in the current module.
TEST=Run javascript:alert(new Date().getTimezoneOffset()). It shouldn't return 0 unless you're actually in GMT.
BUG=16800
http://codereview.chromium.org/165011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL also revises how we print resource errors to make our results more
close resemble those of Mac WebKit.
security/block-test-no-port.html is no longer WONTFIX since we always run
layout tests with a no-proxy configuration now.
security/block-test.html does not need to be skipped on mac since we now have a
FTP implementation ;-)
R=dglazkov
BUG=18610
TEST=none
Review URL: http://codereview.chromium.org/165038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jam
BUG=18598
TEST=WebKit purify bot stays green.
Review URL: http://codereview.chromium.org/164073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=18461
TEST=test_shell_tests --gtest_filter=MediaLeakTest.*
Enabling the MediaLeakTest(s) because they should pass now
due to the problematic webkit change at r46769 was reverted.
Review URL: http://codereview.chromium.org/164005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(1) If the theme provides a inactive tab background, don't offset the
image. This matches the Windows code.
(2) Tile the toolbar background in both the X and Y direction (no longer
use a ninebox for this).
(3) Make the toolbar event box have an invisible window so toolbar
backgrounds with transparency will show the background behind it.
TEST=Install the Grass theme from the theme gallery. It shouldn't look janky.
Review URL: http://codereview.chromium.org/164023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=17481
TEST=media_unittests
Introduced a mesage broadcasting mechanism to notify filters of events from
another filter. In particular this is used to notify all filters that the
audio device has failed and special actions should be taken to handle it. In
this case, demuxer should disable the audio stream and should free the demuxed
audio packets instead of caching them. This will fix the memory leak that
happens if audio device fails during playback.
Review URL: http://codereview.chromium.org/159845
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=timsteele
BUG=18659
TEST=none
Review URL: http://codereview.chromium.org/165069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160676
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SSLWrite.
Ignore errSSLClosedNoNotify for site compatibility, even though it
makes us potentially vulnerable to truncation attacks.
Replace the default ERR_FAILED error code with the more specific
ERR_SSL_PROTOCOL_ERROR.
R=avi
BUG=http://crbug.com/16758
TEST=see bug 16758 for a test case.
Review URL: http://codereview.chromium.org/165025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverts r22593, which was itself a revert of r22555.
Per nsylvain, it looks like the memory_test failures
weren't helped by rolling back this change.
TBR=nsylvain
Review URL: http://codereview.chromium.org/165059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=timsteele
BUG=18656
TEST=none
Review URL: http://codereview.chromium.org/164075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=16675
TBR=pkasting
Review URL: http://codereview.chromium.org/164072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(including abarth's v8 revert, in hopes of fixing reliability).
BUG=none
TEST=no layout redness
TBR=amanda
Review URL: http://codereview.chromium.org/165062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/18480
TEST= Open incognito window. Note that NTP is themed.
Review URL: http://codereview.chromium.org/164002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16128
TEST=Less red on the Mac valgrind bot.
Review URL: http://codereview.chromium.org/165019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/18425
TEST= Cause download shelf to appear. Hover over a link in the extreme lower left corner of the page. Note that status bubble dodges to the right, instead of dropping to obscure the shelf.
Review URL: http://codereview.chromium.org/159878
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=awalker
BUG=none
TEST=no layout test regressions
Review URL: http://codereview.chromium.org/165057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=eroman
Review URL: http://codereview.chromium.org/164057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
linux.
BUG=18206
TEST=none
TBR=tc
Review URL: http://codereview.chromium.org/165050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22604 0039d316-1c4b-4281-b951-d872f2087c98
|