summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Mark MessageLoop::delayed_work_queue_ as initialized so Purify doesn't ↵ericroman@google.com2008-12-173-8/+17
| | | | | | | | | | report any UMRs when reading its comparator. BUG=5555 Review URL: http://codereview.chromium.org/14810 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7171 0039d316-1c4b-4281-b951-d872f2087c98
* Fix WebKit builder.evanm@google.com2008-12-171-0/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7170 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two bugs resulting in bad window resize behavior:sky@google.com2008-12-171-5/+8
| | | | | | | | | | | | | | | | | . Dragging a tab out was forcing the bounds to fit on the monitor. This was a regression introduced during some refactoring. The fix is not to call Window::SetBounds, but instead SetWindowPos (which is roughly what the old code did). . When the bounds of the window change always layout. We need this for the situation where the normal bounds and maximized bounds are the same because we layout differently in the two. BUG=5540 5118 TEST=see description in 5118 Review URL: http://codereview.chromium.org/14511 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7169 0039d316-1c4b-4281-b951-d872f2087c98
* Updated media::MediaFormat to use char/std::string instead of ↵scherkus@chromium.org2008-12-172-22/+22
| | | | | | | | wchar_t/std::wstring. Review URL: http://codereview.chromium.org/14805 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7168 0039d316-1c4b-4281-b951-d872f2087c98
* Yet more layout test wreckage.evanm@google.com2008-12-1713-1375/+8
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7167 0039d316-1c4b-4281-b951-d872f2087c98
* update linux tests failing listtc@google.com2008-12-171-2/+3
| | | | | | | | | | I removed -expected.txt for two of these tests and the other is a plugin test. Review URL: http://codereview.chromium.org/15005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7166 0039d316-1c4b-4281-b951-d872f2087c98
* Increase UMA upload interval, and upload usage stats more oftenjar@google.com2008-12-173-27/+81
| | | | | | | r=evanm Review URL: http://codereview.chromium.org/14186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7165 0039d316-1c4b-4281-b951-d872f2087c98
* bucketing and re-basing more mac testspinkerton@google.com2008-12-1718-86/+1023
| | | | | | Review URL: http://codereview.chromium.org/14807 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7164 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline numeric-conversions per ager's advice.erg@google.com2008-12-173-4/+50
| | | | | | | | | The expected files expect a FAIL line because I can't change the upstream test. Copying the test to the platform/directories doesn't help because the test is actually in a resources/xxx.js file and there seem to be problems with paths in that case. Review URL: http://codereview.chromium.org/15201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7163 0039d316-1c4b-4281-b951-d872f2087c98
* Correct typo in SDCH problem logging code.jar@google.com2008-12-172-3/+4
| | | | | | | r=openvcdiff,huanr Review URL: http://codereview.chromium.org/14802 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7162 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in download tab view that resulted from attempting tosky@google.com2008-12-171-1/+4
| | | | | | | | | | | | | | | paint a download at downloads_.size(). This happened if the last download is visible, in which case row_stop == downloads_.size() and because the loop iterates to row_stop we try accessing downloads_[downloads_.size()]. BUG=5520 TEST=Bring up the downloads view and make sure you can scroll to the end of your downloads without crashing. Review URL: http://codereview.chromium.org/14806 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7161 0039d316-1c4b-4281-b951-d872f2087c98
* Cleans up the code style of the Accessibility Test suite.klink@chromium.org2008-12-1712-893/+848
| | | | | | | | BUG=2236 Review URL: http://codereview.chromium.org/13333 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7160 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 7156.ojan@google.com2008-12-178-202/+19
| | | | | | | Broke the build. Review URL: http://codereview.chromium.org/15402 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7159 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed failed test in net_perftest.darin@chromium.org2008-12-172-1/+2
| | | | | | | | | | | | | | | | | TestAddCookieOnManyHosts would fail due to SetCookie() returning false when true was expected. Cause of the failed cookie insert was due to httponly cookie being used in the test. Removed httponly from cookie. Patch by jroesslein@gmail.com R=darin -This line, and those below, will be ignored-- M AUTHORS M net/base/cookie_monster_perftest.cc git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7158 0039d316-1c4b-4281-b951-d872f2087c98
* More Linux pixeltest work. Going through the expected-fail list.evanm@google.com2008-12-174-13/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7157 0039d316-1c4b-4281-b951-d872f2087c98
* * On POSIX, make sure we don't leak FDs when launching child Processes.jeremy@chromium.org2008-12-178-19/+202
| | | | | | | | | | | | * Add a facility to LaunchProcess() to remap a given FD into a child process. This change is needed for 2 reasons: 1)We want to use a socketpair() for IPC, the child process needs a known FD # for it's side of the socket. 2)The OS X Sandbox doesn't close FDs. Review URL: http://codereview.chromium.org/14497 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7156 0039d316-1c4b-4281-b951-d872f2087c98
* Fix syntax error. TBR to green tree.ojan@google.com2008-12-171-1/+5
| | | | | | Review URL: http://codereview.chromium.org/14804 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7155 0039d316-1c4b-4281-b951-d872f2087c98
* Make the linter just compare base paths instead of looking at all the files ↵ojan@google.com2008-12-174-59/+55
| | | | | | | | | on disk. Now it takes ~3 seconds on my machine. Also, make sure that each path in the test lists actually corresponds to a file/directory on disk. This is slightly stricter than we need to be as we could do partial paths, but I don't see the benefit in supporting that. As it is, I've found a lot of tests that are listed incorrectly in the test_lists because they point to paths that don't exist. Review URL: http://codereview.chromium.org/14099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7154 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 7149.jcampan@chromium.org2008-12-1736-1108/+1607
| | | | | | Review URL: http://codereview.chromium.org/15004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7153 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux release build.evanm@google.com2008-12-171-5/+6
| | | | | | | Review URL: http://codereview.chromium.org/15401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7151 0039d316-1c4b-4281-b951-d872f2087c98
* Revamp of the interstitial pages.jcampan@chromium.org2008-12-1736-1607/+1108
| | | | | | | | | | | | | | The interstitial is now a RVH that is displayed on top of the WebContents with no interaction with the WebContents' RenderViewHostManager. This simplifies the states that the RenderViewHostManager has. The interstitial is responsible for hiding and deleting itself when told to proceed/not proceed or when a navigation occurs or the tab is closed. The interstitial now uses a data URL (instead of loading some alternate HTML), which allowed me to remove some interstitial flags from NavigationController::LoadCommittedDetails and ProvisionalLoadDetails. Also changed tab_utils::GetTabContentsByID to return a WebContents since only WebContents have a RVH associated with them. TEST=Run all ui tests and unit tests. Review URL: http://codereview.chromium.org/13764 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7149 0039d316-1c4b-4281-b951-d872f2087c98
* Add some debug output to the test shell that webkit now expects.estade@chromium.org2008-12-174-26/+31
| | | | | | | | The two deleted baselines were previously the exact same as the webkit baselines, and are now out of date. Review URL: http://codereview.chromium.org/14185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7148 0039d316-1c4b-4281-b951-d872f2087c98
* Include "base/hash_tables.h" instead of hand-picking header files.avi@google.com2008-12-171-2/+1
| | | | | | | | | | | | | | This fixes a compile error with gcc4.3 (hash_fun.h was moved from ext/ to backward/) and seems like the proper way to go since hash_tables.h defines the hash interface for Chromium. Patch from James Vega. http://codereview.chromium.org/14510 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7147 0039d316-1c4b-4281-b951-d872f2087c98
* Unbreak unit_test failure on Windows.phajdan.jr@chromium.org2008-12-171-17/+18
| | | | | | Review URL: http://codereview.chromium.org/15002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7146 0039d316-1c4b-4281-b951-d872f2087c98
* * Add resource file to criteria checker test application to get CompanyName.kuchhal@chromium.org2008-12-173-56/+275
| | | | | | Review URL: http://codereview.chromium.org/15001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7145 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline with borders.tc@google.com2008-12-174-80/+77
| | | | | | | | | | | I accidentally checked in baselines without borders on our form controls. TBR=ojan Review URL: http://codereview.chromium.org/14198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7144 0039d316-1c4b-4281-b951-d872f2087c98
* * Remove re-offer check from criteria checker.kuchhal@chromium.org2008-12-171-154/+0
| | | | | | | | | BUG=1380504 TBR=gwilson Review URL: http://codereview.chromium.org/14197 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7143 0039d316-1c4b-4281-b951-d872f2087c98
* Platform cleanup in browser/ and porting of few files.phajdan.jr@chromium.org2008-12-1711-47/+52
| | | | | | Review URL: http://codereview.chromium.org/14466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7142 0039d316-1c4b-4281-b951-d872f2087c98
* Mostly cleanup.pkasting@chromium.org2008-12-173-136/+107
| | | | | | | | | | | * Use temporary variables when we're going to call AsWebContents() repeatedly * Remove some NOTREACHED()s that don't really help debugging (and none of the surrounding code checks) * Try and simplify or make clearer some bits of code Also enables/disables some commands more selectively: IDC_GO is now enabled only when the go button is visible (i.e. when we're not loading), and several commands whose UI is only available in normal windows are now only enabled in normal windows. This last change fixes a number of weird effects where you could hit different shortcuts in web app and popup windows and trigger commands with little or no UI feedback. Review URL: http://codereview.chromium.org/14182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7141 0039d316-1c4b-4281-b951-d872f2087c98
* Update and inspect V8 failures.erg@google.com2008-12-173-2/+67
| | | | | | | | | number-toString just needed a line added which was in the upstream expected. Review URL: http://codereview.chromium.org/14495 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7140 0039d316-1c4b-4281-b951-d872f2087c98
* Handle HTTP 200 responses received in response to byte range requests issued ↵ananta@chromium.org2008-12-1714-49/+234
| | | | | | | | by the plugin. This means that the server does not support byte range requests. Firefox handles this by destroying the current plugin instance and creating a new instance to handle the response. The stream which is created to pass the data off to the plugin is not seekable.Fix is to emulate Firefox behavior. Will work on unit testing the NPN_RequestRead related code in a separate CB. This fixes http://code.google.com/p/chromium/issues/detail?id=5403Bug=5403 Review URL: http://codereview.chromium.org/14122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7139 0039d316-1c4b-4281-b951-d872f2087c98
* Allow hashmaps and hashsets of FilePath.avi@google.com2008-12-171-0/+19
| | | | | | Review URL: http://codereview.chromium.org/14167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7138 0039d316-1c4b-4281-b951-d872f2087c98
* Mark a test as failing to make the tree go green.tony@chromium.org2008-12-171-0/+3
| | | | | | | TBR=ojan git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7137 0039d316-1c4b-4281-b951-d872f2087c98
* These tests are now fixed.abarth@chromium.org2008-12-171-4/+0
| | | | | | | | R=pamg Review URL: http://codereview.chromium.org/14493 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7136 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 7125.ericroman@google.com2008-12-173-20/+9
| | | | | | | removing the experiment Review URL: http://codereview.chromium.org/14188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7135 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r7131agl@chromium.org2008-12-171-118/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7131 caused duplicates in the tests_fixable.txt file. Redo the intent of r7131: Where the test name ends in ".html" AND The test filename doesn't exist AND test[:-4] + "svg" does exist AND test[:-4] + "svg" doesn't exist in tests_fixable.txt THEN rename the test Script used below: let knownSet = foldl f Set.empty testsFixable where f set (TF.Text _) = set f set (TF.Entry platforms test _ _) | platforms == [] || TF.LINUX `elem` platforms = Set.insert test set | otherwise = set let f v@(TF.Text _) = return v f v@(TF.Entry platforms test results comment) = if ".html" `B8.isSuffixOf` test then do exists <- fileExist $ B8.unpack test if not exists then do let fn = B8.take (B8.length test - 4) test `B8.append` "svg" exists <- fileExist $ B8.unpack fn print fn print $ Set.member fn knownSet if exists then if not (Set.member fn knownSet) then return $ TF.Entry platforms fn results comment else return $ TF.Text "// Check for comments" else return v else return v else return v testsFixable' <- mapM f testsFixable Review URL: http://codereview.chromium.org/14503 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7132 0039d316-1c4b-4281-b951-d872f2087c98
* Fix invalid filenames in tests_fixable.txtagl@chromium.org2008-12-171-61/+61
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Where the test name ends in ".html" AND The test filename doesn't exist AND test[:-4] + "svg" does exist THEN rename the test Script used below: let f v@(TF.Text _) = return v f v@(TF.Entry platforms test results comment) = if ".html" `B8.isSuffixOf` test then do exists <- fileExist $ B8.unpack test if not exists then do let fn = B8.take (B8.length test - 4) test `B8.append` "svg" B8.putStrLn fn exists <- fileExist $ B8.unpack fn if exists then return $ TF.Entry platforms fn results comment else return $ v else return v else return v testsFixable' <- mapM f testsFixable Review URL: http://codereview.chromium.org/14501 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7131 0039d316-1c4b-4281-b951-d872f2087c98
* A few more things in buckets.thomasvl@chromium.org2008-12-172-11/+12
| | | | | | | | | Remove a few that seem to be passing now. Copy on win result over since we'll match that instead of webkit. Lint passes. Review URL: http://codereview.chromium.org/14179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7130 0039d316-1c4b-4281-b951-d872f2087c98
* DatabaseLoadComplete now needs to be run after OnIOInitialize, so change the ↵jam@chromium.org2008-12-171-3/+3
| | | | | | | | | order of the PostTask. BUG=5587 Review URL: http://codereview.chromium.org/14499 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7129 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a helper class used to mark/define critical section in a class and then ↵maruel@chromium.org2008-12-1712-1/+702
| | | | | | | | | | | | install controls to check that those critical sections are not violated. This CL is due the thread posted on chromium-dev: http://groups.google.com/group/chromium-dev/browse_frm/thread/30af0b63b6adb245. From Gaetano Mendola <mendola bigfoot com> Review URL: http://codereview.chromium.org/8621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7127 0039d316-1c4b-4281-b951-d872f2087c98
* Replace some CRects with gfx::Rectagl@chromium.org2008-12-1714-49/+45
| | | | | | | Review URL: http://codereview.chromium.org/14173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7126 0039d316-1c4b-4281-b951-d872f2087c98
* Temp experiment to confirm theory in crbug.com/5555.ericroman@google.com2008-12-173-9/+20
| | | | | | | | | The idea is that by using a comparator which has an (initialized) data member, pop() will avoid a sideffect that reads uninitialized data. Will revert this once it has run on bot. Review URL: http://codereview.chromium.org/14500 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7125 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: rebaseline images and checksums.agl@chromium.org2008-12-172342-1007/+1171
| | | | | | | These have been manually reviewed. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7124 0039d316-1c4b-4281-b951-d872f2087c98
* Increase the chunk size for layout tests (do 120 per run rather than 25). ↵erikkay@google.com2008-12-171-3/+2
| | | | | | | | | This should make each chunk take close to an hour, and thus reduce some of the per-chunk overhead. TBR=nsylvain Review URL: http://codereview.chromium.org/14178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7123 0039d316-1c4b-4281-b951-d872f2087c98
* Add some initial before unload tests. We still need testsojan@google.com2008-12-173-11/+125
| | | | | | | for multiple tabs with beforeunload/unload handlers. Review URL: http://codereview.chromium.org/14085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7122 0039d316-1c4b-4281-b951-d872f2087c98
* Underlying functionality for generating native Visual Studio solution files:sgk@google.com2008-12-173-2/+503
| | | | | | | | | | | | | | | | * New _Node_MSVS.py module (from rspangler) with new MSVSFolder(), MSVSProject() and MSVSSolution() Nodes. This will eventually become a new SCons/Node/MSVS.py module in upstream SCons. * New MSVSNew.py Tool module imports MSVS.py (either from SCons.Node or from our temporary _Node_MSVS.py module) and attaches the appropriate environment methods. * MSVSSolution().Write() will generate a solution file based on explicit configuration in the SConscript files. * While we're here, define $SQLITE_DIR, which will be used by the next checkins. Review URL: http://codereview.chromium.org/14467 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7120 0039d316-1c4b-4281-b951-d872f2087c98
* Make stop work again (I broke it). Rather than revert to the previous ↵pkasting@chromium.org2008-12-171-11/+10
| | | | | | | | | working-but-lame code, this cleans up the code a little further by actually enabling/disabling the stop command at the right times. BUG=5542 Review URL: http://codereview.chromium.org/14498 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7119 0039d316-1c4b-4281-b951-d872f2087c98
* add new ignored errors to global purify filter:erikkay@google.com2008-12-176-883/+0
| | | | | | | | | | BUG=5108 BUG=5464 removed temporary versions of this filter from webkit stack filters git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7118 0039d316-1c4b-4281-b951-d872f2087c98
* Triage some more tests.tc@google.com2008-12-178-371/+368
| | | | | | | | | | | | | | | | 1) move canvas-remote-read-svg-image.html closer to other .getImageData() failures 2) describe failure for autocomplete-cleared-on-back.html and set-form-autocomplete-attribute.html 3) rebaseline float-avoidance.html which passes except for font sizes and form control borders 4) rebaseline fill-stroke-clip-reset-path.html which matches except for font sizes. this test also uses dashboardcompatibilitymode which we don't support in testshell. Review URL: http://codereview.chromium.org/14496 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7117 0039d316-1c4b-4281-b951-d872f2087c98
* Add a test for fts2 prefix searching.mpcomplete@google.com2008-12-171-0/+15
| | | | | | Review URL: http://codereview.chromium.org/14177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7116 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 11:40:56 +0000