| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
algorithm by default.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/248022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
after review)
See http://codereview.chromium.org/222030 for the original review
BUG=none
TEST=compiled & tested chrome target on win/linux, view_examples target on linux.
Review URL: http://codereview.chromium.org/242036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=oshima
Review URL: http://codereview.chromium.org/243034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
to ASSERT_TRUE(... == NULL). Patch by Jacob Mandelson (see http://codereview.chromium.org/202057 ), r=me.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CID=1634
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/242041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=9798,10418,23306
TEST=green is good.
TBR=atwilson
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We expand the _M_mutate rule to match both _M_mutateEjjj (Linux) and
_M_mutateEmmm (Mac) and add a rule for _M_set_length_and_sharable
This patch was prepared by Alexander Potapenko (cc'ed)
Review URL: http://codereview.chromium.org/242054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Make the hyperlink autosize so to the text in it.
TEST=more info looks like a link, and the hand cursor only happens on the link, not with large space on either side.
BUG=17989
Review URL: http://codereview.chromium.org/242052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(pwicks86@gmail.com).
TEST=Use OCMock in a test
BUG=NONE
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Unfortunately, we can't make it more narrow since the stacktrace in the report looks like:
#0 base::Thread::ThreadMain()
#1 ThreadFunc(void*)
#2 ThreadSanitizerStartThread
Review URL: http://codereview.chromium.org/251028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/251001/show
This CL hooks the focus traversal for the TabbedPaneView on Linux with toolkit views.
It also has few focus related fixed (focus with buttons, clearing focus effectively in the focus manager).
BUG=None
TEST=Run the view_examples app. Press tab to move the focus. Try the different tabs.
Review URL: http://codereview.chromium.org/246030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Patch by Bruno Calvignac, http://codereview.chromium.org/193113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/23301
TEST=see bug
Review URL: http://codereview.chromium.org/245035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=see bug
BUG=http://crbug.com/19558
Review URL: http://codereview.chromium.org/249030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/17626
TEST=create a new bookmark bar folder. Open it: the menu should have a disabled item that says "(empty)".
Review URL: http://codereview.chromium.org/235047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I've missed /usr/lib32/nss/libsoftokn3 in the previous patch
( http://codereview.chromium.org/242032 )
("ldd ./sconsbuild/Debug/base_unittests" doesn't show it)
Review URL: http://codereview.chromium.org/235054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updating the failure for now while investigation continues.
BUG=23344
TEST=None
Review URL: http://codereview.chromium.org/255005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/242053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=4359,13907,14831,22296,23306,22552
TBR=atwilson
Review URL: http://codereview.chromium.org/244036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Patch by Thiago Farina, http://codereview.chromium.org/242017
Review URL: http://codereview.chromium.org/251029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23261
TEST=none
Review URL: http://codereview.chromium.org/245045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/transitions/shorthand-border-transitions.html
BUG=http://crbug.com/10382
TBR=huanr
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updating the failure for now while investigation continues.
BUG=23344
TEST=None
Review URL: http://codereview.chromium.org/255003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/245044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This prevents all sorts of fun jank when resizing a window.
BUG=http://crbug.com/23252
TEST=Resize gmail (which is particularly hard on the renderer). The upper left corner of the view should not change, flicker, or jump around.
Review URL: http://codereview.chromium.org/244030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/126045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This came down with WebKit update 48423:48468, just cleaning up to assign a bug number and moving to the right section in test_expectations.txt.
TBR=jrg
BUG=23270
TEST=none
Review URL: http://codereview.chromium.org/246028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable the download location path and the prompt-for-download settings.
BUG=22047
TEST=Preferences --> Under the hood, set download location, downloaded file is in new location.
TEST=Enable prompt for download location, download file, save panel comes up.
Review URL: http://codereview.chromium.org/239008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/254007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
quarantine utility function and move into chrome/browser/cocoa, since common/ is not the right place for browser code.
BUG=22289
TEST=file downloading
Review URL: http://codereview.chromium.org/220037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Load the nib from the main bundle.
- fetch the learn more url from resources instead of hardcoded in source
- the the layout tweak the sizes of the two buttons based on the l10n strings
- make the browser popup auto position based on the size of the checkbox's text.
BUG=20531
TEST=the button always fit their text and position correctly, the browser menu positions next to the text, learn more for breakpad goes to the right language page.
Review URL: http://codereview.chromium.org/248032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fill in the autosizing code so the text fits in all languages.
TEST=popup blocker is sized to it's text in all languages.
BUG=21278
Review URL: http://codereview.chromium.org/242049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Creates a HyperlinkButtonCell that can be used in conjuction with a NSButton
to display the control as a hyperlink (blue underliend text), rather than
a normal Cocoa control.
* Switch the "Get themes..." button in Preferences to be one.
BUG=17989,21414
TEST=Preferences-->Personal Stuff, "Get themes..." is a hyperlink.
Review URL: http://codereview.chromium.org/248019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/245043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG:23336
Review URL: http://codereview.chromium.org/255002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to restore again it
in the same place where the user closed it for the last time.
BUG=22269
TEST=open Search engines, move it to a different location, close it, open it again, see if it is
opened in the latest location that you closed.
Review URL: http://codereview.chromium.org/243024
Patch from tfarina.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=yurys
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
mimeType based on file extension.BUG=23260
Review URL: http://codereview.chromium.org/249032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
default.
BUG=none
Test=Sync my bookmarks should be enabled by default.
Review URL: http://codereview.chromium.org/248024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/244035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tc,jungshik
TEST=None until the corresponding DLLs get built.
Review URL: http://codereview.chromium.org/244034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
API in place.
R=agl
TEST=Covered by our mixed content browser tests
Review URL: http://codereview.chromium.org/248013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
After the last WebKit roll, the following test needs to be rebaselined:
LayoutTests/media/video-empty-source.html
TBR=scherkus
Review URL: http://codereview.chromium.org/244033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=23320
TEST=None
TBR=atwilson@chromium.org
Review URL: http://codereview.chromium.org/245041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=senorblanco@chromium.org
Review URL: http://codereview.chromium.org/254009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
The real fix is probably to add attribute __noreturn__ to CHECK() somehow, but let's fix the tree first.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The approach is to special-case moveToBeginningOfDocument and moveToEndOfDocument in WebFrameImpl::executeCommand(). With this (and the cocoa keyboard bindings patch being landed), the special-case code in WebViewImpl::ScrollViewWithKeyboard() can be removed.
Also add a test for cmd-up/down.
Change chrome.gyp so that it supports osx-only unit tests (_unittest_mac.mm).
Move OnPrintPageAsBitmap to the other printing tests.
BUG=22585
TEST=Go to a page with both text box and scrollbar (e.g. http://en.wikipedia.org ). Pressing cmd-down should scroll to end of page, cmd-up back to start. Clicking the text box and trying some emacs shortcuts should work (ctrl-a jumps to start of line, cmd-h acts as backspace, etc).
Review URL: http://codereview.chromium.org/254002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27464 0039d316-1c4b-4281-b951-d872f2087c98
|