| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/62178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=eroman
Review URL: http://codereview.chromium.org/67033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Implements HTML select popups on Mac OS X as
native Cocoa controls.
BUG=5095 (http://crbug.com/5095)
Review URL: http://codereview.chromium.org/67018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch is by Roland Steiner <rolandsteiner@google.com>.
The original code review is: http://codereview.chromium.org/68001.
The layout test moved upstream from LayoutTests/fast/dom/ to
LayoutTests/fast/xmlhttprequest/, so chromium's forked result needed to move accordingly.
Review URL: http://codereview.chromium.org/67022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
scraping is done after submit events are handled by the page DOM so doing this is safe.
Adds test infrastructure for determining that scraping occurs on submit:
- allow testserver to be configured to serve pages from / on the server
- provide a ui test util that navigates and waits for N subsequent redirections/navigations before returning control to the test to handle automated submission
Eric, please review the test server changes.
Scott, please look over everything else.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13444
Review URL: http://codereview.chromium.org/62145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=tony
Review URL: http://codereview.chromium.org/66027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
method. Also remove some c-style comments that slipped in.
TBR=evan
Review URL: http://codereview.chromium.org/66026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and try to use something lower-level, like a RenderView directly.
Review URL: http://codereview.chromium.org/66021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Too many loose ends.
Review URL: http://codereview.chromium.org/66020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/68005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/66018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/63152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I've run 9 debug runs on my dual core Windows box and
14 debug runs on my quad core Mac. These three were
the only tests that failed. I'm not sure what else
I can do other than to try enabling them for the bots.
Review URL: http://codereview.chromium.org/67021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add -Wall to build/common.gypi (and -Werror, commented out for now).
* Have build/external_code.gypi remove -Wall (and -Werror).
* Remove chromium_code definition from build/all.gyp.
* Remove chromium_code definitions from third_party/ *.gyp files.
* Remove scons-specific -Werror removal in webkit.gyp.
* Remove unused variables from:
base/clipboard_linux.cc
chrome/browser/gtk/download_shelf_gtk.cc
chrome/browser/gtk/bookmark_bar_gtk.cc
Review URL: http://codereview.chromium.org/66001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- move code only used by tests to chrome/test
- make a better, more portable abstraction
For now, it still only works on Windows. But this is the first step
to porting this part of code.
Patch by phajdan.jr@chromium.org: <http://codereview.chromium.org/54003>
Review URL: http://codereview.chromium.org/67004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
during testing.
MetricsService and WebContents weren't handling this case properly.
Review URL: http://codereview.chromium.org/66007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This does not throw the switch to turn it on for the world yet.
Review URL: http://codereview.chromium.org/66008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
We use this to compare different compiler setting, different run-time flags and different branches and revisions of FFmpeg.
Review URL: http://codereview.chromium.org/63068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
bytes" instead, so this does not require additional translations.
BUG=9782
Review URL: http://codereview.chromium.org/67005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
focus (e.g., location bar or find bar had focus). Refactor the special keypress handling so these accelerators work when gtk widgets have focus.
Review URL: http://codereview.chromium.org/67011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Fix GoButtonGtkTest.ChangeModeStop test to call what it's actually supposed to test.
Replace tabs with spaces in chrome.gyp. Also delete a double entry I added earlier.
Review URL: http://codereview.chromium.org/62190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
first try here: <http://codereview.chromium.org/63149>
Review URL: http://codereview.chromium.org/67006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
that this is from parallizing anymore, but these bugs are
basically bugs to look into the general flakiness of
the tests. I'm more and more convinced that for the
majority of these, the test itself is the problem.
Review URL: http://codereview.chromium.org/67016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/67015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This does include some fail lines that I'm being too lazy to fix.
This test itself is in review upstream and the upstream results
won't have the fail lines.
Review URL: http://codereview.chromium.org/67014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
inBrowser::OpenURLFromTab was not using the current tab when no source was
specified. This means we didn't update the correct tab.
This change uses the computed current URL for updating, and also clarifies the
comments in the TabContentsDelegate about what NULL means.
BUG=9799
Review URL: http://codereview.chromium.org/63125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
initialized, since initializing shows them which causes activation to change.
This fixes the regression where select widgets deactivated the frame.s
Review URL: http://codereview.chromium.org/67008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
order to make sure the TabContents' delegate doesn't get clobbered. Fix the define of a file that had been moved a while ago.
Review URL: http://codereview.chromium.org/67007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
downloads.
BUG=1028
TEST=Start several bug downloads, close the browser. A dialog shows up to warn you are about to lose the downloads. Try the wait and continue button. Try again with several windows, and in Incognito mode.
Review URL: http://codereview.chromium.org/62131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/62171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
without domain.
Review URL: http://codereview.chromium.org/63147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
see the NTP for new tabs.
Review URL: http://codereview.chromium.org/65018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ensure there is only 1 process per extension.
I also changed ExtensionMessageService from singleton to one instance per
Profile. This means messages can only be passed to extensions and scripts
within the same profile.
Review URL: http://codereview.chromium.org/62132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also prevent Ctrl+Home and Ctrl+End from being eaten by
the Find window.
Review URL: http://codereview.chromium.org/62180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
scraping is done after submit events are handled by the page DOM so doing this is safe.
Adds test infrastructure for determining that scraping occurs on submit:
- allow testserver to be configured to serve pages from / on the server
- provide a ui test util that navigates and waits for N subsequent redirections/navigations before returning control to the test to handle automated submission
Eric, please review the test server changes.
Scott, please look over everything else.
Review URL: http://codereview.chromium.org/62145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=pinkerton
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
These files now compile on linux (but they don't link) and they still pass windows. When Pawel gets done with his changes to UI test stuff, we should be able to just enable these tests.
The changes to chrome.gyp are just to fix lint errors.
Review URL: http://codereview.chromium.org/63149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tab strip as it now no longer needs to forward messages for everything. Created a toolbar controller to encapsulate much of the toolbar logic that was in the tab contents controller. Better parameterized the tab strip controller so that it could switch any view, not just the main window's content view, when switching tabs.
Review URL: http://codereview.chromium.org/65011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/65014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Mac build fix) now that
http://src.chromium.org/viewvc/chrome?view=rev&revision=13181 has
landed.
Review URL: http://codereview.chromium.org/62179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/65015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
alert, confirm and onbeforeunload. prompt has a dialog, but there's
no text field. I'll work on that next.
It turns out there's no nested message loop on the windows side,
so there's no nested message loop here either.
BUG=9493
Review URL: http://codereview.chromium.org/63134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/62161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13436 0039d316-1c4b-4281-b951-d872f2087c98
|