summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add error messages to JSONReader and friends. This required a bit of ↵aa@chromium.org2008-12-0518-111/+313
| | | | | | | | refactoring to do cleanly. This CL doesn't actually use this capability anywhere except for unit tests. I will add that in a future CL. Review URL: http://codereview.chromium.org/13169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6459 0039d316-1c4b-4281-b951-d872f2087c98
* Add a CHECK to assert that each invocation ofwtc@google.com2008-12-051-0/+5
| | | | | | | | | | | ResourceDispatcherHost::RemovePendingRequest removes exactly one URLRequest from pending_requests_. R=eroman BUG=4749 Review URL: http://codereview.chromium.org/12977 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6458 0039d316-1c4b-4281-b951-d872f2087c98
* changelist for estade readability review.estade@chromium.org2008-12-053-94/+105
| | | | | | | submitted changelist: http://codereview.chromium.org/9154 Review URL: http://codereview.chromium.org/12605 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6457 0039d316-1c4b-4281-b951-d872f2087c98
* Add using_wtl.scons to the chrome\test\automation SCons configuration,sgk@google.com2008-12-051-0/+1
| | | | | | | paralleling addition of using_wtl.vsprops to the VS configuration. Review URL: http://codereview.chromium.org/13401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6456 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline animation/keyframes.htmltc@google.com2008-12-053-4/+66
| | | | | | | | | | | | There's a one line difference where we fail because in V8 typeof(CSSStyleDeclaration) != typeof(rules2.item(0).style). BUG=13154 Review URL: http://codereview.chromium.org/13154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6455 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r6396 the PDF fix to not cancel the manual data streamananta@chromium.org2008-12-055-5/+29
| | | | | | | | | | | | load when the plugin calls NPN_RequestRead. I was looking at the wrong stream implementation in Firefox :( Bug=5009 TBR=jam Review URL: http://codereview.chromium.org/13212 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6454 0039d316-1c4b-4281-b951-d872f2087c98
* Fuzzy matching: remove stray debugging lineagl@chromium.org2008-12-051-1/+0
| | | | | | | | | | | This slipped in via a TBR build fix change (13209) TBR=tony Review URL: http://codereview.chromium.org/13185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6453 0039d316-1c4b-4281-b951-d872f2087c98
* Un-revert 6386 (my CSS change). Layout tests pass for me. I think thempcomplete@google.com2008-12-058-109/+30
| | | | | | | | | builders just need a clobber when this is checked in. I also fixed the SConscript and deleted the old CSS files. Review URL: http://codereview.chromium.org/13146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6452 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build: missed a fileagl@chromium.org2008-12-051-0/+48
| | | | | | | | | TBR=tony Review URL: http://codereview.chromium.org/13209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6449 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a race condition in the SyncChannel code.jam@chromium.org2008-12-052-61/+37
| | | | | | | | | | | The problem is that QueueMessage would be called with listener() on the IPC thread, and then the function would wait on message_lock_ before adding the message and its associated listener. However, in between the time that listener() was called and the lock was taken control of, the listener thread may be calling RemoveListener. The fix is to not send the listener, but instead just send a pointer to the context. It'll be used on the listener thread, at which point listener() can be called to check if the listener is available. BUG=1305036 Review URL: http://codereview.chromium.org/12952 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6448 0039d316-1c4b-4281-b951-d872f2087c98
* Remove LoadURL("about:blank") in the destructor, it crashes the test_shell ↵fqian@google.com2008-12-051-1/+0
| | | | | | | | | | on Linux. TBR = patrick Review URL: http://codereview.chromium.org/13208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6447 0039d316-1c4b-4281-b951-d872f2087c98
* fix chrome_paths to make some test dirs relative to base::DIR_SOURCE_ROOTerikkay@google.com2008-12-054-21/+30
| | | | | | | | | | | | | | rather than chrome::DIR_APP. DIR_APP is in different relative locations on different platforms while DIR_SOURCE_ROOT is the same, so this allows us to share code and be correct on all platforms. Also, enable extensions_service_unittest for Mac and Linux and add an NSAutoreleasePool to ChromeTestSuite (which is now being used by run_all_unittests on Mac and Linux per my earlier checkin). Review URL: http://codereview.chromium.org/13177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6445 0039d316-1c4b-4281-b951-d872f2087c98
* Add fuzzy image matching tool for Linux pixel testsagl@chromium.org2008-12-054-0/+113
| | | | | | | Review URL: http://codereview.chromium.org/13159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6444 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: remove passing tests from tests_fixableagl@chromium.org2008-12-051-80/+6
| | | | | | | | | | | | | | | | | | For each line in tests_fixable: if the platforms list is missing THEN ignore it if the platforms list is [LINUX] AND the test passed the most recent builder run THEN delete it if the platforms list includes LINUX AND the test passed the most recent builder run AND the platforms list does not include WIN THEN remove LINUX from the platforms list Review URL: http://codereview.chromium.org/13180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6443 0039d316-1c4b-4281-b951-d872f2087c98
* UserData Options tabmunjal@chromium.org2008-12-053-3/+44
| | | | | | | | | Plumbing for User Data tab in Options dialog. Review URL: http://codereview.chromium.org/13150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6442 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 6439.nsylvain@chromium.org2008-12-053-13/+4
| | | | | | | Revision 6439 broke the build. I'm reverting it. Please monitor the build after submitting code Review URL: http://codereview.chromium.org/13181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6441 0039d316-1c4b-4281-b951-d872f2087c98
* Change "client" parameter in RLZ ping to "referral" gwilson@google.com2008-12-055-11/+11
| | | | | | | | | | to match Omaha's changes. BUG=1520348 Review URL: http://codereview.chromium.org/12975 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6440 0039d316-1c4b-4281-b951-d872f2087c98
* Same as CL 12831, create a new one to get rid of the eol-style commit error.hclam@chromium.org2008-12-053-4/+13
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6439 0039d316-1c4b-4281-b951-d872f2087c98
* Change the accelerator key for Javascript debug to Ctrl-Shift-D from 'Alt-`'jungshik@google.com2008-12-051-1/+2
| | | | | | | | | BUG=3696,5087 TEST=Install non-en-US keyboard and switch keyboards to one of them (e.g. German, French, Russian) and make sure that shortcut keys for Javascript debug remains 'Ctrl-Shift-L'. Review URL: http://codereview.chromium.org/10652 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6438 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the layout of the Spell Check Options part, in the languages tab, in the ↵sidchat@google.com2008-12-051-18/+20
| | | | | | | | | Fonts and Languages Options Menu, to match with the Mock. Issue=4401 Review URL: http://codereview.chromium.org/12957 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6437 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a bogus initialization of string constants. The stack allocated ↵erikkay@google.com2008-12-051-12/+6
| | | | | | | | | | | string from StringPrintf gets destroyed right away, and c_str is just a pointer to its internal buffer, so the error constant was bogus memory. This showed up in the purify tests. Sorry I missed this in the initial code review. Review URL: http://codereview.chromium.org/13204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6436 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Merge 38850:38900, Part 3dglazkov@google.com2008-12-054-5/+14
| | | | | | Review URL: http://codereview.chromium.org/10425 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6435 0039d316-1c4b-4281-b951-d872f2087c98
* move a few #ifdefs around so that unit_tests does proper path initialization ↵erikkay@google.com2008-12-052-9/+8
| | | | | | | | | | for Mac and Linux. This allows use of things like DIR_TEST_DATA. StatsTable also comes along for the ride. Review URL: http://codereview.chromium.org/13153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6432 0039d316-1c4b-4281-b951-d872f2087c98
* Reverted not-quite-working fix for hotmail issue.plesner@google.com2008-12-054-50/+9
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6431 0039d316-1c4b-4281-b951-d872f2087c98
* bootstrap app target for browser/renderer.pinkerton@google.com2008-12-055-0/+2736
| | | | | | Review URL: http://codereview.chromium.org/13202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6430 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed crash when stack overflow occurs while creating the constructorplesner@google.com2008-12-051-0/+4
| | | | | | | for a don wrapper type. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6429 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed dom node and constructor instantiation so that dom constructorsplesner@google.com2008-12-054-9/+46
| | | | | | | | now have the object prototype as their implicit prototype, rather than the function prototype. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6428 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline to layout tests that are only differ in toString() implementation.olehougaard@google.com2008-12-0510-2/+257
| | | | | | Review URL: http://codereview.chromium.org/12942 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6427 0039d316-1c4b-4281-b951-d872f2087c98
* Update DEPS to pickup changes to ScriptCallContext.h.sgjesse@chromium.org2008-12-051-1/+1
| | | | | | Review URL: http://codereview.chromium.org/13170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6426 0039d316-1c4b-4281-b951-d872f2087c98
* Added line number and source URL information to inspector console messages.sgjesse@chromium.org2008-12-054-6/+97
| | | | | | | | | | | | | This uses a debugger API in V8 which can look at the JavaScript execution stack and find the line number and source URL for the top stack frame. The JavaScript functions required for this are added to a new utility context created in V8Proxy. This context is created as a singleton (on demand) as it has no dependency in the page currently running. I will not submit this change until V8 version 0.4.5 is used in Chrome as this change depends on a new V8 debugger API added to that version. The change also requires a second step to udate the WebKit DEPS. BUG=2960 Review URL: http://codereview.chromium.org/12804 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6425 0039d316-1c4b-4281-b951-d872f2087c98
* We should let binary/octet-stream have an EXE extension to fix compat with ↵abarth@chromium.org2008-12-052-0/+9
| | | | | | | | | | | digsby.com and ohloh.net BUG=1573 R=darin Review URL: http://codereview.chromium.org/13165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6424 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up junk in content sniffing mock-http-headers.abarth@chromium.org2008-12-056-12/+1
| | | | | | | | R=deanm Review URL: http://codereview.chromium.org/13166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6423 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the content sniffing algorithm if the server instructs us to do so ↵abarth@chromium.org2008-12-054-1/+18
| | | | | | | | | | | | with the nosniff directive. For context, see http://blogs.msdn.com/ie/archive/2008/09/02/ie8-security-part-vi-beta-2-update.aspx R=deanm,darin Review URL: http://codereview.chromium.org/12982 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6422 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash on 64-bit systems when an external message hook is installed. Thebrettw@google.com2008-12-051-1/+3
| | | | | | | | | | proxying for CB_GETCOMBOXINFO is wrong and will crash. Instead, call GetComboBoxInfo. BUG=49 Review URL: http://codereview.chromium.org/13156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6420 0039d316-1c4b-4281-b951-d872f2087c98
* update chrome stringstc@google.com2008-12-05110-790/+2479
| | | | | | | | | | | This fixes a the Hebrew translation missing a bunch of strings. TBR=mal Review URL: http://codereview.chromium.org/12976 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6417 0039d316-1c4b-4281-b951-d872f2087c98
* * Add timeout support to POSIX WaitForSingleProcess()jeremy@chromium.org2008-12-053-14/+19
| | | | | | | | * Unify Linux & Mac implementations of WaitForSingleProcess() Review URL: http://codereview.chromium.org/12969 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6416 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly handle (and log) receipt of gzip response to SDCH encode proposaljar@google.com2008-12-053-2/+29
| | | | | | | | | | | | | | | | | | | When the only response to a SDCH encoding proposal (including a statement of an Avail-Dict) is a gzip response, the filtering infrastructure needs to add in a missing "sdch" sniffing filter. This filter should enter into pass-through mode if the content does not have a valid SDCH header. This functionality is critical to the latency experiment, which will signal the fact that a session is in the control group by doing exactly the above pattern (only using gzip, despite the dictionary). This is a blocker for the Chrome SDCH latency experiment. bug = 1520081 reviewers= huanr,openvcdiff,kmixter Review URL: http://codereview.chromium.org/12964 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6415 0039d316-1c4b-4281-b951-d872f2087c98
* Record network latency stats for Win HTTP in a histogramjar@google.com2008-12-052-1/+12
| | | | | | | r=wtc Review URL: http://codereview.chromium.org/12972 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6414 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for gcc build breakscherkus@chromium.org2008-12-051-2/+5
| | | | | | Review URL: http://codereview.chromium.org/13157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6413 0039d316-1c4b-4281-b951-d872f2087c98
* Checking in media::MediaFormat class, which describes the output of a filter.scherkus@chromium.org2008-12-055-1/+223
| | | | | | Review URL: http://codereview.chromium.org/13149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6412 0039d316-1c4b-4281-b951-d872f2087c98
* Apparently the debug-only crash has been fixed. TBR to green build.ojan@google.com2008-12-051-3/+1
| | | | | | Review URL: http://codereview.chromium.org/12973 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6411 0039d316-1c4b-4281-b951-d872f2087c98
* Add new multiprofile files to the SCons build:sgk@google.com2008-12-052-0/+3
| | | | | | | | | chrome\browser\user_data_manager.cc chrome\browser\view\new_profile_dialog.cc chrome\browser\view\select_profile_dialog.cc Review URL: http://codereview.chromium.org/12948 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6410 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: use case-insensitive matching for font names.agl@chromium.org2008-12-051-1/+1
| | | | | | | | | CSS likes to give fonts all lowercase names (verdana, arial etc). Review URL: http://codereview.chromium.org/13139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6409 0039d316-1c4b-4281-b951-d872f2087c98
* Add new debugger_host_impl.cpp to the SCons build.sgk@google.com2008-12-051-0/+1
| | | | | | Review URL: http://codereview.chromium.org/12947 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6408 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Implement setSmartInsertDeleteEnabled andtc@google.com2008-12-057-81/+6
| | | | | | | | | | | setSelectTrailingWhitespaceEnabled" because of layout test regressions. This reverts commit r6404. Review URL: http://codereview.chromium.org/13155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6407 0039d316-1c4b-4281-b951-d872f2087c98
* Remove bindings/js. We no longer use this.dglazkov@google.com2008-12-051-61/+0
| | | | | | Review URL: http://codereview.chromium.org/12971 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6405 0039d316-1c4b-4281-b951-d872f2087c98
* Implement setSmartInsertDeleteEnabled and setSelectTrailingWhitespaceEnabledtc@google.com2008-12-057-6/+81
| | | | | | | | | in the test shell. This causes us to pass at least 2 more tests. Review URL: http://codereview.chromium.org/12933 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6404 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce ExtensionsService. Load extensions on startup from a directory inaa@chromium.org2008-12-0517-32/+435
| | | | | | | | | | the profile if a command-line flag is present. Please carefully scrutinize the threading/ref-counting schenanigans. Review URL: http://codereview.chromium.org/12876 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6403 0039d316-1c4b-4281-b951-d872f2087c98
* Adding the capacity to interact with modal dialogs to the automation framework.jcampan@chromium.org2008-12-0510-53/+203
| | | | | | | | | This change will be used by Ojan to implement some unload handler tests. TEST=Run the ui tests. Review URL: http://codereview.chromium.org/13113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6402 0039d316-1c4b-4281-b951-d872f2087c98
* Split test lists in the way I should've done it originally.evanm@google.com2008-12-051-6/+12
| | | | | | | Review URL: http://codereview.chromium.org/12961 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6401 0039d316-1c4b-4281-b951-d872f2087c98