| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
refactoring to do cleanly. This CL doesn't actually use this capability anywhere except for unit tests. I will add that in a future CL.
Review URL: http://codereview.chromium.org/13169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ResourceDispatcherHost::RemovePendingRequest removes
exactly one URLRequest from pending_requests_.
R=eroman
BUG=4749
Review URL: http://codereview.chromium.org/12977
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
submitted changelist: http://codereview.chromium.org/9154
Review URL: http://codereview.chromium.org/12605
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
paralleling addition of using_wtl.vsprops to the VS configuration.
Review URL: http://codereview.chromium.org/13401
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's a one line difference where we fail because in V8
typeof(CSSStyleDeclaration) != typeof(rules2.item(0).style).
BUG=13154
Review URL: http://codereview.chromium.org/13154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
load when the plugin calls NPN_RequestRead. I was looking at the wrong
stream implementation in Firefox :(
Bug=5009
TBR=jam
Review URL: http://codereview.chromium.org/13212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This slipped in via a TBR build fix change (13209)
TBR=tony
Review URL: http://codereview.chromium.org/13185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
builders just need a clobber when this is checked in.
I also fixed the SConscript and deleted the old CSS files.
Review URL: http://codereview.chromium.org/13146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=tony
Review URL: http://codereview.chromium.org/13209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The problem is that QueueMessage would be called with listener() on the IPC thread, and then the function would wait on message_lock_ before adding the message and its associated listener. However, in between the time that listener() was called and the lock was taken control of, the listener thread may be calling RemoveListener.
The fix is to not send the listener, but instead just send a pointer to the context. It'll be used on the listener thread, at which point listener() can be called to check if the listener is available.
BUG=1305036
Review URL: http://codereview.chromium.org/12952
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
on Linux.
TBR = patrick
Review URL: http://codereview.chromium.org/13208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rather than chrome::DIR_APP. DIR_APP is in different relative locations on
different platforms while DIR_SOURCE_ROOT is the same, so this allows us to
share code and be correct on all platforms.
Also, enable extensions_service_unittest for Mac and Linux and add an
NSAutoreleasePool to ChromeTestSuite (which is now being used by
run_all_unittests on Mac and Linux per my earlier checkin).
Review URL: http://codereview.chromium.org/13177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For each line in tests_fixable:
if the platforms list is missing THEN
ignore it
if the platforms list is [LINUX] AND
the test passed the most recent builder run THEN
delete it
if the platforms list includes LINUX AND
the test passed the most recent builder run AND
the platforms list does not include WIN THEN
remove LINUX from the platforms list
Review URL: http://codereview.chromium.org/13180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Plumbing for User Data tab in Options dialog.
Review URL: http://codereview.chromium.org/13150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Revision 6439 broke the build. I'm reverting it. Please monitor the build after submitting code
Review URL: http://codereview.chromium.org/13181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to match Omaha's changes.
BUG=1520348
Review URL: http://codereview.chromium.org/12975
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=3696,5087
TEST=Install non-en-US keyboard and switch keyboards to one of them (e.g. German, French, Russian) and make sure that shortcut keys for Javascript debug remains 'Ctrl-Shift-L'.
Review URL: http://codereview.chromium.org/10652
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Fonts and Languages Options Menu, to match with the Mock.
Issue=4401
Review URL: http://codereview.chromium.org/12957
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
string from StringPrintf gets destroyed right away, and c_str is just a pointer to its internal buffer, so the error constant was bogus memory. This showed up in the purify tests.
Sorry I missed this in the initial code review.
Review URL: http://codereview.chromium.org/13204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10425
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
for Mac and Linux. This allows use of things like DIR_TEST_DATA.
StatsTable also comes along for the ride.
Review URL: http://codereview.chromium.org/13153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13202
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
for a don wrapper type.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
now have the object prototype as their implicit prototype, rather than
the function prototype.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12942
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This uses a debugger API in V8 which can look at the JavaScript execution stack and find the line number and source URL for the top stack frame. The JavaScript functions required for this are added to a new utility context created in V8Proxy. This context is created as a singleton (on demand) as it has no dependency in the page currently running.
I will not submit this change until V8 version 0.4.5 is used in Chrome as this change depends on a new V8 debugger API added to that version.
The change also requires a second step to udate the WebKit DEPS.
BUG=2960
Review URL: http://codereview.chromium.org/12804
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
digsby.com and ohloh.net
BUG=1573
R=darin
Review URL: http://codereview.chromium.org/13165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=deanm
Review URL: http://codereview.chromium.org/13166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
with the nosniff directive.
For context, see http://blogs.msdn.com/ie/archive/2008/09/02/ie8-security-part-vi-beta-2-update.aspx
R=deanm,darin
Review URL: http://codereview.chromium.org/12982
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
proxying for CB_GETCOMBOXINFO is wrong and will crash. Instead, call
GetComboBoxInfo.
BUG=49
Review URL: http://codereview.chromium.org/13156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a the Hebrew translation missing a bunch of strings.
TBR=mal
Review URL: http://codereview.chromium.org/12976
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
* Unify Linux & Mac implementations of WaitForSingleProcess()
Review URL: http://codereview.chromium.org/12969
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the only response to a SDCH encoding proposal (including a statement of
an Avail-Dict) is a gzip response, the filtering infrastructure needs to
add in a missing "sdch" sniffing filter. This filter should enter into
pass-through mode if the content does not have a valid SDCH header. This
functionality is critical to the latency experiment, which will signal
the fact that a session is in the control group by doing exactly the
above pattern (only using gzip, despite the dictionary).
This is a blocker for the Chrome SDCH latency experiment.
bug = 1520081
reviewers= huanr,openvcdiff,kmixter
Review URL: http://codereview.chromium.org/12964
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=wtc
Review URL: http://codereview.chromium.org/12972
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12973
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
chrome\browser\user_data_manager.cc
chrome\browser\view\new_profile_dialog.cc
chrome\browser\view\select_profile_dialog.cc
Review URL: http://codereview.chromium.org/12948
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CSS likes to give fonts all lowercase names (verdana, arial etc).
Review URL: http://codereview.chromium.org/13139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12947
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
setSelectTrailingWhitespaceEnabled" because of layout test regressions.
This reverts commit r6404.
Review URL: http://codereview.chromium.org/13155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12971
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
in the test shell. This causes us to pass at least 2 more tests.
Review URL: http://codereview.chromium.org/12933
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the profile if a command-line flag is present.
Please carefully scrutinize the threading/ref-counting schenanigans.
Review URL: http://codereview.chromium.org/12876
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This change will be used by Ojan to implement some unload handler tests.
TEST=Run the ui tests.
Review URL: http://codereview.chromium.org/13113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12961
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6401 0039d316-1c4b-4281-b951-d872f2087c98
|