summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Reordered some logic to fix a bug which caused the clearing of the database ↵petersont@google.com2008-11-131-5/+7
| | | | | | | | to malfunction. Review URL: http://codereview.chromium.org/10862 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5365 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize WTF threading before calling EventNames::init() insgk@google.com2008-11-131-0/+1
| | | | | | | | KeyboardTest (as was done in r4786 for DomAutocompleteTests, for debug mode test_shell_tests). Review URL: http://codereview.chromium.org/10669 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5364 0039d316-1c4b-4281-b951-d872f2087c98
* Add extra pass throughs for enforge.agl@chromium.org2008-11-131-4/+6
| | | | | | | | | | | | Add march flag to builds. Our system compilers are assuming > i386 already, but not all gcc installations will do this. Without an march flag, gcc assumes only a 386 and then some atomic operations are compiled to undefined references which break linking. Review URL: http://codereview.chromium.org/10689 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5363 0039d316-1c4b-4281-b951-d872f2087c98
* * Fix Google Chrome build broken by r4284.kuchhal@chromium.org2008-11-131-2/+2
| | | | | | | | TBR=cpu Review URL: http://codereview.chromium.org/10686 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5362 0039d316-1c4b-4281-b951-d872f2087c98
* disable warnings in third_party dmg_fptc@google.com2008-11-132-0/+5
| | | | | | Review URL: http://codereview.chromium.org/10880 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5361 0039d316-1c4b-4281-b951-d872f2087c98
* Do another merge using nifty new merge script (CL for that coming soon).ojan@google.com2008-11-131-1/+1
| | | | | | Review URL: http://codereview.chromium.org/10670 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5360 0039d316-1c4b-4281-b951-d872f2087c98
* Fix LayoutTests/http/tests/loading/gmail-assert-on-load.html test.darin@chromium.org2008-11-132-5/+3
| | | | | | | | | | | The trick here is to properly check for a Frame that has been removed by checking for a null Page. This matches what happens in other WebKit ports. R=dglazkov Review URL: http://codereview.chromium.org/10882 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5359 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary fix on Finnur's behalf to make find useful until bigger fix issky@google.com2008-11-131-2/+4
| | | | | | | | done. Review URL: http://codereview.chromium.org/10881 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5357 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid flakiness related to progress notifications sometimes happening in a ↵darin@chromium.org2008-11-133-35/+5
| | | | | | | | | | | | nested fashion. Due to the event sending controller, it is possible for the completion of one load to kick off another or lead to the cancelation of a third. These situations can easily result in DidStartLoading being called twice without a DidStopLoading in between, and vice versa. Upstream DRT does not care about the progress notifications being ordered properly, and so I don't think we should either. R=tony Review URL: http://codereview.chromium.org/10888 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5356 0039d316-1c4b-4281-b951-d872f2087c98
* Changes UnloadUITest to navigate to last URL synchronously in hopes ofsky@google.com2008-11-131-3/+4
| | | | | | | | | | | | | making ui test more consistent. I suspect I could get the same effect by changing the last sleep to kMaxTestExecutionTime, but seems best to use the sync function here. TEST=none BUG=none Review URL: http://codereview.chromium.org/10692 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5354 0039d316-1c4b-4281-b951-d872f2087c98
* revert these changes to see if this helps the UI tests.beng@google.com2008-11-131-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5353 0039d316-1c4b-4281-b951-d872f2087c98
* Delay the ProcessWork call just like WebKit's DumpRenderTree implementation.darin@chromium.org2008-11-132-10/+18
| | | | | | | | | | | | | | | | To precisely match their behavior, I had to not delay the TestFinished call when there is no work to process. This CL avoids bugs related to DidStartLoading being called without a preceding DidStopLoading. https://bugs.webkit.org/show_bug.cgi?id=21068 describes the duplicate load problem in more detail, and I think that is a real bug that should be fixed. R=brettw Review URL: http://codereview.chromium.org/10676 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5351 0039d316-1c4b-4281-b951-d872f2087c98
* Update webkit deps after idl-file changes.ager@google.com2008-11-131-1/+1
| | | | | | Review URL: http://codereview.chromium.org/10685 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5350 0039d316-1c4b-4281-b951-d872f2087c98
* Unfork SVGElementInstance.idl and EventTargetNode.idl.ager@google.com2008-11-132-13/+11
| | | | | | | | | | EventListener attributes have been added to the WebKit idl files and we can now use them as is with a minor change to the code generator. Also cleaned up DOMWindow.idl and got rid of some of the differences. Review URL: http://codereview.chromium.org/10684 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5349 0039d316-1c4b-4281-b951-d872f2087c98
* Some speculative fixes for UI test flakiness.beng@google.com2008-11-133-11/+15
| | | | | | | | | | - make the window update locking use window visibility instead of WM_SETREDRAW. I believe WM_SETREDRAW is causing the window to become visible during tests. - potential crashes caused by NULL TabcontentsDelegates. TBR=sky Review URL: http://codereview.chromium.org/10674 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5335 0039d316-1c4b-4281-b951-d872f2087c98
* fix scons webkit build on windowstc@google.com2008-11-132-0/+2
| | | | | | | | | | | I added a new dependency to base and it was needed by targets build on windows (but not yet on linux). tbr=sgk Review URL: http://codereview.chromium.org/10868 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5333 0039d316-1c4b-4281-b951-d872f2087c98
* Disable NPAPITester.SelfDeletePluginInvokeAlert UI test. It doesn't seem tompcomplete@google.com2008-11-131-1/+1
| | | | | | | | | | work on the buildbots. I need to find a better way to get the WindowProxy for the alert dialog. TBR=jam Review URL: http://codereview.chromium.org/10667 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5332 0039d316-1c4b-4281-b951-d872f2087c98
* Restructure the the pump for nested loops.deanm@chromium.org2008-11-132-42/+83
| | | | | | | | Change our work dispatching to be based around an event source. This will allow us to still participate when a message loop is pumped by outside code (nested message loops). Review URL: http://codereview.chromium.org/10854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5331 0039d316-1c4b-4281-b951-d872f2087c98
* * fix sandbox build on windowstc@google.com2008-11-133-0/+3
| | | | | | | | tbr=evan Review URL: http://codereview.chromium.org/10863 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5330 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox metrics logging patch splitout, part 5: Add additional ↵pkasting@chromium.org2008-11-1310-47/+58
| | | | | | | | | AutocompleteMatch types, and pass a type to the AutocompleteMatch constructor. The added detail in the new types is not used for anything functional; its sole purpose is for metric logging. Someday we could probably update other bits of the code to make use of this, though (e.g. the paste-and-search vs. paste-and-go determinant code). These are separable changes, but doing either one without the other would have required an annoying number of fragile temporary changes. Review URL: http://codereview.chromium.org/10855 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5329 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the 0x0 canvas used for computing text sizes. Creating this is not ↵brettw@google.com2008-11-133-92/+90
| | | | | | | | | necessary since the text can be sized using the desktop DC, which should be faster. I made this function static, and moved the functions it used into file-local functions since they didn't depend on the class either. This is trying to fix bug 49. This code is very close to the crash, and a 0x0 canvas seems like it might cause problems. However, it is unclear whether this will have any effect (other than performance). Review URL: http://codereview.chromium.org/10409 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5328 0039d316-1c4b-4281-b951-d872f2087c98
* * another lib! fix nettc@google.com2008-11-131-0/+1
| | | | | | | | tbr=evan Review URL: http://codereview.chromium.org/10411 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5327 0039d316-1c4b-4281-b951-d872f2087c98
* * fix stress_cachetc@google.com2008-11-131-0/+1
| | | | | | | | tbr=evan Review URL: http://codereview.chromium.org/10861 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5326 0039d316-1c4b-4281-b951-d872f2087c98
* fix mac buildtony@chromium.org2008-11-133-3/+6
| | | | | | | | | | | need to include dmg_fp config settings in debug and release tbr=playmobil Review URL: http://codereview.chromium.org/10665 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5325 0039d316-1c4b-4281-b951-d872f2087c98
* * fix net buildtc@google.com2008-11-121-0/+1
| | | | | | | | tbr=evan Review URL: http://codereview.chromium.org/10664 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5324 0039d316-1c4b-4281-b951-d872f2087c98
* fix check depstc@google.com2008-11-121-0/+1
| | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/10858 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5322 0039d316-1c4b-4281-b951-d872f2087c98
* fix windows base buildtc@google.com2008-11-121-2/+3
| | | | | | Review URL: http://codereview.chromium.org/10856 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5321 0039d316-1c4b-4281-b951-d872f2087c98
* Allow chromium to be built with some system libs by introducingevanm@google.com2008-11-127-18/+75
| | | | | | | | | | | | | | a variable called SYSTEM_LIBS, consisting of a comma-separated list of system libraries. So far, bzip2, libpng, libjpeg, libxml, libxslt, lzma_sdk, zlib, hunspell, sqlite, libevent are recognized. BUG=4321 Review URL: http://codereview.chromium.org/10626 Patch from Fabien Tassin <fta@sofaraway.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5320 0039d316-1c4b-4281-b951-d872f2087c98
* Make unit_tests pass with pt_BR.UTF-8 locale.tc@google.com2008-11-1234-56/+5525
| | | | | | | | | | | BUG=3675 Patch from Paweł Hajdan jr <phajdan.jr@gmail.com> original issue: http://codereview.chromium.org/9509 Review URL: http://codereview.chromium.org/11002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5319 0039d316-1c4b-4281-b951-d872f2087c98
* Add in the webkit merge revision.ojan@google.com2008-11-121-0/+1
| | | | | | Review URL: http://codereview.chromium.org/11007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5318 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes text field background when disabled/read-only to better matchsky@google.com2008-11-122-23/+44
| | | | | | | | | | | | | | | how Windows looks. This also changes SetEnabled not to adjust read_only_ state. That SetEnabled invoked SetReadOnly is just wrong, the two don't have to be the same. BUG=1218491 TEST=bring up the keyword editor and double click on one of the default search engines, make sure the background of the text field looks disabled. Review URL: http://codereview.chromium.org/10662 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5317 0039d316-1c4b-4281-b951-d872f2087c98
* add distcc_dir to the list of pass through varstc@google.com2008-11-121-1/+1
| | | | | | | Review URL: http://codereview.chromium.org/10658 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5316 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/10610dsh@google.com2008-11-121-6/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5314 0039d316-1c4b-4281-b951-d872f2087c98
* * Try to rename chrome exes in shutdown path as well.kuchhal@chromium.org2008-11-124-21/+37
| | | | | | | | BUG=1463346 Review URL: http://codereview.chromium.org/10805 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5313 0039d316-1c4b-4281-b951-d872f2087c98
* New functions in WebDatabase and WebDataService for the removal of form ↵petersont@google.com2008-11-125-8/+172
| | | | | | | | | | entries made between two given times. BrowserDataRemover::Remove now clears autofill data. BUG=3870 Review URL: http://codereview.chromium.org/9775 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5312 0039d316-1c4b-4281-b951-d872f2087c98
* Update DEPS to point at webkit@5303aa@chromium.org2008-11-121-1/+1
| | | | | | Review URL: http://codereview.chromium.org/10660 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5311 0039d316-1c4b-4281-b951-d872f2087c98
* Fix http://code.google.com/p/chromium/issues/detail?id=4270. Test case added.mpcomplete@google.com2008-11-124-2/+83
| | | | | | | | BUG=4270 Review URL: http://codereview.chromium.org/10620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5310 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test_shell resizing.evanm@google.com2008-11-121-4/+2
| | | | | | | | | | | | | Gtk sizing happens in two passes: first, each widget requests a size, then the containers recursively allocate how much space each child widget gets. For the WebView, we want to request no space (so that we can be resized as small as possible) and when computing our actual size we want to use our allocated size, not our requested size. Review URL: http://codereview.chromium.org/10659 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5309 0039d316-1c4b-4281-b951-d872f2087c98
* Update deps to pull in the new merge and the htmlentitycodes change.ojan@google.com2008-11-121-1/+1
| | | | | | Review URL: http://codereview.chromium.org/10852 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5308 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox metrics logging patch splitout, part 5: Add TypeToString() helpers. ↵pkasting@chromium.org2008-11-123-16/+37
| | | | | | | | One of these is unused for the moment. Review URL: http://codereview.chromium.org/10657 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5307 0039d316-1c4b-4281-b951-d872f2087c98
* Pass in SW_SHOW to ShellExecuteEx as the plugin installers can rely on this ↵ananta@chromium.org2008-11-121-0/+5
| | | | | | | | | | | | | | | flag for displaying UI. The latest flash player installer needs this. Launching this exe without this flag causes the exe to just wait around doing nothing. As part of this CB we also pass in the current directory in SHELLEXECUTEINFO. This is set to the directory where the plugin installer is downloaded. This fixes http://code.google.com/p/chromium/issues/detail?id=4346. Bug=4346 R=nsylvain Review URL: http://codereview.chromium.org/10650 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5306 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability for save dialogs to take a default extension.sky@google.com2008-11-1212-36/+135
| | | | | | | | | BUG=4287 TEST=see bug Review URL: http://codereview.chromium.org/10621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5304 0039d316-1c4b-4281-b951-d872f2087c98
* Fix infobubble crash due to first run bubble having slightly different ↵ben@chromium.org2008-11-122-9/+4
| | | | | | | | | initialization path than the bookmarks bubble. http://crbug.com/4344 Review URL: http://codereview.chromium.org/10849 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5301 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in showing context menu for buttons. In particular becausesky@google.com2008-11-124-15/+25
| | | | | | | | | | | | we weren't resetting state before showing the context menu it was possible for the button to stay in a HOT state even though it isn't. BUG=2620 TEST=see bug Review URL: http://codereview.chromium.org/10835 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5300 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two menu bugs:sky@google.com2008-11-121-1/+20
| | | | | | | | | | | | | | | | | | | . Pressing shift-F10 would make context menu appear then immediately disappear. This is because MenuController was hiding on a WM_SYSKEYUP. I've changed MenuController to do nothing on WM_SYSKEYUP. If a sys key is pressed again, we'll get a WM_SYSKEYDOWN and hide there. . MenuController needed to handle WM_CONTEXTMENU and not dispatch it, otheriwse we could end up with stacked menus. BUG=3685 TEST=bring up bookmark manager, select a row in the table on the right. Press shift-F10 and make sure the context menu appears and stays up. Review URL: http://codereview.chromium.org/10635 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5299 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test_shell_test failure. I had missed the fact that the generated ↵jam@chromium.org2008-11-122-7/+16
| | | | | | | | entity code file already had "&" and ";". Review URL: http://codereview.chromium.org/10654 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5298 0039d316-1c4b-4281-b951-d872f2087c98
* * add MIME type functions to ChromiumBridgeerikkay@google.com2008-11-124-23/+55
| | | | | | | | * add resource protocol to ChromiumBridge Review URL: http://codereview.chromium.org/10836 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5297 0039d316-1c4b-4281-b951-d872f2087c98
* Drop the wakeup pipe completely and use the builtin glib wakeup.deanm@chromium.org2008-11-122-39/+3
| | | | | | Review URL: http://codereview.chromium.org/10848 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5296 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux build. I suck.evanm@google.com2008-11-121-1/+1
| | | | | | | R=deanm git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5295 0039d316-1c4b-4281-b951-d872f2087c98
* Uncomment out these two lines I commented out a few weeks ago so that the ↵ben@chromium.org2008-11-121-4/+0
| | | | | | | | | trunk is usable again. TBR=sky Review URL: http://codereview.chromium.org/10655 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5294 0039d316-1c4b-4281-b951-d872f2087c98