| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
to malfunction.
Review URL: http://codereview.chromium.org/10862
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
KeyboardTest (as was done in r4786 for DomAutocompleteTests,
for debug mode test_shell_tests).
Review URL: http://codereview.chromium.org/10669
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add march flag to builds. Our system compilers are assuming > i386 already, but
not all gcc installations will do this. Without an march flag, gcc assumes only
a 386 and then some atomic operations are compiled to undefined references
which break linking.
Review URL: http://codereview.chromium.org/10689
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=cpu
Review URL: http://codereview.chromium.org/10686
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10880
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10670
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The trick here is to properly check for a Frame that has been removed by
checking for a null Page. This matches what happens in other WebKit ports.
R=dglazkov
Review URL: http://codereview.chromium.org/10882
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
done.
Review URL: http://codereview.chromium.org/10881
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
nested fashion. Due to the event sending controller, it is possible for the completion of one load to kick off another or lead to the cancelation of a third. These situations can easily result in DidStartLoading being called twice without a DidStopLoading in between, and vice versa.
Upstream DRT does not care about the progress notifications being ordered properly, and so I don't think we should either.
R=tony
Review URL: http://codereview.chromium.org/10888
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
making ui test more consistent. I suspect I could get the same effect
by changing the last sleep to kMaxTestExecutionTime, but seems best to
use the sync function here.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/10692
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To precisely match their behavior, I had to not delay the TestFinished call
when there is no work to process.
This CL avoids bugs related to DidStartLoading being called without a preceding
DidStopLoading. https://bugs.webkit.org/show_bug.cgi?id=21068 describes the
duplicate load problem in more detail, and I think that is a real bug that
should be fixed.
R=brettw
Review URL: http://codereview.chromium.org/10676
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10685
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
EventListener attributes have been added to the WebKit idl files and
we can now use them as is with a minor change to the code generator.
Also cleaned up DOMWindow.idl and got rid of some of the differences.
Review URL: http://codereview.chromium.org/10684
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- make the window update locking use window visibility instead of WM_SETREDRAW. I believe WM_SETREDRAW is causing the window to become visible during tests.
- potential crashes caused by NULL TabcontentsDelegates.
TBR=sky
Review URL: http://codereview.chromium.org/10674
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I added a new dependency to base and it was needed by
targets build on windows (but not yet on linux).
tbr=sgk
Review URL: http://codereview.chromium.org/10868
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
work on the buildbots. I need to find a better way to get the WindowProxy for
the alert dialog.
TBR=jam
Review URL: http://codereview.chromium.org/10667
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Change our work dispatching to be based around an event source. This will allow us to still participate when a message loop is pumped by outside code (nested message loops).
Review URL: http://codereview.chromium.org/10854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tbr=evan
Review URL: http://codereview.chromium.org/10863
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
AutocompleteMatch types, and pass a type to the AutocompleteMatch constructor. The added detail in the new types is not used for anything functional; its sole purpose is for metric logging. Someday we could probably update other bits of the code to make use of this, though (e.g. the paste-and-search vs. paste-and-go determinant code).
These are separable changes, but doing either one without the other would have required an annoying number of fragile temporary changes.
Review URL: http://codereview.chromium.org/10855
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
necessary since the text can be sized using the desktop DC, which should be faster. I made this function static, and moved the functions it used into file-local functions since they didn't depend on the class either.
This is trying to fix bug 49. This code is very close to the crash, and a 0x0 canvas seems like it might cause problems. However, it is unclear whether this will have any effect (other than performance).
Review URL: http://codereview.chromium.org/10409
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tbr=evan
Review URL: http://codereview.chromium.org/10411
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tbr=evan
Review URL: http://codereview.chromium.org/10861
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
need to include dmg_fp config settings in debug and release
tbr=playmobil
Review URL: http://codereview.chromium.org/10665
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tbr=evan
Review URL: http://codereview.chromium.org/10664
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=evan
Review URL: http://codereview.chromium.org/10858
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10856
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a variable called SYSTEM_LIBS, consisting of a comma-separated
list of system libraries. So far, bzip2, libpng, libjpeg,
libxml, libxslt, lzma_sdk, zlib, hunspell, sqlite, libevent are recognized.
BUG=4321
Review URL: http://codereview.chromium.org/10626
Patch from Fabien Tassin <fta@sofaraway.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=3675
Patch from Paweł Hajdan jr <phajdan.jr@gmail.com>
original issue: http://codereview.chromium.org/9509
Review URL: http://codereview.chromium.org/11002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
how Windows looks. This also changes SetEnabled not to adjust
read_only_ state. That SetEnabled invoked SetReadOnly is just wrong,
the two don't have to be the same.
BUG=1218491
TEST=bring up the keyword editor and double click on one of the
default search engines, make sure the background of the text field
looks disabled.
Review URL: http://codereview.chromium.org/10662
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10658
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=1463346
Review URL: http://codereview.chromium.org/10805
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
entries made between two given times. BrowserDataRemover::Remove now clears autofill data.
BUG=3870
Review URL: http://codereview.chromium.org/9775
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10660
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=4270
Review URL: http://codereview.chromium.org/10620
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Gtk sizing happens in two passes: first, each widget requests a size, then
the containers recursively allocate how much space each child widget gets.
For the WebView, we want to request no space (so that we can be resized
as small as possible) and when computing our actual size we want to use
our allocated size, not our requested size.
Review URL: http://codereview.chromium.org/10659
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10852
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
One of these is unused for the moment.
Review URL: http://codereview.chromium.org/10657
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
flag for displaying UI. The latest flash player installer needs this. Launching this exe without this flag causes the exe to just wait around doing nothing.
As part of this CB we also pass in the current directory in SHELLEXECUTEINFO. This is set to the directory where the plugin installer is downloaded.
This fixes http://code.google.com/p/chromium/issues/detail?id=4346.
Bug=4346
R=nsylvain
Review URL: http://codereview.chromium.org/10650
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=4287
TEST=see bug
Review URL: http://codereview.chromium.org/10621
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
initialization path than the bookmarks bubble.
http://crbug.com/4344
Review URL: http://codereview.chromium.org/10849
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
we weren't resetting state before showing the context menu it was
possible for the button to stay in a HOT state even though it isn't.
BUG=2620
TEST=see bug
Review URL: http://codereview.chromium.org/10835
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Pressing shift-F10 would make context menu appear then immediately
disappear. This is because MenuController was hiding on a
WM_SYSKEYUP. I've changed MenuController to do nothing on
WM_SYSKEYUP. If a sys key is pressed again, we'll get a
WM_SYSKEYDOWN and hide there.
. MenuController needed to handle WM_CONTEXTMENU and not dispatch it,
otheriwse we could end up with stacked menus.
BUG=3685
TEST=bring up bookmark manager, select a row in the table on the
right. Press shift-F10 and make sure the context menu appears and
stays up.
Review URL: http://codereview.chromium.org/10635
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
entity code file already had "&" and ";".
Review URL: http://codereview.chromium.org/10654
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
* add resource protocol to ChromiumBridge
Review URL: http://codereview.chromium.org/10836
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10848
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
R=deanm
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
trunk is usable again.
TBR=sky
Review URL: http://codereview.chromium.org/10655
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5294 0039d316-1c4b-4281-b951-d872f2087c98
|