| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I marked these as fixed on Windows and now that the
Linux bot has cycled, those look fixed on Linux as well.
TBR=sky
Review URL: http://codereview.chromium.org/24013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Enabled regex test on mac. Seem to work as intended.
- Rebaseline regex/non-pattern-characters. Only error messages differ.
- Add rebaselining for early-acid3-86. Was already rebaselined for Windows/Linux and only error messages differ.
- Update rebaselining for window-lookup-precedence tests. Now matches the Window/Linux versions.
Review URL: http://codereview.chromium.org/20318
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
all)
Text baselines are different due to missing Z in output or because metrics are different.
animate-elem-28-t.svg:
Added text baseline that takes into account the font differences.
animate-elem-40-t.svg:
No longer missing rect outlines so we can add a baseline for this test.
animate-elem-41-t.svg:
Slight pixel differences in how we draw the star. Rebaselining.
animate-elem-61-t.svg:
animate-elem-63-t.svg:
animate-elem-64-t.svg:
animate-elem-65-t.svg:
animate-elem-66-t.svg:
animate-elem-67-t.svg:
animate-elem-68-t.svg:
animate-elem-69-t.svg:
animate-elem-70-t.svg:
filterRegions.svg:
textLength.svg:
gradient-stop-corner-cases.svg:
pattern-deep-referencing.svg:
Slight pixel difference in shading and rounded corners.
animate-elem-80-t.svg:
animate-elem-82-t.svg:
masking-mask-01-b.svg:
pservers-grad-08-b.svg:
pservers-grad-14-b.svg:
Slight shading changes (Skia).
patternPreserveAspectRatioA.png:
Slight font and shading differences.
textProperties.svg:
This is similar to a change I reviewed from Darin after we changed the code transformation during a merge.
text-dom-01-f.svg:
One pixel different in the word "is".
Review URL: http://codereview.chromium.org/21270
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Stop directly referencing WebPluginDelegateImpl.
- Make the password manager to not allocation the data on heap.
- Remove some unneeded includes.
Review URL: http://codereview.chromium.org/20208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Skipped expire_history_backend_unittest.cc because of flakiness
(when we port BookmarkModel::DoneLoading() and BookmarkModel::BlockTillLoaded()
it should be ok to enable it).
Review URL: http://codereview.chromium.org/21304
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
land it in chunks as there are enough diffs, it's gonna risk conflicts.
Review URL: http://codereview.chromium.org/21302
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20313
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20312
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
that's what most of the lines are).
TBR=evanm
Review URL: http://codereview.chromium.org/21301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20300
Patch from Craig Schlenter <craig.schlenter@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
test passes in Chrome, but appears to fail in test shell
because of a difference in how lighttpd is serving up the resource.
BUG=none
TEST=none
TBR=tc
Review URL: http://codereview.chromium.org/21299
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
R=tony (looked over my shoulder before I committed)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
fixed upstream to match the spec and the rebaselining is no longer needed.
Review URL: http://codereview.chromium.org/20314
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20302
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We were trying to include all resources, even those hidden behind an
preprocessor #if.
Review URL: http://codereview.chromium.org/20311
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21295
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
list what's coming in via var sub in the first place).
Review URL: http://codereview.chromium.org/20309
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This is just following up on a code review promise.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
much of the Omnibar code.
Review URL: http://codereview.chromium.org/20306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This reverts commit 9656.
Review URL: http://codereview.chromium.org/20308
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- make following unit tests compile and pass on Linux:
browser/history/expire_history_backend_unittest.cc
browser/history/history_backend_unittest.cc
browser/history/history_querying_unittest.cc
browser/history/starred_url_database_unittest.cc
- #include cleanup (less #ifdefs, more explicit deps)
Review URL: http://codereview.chromium.org/21247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
NOTE: atleast the pngs will have to be redone once we fix the issues w/
scrollbar drawing. Some of the other form items might also needs
to be fixed (dom dump) when the font changes land.
Review URL: http://codereview.chromium.org/21294
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The app target needs to have $(CONFIGURATION_TEMP_DIR)/generated/grit
in the include path.
TBR=awalker
Review URL: http://codereview.chromium.org/20305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cleanup.
- Stupid bug where we were failing if there was a space or '-' in the path to setup.exe
- Some application still read default browser from Software\Classes\http even on Vista so set that
- Some refactoring of apppaths changes to make a method private that doesn't need to be public.
- Move constants in shell_util where rest of the shell related constants are.
- Remove duplicate attempts to create ChromeHTML key
BUG=7568,6732,6504
Review URL: http://codereview.chromium.org/21259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
we need the debugger lib on linux
Review URL: http://codereview.chromium.org/20303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CRLFs in WebKit merges: --force-lf and --file-list. The latter changes the
default interpretation of command-line arguments from a file holding a list
of files to check, to a file that itself should be checked.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/21251
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- fix scons dependencies by adding a target for grit/theme_resources.h
- fix mac build by adding grit to unittest include path
- fix check deps by adding rules for /grit dir.
Create a chrome_resources.vcproj that holds grd files that hold
non-string resources. Put browser_resources.grd into this vcproj.
Port theme_resources.rc/theme_resources.h to theme_resources.grd
and put it in the vcproj too.
I did a find/replace on the theme_resources include line.
Modify grit so header files go in grit_generated_resources/grit/
so the include path can be cleaner. I'll migrate the others
in follow up patches.
theme_resources.rc had a conditional include of distribution_resources.rc
so I had to add support for preprocessor defines to visual studio.
Review URL: http://codereview.chromium.org/24011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20293
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21287
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20294
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20295
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21286
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/23024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Unfork some of the DOMWindow.idl.
Required small changes to the idl parser.
* Move DOMWindow related functions from v8_custom.cpp into Webkit's V8DOMWindowCustom
(see separate CL for the Webkit tree)
* Moves timers from DOMWindow code into the Webkit DOMTimer code.
* Removed a couple of junker methods (forward()/back()) from the IDL. I think they were not needed.
NOTE:
This is dependent on a webkit-tree change. Will roll deps in order to test this.
Review URL: http://codereview.chromium.org/21262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- removed entries for plugin tests that now pass
- removed entries for a few tests that pass (from merges?)
- one test now tends to crash instead of fail, updated that status.
Review URL: http://codereview.chromium.org/21293
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the new resize corner. Local experiment led me to believe that it is WebKit
that is slower when we specify a resize corner area.
To validate this hypothesis, I always return an empty rect to WebKit, but I
still compute and push the rect to the render widget and I also draw the bitmap
even if this will cause it to be drawn on top of the scroll bars when there is
only one.
TBR=brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This matches the behavior of Firefox on Windows and Linux. This change is especially important for plugin compatability on Linux. This also nicely removes a quirk mode.
Review URL: http://codereview.chromium.org/21290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
implementation to rev 9214. The pages_ member of WebFrameImpl must be set
properly or printing will fail.
Patch contributed by Marshall Greenblatt <magreenblatt@gmail.com>
Review url: http://codereview.chromium.org/20222/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We make sure any window is a child of the render view window before moving it.
BUG=7590
Review URL: http://codereview.chromium.org/24012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to LF. 'svn merge' saves them with CRLF otherwise, which interferes with
later merges.
Remove the now-obsolete code that did the same thing after a 3-way merge,
which only took effect when a file had conflicts.
BUG=7536
TEST=run a merge, see no CRLF in text files
Review URL: http://codereview.chromium.org/20289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
running with --enable-dcheck.
Review URL: http://codereview.chromium.org/20292
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This change is the first unit-test that tests our IME backend in the RenderWidget class. Thanks to the unit-test framework for the RenderView class created by Carlos and Brett, we can now implement this unit test. (I'm not sure I use this framework correctly, though. Please blame me if I use it improperly.)
Currently, this IME test just tests if our IME code can properly activate (or de-activate) IMEs for an <input> element and the initial position of a candidate window. I'm going to add more practical cases to this test.
Review URL: http://codereview.chromium.org/20014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20286
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21282
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(WebKit fonts choke with it on)
Review URL: http://codereview.chromium.org/20288
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9645 0039d316-1c4b-4281-b951-d872f2087c98
|