summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Further refactoring of menus for GTK. I've now separated outsky@chromium.org2009-08-2427-4499/+1127
| | | | | | | | | | | | | | | | | everything and menus some what work on GTK. I need to get painting working and I'm sure there will be fine tuning, but I want to check in all this splitting of files before someone else needs change one of these files. Thankfully I wrote an interactive ui test that exercises much of this code, and it still passes:) BUG=none TEST=thoroughly test bookmark menus on windows to make sure I didn't break them. Review URL: http://codereview.chromium.org/174274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24098 0039d316-1c4b-4281-b951-d872f2087c98
* Fix StackTrace on Windows.maruel@chromium.org2009-08-242-73/+29
| | | | | | | | | | The previous implementation was overly verbose. The new one is now functional and the unit test now works. TEST=unit_test BUG=none Review URL: http://codereview.chromium.org/174250 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24097 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 24094, caused a build break.maruel@chromium.org2009-08-247-262/+86
| | | | | | | | | TBR=mnaganov BUG=none TEST=none Review URL: http://codereview.chromium.org/174319 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24096 0039d316-1c4b-4281-b951-d872f2087c98
* Manual code review.thomasvl@chromium.org2009-08-240-0/+0
| | | | | | | | Ignore hunspell since it is pulled in via DEPS. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24095 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools l10n: merge Inspector's and DevTools's strings; also, disable l10n ↵mnaganov@chromium.org2009-08-247-86/+262
| | | | | | | | | | | until mgr agreeement. BUG=none TEST=none Review URL: http://codereview.chromium.org/173267 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24094 0039d316-1c4b-4281-b951-d872f2087c98
* Move debugging stuff out of Getting Started into its own tutorial.kathyw@google.com2009-08-245-133/+233
| | | | | | | | | | | | | | | | (Not done; needs intro text.) Removed --enable-extensions from command line. (Strangely, it made the doc more complicated, since your extension's users will need it. For now.) Made some minor formatting changes. Added a page to point to all the tutorials. Review URL: http://codereview.chromium.org/173197 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24093 0039d316-1c4b-4281-b951-d872f2087c98
* Changes related to improvements to the navigation.kathyw@google.com2009-08-245-54/+86
| | | | | | | | | This change should go in before Raf makes a couple of fixes/improvements to the sidenav. Review URL: http://codereview.chromium.org/173202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24092 0039d316-1c4b-4281-b951-d872f2087c98
* Move the remaining gtk stubs for AutomationProvider out of ↵jhawkins@chromium.org2009-08-232-2/+31
| | | | | | | | | | temp_scaffolding_stubs.cc. BUG=none TEST=none Review URL: http://codereview.chromium.org/174289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24090 0039d316-1c4b-4281-b951-d872f2087c98
* Implement granular cross-origin XHR for extensions.aa@chromium.org2009-08-239-19/+77
| | | | | | | | | | | | | I left the temporary hack that allows all origins until we are ready to break everything all at once. Also, I still need to devise some way to test this. BUG=12129 Review URL: http://codereview.chromium.org/173166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24089 0039d316-1c4b-4281-b951-d872f2087c98
* Added a plugin crash which occurs in NPP_NewStream to the known crashes ↵ananta@chromium.org2009-08-231-0/+4
| | | | | | | | | | | | | | | list. This has been occuring consistently on the recent reliability test runs. Logged a bug to track this http://code.google.com/p/chromium/issues/detail?id=20063 A fix for this is in the works. Bug=20063 TBR=huanr Review URL: http://codereview.chromium.org/173258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24088 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r24085 and r24086, restoring skia asserts to debug-only (test complete).senorblanco@chromium.org2009-08-232-12/+9
| | | | | | | | | | BUG=http://crbug.com/17569 TEST=none TBR=maruel Review URL: http://codereview.chromium.org/173257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24087 0039d316-1c4b-4281-b951-d872f2087c98
* Captain Ahab seems to have capsized his boat. What a bonehead.senorblanco@chromium.org2009-08-231-1/+1
| | | | | | | | | | (Build fix). BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24086 0039d316-1c4b-4281-b951-d872f2087c98
* Captain Ahab here, trying to catch a whale. Temporarily enablingsenorblanco@chromium.org2009-08-232-8/+11
| | | | | | | | | | | | SK_DEBUG for release builds. This will be reverted after a few reliability runs. BUG=http://crbug.com/17569 TEST=None TBR=maruel git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24085 0039d316-1c4b-4281-b951-d872f2087c98
* Resend on IO errors on late bound sockets that were idle.willchan@chromium.org2009-08-222-4/+5
| | | | | | | | | | | According to UMA data, late bound sockets that were idle are significantly more likely to get (reset/close/abort) errors. Currently, we don't resend on late bound sockets that were idle because they weren't reused. This changes that. TODO: determine how long a socket has to be idle before it is likely to get a TCP RST if we try to reuse it. Also document the ClientSocketHandle::ReuseSocketType values. BUG=http://crbug.com/18192. Review URL: http://codereview.chromium.org/174287 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24084 0039d316-1c4b-4281-b951-d872f2087c98
* New images for complex_theme startup tests, to accommodate disk caching change.mirandac@chromium.org2009-08-228-0/+0
| | | | | | | | | BUG= none TEST= none Review URL: http://codereview.chromium.org/174307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24081 0039d316-1c4b-4281-b951-d872f2087c98
* Clears the "Clear auto-opening settings" button (put it in the default state,mhm@chromium.org2009-08-221-0/+2
| | | | | | | | | | | | | | | | ie, disabled), when the user clicks in "Reset to defaults" button. BUG=7334 (http://crbug.com/7334) TEST=Download a file, enable "Always open files of this type" from download item menu, go to Options/Under the Hood and then click on "Reset to defaults" button. Contributed by tfarina (thiago.farina@gmail.com) Review URL: http://codereview.chromium.org/174306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24080 0039d316-1c4b-4281-b951-d872f2087c98
* Enabling "Save as..." in view:source page.mhm@chromium.org2009-08-222-5/+21
| | | | | | | | | BUG=12748 (http://crbug.com/12748) TEST=Goes to view-source:http://www.google.com/ and see if the menu is enabled. Review URL: http://codereview.chromium.org/165068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24079 0039d316-1c4b-4281-b951-d872f2087c98
* Disable this test of encoding override on MacOS and Linux because on those ↵jnd@chromium.org2009-08-221-0/+5
| | | | | | | | | | | | | | platforms AutomationProvider::OverrideEncoding is not implemented yet. BUG=none TEST=none TBR=jshin Review URL: http://codereview.chromium.org/174305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24078 0039d316-1c4b-4281-b951-d872f2087c98
* Use size_t to fix compilation error.jnd@chromium.org2009-08-221-2/+2
| | | | | | | | TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24077 0039d316-1c4b-4281-b951-d872f2087c98
* Use ARRAYSIZE_UNSAFEjnd@chromium.org2009-08-221-2/+2
| | | | | | | | | BUG=none TEST=none TBR=jshik git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24076 0039d316-1c4b-4281-b951-d872f2087c98
* arraysize doesn't accept a type defined inside a function. In these rarejnd@chromium.org2009-08-221-2/+2
| | | | | | | | | | | cases, I have to use the unsafe ARRAYSIZE_UNSAFE() macro BUG=none TEST=none TRB=jshik git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24075 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compilation failure on Mac and Linuxjnd@chromium.org2009-08-221-11/+18
| | | | | | | | | | | BUG=none TEST=none TBR=jshin Review URL: http://codereview.chromium.org/174304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24074 0039d316-1c4b-4281-b951-d872f2087c98
* Add a UI test for "Encoding" menu. Please see crbug.com/5515 for more ↵jnd@chromium.org2009-08-2266-21/+1277
| | | | | | | | details.This change list is based on http://codereview.chromium.org/18417 which was written by xlyuan@chromiumBug=5515 ( http://crbug.com/5515 ) Review URL: http://codereview.chromium.org/165393 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24073 0039d316-1c4b-4281-b951-d872f2087c98
* Use U_ICU_VERSION_SHORT instead of hard-coding the icu data dll and module name.jshin@chromium.org2009-08-221-3/+5
| | | | | | | | | | | This is a companion to http://codereview.chromium.org/174265 BUG=8198 TEST=All the targets relying on ICU are built and run without a problem. Review URL: http://codereview.chromium.org/173233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24072 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 24069.dimich@google.com2009-08-222-125/+6
| | | | | | Review URL: http://codereview.chromium.org/174301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24071 0039d316-1c4b-4281-b951-d872f2087c98
* webkit roll 47638:47646dimich@google.com2009-08-221-1/+1
| | | | | | | | | TBR=jianli BUG=none TEST=none Review URL: http://codereview.chromium.org/174300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24070 0039d316-1c4b-4281-b951-d872f2087c98
* The ResourceDispatcher object does not honor the deferred load flag for a ↵ananta@chromium.org2009-08-222-6/+125
| | | | | | | | | | | | | | | | | | | | request correctly. If this flag is set it correctly queues up any subsequent responses. When the flag is reset it starts dispatching these responses. If the deferred flag is set in the context of these responses it continues to dispatch further responses, which is not correct. Fix is to check if the deferred flag for a request is set in the context of a response and stop dispatching if yes. This fixes bug http://code.google.com/p/chromium/issues/detail?id=19931 and could potentially explain this http://code.google.com/p/chromium/issues/detail?id=19393 Bug=19931 Test= Covered by unit test. Review URL: http://codereview.chromium.org/173187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24069 0039d316-1c4b-4281-b951-d872f2087c98
* Validation of extension api callbacks and event parameters in DEBUGrafaelw@chromium.org2009-08-2217-87/+212
| | | | | | | | BUG=18711 Review URL: http://codereview.chromium.org/173034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24068 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 47630:47638.dimich@google.com2009-08-221-1/+1
| | | | | | | | | TBR=jianli BUG=none TEST=none Review URL: http://codereview.chromium.org/173252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24067 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 24063. The webkit roll was reverted so we don't need this exclusion ↵dimich@google.com2009-08-221-4/+0
| | | | | | | | | | | anymore. TBR=jianli BUG=20016 TEST=none Review URL: http://codereview.chromium.org/173251 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24066 0039d316-1c4b-4281-b951-d872f2087c98
* Revert24047 WebKit Rollmhm@chromium.org2009-08-221-1/+1
| | | | | | | TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24065 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new reliability crash to suppress it. Fallout from webkit roll ↵dimich@google.com2009-08-221-0/+3
| | | | | | | | | | | 47630:47646. TBR=brettw BUG=20016 TEST=none Review URL: http://codereview.chromium.org/174292 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24063 0039d316-1c4b-4281-b951-d872f2087c98
* Add support to glue and syncAPI for header setting. (second try)chron@chromium.org2009-08-224-18/+60
| | | | | | Review URL: http://codereview.chromium.org/174269 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24062 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix the ChromeOS build. This tries to add a views dependency for ↵brettw@chromium.org2009-08-222-3/+9
| | | | | | | | browser_tests, and fixes some simple errors in the focus unit test. Review URL: http://codereview.chromium.org/173243 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24061 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the unused WTL::CRect from window_delegate.h.maruel@chromium.org2009-08-221-5/+0
| | | | | | | | | | | | Patch contributed by thiago.farina@gmail.com BUG=None TEST=None Review: http://codereview.chromium.org/171027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24058 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline LayoutTests/fast/dom/navigator-detached-no-crash.html after ↵jparent@chromium.org2009-08-222-35/+1
| | | | | | | | | | | | http://trac.webkit.org/changeset/47397 added calls to getStorageUpdates(). TEST=ran tests locally BUG=none Review URL: http://codereview.chromium.org/174196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24057 0039d316-1c4b-4281-b951-d872f2087c98
* Remove even more cruft from temp_scaffolding_stubs.h. This change also ↵jhawkins@chromium.org2009-08-223-82/+1
| | | | | | | | | | enables modal_html_dialog_delegate.cc for Mac and Linux, since it's already ported. Porting defines in tab_contents.cc were removed to reflect the current state of the ports. BUG=none TEST=none Review URL: http://codereview.chromium.org/174278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24055 0039d316-1c4b-4281-b951-d872f2087c98
* Add favicons to the Mac bookmark menujrg@chromium.org2009-08-225-92/+170
| | | | | | | | | Landing CL for rsesek@chromium.org Original CL: http://codereview.chromium.org/172084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24054 0039d316-1c4b-4281-b951-d872f2087c98
* Implements unimplemented methods of AutocompleteEditViewGtk and fixes a ↵suzhe@chromium.org2009-08-222-89/+140
| | | | | | | | | | | | | | | | | | | regression issue. This CL implements two unimplemented methods of AutocompleteEditViewGtk: OnRevertTemporaryText() and IsSelectAll(). The implementation are mostly copied from autocomplete_edit_view_mac.mm. Some grammer errors and a valgrind warning introduced by CL 165457 are also fixed. This CL was just updated to fix a regression caused by CL 165457 (issue 19631). BUG=19631: Tabbing on Omnibox enters in to search UI mode TEST=Input something in omnibox and make sure some text is selected and popup view is opened, change current selection in popup view by pressing up/down then press escape to see if omnibox is reverted to its original content and selection. TEST=Make sure www.google.com is one of the search engine, open www.google.com then move the focus back to omnibox and press tab to see if the focus is moved into web page. Review URL: http://codereview.chromium.org/172041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24052 0039d316-1c4b-4281-b951-d872f2087c98
* Reorganize UMA data to measure network latency on sync authorization.brg@chromium.com2009-08-222-6/+13
| | | | | | | | | | Also, the max time for the merge/sync UI should be increased to minutes. BUG=none TEST=none Review URL: http://codereview.chromium.org/174170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24051 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support and exposure of additional accessibility roles. Includes naming ↵klink@chromium.org2009-08-2211-5/+87
| | | | | | | | | | of the LocationBar, and correctly exposing MSAA/ARIA roles for Documents, Graphics, Menubars and Toolbars. BUG=13291,19982 TEST=Assign @role menubar or toolbar to any dom element, and use Inspect32 (or similar tool) to see it exposed correctly. In the same way, <html> tag is exposed as role document. Review URL: http://codereview.chromium.org/174252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24049 0039d316-1c4b-4281-b951-d872f2087c98
* Consider "certificate revoked" as the most serious certificatewtc@chromium.org2009-08-221-2/+2
| | | | | | | | | | | error. R=abarth BUG=none TEST=none Review URL: http://codereview.chromium.org/171056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24048 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 47630:47646. Temporarily remove tests changed in ↵dimich@google.com2009-08-222-1/+6
| | | | | | | | | | | http://trac.webkit.org/changeset/47640 for rebaselining. R=jianli TEST=none BUG=none Review URL: http://codereview.chromium.org/174281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24047 0039d316-1c4b-4281-b951-d872f2087c98
* qt_faststart use %PRIX64 for 64 bit value printfs for better compatibility ↵fbarchard@chromium.org2009-08-211-5/+6
| | | | | | | | | | | with linux64 and mingw. Thanks to ambro on IIRC. BUG=19999 TEST=use qt-faststart on mingw or linux64 and notice some of the printfs have invalid values. Review URL: http://codereview.chromium.org/174272 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24046 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in rebaseline.py that broke the scriptdpranke@google.com2009-08-211-1/+1
| | | | | | | | | | BUG=none R=jparent@chromium.org TEST=none Review URL: http://codereview.chromium.org/174282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24045 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r24043, "linux: call g_thread_init() at relevant startup points"evan@chromium.org2009-08-213-3/+0
| | | | | | Build failures. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24044 0039d316-1c4b-4281-b951-d872f2087c98
* linux: call g_thread_init() at relevant startup pointsevan@chromium.org2009-08-213-0/+3
| | | | | | | | | | | | | | According to glib docs, we need to do this if it's at all possible for us to hit glib on multiple threads. This may be happening when we grab plugin metadata from the file thread. (Note that this is *not* initializing the GDK locking system.) BUG=18957 Review URL: http://codereview.chromium.org/174264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24043 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling 2 video tests that fail intermittently.dimich@google.com2009-08-211-1/+4
| | | | | | | | | TBR=scherkus TEST=none BUG=20004 Review URL: http://codereview.chromium.org/174275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24042 0039d316-1c4b-4281-b951-d872f2087c98
* Improve certificate error mapping.wtc@chromium.org2009-08-211-2/+9
| | | | | | | | | | | | | Fix leaks of (encoded) certificate extensions returned by CERT_FindCertExtension. They can be freed as soon as they are decoded. R=ukai BUG=http://crbug.com/10911 TEST=none Review URL: http://codereview.chromium.org/173154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24041 0039d316-1c4b-4281-b951-d872f2087c98
* If the HTTP response code is -1, don't call OCSPSetResponse because thewtc@chromium.org2009-08-211-1/+6
| | | | | | | | | | | | request failed and there is no response. This fixes the crashes in OCSPTrySendAndReceive. R=willchan BUG=http://crbug.com/19915 TEST=See issue 19915 for steps to reproduce the crash. Review URL: http://codereview.chromium.org/174248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24040 0039d316-1c4b-4281-b951-d872f2087c98