| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
everything and menus some what work on GTK. I need to get painting
working and I'm sure there will be fine tuning, but I want to check in
all this splitting of files before someone else needs change one of
these files.
Thankfully I wrote an interactive ui test that exercises much of this code, and it still passes:)
BUG=none
TEST=thoroughly test bookmark menus on windows to make sure I didn't
break them.
Review URL: http://codereview.chromium.org/174274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The previous implementation was overly verbose. The new one is now functional and the unit test now works.
TEST=unit_test
BUG=none
Review URL: http://codereview.chromium.org/174250
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=mnaganov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174319
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Ignore hunspell since it is pulled in via DEPS.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
until mgr agreeement.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Not done; needs intro text.)
Removed --enable-extensions from command line. (Strangely, it made
the doc more complicated, since your extension's users will need it.
For now.)
Made some minor formatting changes.
Added a page to point to all the tutorials.
Review URL: http://codereview.chromium.org/173197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This change should go in before Raf makes a couple
of fixes/improvements to the sidenav.
Review URL: http://codereview.chromium.org/173202
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
temp_scaffolding_stubs.cc.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I left the temporary hack that allows all origins until we are
ready to break everything all at once.
Also, I still need to devise some way to test this.
BUG=12129
Review URL: http://codereview.chromium.org/173166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
list. This has been occuring consistently on the recent reliability test runs.
Logged a bug to track this http://code.google.com/p/chromium/issues/detail?id=20063
A fix for this is in the works.
Bug=20063
TBR=huanr
Review URL: http://codereview.chromium.org/173258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/17569
TEST=none
TBR=maruel
Review URL: http://codereview.chromium.org/173257
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(Build fix).
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
SK_DEBUG for release builds. This will be reverted after a
few reliability runs.
BUG=http://crbug.com/17569
TEST=None
TBR=maruel
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
According to UMA data, late bound sockets that were idle are significantly more likely to get (reset/close/abort) errors. Currently, we don't resend on late bound sockets that were idle because they weren't reused. This changes that.
TODO: determine how long a socket has to be idle before it is likely to get a TCP RST if we try to reuse it.
Also document the ClientSocketHandle::ReuseSocketType values.
BUG=http://crbug.com/18192.
Review URL: http://codereview.chromium.org/174287
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= none
TEST= none
Review URL: http://codereview.chromium.org/174307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ie, disabled), when the user
clicks in "Reset to defaults" button.
BUG=7334 (http://crbug.com/7334)
TEST=Download a file, enable "Always open files of this type" from download item
menu, go to Options/Under the
Hood and then click on "Reset to defaults" button.
Contributed by tfarina (thiago.farina@gmail.com)
Review URL: http://codereview.chromium.org/174306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12748 (http://crbug.com/12748)
TEST=Goes to view-source:http://www.google.com/ and see if the menu is enabled.
Review URL: http://codereview.chromium.org/165068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
platforms
AutomationProvider::OverrideEncoding is not implemented yet.
BUG=none
TEST=none
TBR=jshin
Review URL: http://codereview.chromium.org/174305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=jshik
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
cases, I have to use the unsafe ARRAYSIZE_UNSAFE() macro
BUG=none
TEST=none
TRB=jshik
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=jshin
Review URL: http://codereview.chromium.org/174304
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
details.This change list is based on http://codereview.chromium.org/18417 which was written by xlyuan@chromiumBug=5515 ( http://crbug.com/5515 )
Review URL: http://codereview.chromium.org/165393
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a companion to http://codereview.chromium.org/174265
BUG=8198
TEST=All the targets relying on ICU are built and run without a problem.
Review URL: http://codereview.chromium.org/173233
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/174301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jianli
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174300
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
request correctly. If this flag is set it correctly queues up any subsequent responses.
When the flag is reset it starts dispatching these responses. If the deferred flag is set in the context
of these responses it continues to dispatch further responses, which is not correct.
Fix is to check if the deferred flag for a request is set in the context of a response and stop dispatching if yes.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=19931 and could potentially explain
this http://code.google.com/p/chromium/issues/detail?id=19393
Bug=19931
Test= Covered by unit test.
Review URL: http://codereview.chromium.org/173187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18711
Review URL: http://codereview.chromium.org/173034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jianli
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
anymore.
TBR=jianli
BUG=20016
TEST=none
Review URL: http://codereview.chromium.org/173251
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
47630:47646.
TBR=brettw
BUG=20016
TEST=none
Review URL: http://codereview.chromium.org/174292
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/174269
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
browser_tests, and fixes some simple errors in the focus unit test.
Review URL: http://codereview.chromium.org/173243
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch contributed by thiago.farina@gmail.com
BUG=None
TEST=None
Review: http://codereview.chromium.org/171027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/47397 added calls to getStorageUpdates().
TEST=ran tests locally
BUG=none
Review URL: http://codereview.chromium.org/174196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
enables modal_html_dialog_delegate.cc for Mac and Linux, since it's already ported. Porting defines in tab_contents.cc were removed to reflect the current state of the ports.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174278
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Landing CL for rsesek@chromium.org
Original CL: http://codereview.chromium.org/172084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
regression issue.
This CL implements two unimplemented methods of AutocompleteEditViewGtk: OnRevertTemporaryText() and IsSelectAll().
The implementation are mostly copied from autocomplete_edit_view_mac.mm.
Some grammer errors and a valgrind warning introduced by CL 165457 are also fixed.
This CL was just updated to fix a regression caused by CL 165457 (issue 19631).
BUG=19631: Tabbing on Omnibox enters in to search UI mode
TEST=Input something in omnibox and make sure some text is selected and popup view is opened, change current selection in popup view by pressing up/down then press escape to see if omnibox is reverted to its original content and selection.
TEST=Make sure www.google.com is one of the search engine, open www.google.com then move the focus back to omnibox and press tab to see if the focus is moved into web page.
Review URL: http://codereview.chromium.org/172041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also, the max time for the merge/sync UI should be increased to minutes.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of the LocationBar, and correctly exposing MSAA/ARIA roles for Documents, Graphics, Menubars and Toolbars.
BUG=13291,19982
TEST=Assign @role menubar or toolbar to any dom element, and use Inspect32 (or similar tool) to see it exposed correctly. In the same way, <html> tag is exposed as role document.
Review URL: http://codereview.chromium.org/174252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
error.
R=abarth
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/171056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/47640 for rebaselining.
R=jianli
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/174281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
with linux64 and mingw. Thanks to ambro on IIRC.
BUG=19999
TEST=use qt-faststart on mingw or linux64 and notice some of the printfs have invalid values.
Review URL: http://codereview.chromium.org/174272
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=jparent@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/174282
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Build failures.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to glib docs, we need to do this if it's at all possible
for us to hit glib on multiple threads. This may be happening
when we grab plugin metadata from the file thread.
(Note that this is *not* initializing the GDK locking system.)
BUG=18957
Review URL: http://codereview.chromium.org/174264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=scherkus
TEST=none
BUG=20004
Review URL: http://codereview.chromium.org/174275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix leaks of (encoded) certificate extensions returned by
CERT_FindCertExtension. They can be freed as soon as they
are decoded.
R=ukai
BUG=http://crbug.com/10911
TEST=none
Review URL: http://codereview.chromium.org/173154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
request failed and there is no response. This fixes the crashes in
OCSPTrySendAndReceive.
R=willchan
BUG=http://crbug.com/19915
TEST=See issue 19915 for steps to reproduce the crash.
Review URL: http://codereview.chromium.org/174248
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24040 0039d316-1c4b-4281-b951-d872f2087c98
|