| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- This changes RecentlyUsedFoldersComboModel::GetItemAt() to return a string16
instead of a wstring.
- This entailed changing the base class, ComboboxModel, and shaving a herd of
yaks.
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3159031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=good spellers are slightly happier
Review URL: http://codereview.chromium.org/3143037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3061044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=included unit test
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
function.
- Remove this obscure function since it was called only once.
- Use Environment::GetVar instead.
BUG=52951
TEST=trybots
Review URL: http://codereview.chromium.org/3135036
TBR=tfarina@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This removes wstrings from BookmarkIndex.
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3112027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=things aren't as green as they should be
TEST=things get greener
Review URL: http://codereview.chromium.org/3125035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3191018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This converts the text parameter in GetBookmarksContainingText() and
DoesBookmarkContainText() to string16. (The languages parameter will wait until
I decide what I want for languages parameters in general.)
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3197009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This actually converts TreeNodeModel::SetTitle(node, title); this is used by
bookmarks.
BUG=23581
TEST=builds nad passes tests
Review URL: http://codereview.chromium.org/3111024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
accessibility roles we know about.
BUG=none.
TEST=Use VoiceOver to confirm the proper role descriptions are read.
Review URL: http://codereview.chromium.org/3200001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
add a FULL_PATH sort option.
BUG=41762
TEST=unit test
Review URL: http://codereview.chromium.org/3175023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Some of the X.509 parsing tests rely on a certain number of principals being returned, and will crash otherwise. Change the checks to be ASSERT_, so that the test fails gracefully rather than bringing down net_unittests
BUG=none
TEST=X509CertificateTest.*
Review URL: http://codereview.chromium.org/3142016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
client certificate on Win
On OS X and Linux (cocoa/gtk), the original X509Certificate pointer supplied in SSLCertRequestInfo's client_certs is the one returned when a user selects a certificate.
On Windows, a new X509Certificate is created from the selected certificate and returned, rather than the original X509Certificate. This translates to a dependency on X509Certificate::Cache to return the same certificate, which, while presently is true, is an implementation specific detail that should not be relied upon.
BUG=none
TEST=SSL client authentication continues to work on Windows
Review URL: http://codereview.chromium.org/3170019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
targetting app tabs. I futzed with this a bit to try and
integrate installed apps extents, but it is complex.
Also, I looked over the original bug where this code was
added: crbug.com/29281. The issue there was that when you
click on a bookmark (presumably in the bookmark bar) the
pinned tab is unexpectedly overwritten. I can see that
complaint, but there is also the use case of clicking
a bookmark and intending it to overwrite the pinned tab.
In summary, I kinda feel like the expectations about
how navigation should work are too ingrained and we
shouldn't be meddling.
BUG=52680
Review URL: http://codereview.chromium.org/3161037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3140022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
dialog shows an image of the omnibox at the top of the dialog box; in RTL languages, this image needs to be reversed and moved to the left.
BUG=52769
TEST=search engine dialog looks correct in RTL languages.
Review URL: http://codereview.chromium.org/3198006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Convert lots of uses of the wstring BookmarkNode::GetTitle() in browser/cocoa.
BUG=23581
TEST=builds and passes
Review URL: http://codereview.chromium.org/3113028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
src/{app,base,net}.
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/3136025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=52957
TBR=glider
Review URL: http://codereview.chromium.org/3148033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Breaks on py2.4 on win)
This makes it easy to digest pass/fail status for individual tests ("OK" is more discoverable than '.' in the output log). And makes it easier to associate LOG messages from chrome with the individual tests triggering them.
BUG=42148
Review URL: http://codereview.chromium.org/3191014
TBR=nirnimesh@chromium.org
Review URL: http://codereview.chromium.org/3126027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=12578
Review URL: http://codereview.chromium.org/3166025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It is causing the extension blacklist and whitelist to be not found.
BUG=47085
TEST=None
Review URL: http://codereview.chromium.org/3125030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
already running.
(Attempt 2 at landing this, this time with changes to fix Enabledness unit test)
BUG=51689
TEST=ExtensionsServiceTest.BlacklistedByPolicyRemovedIfRunning
Review URL: http://codereview.chromium.org/3166023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3161030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the wstring version of BookmarkModel::SetTitle().
BUG=23581
TEST=builds and passes enough tests
Review URL: http://codereview.chromium.org/3142030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The dispatcher host code is just a stub.
BUG=32277
TESTS=none; will be added later
Review URL: http://codereview.chromium.org/3107026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The HttpNetworkTransaction refactor intercepts the client auth
handling and moves it out of DoLoop. Because HandleCertificateRequest
often switches states, this caused a DCHECK and crash in some
circumstances.
This reintegrates it and adds unit tests to catch the DCHECK. We really
want to test sending a legitimate certificate, as well as more
checking interesting errors, but we cannot import temporary keys yet.
We also add a patch for tlslite to send a non-empty certificate_types.
Apple's SSL implementation raises a protocol error otherwise.
BUG=52744,51132,52778
TEST=SSLClientSocketTest.ConnectClientAuth*,URLRequestTest.ClientAuthTest
Review URL: http://codereview.chromium.org/3141026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, tlslite only supports the caller passing in a list of CAs pre-encoded for the TLS CertificateRequest message. This CL improves that, by providing a means of extracting the DER-encoded subject name from an X509 certificate, supplying a list of such names to tlslite's server routines, and having tlslite encode the list of CAs as part of the CertificateRequest.
BUG=47656, 47658
TEST=net_unittests
Review URL: http://codereview.chromium.org/3177015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=it compiles
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56939
Review URL: http://codereview.chromium.org/3177020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3202003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove this obscure function since it was called only once.
- Use Environment::GetVar instead.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3135036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3115011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3133032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A new field to describe the sources of history urls(visits) is added. This field is recorded in visit_database.
So far, it can tell imported, synchronized, entension added or other(mainly testing) entries from user browsed entries.
In the future, history extension API may allow queries to combinate with this criterion.
BUG=none
TEST=Unit tests are already included. Please test the web browser with history from previous
versions to make sure the migration could be done properly. Also try to import or sync some history and inspect the
sources added to the visit_source table in hitory database are correct.
Original review: http://codereview.chromium.org/2906004/show
Patch by weili@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for a specific port. This allows me to alter resolutions for certain ports
like send :80 lookups to one location and :443 lookups to a different
location.
This enables me to mock out support for AlternateProtocol.
BUG=none
TEST=HostMappingRulesTest.PortSpecificMatching
Review URL: http://codereview.chromium.org/3177026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to see if that makes mac release happy.
BUG=none
TEST=none
TBR=eroman
Review URL: http://codereview.chromium.org/3167032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
index initialization and population and provide unit test with test data.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3138006
TBR=mrossetti@chromium.org
Review URL: http://codereview.chromium.org/3197008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=out/Debug/base_unittests --gtest_filter=RegistryTest.*
Review URL: http://codereview.chromium.org/3190010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
may be called from within one of the notifications
of "backend construction done". This CL makes sure
that this scenario is handled properly by invoking
the callbacks one at a time, posting a task before
moving on to the next one.
BUG=52090
TEST=netunittests
Review URL: http://codereview.chromium.org/3173030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
some reason
the test shows up as succeeded even though it is failing.
The test fails when the automation client instance is reused, i.e the new page loads in
the same tab. We need to set the ready state of the active document instance to ready
when we reuse the automation client instance.
TBR=amit
Review URL: http://codereview.chromium.org/3117032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
initialization and population and provide unit test with test data.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3138006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52826
TEST=Valgrind goes green.
TBR=ukai
Review URL: http://codereview.chromium.org/3112026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3146031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Add separate GL version field.
Review URL: http://codereview.chromium.org/3104011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3135039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56955 0039d316-1c4b-4281-b951-d872f2087c98
|