summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Relanding the page info on Gtk Linux.jcampan@chromium.org2009-07-3014-219/+292
| | | | | | | Review URL: http://codereview.chromium.org/159657 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22112 0039d316-1c4b-4281-b951-d872f2087c98
* Pipeline change broke a few layout testskylep@chromium.org2009-07-301-0/+5
| | | | | | | | | | BUG=16738 TEST=none TBR=nsylvain Review URL: http://codereview.chromium.org/160425 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22111 0039d316-1c4b-4281-b951-d872f2087c98
* Provide media slider thumb image for media controls panelhclam@chromium.org2009-07-304-0/+3
| | | | | | Review URL: http://codereview.chromium.org/160415 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22110 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 22041 as it caused plugin crashes in reliability test runs.ananta@chromium.org2009-07-3013-128/+40
| | | | | | | | | | Also reverting 22065/22046/22041 which are changes to knowncrashes.txt. TBR=huanr Review URL: http://codereview.chromium.org/160418 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22109 0039d316-1c4b-4281-b951-d872f2087c98
* Try again: Add unittest for Gtk cookie manager.mattm@chromium.org2009-07-305-33/+458
| | | | | | | | | | | | | | Fix a few bugs of button sensitivity not updating when it should. Add the unittest to the valgrind/unit_tests.gtest_linux.txt list since Gtk is causing UninitCondition errors when run with no DISPLAY. BUG=11507 BUG=15445 Review URL: http://codereview.chromium.org/160420 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22107 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use an assignment as a truth value.wtc@chromium.org2009-07-301-4/+3
| | | | | | | | | | | Original review: http://codereview.chromium.org/159653 R=darin,pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/160419 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22106 0039d316-1c4b-4281-b951-d872f2087c98
* linux: roll gyp DEPS to get makefile fixesevan@chromium.org2009-07-301-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22105 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeURLRequestContext falloutamit@chromium.org2009-07-304-14/+51
| | | | | | | | | | | | | | | | Fix the issues caused by static_cast<ChromeURLRequestContext*>. There were assumptions in the code that a URLRequestContext* will always be ChromeURLRequestContext* and resulting 'static_cast's. This assumption is no longer true. Instead, URLlRequestContext now has a member GetChromeURLRequestContext that returns a ChromeURLRequestContext* if it really that type. BUG=none TEST=none Review URL: http://codereview.chromium.org/160332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22104 0039d316-1c4b-4281-b951-d872f2087c98
* Remove duplication of DieFileDie, and move it to proper location.phajdan.jr@chromium.org2009-07-308-51/+47
| | | | | | | | | TEST=none http://crbug.com/18085 Review URL: http://codereview.chromium.org/159658 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22103 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implement omnibox DnD destination behavior.estade@chromium.org2009-07-302-0/+40
| | | | | | | | BUG=18025 Review URL: http://codereview.chromium.org/160369 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22102 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tab z-ordering on Mac. Make the TabStripController take fullpinkerton@chromium.org2009-07-302-31/+61
| | | | | | | | | | | | | ownership of its list of subviews. The subviews of the TabStripView are now generated directly (in appropriate z-order) from a list of permanent subviews (e.g., the new tab button) and the list of tabs. In general, this patch seems to make tab manipulation much more stable. Patch from Viet-Trung Luu (viettrungluu@gmail.com) BUG=14913 TEST=open/move/close/duplicate/rip/etc. tabs and observe; also check context menus git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22101 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 307 redirects of a POST request to actually send the body again, and add adarin@chromium.org2009-07-305-5/+4
| | | | | | | | | | | | | | | test. Note: the fix is trivial, but adding support for a test required teaching the FileHandler of testserver to consume a post body. BUG=16832 TEST=covered by unit test R=abarth Review URL: http://codereview.chromium.org/149710 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22100 0039d316-1c4b-4281-b951-d872f2087c98
* The interactive_ui_tests depends on chrome being built. Make it so.darin@chromium.org2009-07-301-0/+1
| | | | | | | | | | R=sgk BUG=none TEST=building interactive_ui_tests should build chrome Review URL: http://codereview.chromium.org/160409 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22098 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for moving the mouse so that GetMessagePos would notice.darin@chromium.org2009-07-302-5/+26
| | | | | | | | | | R=pkasting BUG=18079 TEST=covered by TabDraggingTest.Tab2OutOfTabStrip Review URL: http://codereview.chromium.org/160412 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22097 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the valgrind suppression in crbug.com/15762nirnimesh@chromium.org2009-07-301-7/+0
| | | | | | | | | | | The corresponding valgrind error has been fixed. TEST=test_shell_tests under Valgrind should pass BUG=15762 Review URL: http://codereview.chromium.org/159646 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22096 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add unittest for Gtk cookie manager."mattm@chromium.org2009-07-304-434/+24
| | | | | | | | This reverts commit 91bd4c1a4703db44ea45852bf2f62822e1ded743, which caused valgrind errors. TBR=erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22093 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tab dragging to always hide the new tab button while dragging a tab or ↵pinkerton@chromium.org2009-07-306-22/+63
| | | | | | | | | | targeting an existing window. Makes things much nicer. BUG=14923, 14925, 15667 TEST=dragging tabs in and out of windows, and within windows. Make sure new tab button goes away when it should and always comes back. Review URL: http://codereview.chromium.org/160345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22092 0039d316-1c4b-4281-b951-d872f2087c98
* Add a WebKit API that registers a V8 extension to be loaded into contentmpcomplete@chromium.org2009-07-3016-35/+93
| | | | | | | | | | | scripts. BUG=11797 TEST=no Review URL: http://codereview.chromium.org/159542 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22091 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: render view: grab focus *before* forwarding mouse event to renderer.estade@chromium.org2009-07-301-3/+4
| | | | | | | | | BUG=18047 TEST=see bug Review URL: http://codereview.chromium.org/159654 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22090 0039d316-1c4b-4281-b951-d872f2087c98
* Add unittest for Gtk cookie manager.mattm@chromium.org2009-07-304-24/+434
| | | | | | | | | | Fix a few bugs of button sensitivity not updating when it should. BUG=11507 Review URL: http://codereview.chromium.org/159625 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22089 0039d316-1c4b-4281-b951-d872f2087c98
* Fix search engine manager allowing you to remove the current default search ↵mattm@chromium.org2009-07-302-3/+3
| | | | | | | | | | | | | engine. If a search engine entry is already in the main group, MakeDefaultTemplateURL should return the current index(so that button states will be updated) rather than -1(which should mean nothing was done.) BUG=17566 TEST=Select search engine that is already in the main group but not the default, and click "make default". The "make default" and "remove" buttons should no longer be clickable. Review URL: http://codereview.chromium.org/159557 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22088 0039d316-1c4b-4281-b951-d872f2087c98
* Missing buffered attribute for <video>/<audio>hclam@google.com2009-07-303-2/+64
| | | | | | | | | | | | | | | | | | | | | | | | | BUG=16056 TEST=LayoutTests/media/video-buffered.html The current implementation of the buffered attribute for <video> and <audio> is broken. There are several problems around this attribute: 1. We don't have any caching on disk, so we only keep a recent range of bytes close to current playback position. 2. WebKit reports buffered as one range (0, max_time_buffered). But we only cache a short partial range which doesn't start with 0. The correct implementation is a list of ranges buffered. But this has to go into WebKit first. 3. We don't have an accurate mapping between byte offset < - > timestamp. So the current implementation is to lie about what we have buffered. We always say we have buffered everything before the current download position. And we only report one range. The calculation of time is also based on scaling the duration with current buffered bytes. Review URL: http://codereview.chromium.org/160300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22087 0039d316-1c4b-4281-b951-d872f2087c98
* Pull in a new version of xdg-settings that handles localized browser ↵mdm@chromium.org2009-07-301-1/+1
| | | | | | | | | | | settings in KDE 4. BUG=17842 TEST=none Review URL: http://codereview.chromium.org/159651 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22086 0039d316-1c4b-4281-b951-d872f2087c98
* gcc >= 4.3 fixesmdm@chromium.org2009-07-302-1/+2
| | | | | | | | | | Patch from joel.stan@gmail.com: http://codereview.chromium.org/160377 BUG=none TEST=none Review URL: http://codereview.chromium.org/159648 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22085 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Grab the pointer when we grab focus for the source tab's widget. Fixes ↵jhawkins@chromium.org2009-07-301-1/+8
| | | | | | | | | | a crash where events were being sent to an unknown, unrealized widget. BUG=18049 TEST=Quickly drag a tab down out of the tab strip. The browser should not crash. Review URL: http://codereview.chromium.org/160379 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22084 0039d316-1c4b-4281-b951-d872f2087c98
* linux: add a GtkPlug / GtkSocket pair in the plugin processpiman@chromium.org2009-07-302-4/+56
| | | | | | | | | | | | Some plugins assume that the GtkSocket container is in the same process as the plugin, so we give them one. This fixes bug 16928 and the gdk_window_get_origin issue. BUG=16928 Review URL: http://codereview.chromium.org/160380 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22083 0039d316-1c4b-4281-b951-d872f2087c98
* Fix uninitialized memory read in FtpNetworkTransaction.phajdan.jr@chromium.org2009-07-301-2/+0
| | | | | | | | | | The comment is inaccurate anyway. Landing a subset of Ibrar's patch. TBR=wtc Review URL: http://codereview.chromium.org/159652 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22082 0039d316-1c4b-4281-b951-d872f2087c98
* remove duplicate test expectationdarin@chromium.org2009-07-301-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22081 0039d316-1c4b-4281-b951-d872f2087c98
* Removing tcmalloc from gyp so we can build a version of chromehuanr@chromium.org2009-07-303-5/+2
| | | | | | | | | | | | | | | | | | | | | | without tcmalloc for testing purpose. The linker complains about _set_new_mode so I remove the call from the code for now. Note this change is different from the change Bradley is working on which provides an option for building chrome without tcmalloc. This change simply removes tcmalloc from the build. The plan is checking it in, keeping it in trunk for 24 hours, and then reverting it. The benefits are - Having another round of performance comparison between build with and w/o tcmalloc. - Having a full run of UI test under purify with tcmalloc disabled. - Getting a verified CL in case we'd like to build an alternative dev build w/o tcmalloc for A/B test. Review URL: http://codereview.chromium.org/159599 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22080 0039d316-1c4b-4281-b951-d872f2087c98
* These are also failing on the Mac.darin@chromium.org2009-07-301-6/+6
| | | | | | | | | | TBR=brettw TEST=none BUG=18089 Review URL: http://codereview.chromium.org/159650 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22079 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing the description of printing related string translation.evan@chromium.org2009-07-302-3/+3
| | | | | | | | | | BUG=17913 TEST=None Review URL: http://codereview.chromium.org/159574 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22078 0039d316-1c4b-4281-b951-d872f2087c98
* More complete 'inputs' for Linux packaging targets.mmoss@chromium.org2009-07-301-4/+19
| | | | | | | Review URL: http://codereview.chromium.org/159644 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22077 0039d316-1c4b-4281-b951-d872f2087c98
* Pipeline will execute a callback whenever an run-time error has happened.kylep@chromium.org2009-07-305-3/+81
| | | | | | | | BUG=16738 TEST=pipeline_impl_unittest.cc Review URL: http://codereview.chromium.org/160298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22075 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Remove remaining uses of RankingsNode.pointer.rvargas@google.com2009-07-3011-47/+118
| | | | | | | | | | | | | We now have a map of open entries so we don't need to do a lookup through the rankings node anymore. This simplifies the 64 bit version of the code. BUG=17881 TEST=unittests Review URL: http://codereview.chromium.org/159643 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22074 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline worker-constructor.html and enable it and other 2 tests in ↵jianli@chromium.org2009-07-302-4/+5
| | | | | | | | | | | running in UI test. BUG=none TEST=none Review URL: http://codereview.chromium.org/160402 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22073 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary layout test suppressions.darin@chromium.org2009-07-301-1/+9
| | | | | | | | | | | | | | These started failing after landing redirect checking in r22067. Since the same tests are not failing on Windows, I'd prefer to suppress these failures, and investigate offline instead of rolling out the change. TBR=brettw BUG=18089 TEST=none Review URL: http://codereview.chromium.org/159647 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22072 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 22070.jcampan@chromium.org2009-07-3013-292/+212
| | | | | | Review URL: http://codereview.chromium.org/159645 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22071 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of the page info dialog on Linux Gtk.jcampan@chromium.org2009-07-3013-212/+292
| | | | | | | | | | BUG=http://crbug.com/11598 TEST=Visit an HTTPS page, click the lock icon, the page info should show. Review URL: http://codereview.chromium.org/159521 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22070 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable half of new ftp unit tests in url_request_unittest.cc.phajdan.jr@chromium.org2009-07-301-32/+23
| | | | | | | | | | | | This change might introduce flakiness and test hangs, but we have infrastructure in place to quickly detect it. TEST=none http://crbug.com/18036 Review URL: http://codereview.chromium.org/159614 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22069 0039d316-1c4b-4281-b951-d872f2087c98
* Addressing Huan's comments for the following CLananta@chromium.org2009-07-301-2/+2
| | | | | | | | | | | | | | | The script which verifies whether a crash callstack is known expects the callstack to be in lowercase. Converting the recently added Flash callstacks to lowercase. Added a new stack with the associated bug 18083 Please review this at http://codereview.chromium.org/160404 Review URL: http://codereview.chromium.org/160405 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22068 0039d316-1c4b-4281-b951-d872f2087c98
* Add plumbing for allowing the renderer to intercept and cancel redirects beforedarin@chromium.org2009-07-3055-238/+529
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | they are sent. A good portion of this CL is to support the new UI test. The IPC to notify the renderer of a redirect now includes a ResponseInfo struct allowing WebURLLoaderImpl to provide detailed response info (including response headers) to WebKit. This isn't strictly necessary, but I thought I'd include this to make the code more future proof. A cross origin restriction is added to SyncResourceHandler::OnRequestRedirected that mimics the code in WebCore/platform/network/cf/ResourceHandleCFNet.cpp. This is most unfortunate, and I filed a bug at bugs.webkit.org about the similar duplication of logic in WebCore. There seemed to be enough code paths leading to request cancellation at the ResourceDispatcher level that I couldn't easily ensure that a request only gets cancelled once. So, I added an is_cancelled flag to record if it is not necessary to send a ViewHostMsg_CancelRequest IPC. This avoids some warnings in the ResourceDispatcherHost. To support my UI test, I needed to change URLRequestMockHttpJob to know how to serve redirects. I moved URLRequestHttpJob::IsRedirectResponse to its base class, URLRequestJob so that the implementation could be shared. This revealed a minor bug in URLRequest. We were never resetting response_info_ upon following a redirect. I added this code consolidated similar code from URLRequest::Redirect and URLRequest::RestartWithJob into a new PrepareToRestart method. To support my UI test, I added a "hit count" field to URLRequestFilter, and I added an associated automation IPC to query the value. The test was a bit challenging to write because there is no way to tell the difference from JS. Before and after, it appears to JS as though the cross-origin redirect failed. However, the server can see the extra redirect request. So, I simply record the number of hits against URLs of the form http://mock.http/foo, and use that to observe if any extra requests were made. I implemented the new IPC message by extending the AutomationResourceMessageFilter. This allowed me to trap the IPC message on the IO thread where it is safe to probe the URLRequestFilter. I then changed the implementation of AutomationMsg_SetFilteredInet to work similarly. I revised URLRequestMockHTTPJob::GetOnDiskPath to support ports. This actually allowed me to reuse URLRequestMockHTTPJob to service URLs in different security origins. My test redirects from http://mock.http/ to http://mock.http:4000/. Please see the comments in cross-origin-redirect-blocked.html for details about how the test functions. R=brettw,wtc BUG=16413 TEST=covered by resource_dispatcher_host_uitest.cc Review URL: http://codereview.chromium.org/159370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22067 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing the google browser name in about:memory page.kuchhal@chromium.org2009-07-301-11/+15
| | | | | | | | | | BUG=4928 TEST=Open about:memory page a see if the browser name of Google is what is expected. Review URL: http://codereview.chromium.org/159385 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22066 0039d316-1c4b-4281-b951-d872f2087c98
* The script which verifies whether a crash callstack is known expects the ↵ananta@chromium.org2009-07-301-3/+7
| | | | | | | | | | | | callstack to be in lowercase. Converting the recently added Flash callstacks to lowercase. Added a new stack with the associated bug 18083 Review URL: http://codereview.chromium.org/160404 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22065 0039d316-1c4b-4281-b951-d872f2087c98
* Add a way to inject extra cflags in release builds.dank@chromium.org2009-07-301-0/+2
| | | | | | | | | | (I intend to use this as a quickie way to add -g to Release builds so I can see symbols. Is there a better way?) Review URL: http://codereview.chromium.org/159621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22064 0039d316-1c4b-4281-b951-d872f2087c98
* Add Linux package building target.mmoss@chromium.org2009-07-302-121/+172
| | | | | | | | | Also rearrange installer targets with better grouping for easier reading. Review URL: http://codereview.chromium.org/159641 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22063 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the sad tab so that it draws right-side-up on the Macstuartmorgan@google.com2009-07-301-0/+5
| | | | | | | | | BUG=none TEST=Kill a plugin process; sad tab should be right-side up. Review URL: http://codereview.chromium.org/159611 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22062 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable a failing interactive UI test.darin@chromium.org2009-07-301-1/+1
| | | | | | | | | | TBR=avi BUG=18079 TEST=none Review URL: http://codereview.chromium.org/160400 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22061 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of redundant tab layout by installing incognito badge and adjusting ↵pinkerton@chromium.org2009-07-301-3/+4
| | | | | | | | | | tab strip before creating the tab strip controller. BUG=none TEST=initial incognito tab layout should exactly match normal tab layout (including new tab button). Review URL: http://codereview.chromium.org/160397 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22060 0039d316-1c4b-4281-b951-d872f2087c98
* Undo accidental change to common.gypi.aa@chromium.org2009-07-301-1/+0
| | | | | | | | TBR=tony@chromium.org Review URL: http://codereview.chromium.org/160398 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22059 0039d316-1c4b-4281-b951-d872f2087c98
* Properly destroy popups when their parent views are told to destroy.avi@chromium.org2009-07-301-15/+38
| | | | | | | | | BUG=http://crbug.com/12970 TEST=as in bug Review URL: http://codereview.chromium.org/160353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22058 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 09:10:54 +0000