summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Make the bookmark buttons follow theme changes correctly.glen@chromium.org2009-07-243-23/+36
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/160092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21518 0039d316-1c4b-4281-b951-d872f2087c98
* This file (somehow) got removed from the last CL.jorlow@chromium.org2009-07-241-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21517 0039d316-1c4b-4281-b951-d872f2087c98
* Move parts of npruntime into the WebKit API so it no longer has any ↵jorlow@chromium.org2009-07-245-163/+270
| | | | | | | | | | dependencies on WebCore. TEST=none BUG=none Review URL: http://codereview.chromium.org/160091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21516 0039d316-1c4b-4281-b951-d872f2087c98
* Prep for moving Camera Info out of Params into JSONgman@google.com2009-07-2415-2/+1671
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I thought it was best to give you what I have so far for your input and code review instead of giving you everything all at once. This CL implements JSONObject which has a mechanism for adding stuff to be serialized as JSON to the serialization code. Since JSONObject is a serialization only object it seemed okay to put Serialize code inside. I opted to pre-declare JSONFloat and JSONOptionalFloat because I felt it made the code more error free. I had made it were you could just have JSONFloat and then with RegisterJSONValue you'd pass in optional or not but this way, declaring the field in a class makes it more explicit. CameraInfo is the first class that uses it. I'm not set on exactly how it is serialized. Whether it's as "object: { ... }" inside the "properties" section or whether it should have its own section. I think I won't know what until I actually write the deserialization code. That's not imporant for this CL This code, even if checked it, is not used yet as the import code, collada.cc, is not yet creating any of these objects. That's in another CL if you want to take a look http://codereview.chromium.org/160007 That CL will have to have lots of o3djs changes, corresponding sample changes and corresponding selenium test changes. Review URL: http://codereview.chromium.org/160008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21515 0039d316-1c4b-4281-b951-d872f2087c98
* Disable NPAPIVisiblePluginTester.OpenPopupWindowWithPlugin, which is flaky.yuzo@chromium.org2009-07-241-1/+2
| | | | | | | | | | BUG=17645 TEST=none Review URL: http://codereview.chromium.org/159333 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21514 0039d316-1c4b-4281-b951-d872f2087c98
* Change the expectation of only-child-pseudo-class.html to FAIL also for Mac.yuzo@chromium.org2009-07-241-1/+1
| | | | | | | | | | BUG=17635 TEST=none Review URL: http://codereview.chromium.org/160086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21513 0039d316-1c4b-4281-b951-d872f2087c98
* I edited the wrong one. DUH.glen@chromium.org2009-07-241-1/+1
| | | | | | | | | | TBR=nsylvain BUG=none TEST=none Review URL: http://codereview.chromium.org/159337 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21512 0039d316-1c4b-4281-b951-d872f2087c98
* Workaround to get Linux/ChromeOS building - it appears to not be picking up ↵glen@chromium.org2009-07-241-1/+1
| | | | | | | | | | | | file adds to app/theme/google_chrome (product_logo_white.png was added, but the ChromeOS builder can't find it). We need to figure this out tomorrow for beta cutoff. TBR=ben,brettw,nsylvain BUG=none TEST=none Review URL: http://codereview.chromium.org/160090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21511 0039d316-1c4b-4281-b951-d872f2087c98
* Add link to themes gallery.glen@chromium.org2009-07-244-5/+37
| | | | | | | | | BUG=16381 TEST=Go to second page of options, verify that the 'Get themes' button opens a new tab and takes you to the themes gallery. Review URL: http://codereview.chromium.org/160081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21510 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bunch of bugs related to NNTP theming.glen@chromium.org2009-07-2433-36/+193
| | | | | | | | | | | | | | | | | | Basically: - Add NNTP Theming BrowserThemeProvider: - Add NNTP logo inversion capability - Only allow a set of images to be themed. - Tint incognito windows correctly. (Sorry for the feature-mush) BUG=17379,14578,17593 TEST=Make sure the NNTP is themed correctly. Review URL: http://codereview.chromium.org/159305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21509 0039d316-1c4b-4281-b951-d872f2087c98
* Implement OCSP handler for NSS.ukai@chromium.org2009-07-243-0/+626
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/126046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21508 0039d316-1c4b-4281-b951-d872f2087c98
* Make the NNTP listen for the correct theme changed notification.glen@chromium.org2009-07-241-2/+2
| | | | | | | | | BUG=17565 TEST=Install a theme, reset the theme, verify that the NNTP changes correctly in both cases. Review URL: http://codereview.chromium.org/160027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21507 0039d316-1c4b-4281-b951-d872f2087c98
* When closing the download shelf, hide the buttons of the dangerous downloadthakis@chromium.org2009-07-242-4/+6
| | | | | | | | | | | | | | | warning. Also fix the shelf closing animation. BUG=13632 TEST=Download an exe (e.g. limewire from downloads.com), so that a "dangerous download" message appears on the shelf. Then close the shelf. The "Yes" and "No" buttons should be hidden, and the whole download shelf should slide down with all items on it in place. Original review url: http://codereview.chromium.org/159261 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21506 0039d316-1c4b-4281-b951-d872f2087c98
* Recommit of r21474. Original description:glen@chromium.org2009-07-245-3/+22
| | | | | | | | | | | | | | | | """ Make the tab close button color match the tab text. BUG=17378 TEST=Install themes with different tab text colors and verify that the tab close button changes color appropriately. Review URL: http://codereview.chromium.org/155882 """ Changes since then include removing a NOTREACHED and changing that method so that a caller can detect whether a ThemeProvider is available. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21505 0039d316-1c4b-4281-b951-d872f2087c98
* Remove mention that we don't support different types of font rendering from ↵agl@chromium.org2009-07-242-4/+0
| | | | | | the splash page. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21504 0039d316-1c4b-4281-b951-d872f2087c98
* Push bookmarks.remove/removeAll polymorphism into c++. fix bookmarks id ↵rafaelw@chromium.org2009-07-2410-80/+76
| | | | | | | | | | | schema issues (http://code.google.com/p/chromium/issues/detail?id=17562 failed to update schema types from int to string). R=erikkay BUG=17417 Review URL: http://codereview.chromium.org/160064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21503 0039d316-1c4b-4281-b951-d872f2087c98
* Adding Bison and ANTLR grammars for GLSL ES. The grammars are derivedkbr@google.com2009-07-2412-0/+1747
| | | | | | | | | | | | | | | from the OpenGL ES specification and are intended to match the structure in the spec as closely as possible while working with existing tools. Hints were taken from the Mesa GLSL grammar, which uses a custom parser generator, to solve reduce/reduce conflicts in the Bison version. The grammars do nothing at the moment except parse inputs and provide rudimentary error reporting. Follow-on work will extend these grammars with the intended functionality. Basic testing has been done but much more is needed. Review URL: http://codereview.chromium.org/159324 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21499 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typos (incorrectly capitalized 'R': Reset => reset).jshin@chromium.org2009-07-242-2/+2
| | | | | | | | | | | | | | BUG=2834 TEST=Click in "Reset to defaults" button on the options dialog and the 2nd setence should read 'Do you want to reset ...?' TBR=mal Patch by tfarina Original Review: http://codereview.chromium.org/155910 Review URL: http://codereview.chromium.org/160080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21498 0039d316-1c4b-4281-b951-d872f2087c98
* Update test expectations with failures from WebKit merge r46282:r46288agl@chromium.org2009-07-241-0/+3
| | | | | | | BUG=17635 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21497 0039d316-1c4b-4281-b951-d872f2087c98
* The final CL for plumbing DOM Storage.jorlow@chromium.org2009-07-2420-5/+656
| | | | | | | | | | | | | Add webKitClient plumbing for getting/creating storage namespaces. Add a chromium implementation for WebStorageArea and WebStorageNamespace which communicates via IPC with the dom_storage_dispatcher_host in the browser process. Flesh out the StorageAreaProxy and StorageNamespaceProxy to use the aforementioned implementations. The WebStorageArea implementation includes decently aggressive caching optimizations. There's still a lot of work to do, though. BUG=4360 TEST=none Review URL: http://codereview.chromium.org/147248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21495 0039d316-1c4b-4281-b951-d872f2087c98
* I'm apparently the first one who's tried to do hash_map<string16, ...>. ↵jorlow@chromium.org2009-07-241-0/+28
| | | | | | | | | | | | | | Unfortunately, hash_map<> does not know how to hash a string16 when string16 isn't a wstring. I looked in <tr1/functional> and saw that only std::string and std::wstring have hashing functions. This change adds a hashing function for string16's when they're not the same as a std::wstring. BUG=none TEST=none Review URL: http://codereview.chromium.org/160062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21494 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: splice together RendererPreferences and SkFontHostagl@chromium.org2009-07-248-4/+230
| | | | | | | | | | | | | | | | | | | | | Dan Erat has been working down, plumbing the user's font settings from XSETTINGS in the UI thread of the browser to RendererPreferences in the renderer. At the same time, I've been working upwards: implementing subpixel rendering support in Skia and adding an interface to it in WebCore. This patch joins the two together. It adds an API surface to the WebKit API for configuring the font preferences and adds code to translate from RendererPreferences to that API. It's a little unfortunate that we need four sets of enums around the code base for things like the hinting level, but each is supposed to be self contained and adding a dependancy would much more grevious. BUG=12179 http://codereview.chromium.org/159152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21493 0039d316-1c4b-4281-b951-d872f2087c98
* Adds in the ActiveX control for O3D.gspencer@google.com2009-07-247-15/+90
| | | | | | Review URL: http://codereview.chromium.org/160078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21492 0039d316-1c4b-4281-b951-d872f2087c98
* Fix newline issues in tab_renderer.hglen@chromium.org2009-07-241-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21491 0039d316-1c4b-4281-b951-d872f2087c98
* Update test expectations corresponding to changes made upstream.darin@chromium.org2009-07-2413-20/+146
| | | | | | | | | | | | | | | | | | Corresponding to http://trac.webkit.org/changeset/46281: fast/overflow/overflow-with-local-attachment.html Corresponding to http://trac.webkit.org/changeset/46287: fast/css/getComputedStyle/computed-style.html fast/css/getComputedStyle/computed-style-without-renderer.html svg/css/getComputedStyle-basic.xhtml TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/160075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21490 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 21474glen@chromium.org2009-07-245-21/+1
| | | | | | | | | | TBR=joshia BUG=none TEST=none Review URL: http://codereview.chromium.org/160074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21489 0039d316-1c4b-4281-b951-d872f2087c98
* Fixit: Coverity check return value.kuchhal@chromium.org2009-07-241-3/+6
| | | | | | Review URL: http://codereview.chromium.org/159320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21488 0039d316-1c4b-4281-b951-d872f2087c98
* GTK test shell valgrind, try 3. Null out the main window before initiating ↵estade@chromium.org2009-07-241-2/+2
| | | | | | | | shutdown. Review URL: http://codereview.chromium.org/159307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21486 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Omnibox cursor flicker by deleting a bunch of useless code in WindowWin.pkasting@chromium.org2009-07-243-47/+0
| | | | | | | | | | I tested running the app in Vista non-Aero, and I still got resize cursors on all edges and was able to resize the window. BUG=13926 TEST=Mouse around on the omnibox; the cursor should not flicker. Review URL: http://codereview.chromium.org/159245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21485 0039d316-1c4b-4281-b951-d872f2087c98
* Make the Clear Browsing Data dialog box look a little nicer.ben@chromium.org2009-07-248-25/+62
| | | | | | | | | | | | - Now use GtkCheckButton's own label instead of the hack one used only by windows. - Render a background for DialogClientView. BUG=none TEST=none Review URL: http://codereview.chromium.org/160066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21484 0039d316-1c4b-4281-b951-d872f2087c98
* Another try at enabling the content script messaging test.mpcomplete@chromium.org2009-07-247-77/+107
| | | | | | | | | | | | | Also fixes some issues that that test exposes. My previous attempt (http://src.chromium.org/viewvc/chrome?view=rev&revision=21324) was reverted. TEST=no BUG=no Review URL: http://codereview.chromium.org/160048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21483 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the BookmarkEditorGtk.* tests again while I investigate the issue.jhawkins@chromium.org2009-07-241-0/+3
| | | | | | | TBR=dank Review URL: http://codereview.chromium.org/160071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21482 0039d316-1c4b-4281-b951-d872f2087c98
* Enable SVG icons for linux.estade@chromium.org2009-07-242-25/+8
| | | | | | | | | | | get rid of kEnableSVG BUG=12272 TEST=I made it load an svg for the download shelf and it worked. SVGZ did not work. Review URL: http://codereview.chromium.org/159247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21481 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the first run banner.arv@google.com2009-07-234-35/+103
| | | | | | | | | | | | | | First run is determined by checking if there are no thumbnails. The check for no thumbnails is done on the backend since I need to add code to add some pre populated thumbnails and therefore the most visited pages will not be empty on the client. There is one edge case where the banner can show up again and that is if the user blacklists all his thumbnails and restarts chrome. Also, updates the look of the fillers to match the latest mocks. BUG=15079 TEST=Start with a new empty profile. You should see the blue first run banner. Then navigate to some link and come back the NTP. The banner should not be shown again. Also, test that this did not break the yellow notification banner shown when a thumbnail is removed. Review URL: http://codereview.chromium.org/159304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21480 0039d316-1c4b-4281-b951-d872f2087c98
* Added menus for bookmark bar folders. This is NOT based on the Colejrg@chromium.org2009-07-2311-200/+506
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | prototype; it is an attempt to get something functional in the short term, and have a visual baseline before doing something new. Added folder icons for bookmark bar folder buttons. Added an "off the side" button/menu for bookmark buttons which don't fit on the bar. Updated "Add page..." item to allow creating bookmarks in the folders (if selected over a folder button). BUG=http://crbug.com/8381 TEST=Here we go: 1) Make sure bookmark bar folders have the "folder" icon. 2) Right click on a folder --> Add Page, and add a bookmark. Make sure bookmark is now in the folder, not at the top level. 3) (Oh, you just implicitly verified you can open bookmark folders!) 4) Add 5 bookmarks then shrink the window thinner so all bookmark buttons don't fit. Make sure "off the right" button gets enabled (on right side of bar) and shows bookmarks in a pop-up menu (when clicked) that don't completely fit on the bar. 5) Make it super-wide so the all fit and make sure "off the right" button is disabled. 6) Add a bunch of bookmarks to a folder; make sure they all work. 7) Add nested folders (by editing the bookmark pref file and restarting Chrome) and make sure bookmark folder buttons have nested/cascading menus. Review URL: http://codereview.chromium.org/159286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21479 0039d316-1c4b-4281-b951-d872f2087c98
* linux: obey window positioning information when bounds are overriddenevan@chromium.org2009-07-232-4/+17
| | | | | | | | | | | | | Normally we want to let windows position themselves, but in some cases (like dropping a tab) we really do want to drop the window where we dropped. BUG=15404 TEST=Drag off a tab and drop it. It should drop where you released it. Review URL: http://codereview.chromium.org/159316 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21478 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux/mac build errors.glen@chromium.org2009-07-231-3/+3
| | | | | | | | | TBR=jrg BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21477 0039d316-1c4b-4281-b951-d872f2087c98
* Adds MSAA information to various (previously uncovered) bits of the UI, ↵klink@chromium.org2009-07-2315-30/+193
| | | | | | | | | | | including Bookmark and Extensions infobars. This is to moving towards completing the hierarchy for the benefit of full screen reader support. BUG=None. Test=None. Review URL: http://codereview.chromium.org/155446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21476 0039d316-1c4b-4281-b951-d872f2087c98
* LayoutTests/fast/forms/select-popup-pagekeys.html no longer fails!darin@chromium.org2009-07-231-3/+0
| | | | | | | | | | TBR=snej BUG=17589 TEST=none Review URL: http://codereview.chromium.org/160069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21475 0039d316-1c4b-4281-b951-d872f2087c98
* Make the tab close button color match the tab text.glen@chromium.org2009-07-235-0/+20
| | | | | | | | | BUG=17378 TEST=Install themes with different tab text colors and verify that the tab close button changes color appropriately. Review URL: http://codereview.chromium.org/155882 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21474 0039d316-1c4b-4281-b951-d872f2087c98
* Add a boolean parameter to Client::RenderClient() to choose whether tomaf@google.com2009-07-237-18/+31
| | | | | | | | | | | | | | make the javascript render callback or not. Generally you want to pass true, but if the render is happening in non-windowed mode (eg on a Mac) and is in response to an update event rather than a timer, it can be useful to pass false to prevent the javascript code triggering another update and causing an infinite calback loop. Case in point is the custom camera example, which modifies some HTML form text fields on render callback, which on Firefox causes a plugin invalidation and round and round we would go. Review URL: http://codereview.chromium.org/159181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21473 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in VisitSegmentDatabase::QuerySegmentUsage and ↵meelapshah@chromium.org2009-07-233-10/+8
| | | | | | | | | | | HistoryBackend::QueryTopURLsAndRedirects. BUG=16104 TEST=sh tools/valgrind/chrome_test.sh -t ui --gtest_filter=TabRestoreUITest.RestoreIntoSameWindow Review URL: http://codereview.chromium.org/160060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21472 0039d316-1c4b-4281-b951-d872f2087c98
* Fix message queue test build breakage.gspencer@google.com2009-07-232-13/+15
| | | | | | Review URL: http://codereview.chromium.org/159315 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21471 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing several problems with the build.gspencer@google.com2009-07-234-5/+9
| | | | | | | | | | | | | - Had to make one line file_path_utils conditional on which build system was building it (because GYP build and scons build use different versions of chrome/base). - Missed a couple instances of "file/" in the path to nixysa. - New version of breakpad has a different API on the Mac. Review URL: http://codereview.chromium.org/160056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21470 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a new parsing system to the metadata url request.brettw@chromium.org2009-07-2313-7/+442
| | | | | | | | | | | BUG=none TEST=none Original review: http://codereview.chromium.org/155803 Patch by: dhg@google.com Review URL: http://codereview.chromium.org/160059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21469 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Set the treeview column title even for headers we aren't displaying. ↵jhawkins@chromium.org2009-07-232-5/+2
| | | | | | | | | | Older versions of gtk trip up on an empty title string. BUG=15445 TEST=Watch the Linux valgrind bot stay green. Review URL: http://codereview.chromium.org/159312 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21468 0039d316-1c4b-4281-b951-d872f2087c98
* Update WebKit from 46282 to 46288.darin@chromium.org2009-07-232-5/+6
| | | | | | | | | | TBR=pkasting TEST=none BUG=none Review URL: http://codereview.chromium.org/160057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21467 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the browser to send actions back to the render for media element ↵ajwong@chromium.org2009-07-2320-104/+351
| | | | | | | | | | | | | context menus. Also renamed ContextNodeType per fishd's suggestion. BUG=15686 TEST=none Review URL: http://codereview.chromium.org/155954 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21466 0039d316-1c4b-4281-b951-d872f2087c98
* Merged PipelineInternal into PipelineImpl, eliminating a ton of ↵scherkus@chromium.org2009-07-233-334/+210
| | | | | | | | | | | | | | | | | thread-UNsafeness and confusion. Long story short: there's no reason to split an implementation of class between two classes. The data was being held in one class, with the other class accessing it privately without acquiring the lock. Really, really painful to debug as well. Now we have a unified implementation of Pipeline that takes care of client API requests as well as filter interaction. Since Pipeline is properly reference counted and there are two less objects to worry about, the crash reported in 3.0.195.1 should also be resolved. BUG=17107,17548 TEST=pipeline tests, media player and chrome ui tests Review URL: http://codereview.chromium.org/159246 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21464 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: Add cookie details to cookie manager.mattm@chromium.org2009-07-232-8/+153
| | | | | | | | BUG=11507 Review URL: http://codereview.chromium.org/155974 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21463 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-22 23:04:54 +0000